Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

disallow empty metadata dict in favour of null

Browse Source
This commit is contained in:
Scott Sadler 2016-11-28 17:31:35 +01:00
parent 71dcee019f
commit a6eb52d76d
3 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bigchaindb/common/schema/transaction.yaml
View File

@ -245,6 +245,7 @@ definitions:
- type: object
description: |
User provided transaction metadata. This field may be ``null`` or may
contain an object with freeform metadata.
contain an non empty object with freeform metadata.
additionalProperties: true
minProperties: 1
- type: 'null'

2
docs/server/source/schema/transaction.rst
View File

@ -301,7 +301,7 @@ Metadata
--------
User provided transaction metadata. This field may be ``null`` or may
contain an object with freeform metadata.
contain an non empty object with freeform metadata.

10
tests/common/test_schema.py
View File

@ -16,6 +16,16 @@ def test_validate_transaction_signed_transfer(signed_transfer_tx):
validate_transaction_schema(signed_transfer_tx.to_dict())
def test_validate_fails_metadata_empty_dict(create_tx):
create_tx.metadata = {'a': 1}
validate_transaction_schema(create_tx.to_dict())
create_tx.metadata = None
validate_transaction_schema(create_tx.to_dict())
create_tx.metadata = {}
with raises(SchemaValidationError):
validate_transaction_schema(create_tx.to_dict())
def test_validation_fails():
with raises(SchemaValidationError):
validate_transaction_schema({})