Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added a error log when learner is not sync with etcd leader.

Browse Source 
Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
This commit is contained in:
Ishan Tyagi
2024-01-30 15:42:11 +05:30
committed by ishan16696
parent 15f95ec49b
commit 16a5e1da71
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
server/etcdserver/server.go
View File

@@ -102,7 +102,9 @@ const (
recommendedMaxRequestBytes = 10 * 1024 * 1024
readyPercent = 0.9
// readyPercentThreshold is a threshold used to determine
// whether a learner is ready for a transition into a full voting member or not.
readyPercentThreshold = 0.9
DowngradeEnabledPath = "/downgrade/enabled"
)
@@ -1491,8 +1493,7 @@ func (s *EtcdServer) promoteMember(ctx context.Context, id uint64) ([]*membershi
func (s *EtcdServer) mayPromoteMember(id types.ID) error {
lg := s.Logger()
err := s.isLearnerReady(uint64(id))
if err != nil {
if err := s.isLearnerReady(lg, uint64(id)); err != nil {
return err
}
@@ -1515,7 +1516,7 @@ func (s *EtcdServer) mayPromoteMember(id types.ID) error {
// check whether the learner catches up with leader or not.
// Note: it will return nil if member is not found in cluster or if member is not learner.
// These two conditions will be checked before toApply phase later.
func (s *EtcdServer) isLearnerReady(id uint64) error {
func (s *EtcdServer) isLearnerReady(lg *zap.Logger, id uint64) error {
if err := s.waitAppliedIndex(); err != nil {
return err
}
@@ -1546,8 +1547,16 @@ func (s *EtcdServer) isLearnerReady(id uint64) error {
}
leaderMatch := rs.Progress[leaderID].Match
learnerReadyPercent := float64(learnerMatch) / float64(leaderMatch)
// the learner's Match not caught up with leader yet
if float64(learnerMatch) < float64(leaderMatch)*readyPercent {
if learnerReadyPercent < readyPercentThreshold {
lg.Error(
"rejecting promote learner: learner is not ready",
zap.Float64("learner-ready-percent", learnerReadyPercent),
zap.Float64("ready-percent-threshold", readyPercentThreshold),
)
return errors.ErrLearnerNotReady
}