Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

etcdserver/api/rafthttp: document round-trip metrics, clean up

Browse Source 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
This commit is contained in:
Gyuho Lee 2018-05-23 13:45:43 -07:00
parent 5a9e48be30
commit 640f5e64a9
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
etcdserver/api/rafthttp/metrics.go
View File

@ -53,7 +53,7 @@ var (
[]string{"From"},
)
rtts = prometheus.NewHistogramVec(prometheus.HistogramOpts{
rttSec = prometheus.NewHistogramVec(prometheus.HistogramOpts{
Namespace: "etcd",
Subsystem: "network",
Name: "peer_round_trip_time_seconds",
@ -72,5 +72,5 @@ func init() {
prometheus.MustRegister(receivedBytes)
prometheus.MustRegister(sentFailures)
prometheus.MustRegister(recvFailures)
prometheus.MustRegister(rtts)
prometheus.MustRegister(rttSec)
}

8
etcdserver/api/rafthttp/probing_status.go
View File

@ -44,9 +44,10 @@ func addPeerToProber(lg *zap.Logger, p probing.Prober, id string, us []string) {
} else {
plog.Errorf("failed to add peer %s into prober", id)
}
} else {
go monitorProbingStatus(lg, s, id)
return
}
go monitorProbingStatus(lg, s, id)
}
func monitorProbingStatus(lg *zap.Logger, s probing.Status, id string) {
@ -83,7 +84,8 @@ func monitorProbingStatus(lg *zap.Logger, s probing.Status, id string) {
plog.Warningf("the clock difference against peer %s is too high [%v > %v]", id, s.ClockDiff(), time.Second)
}
}
rtts.WithLabelValues(id).Observe(s.SRTT().Seconds())
rttSec.WithLabelValues(id).Observe(s.SRTT().Seconds())
case <-s.StopNotify():
return
}