Merge pull request #5016 from gyuho/lease_simple

*: clean up from gosimple

clientv3/lease.go

@@ -381,11 +381,7 @@ func (l *lessor) switchRemoteAndStream(prevErr error) error {
 	l.remote = pb.NewLeaseClient(l.conn)
 	l.mu.Unlock()
 
-	serr := l.newStream()
-	if serr != nil {
-		return serr
-	}
-	return nil
+	return l.newStream()
 }
 
 func (l *lessor) newStream() error {

etcdserver/api/v3rpc/key.go

@@ -169,11 +169,7 @@ func checkTxnRequest(r *pb.TxnRequest) error {
 			return err
 		}
 	}
-	if err := checkRequestDupKeys(r.Failure); err != nil {
-		return err
-	}
-
-	return nil
+	return checkRequestDupKeys(r.Failure)
 }
 
 // checkRequestDupKeys gives rpctypes.ErrDuplicateKey if the same key is modified twice

etcdserver/auth/auth.go

@@ -335,11 +335,7 @@ func (s *store) GetRole(name string) (Role, error) {
 	}
 	var r Role
 	err = json.Unmarshal([]byte(*resp.Event.Node.Value), &r)
-	if err != nil {
-		return r, err
-	}
-
-	return r, nil
+	return r, err
 }
 
 func (s *store) CreateRole(role Role) error {
@@ -497,10 +493,7 @@ func (r Role) merge(n Role) (Role, error) {
 		return out, err
 	}
 	out.Permissions, err = out.Permissions.Revoke(n.Revoke)
-	if err != nil {
-		return out, err
-	}
-	return out, nil
+	return out, err
 }
 
 func (r Role) HasKeyAccess(key string, write bool) bool {

etcdserver/storage.go

@@ -66,11 +66,7 @@ func (st *storage) SaveSnap(snap raftpb.Snapshot) error {
 	if err != nil {
 		return err
 	}
-	err = st.WAL.ReleaseLockTo(snap.Metadata.Index)
-	if err != nil {
-		return err
-	}
-	return nil
+	return st.WAL.ReleaseLockTo(snap.Metadata.Index)
 }
 
 func readWAL(waldir string, snap walpb.Snapshot) (w *wal.WAL, id, cid types.ID, st raftpb.HardState, ents []raftpb.Entry) {

storage/backend/backend.go

@@ -297,11 +297,7 @@ func defragdb(odb, tmpdb *bolt.DB, limit int) error {
 				tmpb = tmptx.Bucket(next)
 				count = 0
 			}
-			err = tmpb.Put(k, v)
-			if err != nil {
-				return err
-			}
-			return nil
+			return tmpb.Put(k, v)
 		})
 	}
 

tools/functional-tester/etcd-agent/client/client.go

@@ -96,10 +96,7 @@ func (a *agent) RecoverPort(port int) error {
 func (a *agent) Status() (Status, error) {
 	var s Status
 	err := a.rpcClient.Call("Agent.RPCStatus", struct{}{}, &s)
-	if err != nil {
-		return s, err
-	}
-	return s, nil
+	return s, err
 }
 
 func (a *agent) ID() uint64 {

tools/functional-tester/etcd-tester/failure.go

@@ -257,10 +257,7 @@ func newFailureIsolate() *failureIsolate {
 
 func (f *failureIsolate) Inject(c *cluster, round int) error {
 	i := round % c.Size
-	if err := c.Agents[i].DropPort(peerURLPort); err != nil {
-		return err
-	}
-	return nil
+	return c.Agents[i].DropPort(peerURLPort)
 }
 
 func (f *failureIsolate) Recover(c *cluster, round int) error {