Merge pull request #10121 from dannysauer/etcdctl_message_fix

etcdctl: More helpful error handling in member add
This commit is contained in:
Gyuho Lee 2018-09-25 14:57:01 -07:00 committed by GitHub
commit a3e242d80a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -96,9 +96,18 @@ The items in the lists are ID, Status, Name, Peer Addrs, Client Addrs.
// memberAddCommandFunc executes the "member add" command.
func memberAddCommandFunc(cmd *cobra.Command, args []string) {
if len(args) != 1 {
if len(args) < 1 {
ExitWithError(ExitBadArgs, fmt.Errorf("member name not provided."))
}
if len(args) > 1 {
errorstring := "too many arguments"
for _, v := range args {
if strings.HasPrefix(strings.ToLower(v), "http"){
errorstring += ", did you mean \"--peer-urls " + v + "\""
}
}
ExitWithError(ExitBadArgs, fmt.Errorf(errorstring))
}
newMemberName := args[0]
if len(memberPeerURLs) == 0 {