Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #17618 from Akiqqqqqqq/feature-wal-write-metric

Browse Source 
feat: add wal write system call metrics observation (main)
This commit is contained in:
Benjamin Wang 2024-03-31 16:54:20 +01:00 committed by GitHub
commit cc32fa8559
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 34 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
server/storage/wal/encoder.go
View File

@ -20,6 +20,7 @@ import (
"io"
"os"
"sync"
"time"
"go.etcd.io/etcd/pkg/v3/crc"
"go.etcd.io/etcd/pkg/v3/ioutil"
@ -84,17 +85,9 @@ func (e *encoder) encode(rec *walpb.Record) error {
data = e.buf[:n]
}
lenField, padBytes := encodeFrameSize(len(data))
if err = writeUint64(e.bw, lenField, e.uint64buf); err != nil {
return err
}
data, lenField := prepareDataWithPadding(data)
if padBytes != 0 {
data = append(data, make([]byte, padBytes)...)
}
n, err = e.bw.Write(data)
walWriteBytes.Add(float64(n))
return err
return write(e.bw, e.uint64buf, data, lenField)
}
func encodeFrameSize(dataBytes int) (lenField uint64, padBytes int) {
@ -113,10 +106,28 @@ func (e *encoder) flush() error {
return e.bw.Flush()
}
func writeUint64(w io.Writer, n uint64, buf []byte) error {
// http://golang.org/src/encoding/binary/binary.go
binary.LittleEndian.PutUint64(buf, n)
nv, err := w.Write(buf)
func prepareDataWithPadding(data []byte) ([]byte, uint64) {
lenField, padBytes := encodeFrameSize(len(data))
if padBytes != 0 {
data = append(data, make([]byte, padBytes)...)
}
return data, lenField
}
func write(w io.Writer, uint64buf, data []byte, lenField uint64) error {
// write padding info
binary.LittleEndian.PutUint64(uint64buf, lenField)
start := time.Now()
nv, err := w.Write(uint64buf)
walWriteBytes.Add(float64(nv))
if err != nil {
return err
}
// write the record with padding
n, err := w.Write(data)
walWriteSec.Observe(time.Since(start).Seconds())
walWriteBytes.Add(float64(n))
return err
}

9
server/storage/wal/metrics.go
View File

@ -28,6 +28,15 @@ var (
Buckets: prometheus.ExponentialBuckets(0.001, 2, 14),
})
walWriteSec = prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: "etcd",
Subsystem: "disk",
Name: "wal_write_duration_seconds",
Help: "The latency distributions of write called by WAL.",
Buckets: prometheus.ExponentialBuckets(0.001, 2, 14),
})
walWriteBytes = prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: "etcd",
Subsystem: "disk",