Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Lili Cosic <cosiclili@gmail.com>
This commit is contained in:
Sergey Kacheev 2021-08-01 00:20:50 +07:00 committed by GitHub
parent b922a28622
commit eac75c28ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/netutil/netutil.go
View File

@ -192,7 +192,7 @@ func URLStringsEqual(ctx context.Context, lg *zap.Logger, a []string, b []string
sort.Sort(types.URLs(urlsB))
for i := range urlsA {
if !reflect.DeepEqual(urlsA[i], urlsB[i]) {
// If urls are not equal, try to resolve it and compare again.
// If URLs are not equal, try to resolve it and compare again.
return urlsEqual(ctx, lg, urlsA, urlsB)
}
}
@ -212,7 +212,7 @@ func stringsToURLs(us []string) ([]url.URL, error) {
for _, str := range us {
u, err := url.Parse(str)
if err != nil {
return nil, fmt.Errorf("failed to parse %q", str)
return nil, fmt.Errorf("failed to parse string to URL: %q", str)
}
urls = append(urls, *u)
}