19993 Commits

Author SHA1 Message Date
Wenkang Zhang
03d8fff0d8 clientv3: add Ctx() to return context of session
Signed-off-by: Wenkang Zhang <314830391@qq.com>
2023-07-18 15:22:53 +08:00
Benjamin Wang
0c643dfb21
Merge pull request #16258 from etcd-io/dependabot/github_actions/github/codeql-action-2.20.4
build(deps): bump github/codeql-action from 2.20.3 to 2.20.4
2023-07-17 19:30:35 +01:00
dependabot[bot]
91215fb1ca
build(deps): bump github/codeql-action from 2.20.3 to 2.20.4
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.3 to 2.20.4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](46ed16ded9...489225d82a)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-17 17:24:31 +00:00
Benjamin Wang
bedd13298d
Merge pull request #16251 from liangyuanpeng/changelog_backport_13577
Add changelog for backport 13577 to 3.4&3.5.
2023-07-17 08:25:25 +01:00
Marek Siarkowicz
11d22abe2b
Merge pull request #16249 from iuriatan/update-linter
Update linter and protoc
2023-07-17 09:13:06 +02:00
Lan
6a9ea5ba6c Add changelog for backport 13577 to 3.4&3.5.
Signed-off-by: Lan Liang <gcslyp@gmail.com>
2023-07-17 13:39:15 +08:00
Benjamin Wang
ff411f517f
Merge pull request #16224 from CaojiamingAlan/expose_isOptsWithFromKey_and_isOptsWithPrefix
expose op.isOptsWithFromKey and op.isOptsWithPrefix
2023-07-15 18:35:39 +01:00
iuriatan
b424e60289 Update protoc from 3.14.0 to 3.20.3
Signed-off-by: iuriatan <iuriatan@gmail.com>
2023-07-14 16:46:26 -03:00
iuriatan
abbfc2964a Fix goword issue
Fix `make verify` issues after updating golangci-lint

Signed-off-by: iuriatan <iuriatan@gmail.com>
2023-07-14 16:46:26 -03:00
iuriatan
b798aae9c5 Update golangci-lint from 1.49.0 to 1.53.3
Signed-off-by: iuriatan <iuriatan@gmail.com>
2023-07-14 16:46:26 -03:00
Benjamin Wang
882edb3d63
Merge pull request #16231 from jmhbnz/robustness-arm64-release-35
Add new job for nightly release35 arm64 robustness
2023-07-14 14:56:38 +01:00
Benjamin Wang
c59bc52286
Merge pull request #16200 from kensou97/keepalive-ctx-closer
clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc…
2023-07-14 13:46:15 +01:00
Benjamin Wang
dee90e19f1
Merge pull request #16229 from ahrtr/changelog_20230712
Changelog: add items to cover the fix of bumping go to 1.19.11
2023-07-14 12:08:07 +01:00
Marek Siarkowicz
2dc7891c7b
Merge pull request #16234 from jmhbnz/add-new-reviewer
Add jmhbnz as etcd reviewer
2023-07-13 12:01:48 +02:00
Marek Siarkowicz
f008184b0e
Merge pull request #16232 from cuishuang/main
remove repetitive the
2023-07-13 11:59:14 +02:00
James Blair
a35d24ab72
Add jmhbnz as etcd reviewer.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-07-13 21:46:04 +12:00
cui fliter
6760dc9572 remove repetitive the
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-07-13 17:01:01 +08:00
James Blair
5ffac59d88
Add new job for nightly release35 arm64 robustness.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-07-13 20:58:16 +12:00
Benjamin Wang
1cf49e5ef0
Merge pull request #16173 from fuweid/fix-datarace-in-expect
pkg/expect: fix data race
2023-07-13 08:49:13 +01:00
Marek Siarkowicz
1ee6be793e
Merge pull request #16226 from ahrtr/go_20230712
Bump go version to 1.19.11 to fix CVE GO-2023-1878
2023-07-13 09:30:57 +02:00
Wei Fu
56edfa6e28 pkg/expect: fix data race
Let's say there is command which outputs one line and exit with error.

There are three goroutines to acquire the lock:

1. ep.read()
2. ep.waitSaveExitErr()
3. ep.Expect()

When ep.read goroutine reads the log but it doesn't acquire the lock in
time, the ep.waitSaveExitErr acquires the lock and updates the
`exitErr`. And then ep.Expect acquires lock but it doesn't see any log
yet and then returns err.

It's hard to reproduce it in local. Add the extra sleep can reproduce it.

```diff
diff --git a/pkg/expect/expect.go b/pkg/expect/expect.go
index a512a3ce4..602bea73f 100644
--- a/pkg/expect/expect.go
+++ b/pkg/expect/expect.go
@@ -128,6 +128,7 @@ func (ep *ExpectProcess) tryReadNextLine(r *bufio.Reader) error {
        printDebugLines := os.Getenv("EXPECT_DEBUG") != ""
        l, err := r.ReadString('\n')

+       time.Sleep(10 * time.Millisecond)
        ep.mu.Lock()
        defer ep.mu.Unlock()
```

See it once in Github Action [1]. In order to fix it, the patch introduces
`readCloseCh` to wait for ep.read to get all the data and retry it.

[1]: https://github.com/etcd-io/etcd/pull/16137#issuecomment-1605838518

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-07-13 14:56:21 +08:00
Benjamin Wang
8fd423332e Changelog: add items to cover the fix of bumping go to 1.19.11
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-12 17:02:09 +01:00
Benjamin Wang
3c33fc1cf7 bump go version to 1.19.11
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-12 16:47:49 +01:00
Benjamin Wang
930dbbc28d
Merge pull request #16196 from fuweid/benchmark-support-range-countonly
tools/benchmark: support --count-only for range
2023-07-12 16:42:38 +01:00
Benjamin Wang
5216eea132
Merge pull request #16198 from vianamjr/clientv3-precent-nil-pointer
Clientv3 prevent nil pointer
2023-07-12 15:42:26 +01:00
caojiamingalan
06579d9cd1 expose op.isOptsWithFromKey and op.isOptsWithPrefix
Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
2023-07-11 14:34:51 -05:00
Marek Siarkowicz
a639ecd4ee
Merge pull request #16219 from ahrtr/3.4.27_release_date
Changelog: update etcd 3.4.27's release date
2023-07-11 13:07:39 +02:00
Benjamin Wang
d934510bdd Changelog: update etcd 3.4.27's release date
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-11 10:38:08 +01:00
Marek Siarkowicz
4f37baf287
Merge pull request #16152 from jmhbnz/template-arm64-jobs
Templated arm64 integration and e2e workflows for main and release-3.5
2023-07-11 10:12:32 +02:00
Marek Siarkowicz
2d771b6f8f
Merge pull request #16189 from jmhbnz/update-community-meeting
Update community meeting frequency to fortnightly
2023-07-11 09:36:15 +02:00
Marek Siarkowicz
d206977927
Merge pull request #16218 from fuweid/update34changelog
CHANGELOG: add item for 3.4.27
2023-07-11 09:06:39 +02:00
Wei Fu
c2474d2999 CHANGELOG: add item for 3.4.27
- embed: fix nil pointer dereference when stopServer

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-07-11 14:55:28 +08:00
Benjamin Wang
c853b9c337
Merge pull request #16210 from ahrtr/dependency_20230710
Bump dependencies
2023-07-10 20:21:07 +01:00
Benjamin Wang
1f07d8f159
Merge pull request #16205 from etcd-io/dependabot/github_actions/github/codeql-action-2.20.3
build(deps): bump github/codeql-action from 2.20.2 to 2.20.3
2023-07-10 19:18:24 +01:00
Marek Siarkowicz
5ed5807bf4
Merge pull request #16197 from wenjiaswe/patch-2
Asking for approval to regain maintainer status
2023-07-10 20:10:58 +02:00
Benjamin Wang
bad0894aa3 dependency: bump gotest.tools/gotestsum from v1.10.0 to v1.10.1
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:51:51 +01:00
Benjamin Wang
2c22ca7eba dependency: bump golang.org/x/net from v0.11.0 to v0.12.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:43:30 +01:00
Benjamin Wang
843ddb4b1e dependency: bump golang.org/x/crypto from v0.10.0 to v0.11.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:40:35 +01:00
Benjamin Wang
149256735d dependency: bump golang.org/x/sys from v0.9.0 to v0.10.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:38:16 +01:00
dependabot[bot]
0afea07767
build(deps): bump github/codeql-action from 2.20.2 to 2.20.3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.2 to 2.20.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](004c5de30b...46ed16ded9)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-10 17:25:31 +00:00
Marcondes Viana
2ec12e4b4e clientv3: prevent nil pointer call in get method
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-07-10 08:16:00 -03:00
zhangwenkang
21eb8d2c3b clientv3: create keepAliveCtxCloser goroutine only if ctx can be canceled
Signed-off-by: zhangwenkang <zwenkang@vmware.com>
2023-07-10 01:11:23 +08:00
Wenjia
4755a1646c Update MAINTAINERS
Sending this PR to ask for approval to regain maintainer status.

Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
2023-07-07 01:16:47 -07:00
Marek Siarkowicz
82f6cb4635
Merge pull request #16194 from wenjiaswe/patch-1
Update CHANGELOG for #16029 #16165 #16193
2023-07-07 09:39:42 +02:00
Wenjia
e3e58880d3 Update CHANGELOG for #16029 #16165 #16193
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
2023-07-07 00:29:49 -07:00
Wei Fu
70c8f04a18 tools/benchmark: support --count-only for range
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-07-07 15:07:12 +08:00
Benjamin Wang
ac88260aaf
Merge pull request #16191 from chaochn47/fix-runtime-reconfig-test
tests: exclude learner endpoint from MemberPromote
2023-07-07 07:15:02 +01:00
James Blair
0b6fd24afb
Update community meeting frequency to fortnightly.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-07-07 15:00:37 +12:00
Benjamin Wang
4364e7581b
Merge pull request #16120 from Tachone/shitao.lst/fix_db_close
etcdutl: fix db double closed
2023-07-06 20:03:51 +01:00
Benjamin Wang
f4444e8fb3
Merge pull request #16154 from CaojiamingAlan/uber_applier_test
add tests for uber applier
2023-07-06 20:00:11 +01:00