1475 Commits

Author SHA1 Message Date
Marek Siarkowicz
902436eee5
Merge pull request #17078 from overvenus/ignore-message-mismatch
server: ignore raft messages if member id mismatch
2023-12-07 16:50:08 +01:00
Neil Shen
9f82390ae9 server: refine TestProcessIgnoreMismatchMessage
Signed-off-by: Neil Shen <overvenus@gmail.com>
2023-12-07 20:32:43 +08:00
Neil Shen
fb769c4306 server: ignore raft messages if member id mismatch
Ignore Raft messages when the `To` field mismatches the local member ID.
In cases where incorrect Raft messages are dispatched, potentially due
to a malfunctioning switch, this proactive check prevents panics,
such as "tocommit is out of range".

Signed-off-by: Neil Shen <overvenus@gmail.com>
2023-12-07 11:57:45 +08:00
Sharath Sivakumar
235ec793fd
dependency: bump golang.org/x/net from 0.18.0 to 0.19.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-12-06 13:44:54 +01:00
Benjamin Wang
9a6eeb5f7e Rollback the pull/14080: which fixed the potential deadlock
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2023-12-05 10:51:38 +00:00
Ivan Valdes
8578e07117
server: disable redirects in peer communication
Disable following redirects from peer HTTP communication on the client's side.
Etcd server may run into SSRF (Server-side request forgery) when adding a new
member. If users provide a malicious peer URL, the existing etcd members may be
redirected to another unexpected internal URL when getting the new member's
version.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2023-12-04 13:53:28 -08:00
Marek Siarkowicz
bc697bc26e Revert "Switch to validating v3 when v2 and v3 are synchronized"
This reverts commit 4fe46f92030e4381e6f9bf95adbb22a08282d297.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-12-03 18:12:09 +01:00
vivekpatani
d616195189 etcdctl,etcdutl,server,tests: bump golang.org/x/time to v0.5.0
- https://github.com/etcd-io/etcd/pull/17031

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-30 10:14:56 -08:00
vivekpatani
b205f1403b etcdutl,server,tests,tools: bump golang.org/x/crypto to v0.16.0
- https://github.com/etcd-io/etcd/pull/17030

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-30 10:14:27 -08:00
vivekpatani
2afd2ddee5 *: bump golang.org/x/sys to 0.15.0
- https://github.com/etcd-io/etcd/pull/17029

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-30 10:13:29 -08:00
Thomas Meyer
b5b0b8dbd4 Fix message in case of unsupported platform
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
2023-11-28 13:36:33 +01:00
Marek Siarkowicz
03d551243b
Merge pull request #17015 from serathius/extract-membership-applier
Extract membership applier
2023-11-27 19:59:21 +01:00
Marek Siarkowicz
62b772c321
Merge pull request #17021 from serathius/test-applyconfstate
Test ApplyConfState after restart
2023-11-27 13:19:50 +01:00
Marek Siarkowicz
fbdf65f101 Test v3 storage configuration validation
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-27 12:00:47 +01:00
Benjamin Wang
e1d79097d5
Merge pull request #17017 from serathius/switch-validation-v3
Switch to validating v3 when v2 and v3 are synchronized
2023-11-27 10:50:14 +00:00
Marek Siarkowicz
e192a05193 Test ApplyConfState after restart
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-26 17:40:28 +01:00
Benjamin Wang
a97052acf4 remove unused method and functions
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2023-11-25 16:16:52 +00:00
Marek Siarkowicz
4fe46f9203 Switch to validating v3 when v2 and v3 are synchronized
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-24 17:46:33 +01:00
Marek Siarkowicz
2ad21558ac Remove shouldApplyV3 from the v3 applier
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-24 16:13:25 +01:00
Marek Siarkowicz
d22c00ccee Extract membership applier
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-24 15:57:15 +01:00
Marek Siarkowicz
7fdb33065d Move duplicated shouldApplyV3 logic up into apply method
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-24 10:21:14 +01:00
Marek Siarkowicz
093666f450 Cleanup v2 applier
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-23 15:41:13 +01:00
Marek Siarkowicz
c72ff1e69c Remove syncing the v2 store TTLs
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-23 14:55:01 +01:00
Marek Siarkowicz
ed3375e076 Remove v2 apply logic
v2 store is no longer available in v3.6.
We can remove apply logic for it as they will never be used.

Only v2 PUT is neeeded as it applies to v3 storage and etcd v3.5 uses it for setting member
attributes and cluster version.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-23 14:13:07 +01:00
Marek Siarkowicz
28d9564962
Merge pull request #16994 from serathius/tests-v2-cluster-version
Add tests for setting cluster version using v2 request
2023-11-22 21:11:18 +01:00
Marek Siarkowicz
2f30760b37 Add tests for setting cluster version using v2 request
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-22 18:05:19 +01:00
Marek Siarkowicz
29dd025b84 Stop using v2 requests in server tests
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-22 14:41:53 +01:00
Benjamin Wang
fd0882b67e
Merge pull request #16984 from siyuanfoundation/lin-read
etcdserver: add linearizable_read check to readyz.
2023-11-21 19:51:12 +00:00
Siyuan Zhang
12b640523a etcdserver: add linearizable_read check to readyz.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2023-11-21 11:13:20 -08:00
Benjamin Wang
ec6147cd04
Merge pull request #16967 from serathius/remove-v2-proposals
Remove v2 proposals code
2023-11-21 15:35:51 +00:00
Benjamin Wang
bccd56ae48
Merge pull request #16985 from jmhbnz/update-dependencies
[2023-11-21] Bump dependencies identified by dependabot
2023-11-21 15:06:57 +00:00
James Blair
3a9a7483b7
depdendency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.46.0 to 0.46.1.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 20:03:48 +13:00
James Blair
3b37afec7b
Don't follow redirects when checking peer urls.
It's possible that etcd server may run into SSRF situation when adding a new member. If users provide a malicious peer URL, the existing etcd members may be redirected to other unexpected internal URL when getting the new member's version.

Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 10:25:20 +13:00
James Blair
08aabfea02
depdendency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.20.0 to 1.21.0.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 10:06:15 +13:00
James Blair
5449f0fb99
depdendency: bump go.opentelemetry.io/otel/sdk from 1.20.0 to 1.21.0.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 10:04:28 +13:00
Marek Siarkowicz
dd7a4d28a8 Remove code used to make v2 proposals
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-19 22:39:33 +01:00
Marek Siarkowicz
b4fd31f254 Remove code for setting cluster version via V2 API
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-19 15:28:52 +01:00
Sharath Sivakumar
33b526f58d
dependency: bump golang.org/x/net from 0.17.0 to 0.18.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-16 11:03:00 +01:00
Sharath Sivakumar
4907fedbc3
dependency: bump golang.org/x/crypto from 0.14.0 to 0.15.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-16 10:50:17 +01:00
Sharath Sivakumar
7586098f78
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.18.0 to 2.18.1
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-16 10:44:50 +01:00
Siyuan Zhang
3897103b77 etcdserver: add metric counters for livez/readyz health checks.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2023-11-14 09:26:00 -08:00
Sharath Sivakumar
acd5724689
dependency: bump go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.19.0 to 1.20.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-13 12:18:48 +01:00
Sharath Sivakumar
8066e8116b
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.45.0 to 0.46.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-13 11:53:02 +01:00
vivekpatani
8da89177a9 etcdctl,etcdutl,pkg,server,tests,tools: bump github.com/spf13/cobra from 1.7.0 to 1.8.0
- https://github.com/etcd-io/etcd/pull/16878/

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-09 11:02:36 -06:00
vivekpatani
ed30fb1226 *: bump golang.org/x/sys from 0.13.0 to 0.14.0
- https://github.com/etcd-io/etcd/pull/16875

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-09 11:02:36 -06:00
Tessa Pham
2b7e1c6f82 fix scripts
Signed-off-by: Tessa Pham <hpham111@bloomberg.net>
2023-11-08 00:27:13 -06:00
vivekpatani
d2ada92830 etcdctl,etcdutl,server,tests: update golang.org/x/time to v0.4.0
- https://github.com/etcd-io/etcd/pull/16880

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-07 11:01:51 -06:00
vivekpatani
8264b4e9ae clientv3,server,tests: bump dependencies identified by dependabot
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-05 09:27:37 -06:00
Chao Chen
8a6c1335e2 v3rpc: run health notifier to listen on online defrag state change
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-10-28 17:49:24 -07:00
Benjamin Wang
1101655b9f bump bbolt to 1.3.8 for main branch
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-10-26 16:34:15 +01:00