Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
19,273 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

1074 Commits

Author SHA1 Message Date
demoManito
72cf0cc04a etcd: modify declaring empty slices 
declare an empty slice to var s []int replace  s :=[]int{}, https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices

Signed-off-by: demoManito <1430482733@qq.com>
 2022-09-16 14:41:14 +08:00
Bogdan Kanivets
c31d758189 functional: remove SIGQUIT_ETCD_AND_REMOVE_DATA_AND_STOP_AGENT command 
Problem: both SIGQUIT_ETCD_AND_REMOVE_DATA_AND_STOP_AGENT and test.sh
will attempt to stop agents and remove directories.

Solution: since test.sh creates directories and starts test, it should be
responsible for cleanup.

See https://github.com/etcd-io/etcd/issues/14384

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
 2022-09-15 10:55:32 -07:00
Marek Siarkowicz
b5bbf04503
Merge pull request #14460 from ahrtr/fix_TestV3AuthRestartMember_20220913 
Integration_test: fix the flaky test TestV3AuthRestartMember
 2022-09-14 09:44:15 +02:00
Benjamin Wang
e8ad008067 integration_test: fix the flaky test TestV3AuthRestartMembe 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-14 14:30:37 +08:00
Marek Siarkowicz
157ee32da4 test: Clean incorrectly used StopSignal field from expect 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-09-13 15:22:45 +02:00
Marek Siarkowicz
92d8d7f41e
Merge pull request #14445 from tjungblu/movelead_main 
etcdctl: fix move-leader for multiple endpoints
 2022-09-09 11:20:33 +02:00
Thomas Jungblut
3fc16608f7 etcdctl: fix move-leader for multiple endpoints 
Due to a duplicate call of clientConfigFromCmd, the move-leader command
would fail with "conflicting environment variable is shadowed by corresponding command-line flag".
Also in scenarios where no command-line flag was supplied.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
 2022-09-09 10:38:13 +02:00
Clark
6a5dd09fe6 tests: Migrate member remove tests to common framework 
Signed-off-by: Clark <fwyongxing@gmail.com>
 2022-09-09 15:09:10 +08:00
Yingrong Zhao
57206f9dfb shutdown tracer provider first 
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
 2022-09-06 11:26:31 -04:00
Marek Siarkowicz
f0c95cadea
Merge pull request #14281 from clarkfw/migrate-member-add-tests 
tests: Migrate member add tests to common framework
 2022-09-06 09:27:28 +02:00
Clark
fcc076fb78 tests: Migrate member add tests to common framework 
Signed-off-by: Clark <fwyongxing@gmail.com>
 2022-09-06 11:02:54 +08:00
Benjamin Wang
cc840336f0 move consistent_index forward when executing alarmList operation 
The alarm list is the only exception that doesn't move consistent_index
forward. The reproduction steps are as simple as,

```
etcd --snapshot-count=5 &
for i in {1..6}; do etcdctl  alarm list; done
kill -9 <etcd_pid>
etcd
```

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-05 10:05:55 +08:00
Clark
3f3149b15f tests: fix failed integration test cases after enabling --strict-reconfig-check by default 
Signed-off-by: Clark <fwyongxing@gmail.com>
 2022-09-03 15:56:51 +08:00
Clark
3beb25489d tests: enable --strict-reconfig-check by default and expose it to common framework 
Signed-off-by: Clark <fwyongxing@gmail.com>
 2022-08-31 22:21:23 +08:00
Benjamin Wang
e1c5d2a9ac fix test code compiling error due to not enough arguments in call to node0.Restart 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-08-30 13:15:04 +08:00
Piotr Tabor
de41f83343
Merge pull request #14383 from serathius/context-e2e 
tests: Add context to e2e cluster start
 2022-08-29 21:12:12 +02:00
Allen Ray
c52108942b
Merge branch 'main' into main 2022-08-29 12:07:27 -04:00
Benjamin Wang
fdf22b241a add the missing parameter 'name' into SpawnCmdWithLogger for cov test 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-08-29 13:37:23 +08:00
Hitoshi Mitake
9c8326bb50
Merge pull request #14358 from vivekpatani/main 
server/auth: refresh cache on each NewAuthStore
 2022-08-27 11:13:59 +09:00
Benjamin Wang
dc4b810195
Merge pull request #14388 from niconorsk/fix/notify-systemd-when-cluster-ready-times-out 
etcdmain: Honour ExperimentalWaitClusterReadyTimeout in startEtcd
 2022-08-26 18:34:52 +08:00
Nicolai Moore
e15bdd9df1 etcdmain: Honour ExperimentalWaitClusterReadyTimeout in startEtcd 
When we can't reach quorum, we were waiting forever and never sending
the systemd notify message. As a result, systemd would eventually time out
and restart the etcd process which likely would make the unhealthy cluster
in an even worse state

Improves #13785

Signed-off-by: Nicolai Moore <niconorsk@gmail.com>
 2022-08-26 18:06:50 +10:00
Benjamin Wang
f00578c3cd
Merge pull request #14389 from ahrtr/cleanup_e2e_fields 
Cleanup some e2e test configurations
 2022-08-26 15:05:53 +08:00
Marek Siarkowicz
70de5c8937 tests: Add context to e2e cluster start 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-08-26 08:08:17 +02:00
Benjamin Wang
17b83ea810 Cleanup some e2e test configurations 
Notes:
1. compactPhysical in ctlCtx and withQuota aren't used at all, they are dead code.
2. quotaBackendBytes in ctlCtx isn't used either. Instead, users (test cases) set the QuotaBackendBytes directly.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-08-26 13:53:33 +08:00
Marek Siarkowicz
46fe4b8e1c tests: Rename common client lease methods to match 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-08-26 07:12:47 +02:00
Marek Siarkowicz
b7272df69f tests: Remove dummy client implementations 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-08-26 07:12:47 +02:00
Marek Siarkowicz
72bec6fbc2 tests: Add context to common client interface 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-08-26 07:12:45 +02:00
Benjamin Wang
e40828540c
Merge pull request #14354 from biosvs/add-client-auto-sync-to-proxy 
Added client-auto-sync-interval argument to the grpc-proxy
 2022-08-26 05:36:01 +08:00
Vitalii Levitskii
be58a2539c Added client-auto-sync-interval argument to the grpc-proxy 
Signed-off-by: Vitalii Levitskii <vitalii@uber.com>
 2022-08-25 15:33:38 +03:00
Marek Siarkowicz
f36a8782f0
Merge pull request #14345 from nic-chen/tests/watch 
tests: Migrate watch test to common framework
 2022-08-25 13:35:34 +02:00
Marek Siarkowicz
7086a06490
Merge pull request #14377 from tjungblu/flake_14333 
Add ErrTimeoutDueToLeaderFail as expected error
 2022-08-25 10:04:53 +02:00
Benjamin Wang
82bf79d4ce
Merge pull request #14376 from biosvs/fix-expect-package 
Fixed infinite loop in ExpectProcess.ExpectFunc
 2022-08-25 05:29:30 +08:00
Vitalii Levitskii
71c5360f98 Fixed infinite loop in ExpectProcess.ExpectFunc 
Signed-off-by: Vitalii Levitskii <vitalii@uber.com>
 2022-08-24 16:46:24 +03:00
Thomas Jungblut
e1e92e9c0d Add ErrTimeoutDueToLeaderFail as expected error 
This fixes ci flakes where timeouts are expected to happen in network
partitions.
issue: #14333

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
 2022-08-24 13:56:45 +02:00
vivekpatani
ae608da7e6 server,test: refresh cache on each NewAuthStore 
- permissions were incorrectly loaded on restarts.
- https://github.com/etcd-io/etcd/issues/14355

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
 2022-08-23 20:11:47 -07:00
nic-chen
f6ed36372b tests: Migrate watch test to common framework 
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
 2022-08-22 21:55:57 +08:00
Sahdev Zala
192d635da9
Merge pull request #14292 from tjungblu/debug_e2e 
Add test name to e2e cluster members
 2022-08-20 19:30:44 -04:00
Benjamin Wang
d8ee37641d Cleanup all etcd-agent and etcd processes when the test finishes 
There are two cases, when interrupted by users, then forcibly kill
all processes. Otherwise, gracefully terminate all processes.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-08-18 17:15:39 +08:00
Benjamin Wang
2f51d3d9b7 improve the performance of starting functional test 
The proxy must be waiting for the etcd to be running, but the current
implementation hard codes the wating time as 5 seconds. The improvement
is to dynamically check whether the etcd is running, and start the
proxy when etcd port is reachable.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-08-18 04:18:11 +08:00
Sam Batschelet
76a5902efa server/etcdmain: add configurable cipher list to gRPC proxy listener 
Signed-off-by: Allen Ray <alray@redhat.com>
 2022-08-17 10:56:27 -04:00
Yingrong Zhao
ea2f299ba0 embed: add integration test for distributed tracing 
To verify distributed tracing feature is correctly setup, this PR adds
an integration test for this feature.
In the process of writing the test, I discovered a goroutine leak due to
the TraceProvider not being closed. This PR fixs this issue as well.

Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
 2022-08-15 11:19:10 -04:00
Benjamin Wang
bba4eb4d81 Improve functional test code 
Get duplicated code wraped in common functions, and simplify
error handling.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-08-15 16:59:39 +08:00
Clark
0b9f43410a tests: e2e and integration share TickDuration constant 
Signed-off-by: Clark <fwyongxing@gmail.com>
 2022-08-14 18:49:46 +08:00
Clark
a5409c62e6 tests: add WaitLeader function to common framework 
Signed-off-by: Clark <fwyongxing@gmail.com>
 2022-08-11 12:46:40 +08:00
Clark
7fa88fb8f7 tests: fix status responses size and nil 
Signed-off-by: Clark <fwyongxing@gmail.com>
 2022-08-03 03:10:45 +08:00
Thomas Jungblut
51933a7c8b Add test name to e2e cluster members 
This should aid in debugging test flakes, especially in tests where the process is restarted very often and thus changes its pid.
Now it's a lot easier to grep for different members, also when different tests fail at the same time.
The test TestDowngradeUpgradeClusterOf3 as mentioned in #13167 is a good example for that.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
 2022-08-01 15:57:16 +02:00
Benjamin Wang
68c0cf834a
Merge pull request #14288 from VladSaioc/bugfix-goleak-watchtest 
Fixed goroutine leak in tests/integration/clientv3/watch_test.go
 2022-08-01 06:55:57 +08:00
Benjamin Wang
9e9e500d57
Merge pull request #14287 from VladSaioc/bugfix-queue-test 
Fixed goroutine leak
 2022-08-01 06:52:40 +08:00
VladSaioc
2c89834608 Fixed goroutine leak in tests/integration/v3_watch_restore_test.go 
Signed-off-by: VladSaioc <vladsaioc10@gmail.com>
 2022-07-31 23:28:26 +02:00
VladSaioc
cbfddfe63f Fixed goroutine leak in tests/integration/clientv3/watch_test.go 
Signed-off-by: VladSaioc <vladsaioc10@gmail.com>
 2022-07-31 23:09:50 +02:00