21588 Commits

Author SHA1 Message Date
Marek Siarkowicz
24e05998c6
Merge pull request #18287 from fuweid/update-goleak
client/pkg/testutil: update interestingGoroutines
2024-07-06 08:15:27 +02:00
Wei Fu
ccaea7edae client/pkg/testutil: update interestingGoroutines
The Go runtime uses runtime Finalizer to delete cert [[1]]. The
interestingGoroutines is able to collect stack like,

```plain
leak.go:103: Found leaked goroutined BEFORE test appears to have leaked :
        sync.(*Map).LoadAndDelete(0xc00031e180, {0xe07320, 0xc00009fde0})
                /usr/local/go/src/sync/map.go:272 +0x192
        sync.(*Map).Delete(...)
                /usr/local/go/src/sync/map.go:297
        crypto/tls.(*certCache).evict(...)
                /usr/local/go/src/crypto/tls/cache.go:73
        crypto/tls.(*certCache).active.func1(0x0?)
                /usr/local/go/src/crypto/tls/cache.go:65 +0x67
```

It's caused by GC instead of leaky goroutine. interestingGoroutines
should skip it.

[1]: 8e1fdea831/src/crypto/tls/cache.go (L63)

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-07-05 22:24:37 +08:00
Marek Siarkowicz
c9fdc609bb
Merge pull request #18277 from siyuanfoundation/rbst
robustness: remove head rev match in validateGotAtLeastOneProgressNotify
2024-07-04 16:00:03 +02:00
Benjamin Wang
1b251939e6
Merge pull request #18282 from thedtripp/changelogBumpGoVersion
CHANGELOG: Update  to reflect go version 1.21.12 bump
2024-07-04 13:33:07 +01:00
Marek Siarkowicz
8a3d833950
Merge pull request #18278 from ahmetb/patch-1
Update CHANGELOG-3.5 with backported commit
2024-07-04 09:20:50 +02:00
Marek Siarkowicz
241dc9ed1e
Merge pull request #18281 from harshitasao/scorecard-badge-link
changed the scorecard badge link to the standard format
2024-07-04 09:19:57 +02:00
James Blair
059371a02f
Merge pull request #18250 from jmhbnz/main
Remove gsutil acl command for bucket permissions from release.sh
2024-07-04 13:43:54 +12:00
James Blair
345501c1df
Merge pull request #18280 from ivanvc/check-tools-mod-in-verify-deps
make: Include tools/mod when checking dependency versions
2024-07-04 13:29:49 +12:00
D Tripp
9b87477ded changelog: udpate changelog to reflect go version 1.21.12 bump.
Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-07-04 00:30:12 +00:00
Ivan Valdes
ddfa70fb55
dependency: bump tools/mod google.golang.org/genproto/googleapis/rpc to v0.0.0-20240520151616-dc85e6b867a5
Use the same version across all the modules from the project.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-07-03 15:24:25 -07:00
Ivan Valdes
ba4b2bffeb
make: Include tools/mod when checking dependency versions
As tools/mod is not part of the test library's modules, the check to verify
consistent dependency versions ignored it. Explicitly get the dependencies from
this module when running verify-dep.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-07-03 15:21:31 -07:00
harshitasao
6dce6631de changed the scorecard badge link to the standard format
Signed-off-by: harshitasao <harshitasao@gmail.com>
2024-07-04 01:59:59 +05:30
Benjamin Wang
dcef14a32f
Merge pull request #18273 from ArkaSaha30/deps_mgmt_1_7_24
Follow up manual Dependency Bump
2024-07-03 20:14:40 +01:00
Ahmet Alp Balkan
c467a57838 Update CHANGELOG-3.5
Mention the 0a960a2 backported to 3.5 release in the changelog.

Signed-off-by: Ahmet Alp Balkan <ahmet@linkedin.com>
2024-07-03 18:13:51 +00:00
Siyuan Zhang
cded6b0ac6 robustness: remove head rev match in validateGotAtLeastOneProgressNotify
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-07-03 09:03:54 -07:00
ArkaSaha30
5a8e77ffc2
dependency: bump github.com/prometheus/common from 0.54.0 to 0.55.0
This commit bumps github.com/prometheus/common from 0.54.0 to 0.55.0 in tools/mod.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-03 14:30:59 +05:30
Benjamin Wang
0f24953852
Merge pull request #18266 from ArkaSaha30/deps_mgmt_1_7_24
[2024-07-03] Manual Dependency Bump
2024-07-03 07:33:30 +01:00
Benjamin Wang
0a5d905209
Merge pull request #18270 from thedtripp/main-go-2024-2963
Bump Go version to 1.22.5: GO-2024-2963 fix.
2024-07-03 07:29:55 +01:00
D Tripp
8f974669c5 Bump Go version to 1.22.5: GO-2024-2963 fix.
Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-07-03 05:07:03 +00:00
ArkaSaha30
fc33323a5d
dependency: bump github.com/prometheus/common from 0.54.0 to 0.55.0
This commit will bump the dependency github.com/prometheus/common from 0.54.0 to 0.55.0

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-03 00:58:28 +05:30
ArkaSaha30
708c3d8cf4
dependency: bump github.com/bgentry/speakeasy from 0.1.0 to 0.2.0
This commit will bump dependency github.com/bgentry/speakeasy from 0.1.0 to 0.2.0
raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-03 00:56:44 +05:30
Benjamin Wang
37cbd6cd97
Merge pull request #18233 from jcferretti/etcdctl-minmaxcreatemod
etcdctl: add support for filtering by {min,max} x {create,mod} x {revision}
2024-07-02 18:55:09 +01:00
Cristian Ferretti
07b35dd7e3 etcdctl: add support for filtering by {min,max} x {create,mod} x {revision}
Signed-off-by: Cristian Ferretti <jcferretti2020@gmail.com>
2024-07-02 12:48:00 -04:00
Marek Siarkowicz
bf78a233ff
Merge pull request #18245 from ahmetb/ahmet/supress-log
Suppress noisy basic auth token deletion log
2024-07-02 09:41:52 +02:00
James Blair
2af08e0642
Merge pull request #18256 from etcd-io/dependabot/github_actions/github/codeql-action-3.25.11
build(deps): bump github/codeql-action from 3.25.10 to 3.25.11
2024-07-02 06:47:36 +12:00
dependabot[bot]
7ed3359a89
build(deps): bump github/codeql-action from 3.25.10 to 3.25.11
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.10 to 3.25.11.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](23acc5c183...b611370bb5)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-01 17:04:16 +00:00
James Blair
04082b7672
Merge pull request #18249 from ivanvc/remove-govulncheck-github-workflow
github: remove govulncheck action
2024-06-30 05:13:39 +12:00
James Blair
f0246a9f84
Remove gsutil acl command for bucket permissions.
The bucket is already fully public so new releases don't need to run this command.

This will prevent significant terminal spam during the release process as there are thousands of objects in the bucket.

Signed-off-by: James Blair <mail@jamesblair.net>
2024-06-29 17:39:06 +12:00
Ivan Valdes
34361a1a81
github: remove govulncheck action
This job has already been migrated to prow.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-28 22:07:01 -07:00
James Blair
8e20ad03ac
Merge pull request #18246 from ivanvc/update-3.4.33-release-date
changelog/3.4: set 3.4.33 release date
2024-06-29 11:54:03 +12:00
Ivan Valdes
396e2918f7
changelog/3.4: set 3.4.33 release date
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-28 15:30:56 -07:00
Ahmet Alp Balkan
ec289a8129 Suppress noisy basic auth token deletion log
Right now the basic auth tokens that are deleted after `--auth-token-ttl`
cause info-level logs to be emitted. Change this to debug. This helps with
the issue at #18244 where calling `/readyz` frequently pollutes the etcd server
logs with this log message.

Fixes #18244.

Signed-off-by: Ahmet Alp Balkan <ahmet@linkedin.com>
2024-06-28 12:12:01 -07:00
James Blair
1c22e7b36b
Merge pull request #18243 from masonyc/cleanup-unneeded-logger-check
etcd-client: Clean up unnecessary nil Logger check
2024-06-28 21:42:11 +12:00
Benjamin Wang
3cd044f4bd
Merge pull request #18201 from MadhavJivrajani/e2e-issue-18089
tests/e2e: add e2e test to reproduce issue 18089
2024-06-28 09:43:10 +01:00
Mason Chen
7dec366acd etcdclient: Clena up unnecessary nil Logger check
Clean up unnecessary nil Logger for listener.go as pointed out in issue
#18084

Signed-off-by: Mason Chen <mason.yunchen@gmail.com>
2024-06-28 20:11:44 +12:00
Marek Siarkowicz
9d04ab24b8
Merge pull request #18241 from serathius/robustness-failpoint-name
Add failpoint name to test name allowing us to track a per failpoint failures in testgrid
2024-06-27 19:41:48 +02:00
Marek Siarkowicz
c41e02f7b6 Add failpoint name to test name allowing us to track a per failpoint failures in testgrid
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-27 18:35:04 +02:00
Madhav Jivrajani
ebf2cac6bd tests/e2e: add e2e test to reproduce issue 18089
The goal is to reproduce a DELETE event being dropped in a watch after a compaction
occurs on the revision where the deletion took place. In order to reproduce this, we
perform the following sequence (steps for reproduction thanks to @ahrtr):
  - PUT k v2 (assume returned revision = r2)
  - PUT k v3 (assume returned revision = r3)
  - PUT k v4 (assume returned revision = r4)
  - DELETE k (assume returned revision = r5)
  - PUT k v6 (assume returned revision = r6)
  - COMPACT r5
  - WATCH rev=r5

We should get the DELETE event (r5) followed by the PUT event (r6). However, currently we only
get the PUT event with returned revision of r6 (key=k, val=v6).

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-06-27 14:51:12 +05:30
James Blair
21e5876f7f
Merge pull request #18219 from lhy1024/add-etcd-log
[3.5] CHANGELOG: support multiple values for allowed client and peer …
2024-06-26 12:16:19 +12:00
James Blair
38535c2dd8
Merge pull request #18228 from henrybear327/dependency_update/6_24_24
[2024-06-24] Bump dependency updates identified by dependabot
2024-06-26 10:06:48 +12:00
Marek Siarkowicz
917ded9eda
Merge pull request #18214 from serathius/robustness-separate-persisted
Separate persisted responses without knowing their revision to prevent duplicating state during linearization
2024-06-25 23:22:36 +02:00
lhy1024
e7f51cbd5f [3.5] CHANGELOG: support multiple values for allowed client and peer TLS identities
Signed-off-by: lhy1024 <admin@liudos.us>
2024-06-25 20:49:56 +08:00
Benjamin Wang
a897676d54
Merge pull request #18210 from rleungx/update-changelog
Update release-3.6 changelog
2024-06-25 13:22:46 +01:00
Chun-Hung Tseng
5be397a6a8
Fix a linter issue
golangci-lint reports the following issue:
storage/mvcc/kvstore.go:312:27: (*store).restore - result 0 (error) is always nil (unparam)

It's due to the fact that both Attach() and compactLockfree() within the
function restore() are able to return an error, but we only log them in
the current implementation. Thus, the return value restore() is always
nil, hence the linter warning.

We have agreed to suppress the linter warning for now [1].

Reference:
[1] https://github.com/etcd-io/etcd/pull/18228#issuecomment-2187309957

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-25 11:45:53 +02:00
Chun-Hung Tseng
bfc4dc6206
dependency: bump github.com/google/yamlfmt from 0.12.1 to 0.13.0
Reference:
- https://github.com/etcd-io/etcd/pull/18222

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-25 11:23:58 +02:00
Chun-Hung Tseng
bca81b9450
dependency: bump github.com/golangci/golangci-lint from 1.59.0 to 1.59.1
Reference:
- https://github.com/etcd-io/etcd/pull/18223

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-25 11:23:58 +02:00
James Blair
d80d0f0c8b
Merge pull request #18226 from etcd-io/dependabot/github_actions/aquasecurity/trivy-action-0.23.0
build(deps): bump aquasecurity/trivy-action from 0.22.0 to 0.23.0
2024-06-25 09:40:47 +12:00
Marek Siarkowicz
1870222f41 Separate persisted responses without knowing their revision to prevent duplicating state during linearization
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-24 21:38:27 +02:00
Marek Siarkowicz
0dd79f4e18
Merge pull request #18227 from serathius/robustness-test-patch-history
Add tests for patching history to check output and return values
2024-06-24 21:38:18 +02:00
Marek Siarkowicz
35f4556b59 Add tests for patching history to check output and return values
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-24 20:41:32 +02:00