Yicheng Qin
3c1e6b54b3
pkg/netutil: stop resolving in place
...
It helps to copy out a and b, and not modify the original a and b.
2015-08-21 12:09:17 -07:00
Yicheng Qin
1c334979cd
pkg/netutil: not introduce empty url when converting
...
It should not make slices with length and append elements at the same
time.
2015-08-21 12:08:17 -07:00
Yicheng Qin
7b871aab41
pkg/netutil: not export resolve and urlsEqual functions
...
They are only used in this package, so there is no need to public them.
2015-08-21 11:58:37 -07:00
Yicheng Qin
b1192e5c48
pkg/netutil: fix false negative comparison
...
Sort the resolved URLs before DeepEqual, so it will not compare URLs
that may be out of order due to resolution.
2015-08-21 10:15:08 -07:00
Yicheng Qin
72462a72fb
etcdserver: remove TODO to delete URLStringsEqual
...
Discovery SRV supports to compare IP addresses with domain names,
so we need URLStringsEqual function.
2015-08-21 09:52:17 -07:00
Yicheng Qin
8ea3d157c5
Revert "Revert "Treat URLs have same IP address as same""
...
This reverts commit 3153e635d5799f1ff8715fd4b7c07e0283820acd.
Conflicts:
etcdserver/config.go
2015-08-21 09:41:13 -07:00
Xiang Li
e8e507b29b
Merge pull request #3348 from xiang90/l
...
use limited listener from golang
2015-08-20 22:44:51 -07:00
Xiang Li
ff37cc455c
pkg/transport: remove home-grown limitedListener
2015-08-20 20:03:27 -07:00
Xiang Li
92634356c1
*: use limitedListener from golang
2015-08-20 20:02:35 -07:00
Xiang Li
da9a12b97c
Merge pull request #3344 from xiang90/startup_version
...
etcdmain: print out version information on startup
2015-08-20 15:10:25 -07:00
Xiang Li
6b77c146ec
etcdmain: print out version information on startup
2015-08-20 14:50:16 -07:00
Xiang Li
7cf9770e12
Merge pull request #3340 from xiang90/fix_perallocate
...
pkg/fileutil: treat not support error as nil error in preallocate
2015-08-20 11:38:03 -07:00
Xiang Li
3ca5482251
pkg/fileutil: treat not support error as nil error in preallocate
2015-08-20 11:15:02 -07:00
Xiang Li
4a6d6b0052
Merge pull request #3338 from spacejam/master
...
Reversion->Revision
2015-08-20 10:16:31 -07:00
Tyler Neely
acd7a92f03
storage: reversion -> revision
2015-08-20 08:39:07 -07:00
Yicheng Qin
e1dfcec0ab
Merge pull request #3327 from yichengq/bench-2.2
...
docs/benchmarks: add benchmark result for 2.2
2015-08-20 00:18:32 -07:00
Yicheng Qin
807de81172
docs/benchmarks: add benchmark result for 2.2
...
And it analyzes the reason for performance changes.
2015-08-19 23:59:33 -07:00
Yicheng Qin
795e962403
Merge pull request #3334 from mitake/snap-marsharing-prometheus
...
snap: export durations of marsharing cost during snapshot save
2015-08-19 20:59:04 -07:00
Hitoshi Mitake
7a6d33620f
snap: export durations of marshalling cost during snapshot save
...
Currently, total duration of snapshot saving is exported for
prometheus. For more detailed analysis, this commit let etcd export
durations of marshalling for prometheus.
2015-08-20 12:47:07 +09:00
Yicheng Qin
46a2ae77a1
hack/benchmark: add script for benchmark
...
This is for etcd benchmark.
2015-08-19 20:37:27 -07:00
Xiang Li
b0303e948c
Merge pull request #3323 from xiang90/cl_health
...
etcdctl: use health endpoint to greatly simplify health checking
2015-08-19 17:15:52 -07:00
Xiang Li
568d1c6783
etcdctl: use health endpoint to greatly simplify health checking
2015-08-19 11:47:08 -07:00
Xiang Li
60387dc408
Merge pull request #3320 from yichengq/doc-rtt
...
docs: document how to set heartbeat interval and election timeout
2015-08-19 11:08:05 -07:00
Xiang Li
28b61acd9e
Merge pull request #3324 from xiang90/raft_logging
...
raft: downgrade the logging around snapshot to debugf
2015-08-18 17:18:08 -07:00
Xiang Li
d01b6cd639
Merge pull request #3326 from elimisteve/master
...
client: fixed typo in WatcherOptions docs
2015-08-18 16:49:43 -07:00
Steve Phillips
952827157a
client: fixed typo in WatcherOptions docs
...
specifices -> specifies
2015-08-18 16:43:09 -07:00
Xiang Li
b3d2a621ab
Merge pull request #3325 from elimisteve/master
...
client: spelling error in docs (occured -> occurred)
2015-08-18 16:35:13 -07:00
Steve Phillips
69fc796926
client: spelling error in docs (occured -> occurred)
2015-08-18 16:26:52 -07:00
Xiang Li
50c1db3fbf
raft: downgrade the logging around snapshot to debugf
...
Snapshot related logging is spamming when leader trying to
sync a failed peer.
2015-08-18 15:43:53 -07:00
Yicheng Qin
7082d3a765
docs: document how to set heartbeat interval and election timeout
...
It gives more details about how to set heartbeat interval and election
timeout correctly based on RTT.
2015-08-18 13:54:44 -07:00
Xiang Li
28cec1128d
Merge pull request #3322 from philips/use-proxy-as-default-endpoint
...
Procfile: use proxy as default
2015-08-18 12:38:51 -07:00
Yicheng Qin
087061e434
Merge pull request #3303 from yichengq/auth-path
...
use canonical path for auth
2015-08-18 12:06:48 -07:00
Yicheng Qin
4778d780a8
pkg/pathutil: change copyright for path.go
...
The file only contains the function that is borrowed from std http lib,
so we use their copyright.
2015-08-18 11:48:22 -07:00
Brandon Philips
9106675fd4
Procfile: use proxy as default
...
I think it makes sense to make the proxy listen on the default port so
we can give the proxy more testing by default. Also, this should make it
easy to kill a single etcd member and test that etcdctl still works,
etc.
However, I have hit a bug: the proxy takes several seconds
2015-08-18 09:42:13 -07:00
Yicheng Qin
fab3feab66
etcdctl/role: reject non-canonical permission path
...
Non-canonical permission path is useless because the path received
by auth is always canonical, which is due to our ServeMux always
redirects request to canonical path().
This helps users to detect path permission setting error early.
Ref: http://godoc.org/net/http#ServeMux
2015-08-18 08:59:53 -07:00
Yicheng Qin
b5ec7f543a
client: use canonical url path in request
...
The main change is that it keeps the trailing slash. This helps
auth feature to judge path permission accurately.
2015-08-18 08:59:48 -07:00
Yicheng Qin
927d5f3d26
Merge pull request #3301 from yichengq/ca-file
...
etcdmain: update -ca-file description
2015-08-17 23:36:33 -07:00
Yicheng Qin
c0747a7b8b
etcdmain: update -ca-file description
...
so people could deprecate old flags and use new flags much easier.
2015-08-17 22:36:04 -07:00
Yicheng Qin
bcb4d5d53e
Merge pull request #3311 from yichengq/request-timeout
...
extend hardcoded timeout for globally-deployed etcd cluster
2015-08-17 17:00:24 -07:00
Xiang Li
dfc6b4436f
Merge pull request #3315 from xiang90/key_err
...
etcdhttp:write etcderror for all errors in keyhandler
2015-08-17 16:54:12 -07:00
Yicheng Qin
ffae601af5
etcdmain: calculate dial timeout for peer transport
...
This helps peer communication in globally-deployed cluster.
2015-08-17 16:52:53 -07:00
Yicheng Qin
1375ef8985
etcdserver: remove getVersion timeout
...
The request can still time out because we have set dial timeout and
read/write timeout. It increases timeout expectation from 1s to 5s,
but it makes it workable in globally-deployer cluster.
2015-08-17 16:50:40 -07:00
Xiang Li
c7fbc01ef1
Merge pull request #3314 from sebschrader/proxy-loop
...
Warn about proxy loops with incorrect advertise-client-urls
2015-08-17 16:04:00 -07:00
Xiang Li
d487cf6b63
etcdhttp:write etcderror for all errors in keyhandler
2015-08-17 15:51:29 -07:00
Sebastian Schrader
f70950ff93
docs: warn about proxy loops with incorrect advertise-client-urls
2015-08-18 00:42:48 +02:00
Yicheng Qin
c530385d6d
Merge pull request #3313 from yichengq/internal-timeout
...
etcdserver: use ReqTimeout only
2015-08-17 15:05:46 -07:00
Xiang Li
af6d1d3d95
Merge pull request #3310 from xiang90/http_err
...
*: key handler should write auth error as etcd error
2015-08-17 14:57:19 -07:00
Yicheng Qin
2d5b95c49f
etcdserver: use ReqTimeout only
...
We cannot refer RTT value from heartbeat interval, so CommitTimeout
is invalid. Remove it and use ReqTimeout instead.
2015-08-17 14:54:25 -07:00
Xiang Li
87f061bab2
*: key handler should write auth error as etcd error
2015-08-17 14:45:45 -07:00
Xiang Li
ba3a9b5f92
Merge pull request #3309 from xiang90/enforce
...
etcdserver: add version enforcement when setting cluster version
2015-08-17 12:41:04 -07:00