16236 Commits

Author SHA1 Message Date
Wei Fu
4b7c1f49dd *: update tests for watch API when compact on tombstone revision
Signed-off-by: Wei Fu <fuweid89@gmail.com>
(cherry picked from commit ee33652775842b96d1c0ab601ec3002078998c2a)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-08-20 19:05:28 +08:00
Benjamin Wang
f3fc5c7a7d
Merge pull request #18455 from fuweid/34-backport-18274-part1
[3.4] tests/e2e: add e2e test to reproduce issue 18089
2024-08-19 11:11:56 +01:00
Benjamin Wang
d489b14db5
Merge pull request #18456 from fuweid/34-backport-18274-part2
[3.4] mvcc/*_test.go: should not use duplicate revision.Main for one key
2024-08-19 11:11:38 +01:00
Wei Fu
c88871f8a3 mvcc/*_test.go: should not use duplicate revision.Main for one key
Backport of #18321

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-08-17 12:22:32 +08:00
Madhav Jivrajani
40bd8c90a7 tests/e2e: add e2e test to reproduce issue 18089
The goal is to reproduce a DELETE event being dropped in a watch after a compaction
occurs on the revision where the deletion took place. In order to reproduce this, we
perform the following sequence (steps for reproduction thanks to @ahrtr):
  - PUT k v2 (assume returned revision = r2)
  - PUT k v3 (assume returned revision = r3)
  - PUT k v4 (assume returned revision = r4)
  - DELETE k (assume returned revision = r5)
  - PUT k v6 (assume returned revision = r6)
  - COMPACT r5
  - WATCH rev=r5

We should get the DELETE event (r5) followed by the PUT event (r6). However, currently we only
get the PUT event with returned revision of r6 (key=k, val=v6).

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
(cherry picked from commit ebf2cac6bda38892121585d2467982da54e60ef1)
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-08-17 11:25:28 +08:00
Benjamin Wang
c12e9555e8
Merge pull request #18445 from henrybear327/3.4_go/1.22.0
[release-3.4] Bump go toolchain to 1.22.6
2024-08-16 19:21:34 +01:00
Chun-Hung Tseng
24194255c4
Fix minute endpoint trailing space issue
Reference:
- https://github.com/etcd-io/etcd/pull/18445#issuecomment-2290739111

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-08-16 17:20:51 +02:00
Benjamin Wang
e0ef96983f
Merge pull request #18452 from ahrtr/lease_5members_20240816_3.4
[3.4] test: extend leaseRevoke and leaseRenew test to support 5 members cluster
2024-08-16 16:01:08 +01:00
Benjamin Wang
f837a750f8 test: extend leaseRevoke and leaseRenew test to support 5 members cluster
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-08-16 13:31:49 +01:00
James Blair
0b9e1718cf
Merge pull request #18448 from thedtripp/backportOwnersFile2
Complete backport of OWNERS file.
2024-08-16 17:19:50 +12:00
D Tripp
eec63afcfd Complete backport of OWNERS file.
Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-08-16 00:49:41 +00:00
Chun-Hung Tseng
307e30772b Bump go toolchain to 1.22.6
Reference:
- https://github.com/etcd-io/etcd/issues/18443

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-14 23:57:06 +02:00
Benjamin Wang
1956a4783e
Merge pull request #18440 from ahrtr/improve_leaseRenew_20240814_3.4
[3.4] Skip leadership check if the etcd instance is active processing heartbeats
2024-08-14 21:23:01 +01:00
Benjamin Wang
9dee9b7ab5 Skip leadership check if the etcd instance is active processing heartbeats
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-08-14 17:00:38 +01:00
Benjamin Wang
b71ae9be55
Merge pull request #18422 from henrybear327/go/3.4-1.21.13
[release-3.4] go version bump from 1.21.12 to 1.21.13
2024-08-08 22:03:00 +01:00
Chun-Hung Tseng
f0534f45c6
[release-3.4] go version bump from 1.21.12 to 1.21.13
Reference: https://github.com/etcd-io/etcd/issues/18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:31:45 +02:00
Marek Siarkowicz
74ae47fa3b
Merge pull request #18396 from serathius/release-3.4-gofail
Upgrade gofail to v0.2.0
2024-08-02 09:31:52 +02:00
Marek Siarkowicz
a071846677 Upgrade gofail to v0.2.0
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-08-02 08:52:43 +02:00
Marek Siarkowicz
6d8a259951
Merge pull request #18389 from etcd-io/dependabot/docker/release-3.4/distroless/static-debian11-1dbe426d60caed5d19597532a2d74c8056cd7b1674042b88f7328690b5ead8ed
build(deps): bump distroless/static-debian11 from `6d31326` to `1dbe426`
2024-08-01 20:41:11 +02:00
dependabot[bot]
2b25e04137
build(deps): bump distroless/static-debian11 from 6d31326 to 1dbe426
Bumps distroless/static-debian11 from `6d31326` to `1dbe426`.

---
updated-dependencies:
- dependency-name: distroless/static-debian11
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-01 17:57:26 +00:00
James Blair
8bd8d2bf8e
Merge pull request #18345 from jmhbnz/release-3.4
[3.4] Remove gsutil acl command for bucket permissions
2024-07-20 19:59:11 +12:00
James Blair
a1375b7814
Remove gsutil acl command for bucket permissions.
The bucket is already fully public so new releases don't need to run this command.

This will prevent significant terminal spam during the release process as there are thousands of objects in the bucket.

Backports f0246a9f84

Signed-off-by: James Blair <mail@jamesblair.net>
2024-07-20 11:47:58 +12:00
Benjamin Wang
dae8ba65ef
Merge pull request #18311 from mohamedawnallah/backport-3.4-fmtgRPCMetadata
[3.4] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing
2024-07-13 07:02:41 +01:00
Mohamed Awnallah
65421460b1
client/v3/watch_test.go: test fmt metadata print
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Co-authored-by: Benjamin Wang <ahrtr>
2024-07-13 01:36:41 +03:00
Mohamed Awnallah
3e71cf50f5
client/v3/watch.go: use fmt for metadata printing
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
2024-07-12 14:36:38 +03:00
Benjamin Wang
518accfded
Merge pull request #18215 from thedtripp/feature/fixFailingReviveChecks
[3.4] installed revive on CI and added doc.go to fix revive linter errors
2024-07-04 13:09:28 +01:00
D Tripp
a72fe1b4c2 etcd 3.4: Fix failing revive checks.
Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-07-03 23:44:16 +00:00
D Tripp
640e54552a etcd 3.4: Install revive linter on CI if not installed.
This is based on commit 4f238837aa and pull request https://github.com/etcd-io/etcd/pull/14872.

Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-07-03 23:44:16 +00:00
Benjamin Wang
f4e506aa24
Merge pull request #18272 from thedtripp/3.4go-2024-2963
[3.4]: Bump Go version to 1.21.12: GO-2024-2963 fix.
2024-07-03 07:30:57 +01:00
D Tripp
45d26bcc60 3.4: Bump Go version to 1.21.12: GO-2024-2963 fix.
Based on commit 74533d94b2ce4cb5bde19c02a652ade7fa9dc5d4 and https://github.com/etcd-io/etcd/pull/18130/

Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-07-03 05:31:08 +00:00
James Blair
9873813674
Merge pull request #18248 from thedtripp/feature/installShellcheckBackport3.4
[3.4] Install shellcheck if it is not present
2024-06-30 05:08:33 +12:00
D Tripp
e3c0ac0bec etcd 3.4: Install shellcheck if not installed.
Include conditional logic to install shellcheck with correct architecture.

This is based on commit 4f23883 and pull request etcd-io#14872.

Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-06-28 23:34:25 +00:00
D Tripp
f599316654 etcd 3.4: fix shellcheck violations [SC2086] by adding double quotes to variables where needed.
Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-06-28 23:32:36 +00:00
Wenjia Zhang
5cd1d285d7 Bump the version to 3.4.33
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
v3.4.33
2024-06-13 14:10:46 +00:00
Benjamin Wang
88ff600ed9
Merge pull request #18139 from ahrtr/3.4_apply_log_20240606
[3.4] print error log when validation on conf change failed
2024-06-07 09:53:21 +01:00
Benjamin Wang
f0276cb4fa print error log when validation on conf change failed
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-06-06 19:34:44 +01:00
Benjamin Wang
041cd4eb31
Merge pull request #18130 from ArkaSaha30/release-3.4-cve-2024-24790
[3.4]Bump Go version to 1.21.11: CVE 2024-24790 fix
2024-06-05 10:37:46 +01:00
ArkaSaha30
74533d94b2
Bump Go version to 1.21.11: CVE 2024-24790 fix
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-06-05 13:56:43 +05:30
Marek Siarkowicz
88c2295768
Merge pull request #18106 from ivanvc/release-3.4-scripts-release-shallow-git-clone
[3.4] scripts/release: shallow clone repository
2024-06-01 07:21:23 +02:00
Ivan Valdes
0e17a3310e
scripts/release: shallow clone repository
Backport of commit 4881e53677f6cb592aa1cf7ee15bfd51e6cf1ff9 / pull
request #18095.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-05-31 15:39:51 -07:00
James Blair
d37a470645
Merge pull request #18016 from MadhavJivrajani/go-version-setup
[release-3.4]  Setup a way to consistently manage go versions across scripts and go.mods
2024-05-16 20:58:56 +12:00
Madhav Jivrajani
90666624f3 .*: sync go toolchain version and add ability to verify versions
This commit adds a script to sync the version present in .go-version
across all go.mod files as the toolchain directive. As part of that,
this commit also modifies go.mod files that did not have synced toolchain
directives.

Additionally, this also adds a script to verify all toolchain and go
directives against the version present in .go-version as follows:
(1) The go directive <= version in .go-version
(2) The toolchain directive == version in .go-version

This script runs as part of the `make verify` target, making it run
as a presbumit by default.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-05-15 15:35:21 +05:30
Benjamin Wang
70cc6cce7e
Merge pull request #17981 from lavishpal/update/golang-to-1.21.10
[3.4] dependency: update golang to 1.21.10
2024-05-10 20:04:10 +01:00
Lavish pal
6566399fa9 update golang to 1.21.10
Signed-off-by: Lavish pal <lvishpal408@gmail.com>
2024-05-10 18:46:43 +05:30
Benjamin Wang
ce4e46202a
Merge pull request #17945 from tjungblu/bboltbump3.4_1.3.10
Bump bbolt to 1.3.10 for 3.4
2024-05-06 11:53:36 +01:00
Thomas Jungblut
1f138ae558 Bump bbolt to 1.3.10 for 3.4
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2024-05-06 11:34:57 +02:00
James Blair
6f05ab9e99
Merge pull request #17919 from etcd-io/dependabot/docker/release-3.4/distroless/static-debian11-6d31326376a7834b106f281b04f67b5d015c31732f594930f2ea81365f99d60c
build(deps): bump distroless/static-debian11 from `046b92c` to `6d31326`
2024-05-03 05:35:25 +12:00
dependabot[bot]
61acd0f257
build(deps): bump distroless/static-debian11 from 046b92c to 6d31326
Bumps distroless/static-debian11 from `046b92c` to `6d31326`.

---
updated-dependencies:
- dependency-name: distroless/static-debian11
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-05-01 17:23:54 +00:00
Benjamin Wang
4ac6554c44
Merge pull request #17896 from ivanvc/release-3.4-fix-grpc-proxy-member-list-not-updated-with-node-deletion
[3.4] fix grpc proxy member list not updated with node deletion
2024-04-30 19:55:07 +01:00
Ivan Valdes
f65ff88511
grpcproxy: fix memberlist results not update when proxy node down
If grpc starts with `--resolver-prefix`, its memberlist will return all
alive proxy nodes. When one GRPC proxy node goes down it shouldn't
return that node, however, it's returned.

Backport of PR #15907 / commit ecfed91e5050431385961573e5c09658a66a59d5.

Co-authored-by: yellowzf <zzhf3311@163.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-04-29 10:22:00 -07:00