17094 Commits

Author SHA1 Message Date
Piotr Tabor
4c6c506575
Merge pull request #13063 from serathius/integration-defer
integration: Use subtests to defer cluster.Terminate call
2021-06-01 17:19:05 +02:00
Piotr Tabor
c15af6df03
Merge pull request #13058 from ptabor/20210531-functional-test-logging
Improve output of the 'functional' tests
2021-06-01 16:09:03 +02:00
Marek Siarkowicz
d669eb038d integration: Use subtests to defer cluster.Terminate call
This fixes cases where Terminate is not called due to t.Fatal call
2021-06-01 15:59:02 +02:00
Piotr Tabor
0edb69ae55
Merge pull request #13060 from serathius/limit
etcdserver:  Fix invalid count returned on Range with Limit
2021-06-01 15:56:29 +02:00
Marek Siarkowicz
182aef6e6b etcdserver: Fix invalid count returned on Range with Limit 2021-06-01 15:04:28 +02:00
Piotr Tabor
ea8b9e6c18 Improve output of the 'functional' tests
- Use go testing infrastructure, such that logs are printed only in
case of failure.
 - Split the test into multiple sub-round and sub-round-testcases such
   that tree of execution reflects the logic.
 - Use 'development' loggers that are formatting the output to be human
readable.
2021-05-31 15:31:48 +02:00
Piotr Tabor
c7cbc6befa
Merge pull request #13027 from lilic/benchmark-readme
tools/benchmark/README.md: Update installation as go get does not work
2021-05-31 10:37:49 +02:00
Lili Cosic
312908c068 tools/benchmark/README.md: Update installation as go get does not work 2021-05-31 10:25:37 +02:00
Piotr Tabor
71448cb516
Merge pull request #13052 from ptabor/20210527-before-test-public
integration.BeforeTest can be run without leak-detection.
2021-05-30 23:20:02 +02:00
Piotr Tabor
004081cc08
Merge pull request #13045 from wilsonwang371/add-benchmark-param
tool: save test parameters in mixed read/write benchmark script.
2021-05-27 20:56:11 +02:00
Piotr Tabor
f15e0b8237 integration.BeforeTest can be run without leak-detection. 2021-05-27 20:55:11 +02:00
Wilson Wang
8389ab8751 tool: save test parameters in mixed read/write benchmark script. 2021-05-26 20:38:49 -07:00
Piotr Tabor
71934ff244
Merge pull request #13010 from ipixiu/imp/store-scheduleCompaction-lock
limit tx lock scope in store.scheduleCompaction
2021-05-26 08:51:44 +02:00
Piotr Tabor
db556c11b2
Merge pull request #13042 from wilsonwang371/no-hardcoded-repeat
tools: no hardcoded repeat times in rw-benchmark scripts
2021-05-26 08:36:10 +02:00
Wilson Wang
2ab2b4035c tools: no hardcoded repeat times in rw-benchmark scripts 2021-05-25 15:43:46 -07:00
Gyuho Lee
adecd73975
Merge pull request #13039 from ptabor/20210525-make-logger-public
Expose clientv3.CreateDefaultZapLoggerConfig
2021-05-25 14:42:42 -07:00
Gyuho Lee
a3f14cdf53
Merge pull request #13040 from wilsonwang371/main
tools: update mixed read/write benchmark script
2021-05-25 14:42:27 -07:00
Piotr Tabor
bda32db121 Expose clientv3.CreateDefaultZapLoggerConfig
Need raised in
f3f4259d3f.

BTW: Alligned the implementation of grpclogs with what we use in embed
server, so reduced the client code dependencies.
2021-05-25 22:59:08 +02:00
Wilson Wang
db8ce62984 tools: update mixed read/write benchmark script 2021-05-25 13:30:56 -07:00
Gyuho Lee
99c8b4dae1
Merge pull request #13038 from wilsonwang371/perf-eval
tools: add mixed read-write performance evaluation scripts
2021-05-25 12:49:02 -07:00
Wilson Wang
79b2777482 tools: add mixed read-write performance evaluation scripts 2021-05-25 12:03:42 -07:00
Sahdev Zala
05674c87fb
Merge pull request #13018 from ipixiu/feature/bolt-compaction-sleep-interval
add bolt compaction sleep interval
2021-05-25 10:06:47 -04:00
Gyuho Lee
7a7b668edb
Merge pull request #12933 from wilsonwang371/shared_txReadBuffer
server: set multiple concurrentReadTx instances share one txReadBuffer
2021-05-24 16:38:14 -07:00
Wilson Wang
9c82e8c72b server: set multiple concurrentReadTx instances share one txReadBuffer. 2021-05-24 15:16:53 -07:00
赵延
64b01a7a8d
Enhance the root permission, when root role exist, it always return rootPerm. (#13006)
etcdctl role grant-permission root readwrite foo.
see etcdctl role get root output.
Before:
Role root
KV Read:
        foo
KV Write:
        foo
After:
Role root
KV Read:
        [, <open ended>
KV Write:
        [, <open ended>
2021-05-24 14:58:00 -07:00
Piotr Tabor
d2e04a7171
Merge pull request #13034 from spzala/updatechangelog
CHANGELOG: add missing default setting for grpc gateway flag
2021-05-24 21:59:14 +02:00
Sahdev Zala
30a67850ce CHANGELOG: add missing default setting for grpc gateway flag
Add missing changelog entry for the flag setting for the
enable-grpc-gateway.
2021-05-24 13:30:09 -04:00
Piotr Tabor
06538eee8d
Merge pull request #13032 from astromechza/patch-1
CHANGELOG: added missing entry for ClientCertFile
2021-05-24 11:39:46 +02:00
Ben Meier
2ca308969d
CHANGELOG: added missing entry for ClientCertFile 2021-05-24 10:08:28 +01:00
AlexStocks
184b0e5d49 add sleep interval 2021-05-24 16:22:00 +08:00
Piotr Tabor
6c72c1b09c
Merge pull request #13024 from timmyyuan/fix-goroutine-leak
Fix the goroutine leak in StubServer
2021-05-21 15:53:57 +02:00
Ting Yuan
838be9c751 Omit the blank line 2021-05-21 21:25:49 +08:00
Ting Yuan
2d2a95c3fb Fix the format issue 2021-05-21 21:23:38 +08:00
Ting Yuan
1b700e5ed8 Fix the goroutine leak in StubServer
---

(If this PR fixes a github issue, please add `Fixes #<xyz>`)

Fixes #13023

(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>`
to link to the master issue)

Master Issue: #13023

*Motivation*

Currently, StubServer can stop itself (by Stop()) before it start its
grpc server (created by Start()). This race condition may lead to a
goroutine leak mentioned by #13023.

*Modifications*

This PR add a channel to force the Stop() started after Start()

*Verify this change*

Please pick either of following options.

- This change is already covered by existing tests, such as *(please describe tests)*.

Test/TestEtcdGrpcResolver
2021-05-21 20:54:06 +08:00
Piotr Tabor
e149da312a
Merge pull request #13017 from gpavanb1/assert_replace
*: Replace internal testutil AssertEqual function
2021-05-21 11:30:07 +02:00
Pavan BG
facba6c663 client: Replace nil value testing with assert.Nil
Multiple errors in previous commit where `nil` is not being detected by `assert.Equal`
2021-05-21 14:18:01 +05:30
Pavan BG
25d3c1b068 *: Fixed go.sum
Ran fix.sh script to correct for differences in go.sum, perhaps due to multiple Golang versions
2021-05-21 13:28:43 +05:30
Pavan BG
ce5bb69c28 client: Added missing packages
go.etcd.io/etcd/client/pkg/v3/testutil: package github.com/stretchr/testify/assert imported from implicitly required module; to add missing requirements, run:
2021-05-20 21:44:12 +05:30
Pavan BG
319ef4aa42 client: Removed AssertEqual function
Used github.com/stretchr/testify/assert to replace the AssertEqual function definition. Required the use of copyToInterface to copy a string slice to the empty interface slice
2021-05-20 21:33:07 +05:30
Pavan BG
d9c5e1f0a2 *: Replace internal testutil AssertEqual function in favour of github.com/stretchr/testify/assert.Equals
To maintain uniformity in testing methodology, assert.Equals has been used everywhere while replacing testutil.AssertEqual

Fixes #13015
2021-05-20 19:55:45 +05:30
Piotr Tabor
b29e8e47a6
Merge pull request #13014 from lilic/functional-socket-reuse
tests/functional: Set socket-reuse-port and socket-reuse-address
2021-05-20 15:00:43 +02:00
Piotr Tabor
e299264cf3
Merge pull request #13011 from lilic/socket-options-file
WIP: client,server: Expose reuse-port and reuse-address so they can be configured via a config file
2021-05-20 13:50:21 +02:00
Lili Cosic
0ee2aba910 .github/workflows/functional.yaml: Adjust to use new script 2021-05-20 13:41:41 +02:00
Lili Cosic
b23ab1f759 tests/functional: Require same version of protoc everwhere
The main genproto.sh script requires latest version, this confirms the
test protoc to do the same.
2021-05-20 13:41:41 +02:00
Lili Cosic
fe2a9bd7e9 Update go.mod and go.sum files after running scripts 2021-05-20 13:41:41 +02:00
Lili Cosic
cb8c0a0507 tests/functional/rpcpb/rpc.pb.go: Regenerate
run ./scripts/genproto.sh
2021-05-20 13:41:41 +02:00
Lili Cosic
13bf7b0766 tests/functional: Set socket-reuse-port and socket-reuse-address
Due to flakes in CI and locally which resulted due to shared servers
there is suspcion that fixed port numbers are to blame. This reuses port
and address.
2021-05-20 13:41:41 +02:00
Piotr Tabor
41227b7a2b
Merge pull request #13012 from gliptak/patch-2
Correct typo
2021-05-20 12:38:38 +02:00
Lili Cosic
e0e4ddc268 test.sh: Reference test.sh instead of deprecated test 2021-05-20 10:00:27 +02:00
Lili Cosic
7957f4461d server/embed/config_test.go: Add unit test for socket options 2021-05-20 10:00:27 +02:00