19570 Commits

Author SHA1 Message Date
Marek Siarkowicz
7261f6a39d
Merge pull request #15713 from jmhbnz/create-membership-issue-template
Add issue template for new membership nominations.
2023-04-14 10:29:36 +02:00
James Blair
8aa00159d6
Add issue template for new membership nominations.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-14 20:08:56 +12:00
Benjamin Wang
22f3e50ada
Merge pull request #15672 from fuweid/cleanup-15514
chore: cleanup #15514 (Rewrite etcd scripts in strict mode)
2023-04-13 13:06:09 +08:00
Wei Fu
9f034fbaa8 chore: use tools/mod to lock the cfssl cmd version
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:06:31 +08:00
Wei Fu
9dc54ca32c chore: add strict mode for pkg/proxy/fixtures/gencerts.sh
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Wei Fu
dc2cf29598 chore: add strict mode to scripts/test_lib.sh
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Wei Fu
8cd5969248 chore: use strict mode for tests/*/*.sh
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Wei Fu
78d2ead804 chore: deprecate tests/manual folder
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Marek Siarkowicz
29e7971721
Merge pull request #15611 from serathius/robustness-merge-failpoints
Robustness merge failpoints
2023-04-12 16:06:30 +02:00
Marek Siarkowicz
e48ef9ea6a tests/robustness: Disable blackholing traffic till snapshot for v3.4.X
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:39:57 +02:00
Marek Siarkowicz
d19752f16a tests/robustness: Unify failpoint lists by depending on availability checking
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:38:30 +02:00
Marek Siarkowicz
625d427eb5 tests/robustness: Separate triggering failpoint from injection
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:36:50 +02:00
Marek Siarkowicz
932415a8d5 tests/robustness: Verify cluster configuration in failpoint availability
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:36:50 +02:00
Benjamin Wang
817aba57c7
Merge pull request #15637 from chaochn47/reduce_e2e_test_runtime
tests/framwork/e2e/cluster.go: revert back to sequential cluster stop to reduce e2e test run time
2023-04-12 14:45:29 +08:00
Chao Chen
941c4afb0c tests/framwork/e2e/cluster.go: revert back to sequential cluster stop to reduce e2e test run time
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-04-11 22:08:18 -07:00
Marek Siarkowicz
6519a15db4
Merge pull request #15639 from ArkaSaha30/add-unit-test-malformed-jwt
server/auth: fix panic a malformed jwt generation and add test-cases
2023-04-11 12:19:28 +02:00
Marek Siarkowicz
daf9d234d8
Merge pull request #15694 from ahrtr/dependency_20230411
Bump some dependencies
2023-04-11 10:55:47 +02:00
Marek Siarkowicz
d6d4e62f60
Merge pull request #15678 from ahrtr/changelog_jwt_panic_20230410
changelog: add items to cover some fixes for 3.5.8 and 3.4.25
2023-04-11 10:51:16 +02:00
Benjamin Wang
0375317166
Merge pull request #15679 from HeavenTonight/main
Fix link for maintainers role and responsibilities in README.md
2023-04-11 13:02:28 +08:00
Benjamin Wang
946be6b3a5 changelog: add items to cover some fixes for 3.5.8 and 3.4.25
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 12:59:06 +08:00
Benjamin Wang
dae1d70189 test: workaround the breaking change in jonboulle/clockwork
See
- https://github.com/jonboulle/clockwork/pull/55
- https://github.com/jonboulle/clockwork/blob/v0.3.0/clockwork.go#L42

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 12:01:09 +08:00
Benjamin Wang
ff08625126 dedpendency: bump gotest.tools/gotestsum from 1.9.0 to 1.10.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 08:56:09 +08:00
Benjamin Wang
dddd4780c2 dependency: bump github.com/spf13/cobra from 1.6.1 to 1.7.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 08:51:26 +08:00
Benjamin Wang
a283eb5e03 dependency: bump golang.org/x/sys from 0.6.0 to 0.7.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 08:47:31 +08:00
Benjamin Wang
eb9b15bf49 dependency: bump golang.org/x/net from 0.8.0 to 0.9.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 08:44:26 +08:00
Benjamin Wang
8a27dd4db4 dependency: bump github.com/jonboulle/clockwork from 0.3.0 to 0.4.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 08:36:44 +08:00
Benjamin Wang
ddcba8329a
Merge pull request #15693 from jmhbnz/fix-preallocate-static-analysis
Fix gofmt for client/pkg/fileutil/preallocate.go
2023-04-11 07:05:40 +08:00
James Blair
ffdd8d79a7
Fix gofmt for client/pkg/fileutil/preallocate.go.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-11 10:57:41 +12:00
Benjamin Wang
0406ab9a29
Merge pull request #15281 from MarkintoshZ/preallocate-docs
Show darwin as supported in fileutil.Preallocate docstring
2023-04-11 06:33:08 +08:00
Benjamin Wang
1683231216
Merge pull request #15667 from fuweid/deflake-issue-15545-TestV3WatchRestoreSnapshotUnsync
tests: deflake TestV3WatchRestoreSnapshotUnsync
2023-04-11 06:00:42 +08:00
Wei Fu
536953ec6c tests: deflake TestV3WatchRestoreSnapshotUnsync
The TestV3WatchRestoreSnapshotUnsync setups three members' cluster.
Before serving any update requests from client, after leader elected,
each member will have index 8 log: 3 x ConfChange +
3 x ClusterMemberAttrSet + 1 x ClusterVersionSet.

Based on the config (SnapshotCount: 10, CatchUpCount: 5), we need to
file update requests to trigger snapshot at least twice.

T1: L(snapshot-index: 11, compacted-index:  6) F_m0(index: 8)
T2: L(snapshot-index: 22, compacted-index: 17) F_m0(index: 8, out of date)

After member0 recovers from network partition, it will reject leader's
request and return hint (index:8, term:x). If it happens after
second snapshot, leader will find out the index:8 is out of date and
force to transfer snapshot.

However, the client only files 15 update requests and leader doesn't
finish the process of snapshot in time. Since the last of
compacted-index is 6, leader can still replicate index:9 to member0
instead of snapshot.

```bash
cd tests/integration
CLUSTER_DEBUG=true go test -v -count=1 -run TestV3WatchRestoreSnapshotUnsync ./
...

INFO    m2.raft 3da8ba707f1a21a4 became leader at term 2        {"member": "m2"}
...
INFO    m2      triggering snapshot     {"member": "m2", "local-member-id": "3da8ba707f1a21a4", "local-member-applied-index": 22, "local-member-snapshot-index": 11, "local-member-snapshot-count": 10, "snapshot-forced": false}
...

cluster.go:1359: network partition between: 99626fe5001fde8b <-> 1c964119da6db036
cluster.go:1359: network partition between: 99626fe5001fde8b <-> 3da8ba707f1a21a4
cluster.go:416: WaitMembersForLeader

INFO    m0.raft 99626fe5001fde8b became follower at term 2      {"member": "m0"}
INFO    m0.raft raft.node: 99626fe5001fde8b elected leader 3da8ba707f1a21a4 at term 2   {"member": "m0"}
DEBUG   m2.raft 3da8ba707f1a21a4 received MsgAppResp(rejected, hint: (index 8, term 2)) from 99626fe5001fde8b for index 23      {"member": "m2"}
DEBUG   m2.raft 3da8ba707f1a21a4 decreased progress of 99626fe5001fde8b to [StateReplicate match=8 next=9 inflight=15]  {"member": "m2"}

DEBUG   m0      Applying entries        {"member": "m0", "num-entries": 15}
DEBUG   m0      Applying entry  {"member": "m0", "index": 9, "term": 2, "type": "EntryNormal"}

....

INFO    m2      saved snapshot  {"member": "m2", "snapshot-index": 22}
INFO    m2      compacted Raft logs     {"member": "m2", "compact-index": 17}
```

To fix this issue, the patch uses log monitor to watch "compacted Raft
log" and expect that two members should compact log twice.

Fixes: #15545

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-10 22:27:58 +08:00
guiyong.ou
53cce31680 Fix link for maintainers role and responsibilities in README.md
Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

Fix link for maintainers role and responsibilities in README.md

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>

fix

Signed-off-by: guiyong.ou <guiyong.ou@daocloud.io>
2023-04-10 12:58:44 +08:00
ArkaSaha30
a1fa3bfe51 Add test cases for malformed jwt fix
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2023-04-10 09:38:49 +05:30
Benjamin Wang
3393d13567
Merge pull request #15675 from Mskxn/main
fix: different errc to avoid confused when timeout
2023-04-10 10:22:02 +08:00
Msk
a3743a79bc tests: use separate errc for each case in TestTxnPanics
Signed-off-by: Msk <118117161+Mskxn@users.noreply.github.com>
2023-04-10 09:16:39 +08:00
Benjamin Wang
f7af6b64ba
Merge pull request #15673 from fuweid/chore-expect-pkg-comment
chore: remove pkg/expect TODO comment
2023-04-09 14:06:22 +08:00
Wei Fu
85b4da6121 chore: remove pkg/expect TODO comment
https://github.com/google/goexpect has been archived on Feb 7, 2023.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-09 12:57:32 +08:00
Benjamin Wang
da36ce2fe9
Merge pull request #15670 from etcd-io/dependabot/github_actions/github/codeql-action-2.2.11
build(deps): bump github/codeql-action from 2.2.10 to 2.2.11
2023-04-08 17:15:30 +08:00
dependabot[bot]
ce089755e1
build(deps): bump github/codeql-action from 2.2.10 to 2.2.11
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.10 to 2.2.11.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](8c8d71dde4...d186a2a36c)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-08 06:58:00 +00:00
Benjamin Wang
08e6d67b3c
Merge pull request #15650 from etcd-io/dependabot/github_actions/github/codeql-action-2.2.10
build(deps): bump github/codeql-action from 2.2.9 to 2.2.10
2023-04-08 14:57:28 +08:00
Marek Siarkowicz
7153a8f2f4
Merge pull request #15646 from serathius/robustness-readme-watch-issue
tests/robustness: Document analysing watch issue
2023-04-07 23:45:42 +02:00
Marek Siarkowicz
caa775d235
Merge pull request #15663 from serathius/2fa
Require 2FA enabled for all members
2023-04-07 10:59:11 +02:00
Marek Siarkowicz
620956a613
Merge pull request #15654 from ahrtr/changelog_bump_go_20230406
changelog: update items to cover the some new changes in 3.5 and 3.4
2023-04-07 10:55:27 +02:00
Marek Siarkowicz
535ff9638b
Merge pull request #15617 from serathius/robustness-client-refactor
tests: Make using etcdctl expicit in e2e tests
2023-04-07 10:51:01 +02:00
Marek Siarkowicz
7a0e27ac21
Merge pull request #15657 from serathius/maintainers-update
Update maintainer list
2023-04-07 10:47:45 +02:00
Marek Siarkowicz
d72220400b Require 2FA enabled for all members
After this PR is merge, I will enable enforcement on etcd org.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-07 10:41:51 +02:00
Benjamin Wang
64176be02f changelog: update items to cover some changes in 3.5 and 3.4
1. Bumped golang to 1.19.8;
2. etcdserver: set zap logging to wsproxy;
3. Fix CVE-2021-28235.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-07 13:47:13 +08:00
dependabot[bot]
4ea5c08abc build(deps): bump github/codeql-action from 2.2.9 to 2.2.10
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.9 to 2.2.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](04df1262e6...8c8d71dde4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-07 13:06:23 +08:00
Marek Siarkowicz
89f3e20c18 Update maintainer list
Got a confirmation from Sam that he is retiring his contributions.
Removing Tobias as raft was moved to separate repo.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-06 21:12:13 +02:00
Marek Siarkowicz
5327d91c20
Merge pull request #15586 from serathius/changelog-v3.5.8
changelog: Refactor changelog and add changes for v3.5.8
2023-04-06 14:47:16 +02:00