11837 Commits

Author SHA1 Message Date
Sam Batschelet
78f1a05493 version: 3.2.32
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
2021-03-26 13:04:17 -04:00
Sam Batschelet
7a07e9f3b3
Merge pull request #12639 from retroflexer/check-nil-decoder
wal: fix panic when decoder not set
2021-01-21 13:13:55 -05:00
Sahdev P. Zala
8d4ab97008 wal: fix panic when decoder not set
Handle the related panic and clarify doc.
2021-01-21 13:00:34 -05:00
Piotr Tabor
79c998d91a
Merge pull request #12638 from retroflexer/check-slice-range-in-ReadAll
wal: check out of range slice in "ReadAll", "decoder"
2021-01-21 14:26:24 +01:00
Gyuho Lee
b14255c0b4 wal: check out of range slice in "ReadAll", "decoder"
wal: add slice bound checks in decoder

CHANGELOG-3.5: add wal slice bound check
CHANGELOG-3.5: add "decodeRecord"

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2021-01-21 07:25:04 -05:00
Piotr Tabor
13465d6d3d
Merge pull request #12553 from kolyshkin/3.2-fix-lock
[3.2 backport] pkg/fileutil: fix constant for linux locking
2021-01-16 22:19:50 +01:00
Moritz Both
229492c969 pkg/fileutil: fix constant for linux locking
The constant F_OFD_GETLK is 36, not 37, according to
/usr/include/bits/fcntl-linux.h
Credits go to joakim-tjernlund who digged deep enough
to find this.

Fixes #31182
2020-12-14 10:59:42 -08:00
Gyuho Lee
ba92a0e70f version: 3.2.31
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
v3.2.31
2020-08-18 09:37:40 -07:00
Gyuho Lee
55db5b49e8 etcdserver: add OS level FD metrics
Similar counts are exposed via Prometheus.
This adds the one that are perceived by etcd server.

e.g.

os_fd_limit 120000
os_fd_used 14
process_cpu_seconds_total 0.31
process_max_fds 120000
process_open_fds 17

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-08-18 09:37:11 -07:00
Gyuho Lee
b7243f0175 pkg/runtime: optimize FDUsage by removing sort
No need sort when we just want the counts.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-08-18 09:35:58 -07:00
Gyuho Lee
7619b2f744 etcdserver/etcdserverpb: change protobuf field type from int to int64
ref. https://github.com/etcd-io/etcd/pull/12106

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-08-18 09:34:43 -07:00
Jingyi Hu
17acb61209
Merge pull request #11691 from wswcfan/fix-etcd-3.2-to-3.3-upgrade-bug
etcdserver: fix LeaseRevoke may fail to apply when authentication is enabled and upgrading cluster from etcd-3.2 to etcd-3.3
2020-05-22 03:28:16 +08:00
shawwang
6e77b87c06 auth, etcdserver: attaching a fake root token when calling LeaseRevoke
fix LeaseRevoke may fail to apply when authentication is enabled
and upgrading cluster from etcd-3.2 to etcd-3.3 (#11691)
2020-05-11 23:49:14 +08:00
Gyuho Lee
b7644ae5f0 version: 3.2.30
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
v3.2.30
2020-04-01 10:48:30 -07:00
Gyuho Lee
325f2d253c wal: add "etcd_wal_writes_bytes_total"
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-04-01 10:48:27 -07:00
Gyuho Lee
b05103392d pkg/ioutil: add "FlushN"
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-04-01 10:44:18 -07:00
Gyuho Lee
b69c0023c9 version: 3.2.29
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
v3.2.29
2020-03-18 17:19:14 -07:00
Gyuho Lee
35d1d2d58e etcdserver/api/v3rpc: handle api version metadata, add metrics
ref.
https://github.com/etcd-io/etcd/pull/11687

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-03-18 17:19:14 -07:00
Gyuho Lee
20b27a887d clientv3: embed api version in metadata
ref.
https://github.com/etcd-io/etcd/pull/11687

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

clientv3: fix racy writes to context key

=== RUN   TestWatchOverlapContextCancel

==================

WARNING: DATA RACE

Write at 0x00c42110dd40 by goroutine 99:

  runtime.mapassign()

      /usr/local/go/src/runtime/hashmap.go:485 +0x0

  github.com/coreos/etcd/clientv3.metadataSet()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/ctx.go:61 +0x8c

  github.com/coreos/etcd/clientv3.withVersion()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/ctx.go:47 +0x137

  github.com/coreos/etcd/clientv3.newStreamClientInterceptor.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/client.go:309 +0x81

  google.golang.org/grpc.NewClientStream()

      /go/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/stream.go:101 +0x10e

  github.com/coreos/etcd/etcdserver/etcdserverpb.(*watchClient).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/etcdserver/etcdserverpb/rpc.pb.go:3193 +0xe9

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).openWatchClient()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:788 +0x143

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).newWatchClient()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:700 +0x5c3

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).run()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:431 +0x12b

Previous read at 0x00c42110dd40 by goroutine 130:

  reflect.maplen()

      /usr/local/go/src/runtime/hashmap.go:1165 +0x0

  reflect.Value.MapKeys()

      /usr/local/go/src/reflect/value.go:1090 +0x43b

  fmt.(*pp).printValue()

      /usr/local/go/src/fmt/print.go:741 +0x1885

  fmt.(*pp).printArg()

      /usr/local/go/src/fmt/print.go:682 +0x1b1

  fmt.(*pp).doPrintf()

      /usr/local/go/src/fmt/print.go:998 +0x1cad

  fmt.Sprintf()

      /usr/local/go/src/fmt/print.go:196 +0x77

  github.com/coreos/etcd/clientv3.streamKeyFromCtx()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:825 +0xc8

  github.com/coreos/etcd/clientv3.(*watcher).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:265 +0x426

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:959 +0x23e

Goroutine 99 (running) created at:

  github.com/coreos/etcd/clientv3.(*watcher).newWatcherGrpcStream()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:236 +0x59d

  github.com/coreos/etcd/clientv3.(*watcher).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:278 +0xbb6

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:959 +0x23e

Goroutine 130 (running) created at:

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:979 +0x76d

  github.com/coreos/etcd/clientv3/integration.TestWatchOverlapContextCancel()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:922 +0x44

  testing.tRunner()

      /usr/local/go/src/testing/testing.go:657 +0x107

==================

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-03-18 17:19:14 -07:00
Gyuho Lee
42d749057d etcdserver/api/etcdhttp: log server-side /health checks
ref.
https://github.com/etcd-io/etcd/pull/11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2020-03-18 17:19:14 -07:00
Joe Betz
a0d497b54a
mvcc/backend: Delete orphaned db.tmp files before defrag 2020-02-13 12:44:59 -08:00
Sam Batschelet
2d861f39e9 version: 3.2.28
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
v3.2.28
2019-11-03 07:33:22 -05:00
Gyuho Lee
aaab73020c
Merge pull request #11316 from jingyih/automated-cherry-pick-of-#11308-upstream-release-3.2
Automated cherry pick of #11308 on release-3.2
2019-10-30 21:24:44 -07:00
Jingyi Hu
e2cb1a417c etcdserver: wait purge file loop during shutdown
To prevent the purge file loop from accidentally acquiring the file lock
and remove the files during server shutdowm.
2019-10-30 17:07:03 -07:00
Gyuho Lee
fb5e7bfe00
Merge pull request #11277 from wenjiaswe/fixtests
e2e test: remove metricsURLScheme from e2e tests
2019-10-17 17:12:27 -07:00
Wenjia Zhang
8a0b902bc6 Fix e2e tests failure 2019-10-17 17:02:47 -07:00
Gyuho Lee
db9f5b0e43
Merge pull request #11271 from wenjiaswe/automated-cherry-pick-of-#11261-upstream-release-3.2
cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.2
2019-10-17 14:17:44 -07:00
Wenjia Zhang
fc5f94144b Add cluster version fix #11233, #11254, #11265 2019-10-17 12:39:47 -07:00
Gyuho Lee
a038dc6464 tests/e2e: test cluster version
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-10-17 12:39:47 -07:00
Gyuho Lee
5454bb9982 etcdserver/*: add "etcd_cluster_version" metric
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-10-17 12:39:47 -07:00
Gyuho Lee
cc959b4e5a
Merge pull request #11195 from andyliuliming/release-3.2-cherry
etcdserver: cherry-pick skip client san verification option for 3.2 version.
2019-10-09 09:42:22 -07:00
Andy Liu
c552f11bfe helper document update. 2019-10-09 13:32:13 +08:00
Andy Liu
ab1f4fec07 etcdserver: add unit test. 2019-10-03 16:03:47 +08:00
Andy Liu
e16076a8e0 etcdserver: cherry-pick skip client san verification option for 3.2 version.
Co-authored-by: Martin Weindel <martin.weindel@sap.com>
Co-authored-by: Jingyi Hu <jingyih@google.com>
Co-authored-by: Liming Liu <andyliuliming@outlook.com>
2019-10-03 10:15:09 +08:00
Gyuho Lee
bdd97d5ffa version: 3.2.27
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
v3.2.27
2019-09-17 13:32:44 -07:00
Gyuho Lee
b7fab558a1
Merge pull request #11157 from gyuho/release-3.2-patch
etcdctl/ctlv3: do not modify db file on "restore"
2019-09-17 11:10:58 -07:00
Gyuho Lee
c7e4e50879 scripts: remove "ACI" builds
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-09-16 22:53:44 -07:00
zhesi.huang
4e375497ea etcdctl/ctlv3: do not modify db file on "restore" 2019-09-16 22:43:25 -07:00
Jingyi Hu
c074e5c12b
Merge pull request #11135 from jingyih/automated-cherry-pick-of-#11126-origin-release-3.2
Automated cherry pick of #11126 on release-3.2
2019-09-07 00:03:52 -07:00
Jingyi Hu
948c284235 mvcc: add store revision metrics
Add experimental metrics etcd_debugging_mvcc_current_revision and
etcd_debugging_mvcc_compact_revision.
2019-09-06 17:22:45 -07:00
Gyuho Lee
85015077a4
Merge pull request #10794 from jingyih/automated-cherry-pick-of-#10788-origin-release-3.2
Automated cherry pick of #10788 on release-3.2
2019-06-05 14:40:04 -07:00
Jingyi Hu
6dd1e913a1 ctlv3: add missing newline in EndpointHealth
To make the output consistent with the output before #9540.
2019-06-05 14:37:59 -07:00
Gyuho Lee
4a1ffd836a
Merge pull request #10783 from jingyih/cherrypick_9540_to_release3p2
ctlv3: cherry pick of #9540 to release 3.2
2019-06-04 09:52:32 -07:00
Gyuho Lee
64d53adb1f ctlv3: support "write-out" for "endpoint health" command
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2019-06-03 17:30:31 -07:00
Luc Perkins
29d42fa1d2
Documentation metadata for 3.2 branch (#10695)
* Add documentation metadata and remove v2 docs

Signed-off-by: lucperkins <lucperkins@gmail.com>

* Add upgrade _index.md

Signed-off-by: lucperkins <lucperkins@gmail.com>
2019-04-30 14:02:44 -07:00
Joe Betz
42f7d25d8c
Merge pull request #10657 from jpbetz/automated-cherry-pick-of-#10646-release-3.2
Automated cherry pick of #10646
2019-04-18 14:10:05 -07:00
Yingnan Zhang
bcbe6dbc29
mvcc: fix db_compaction_total_duration_milliseconds 2019-04-17 16:32:46 -07:00
Joe Betz
e06761ed79
Merge pull request #10452 from jpbetz/automated-cherry-pick-of-#10443-origin-release-3.2
Automated cherry pick of #10443 to release 3.2
2019-02-06 09:59:10 -08:00
Iskander Sharipov
1d80d5f497
etcdctl: fix strings.HasPrefix args order
Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
2019-02-05 13:17:54 -08:00
Gyuho Lee
06cec40911 version: 3.2.26
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
v3.2.26
2019-01-11 10:04:58 -08:00