Thomas Jungblut
86bc0a25c4
etcdctl: fix move-leader for multiple endpoints
...
Due to a duplicate call of clientConfigFromCmd, the move-leader command
would fail with "conflicting environment variable is shadowed by corresponding command-line flag".
Also in scenarios where no command-line flag was supplied.
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2022-09-08 15:51:19 +02:00
Marek Siarkowicz
6cc1345a0b
Migrate PR testing from travis to GitHub actions
2021-06-23 18:25:29 +02:00
Saeid Bostandoust
4bacd21e20
fix check datascale command for https endpoints
2021-06-11 11:58:20 +02:00
jingyih
379d01a0d2
etcdctl: fix member add command
...
Use members information from member add response, which is
guaranteed to be up to date.
2020-02-29 07:18:11 -08:00
Jingyi Hu
b7ff97f54e
etcdctl: fix member add command
2019-10-03 13:52:22 -07:00
Gyuho Lee
ea45cd61d0
Merge pull request #10788 from jingyih/add_missing_newline_EndpointHealth
...
ctlv3: add newline in EndpointHealth output
2019-06-05 02:19:54 -07:00
Jingyi Hu
17e10fe13f
ctlv3: add missing newline in EndpointHealth
...
To make the output consistent with the output before #9540 .
2019-06-04 15:52:29 -07:00
Hitoshi Mitake
5a67dd788d
*: support creating a user without password
...
This commit adds a feature for creating a user without password. The
purpose of the feature is reducing attack surface by configuring bad
passwords (CN based auth will be allowed for the user).
The feature can be used with `--no-password` of `etcdctl user add`
command.
Fix https://github.com/coreos/etcd/issues/9590
2019-05-30 21:59:30 +09:00
Gyuho Lee
34bd797e67
*: revert module import paths
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2019-05-28 15:39:35 -07:00
WizardCXY
a039f2efb8
clientv3, etcdctl: MemberPromote for learner
2019-05-15 13:48:52 -07:00
Jingyi Hu
355d0ab2a6
*: add learner field in endpoint status
...
Added learner field to endpoint status API.
2019-05-15 13:13:59 -07:00
Jingyi Hu
2b76200f70
*: add MemberAddAsLearner to clientv3 Cluster API
...
Made changes to Clientv3 Cluster API:
- Added MemberAddAsLearner.
- Reverted changes to MemberAdd - removed input parameter isLearner.
2019-05-14 16:56:44 -07:00
Jingyi Hu
1e38de5b9d
etcdctl: add learner field in member list output
2019-05-14 13:10:22 -07:00
Jingyi Hu
a67d934410
etcdctl: support MemberAdd for learner
...
Added support for "etcdctl member add --learner".
2019-05-14 13:10:22 -07:00
Jingyi Hu
fc14608cb7
clientv3: support MemberAdd for learner
...
Added IsLearner flag to clientv3 MemberAdd API.
2019-05-14 13:10:22 -07:00
shivaramr
9150bf52d6
go modules: Fix module path version to include version number
2019-04-26 15:29:50 -07:00
Iskander Sharipov
48a2442fd7
etcdctl: fix strings.HasPrefix args order
...
Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
2019-02-02 02:39:27 +03:00
Mark McLoughlin
36d7acf330
etcdctl: fix interactive mode panic
...
Don't panic if command is given in interactive mode, give a nice error
message instead.
Before:
$ ./bin/etcdctl watch -i
<hit return>
panic: runtime error: index out of range
goroutine 1 [running]:
etcdctl/ctlv3/command.watchInteractiveFunc(...)
etcd/etcdctl/ctlv3/command/watch_command.go:104 ...
After:
$ ./bin/etcdctl watch -i
<hit return>
Invalid command: (watch and progress supported)
foo
Invalid command foo (only support watch)
2019-01-14 13:01:37 +00:00
Sam Batschelet
a82703b69e
*: error strings should not end with punctuation or a newline (ST1005)
...
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
2019-01-08 21:04:20 -05:00
Jingyi Hu
5b6b03d081
etcdctl: add timeout to snapshot save command
...
snapshot save command by default has no timeout, but respects user
specified command timeout.
2018-12-04 20:36:48 -08:00
Shin'ya Ueoka
aa4313a55a
*: fix github links
2018-11-10 11:14:18 +09:00
Sam Batschelet
fa35126ef8
*: add client support for discovery-srv-name
...
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
2018-11-09 10:13:04 -05:00
Gyuho Lee
1a8c520979
ctlv3: fix gofmt
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2018-09-28 09:53:24 -07:00
Danny Sauer
36d227c9e5
etcdctl: Prettier error handling in member add
...
Maintain existing error message for not-enough-args
Add "too many args" if too many args
Add more helpful error message if v2 syntax was used
New output:
```
sauer@host:~/dev/etcd$ ./bin/etcdctl --endpoints http://localhost:5001 member add
Error: member name not provided.
sauer@host:~/dev/etcd$ ./bin/etcdctl --endpoints http://localhost:5001 member add node2 node2
Error: too many arguments
sauer@host:~/dev/etcd$ ./bin/etcdctl --endpoints http://localhost:5001 member add node2 http://localhost:6002
Error: too many arguments, did you mean "--peer-urls http://localhost:6002 "
sauer@host:~/dev/etcd$ ./bin/etcdctl --endpoints http://localhost:5001 member add http://localhost:6002 node2
Error: too many arguments, did you mean "--peer-urls http://localhost:6002 "
```
2018-09-25 16:50:57 -05:00
Gyuho Lee
0ef9ef3c74
*: rerun "gofmt"
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2018-08-28 18:25:39 -07:00
Gyuho Lee
d37f1521b7
*: update import paths to "go.etcd.io/etcd"
...
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
2018-08-28 17:47:55 -07:00
Sahdev P. Zala
7f001c1f00
etcdctl: fix get command error when no arg provided
...
The current error is incorrect. Providing a similar one to the del
command.
2018-08-19 19:54:18 -04:00
Gyuho Lee
42bef8460c
*: clean up code format
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-07-21 16:34:56 -07:00
Joe Betz
4b51b6de49
*: Add progress notify request watch request
2018-06-27 16:46:13 -07:00
Gyuho Lee
65192fddfa
ctlv3: support TLS endpoints for move-leader command
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-06-05 13:48:09 -07:00
Sahdev P. Zala
eff8166a45
Check: correct the memory limit
...
We should be doing 3M not 30 as it's said in the doc comment.
2018-06-05 09:46:56 -04:00
Gyuho Lee
dbb37f98fd
Merge pull request #9730 from mitake/user-w-colon
...
etcdctl: add --password flag to the subcommand user add
2018-05-29 11:14:46 -07:00
Vimal K
807dfcea78
etcdctl: fixes 9583. trim spaces in ETCDCTL_ENDPOINTS
2018-05-26 04:58:06 +05:30
Gyuho Lee
9149565cb3
*: move to "etcdserver/api/membership"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-05-21 10:31:16 -07:00
Gyuho Lee
4d80753804
etcdctl: rename internal snapshot packages
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-05-21 07:45:34 -07:00
Hitoshi Mitake
8fcab98bf2
etcdctl: add flags for specifying password
...
This commit adds two flags to etcdctl:
1. `--password` flag to etcdctl as a global option. It can be used for
specifying password for authentication required for the command
execution.
2. `--new-user-password` flag to `etcdctl user add`. It can be used
for specifying password of newly created user by the command.
The main motivation of the flags is allowing user to have : in its
name.
Fix https://github.com/coreos/etcd/issues/9691
2018-05-21 16:18:01 +09:00
Gyuho Lee
7a92bbfed2
etcdserver/*: move internal v2 packages
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-05-14 12:49:49 -07:00
Gyuho Lee
167c711467
etcdctl/ctlv3: fix fmt test warnings
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-05-09 15:39:44 -07:00
Sahdev P. Zala
8ba41d5191
etcdctl/check: create progress bar for datascale
...
Create a progress bar. The bar will show progress for a given workload.
Fixes #9328
2018-05-08 18:32:54 -04:00
Gyuho Lee
44cda79105
etcdctl/ctlv3: fix watch with exec commands
...
Following command was failing because the parser incorrectly
picks up the second "watch" string in exec command, thus
passing wrong exec commands.
```
ETCDCTL_API=3 ./bin/etcdctl watch aaa -- echo watch event received
panic: runtime error: slice bounds out of range
goroutine 1 [running]:
github.com/coreos/etcd/etcdctl/ctlv3/command.parseWatchArgs(0xc42002e080, 0x8, 0x8, 0xc420206a20, 0x5, 0x6, 0x0, 0x0, 0x0, 0x0, ...)
/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:303 +0xbed
github.com/coreos/etcd/etcdctl/ctlv3/command.watchCommandFunc(0xc4202a7180, 0xc420206a20, 0x5, 0x6)
/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:73 +0x11d
github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).execute(0xc4202a7180, 0xc420206960, 0x6, 0x6, 0xc4202a7180, 0xc420206960)
/home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:766 +0x2c1
github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1363de0, 0xc420128638, 0xc420185e01, 0xc420185ee8)
/home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:852 +0x30a
github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).Execute(0x1363de0, 0x0, 0x0)
/home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:800 +0x2b
github.com/coreos/etcd/etcdctl/ctlv3.Start()
/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/ctl_nocov.go:25 +0x8e
main.main()
/home/gyuho/go/src/github.com/coreos/etcd/etcdctl/main.go:40 +0x17b
```
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-05-03 17:22:34 -07:00
Gyuho Lee
200401248a
Merge pull request #9665 from gyuho/unconvert
...
test: integrate github.com/mdempsky/unconvert
2018-05-01 09:52:44 -07:00
Gyuho Lee
b44e43278a
etcdctl/ctlv3: fix "unconvert" warnings
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-04-30 15:32:16 -07:00
Gyuho Lee
86cee93d6b
etcdctl/ctlv3: remove "strings.Compare == 0"
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-04-30 15:11:11 -07:00
Eric Chiang
55001977ed
etcdctl/ctlv3/command: don't print gRPC WARNING logs by default
...
Despite holding important information, these are too noisy.
See https://github.com/coreos/etcd/pull/9623
2018-04-25 15:26:54 -07:00
Eric Chiang
9ce295a812
etcdctl/ctlv3/command: enable gRPC WARNING logs by default
2018-04-24 16:19:02 -07:00
Gyuho Lee
ae9ccd883d
etcdctl/ctlv3: fix snapshot command e2e tests
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-04-16 17:36:00 -07:00
Gyuho Lee
6dbce6b9a4
clientv3,etcdctl: support structured logger
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-04-16 17:36:00 -07:00
Gyuho Lee
90e5af76f3
etcdctl/ctlv3: use new snapshot package
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-04-12 10:49:48 -07:00
Gyuho Lee
ff455e3567
Merge pull request #9540 from gyuho/hhh
...
ctlv3: support "write-out" for "endpoint health" command
2018-04-06 13:25:11 -07:00
Gyuho Lee
d019d3141a
ctlv3: support "write-out" for "endpoint health" command
...
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2018-04-06 11:31:00 -07:00