18276 Commits

Author SHA1 Message Date
Benjamin Wang
8b6c8b4c96 add unit test for pkg/flags/Uint32FromFlag in uint32_test.go
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-07 04:52:28 +08:00
Benjamin Wang
1a6fe4dbc6 update the comment for MaxConcurrentStreams to clearly state it's the max value for each client.
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-07 04:51:20 +08:00
Benjamin Wang
f40b676701 add e2e test cases to cover the maxConcurrentStreams
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00
Benjamin Wang
053ba95ed5 set max concurrent streams to the http2 server
The default max stream is 250 in http2. When there are more then
250 streams, the client side may be blocked until some previous
streams are released. So we need to support configuring a larger
`MaxConcurrentStreams`.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00
Benjamin Wang
d8347ec683 add & refine the uint32Value data type
The golang buildin package `flag` doesn't support `uint32` data
type, so we need to support it via the `flag.Var`.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00
杨金珏
6220174687 support custom grpc.MaxConcurrentStreams
There is no update on the original PR (see below) for more then 2
weeks. So Benjamin(@ahrtr) continues to work on the PR. The first
step is to rebase the PR, because there are lots of conflicts with
the main branch.

The change to go.mod and go.sum reverted, because they are not needed.
The e2e test cases are also reverted, because they are not correct.

```
https://github.com/etcd-io/etcd/pull/14081
```

Signed-off-by: nic-chen <chenjunxu6@gmail.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-06 03:43:46 +08:00
Marek Siarkowicz
248f072370
Merge pull request #14194 from ahrtr/update_etcdctl_typo
Fix a typo in etcdctl readme for the elect command
2022-07-05 14:55:41 +02:00
Benjamin Wang
231bee6fe2 fix a typo in etcdctl readme for the elect command
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-07-05 16:03:45 +08:00
Benjamin Wang
07d620822f
Merge pull request #14173 from SimFG/ctl_err
ectdctl: Add the `SilenceErrors` config For the `cobra.Command`
2022-07-05 06:10:11 +08:00
Benjamin Wang
960d4c2dce
Merge pull request #14154 from ahrtr/3.4_changelog_lease_revoke_20220624
Update 3.4 change log to cover fixes for two issues
2022-07-05 06:09:38 +08:00
Piotr Tabor
1749a07a20
Merge pull request #14172 from SimFG/snap_log
snap: Delete the nil judgment of the log object
2022-07-04 23:57:15 +02:00
SimFG
66f15f8efb ectdctl: Handle the repeat error message when the unknown command error occurs
Avoid repeated printing of error messages.

Signed-off-by: SimFG <1142838399@qq.com>
2022-07-04 11:02:08 +08:00
Benjamin Wang
33347b6845
Merge pull request #13954 from mitake/perm-cache-lock
server/auth: protect rangePermCache with a mutex
2022-07-03 07:01:46 +08:00
Hitoshi Mitake
de09174a3f server/auth: protect rangePermCache with a RW lock
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
2022-07-02 23:23:13 +09:00
Benjamin Wang
f94af77d4a
Merge pull request #14184 from ahrtr/fix_proxy_test_certificate_20220630
Remove duplicate certificate configuration for proxy test
2022-07-01 05:33:50 +08:00
Benjamin Wang
ae9ca48a3f remove duplicate certificate configuration for proxy test
The issue was introduced in the following commit,
093282f5ea

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-06-30 10:26:36 +08:00
Sahdev Zala
2a0e92fac0
Merge pull request #14182 from spzala/isoptswithprefix
Client: fix check for WithPrefix op
2022-06-29 19:32:05 -04:00
Sahdev Zala
8637c54bcc Client: fix check for WithPrefix op
Make sure that WithPrefix correctly set the flag, and add test.
Also, add test for WithFromKey.

fixes #14056

Signed-off-by: Sahdev Zala <spzala@us.ibm.com>
2022-06-29 17:52:05 -04:00
SimFG
107b7c06ab sanp: Delete the nil judgment of the log object
Move some methods into the `Snapshotter` object for removing the `lg == nil` judgment

Signed-off-by: SimFG <1142838399@qq.com>
2022-06-28 19:35:33 +08:00
Benjamin Wang
7a1cecd5fa
Merge pull request #14165 from eval-exec/expected-process-stopsignal
pkg/expect: send SIGTERM to target expect process instead of SIGKILL for `Stop()`
2022-06-28 12:38:59 +08:00
Benjamin Wang
19f5ff664a
Merge pull request #14166 from chavacava/fix-14162
fix #14162
2022-06-27 09:38:33 +08:00
Marek Siarkowicz
815e05d226
Merge pull request #14160 from chavacava/patch-1
removes empty option in JSON tag
2022-06-26 18:55:51 +02:00
Marek Siarkowicz
64443f108b
Merge pull request #14157 from SimFG/proxy_pb
proxy: Put the pb object into the struct
2022-06-26 18:53:42 +02:00
Marek Siarkowicz
c1da9dd0f0
Merge pull request #14153 from SimFG/verfiy_backend
verify: Get backend using simple api
2022-06-26 18:49:44 +02:00
chavacava
756d77663b removes empty option in JSON tag
option can not be empty in JSON tag

Signed-off-by: chavacava <salvadorcavadini+github@gmail.com>
2022-06-26 12:13:20 +02:00
chavacava
f220bfe1e0 fix #14162
Signed-off-by: chavacava <salvadorcavadini+github@gmail.com>
2022-06-26 11:44:11 +02:00
Eval EXEC
e2bff7cfe1
pkg/expect: send SIGTERM to target expect process instead of SIGKILL
Signed-off-by: Eval EXEC <execvy@gmail.com>
2022-06-26 16:39:30 +08:00
Benjamin Wang
f99c68839f
Merge pull request #14163 from chavacava/fix-14161
fix #14161
2022-06-26 12:43:06 +08:00
chavacava
0887d9acf1 fix #14161
Signed-off-by: chavacava <salvadorcavadini+github@gmail.com>
2022-06-25 10:09:05 +00:00
SimFG
a6bbf7c10b proxy: Put the pb object into the struct
Avoid repeated creation of pb objects.

Signed-off-by: SimFG <1142838399@qq.com>
2022-06-25 10:15:03 +08:00
Benjamin Wang
cabdb13dad
Merge pull request #14152 from pacoxu/patch-2
sync-changelog: /health break change was reverted
2022-06-25 04:42:50 +08:00
Benjamin Wang
899bcc8fe5 update 3.4 change log to cover fixes for two issues
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-06-24 17:46:51 +08:00
SimFG
2a1b7fdb52 verify: Get backend using simple api
Make the code simple and clear.

Signed-off-by: SimFG <1142838399@qq.com>
2022-06-24 16:58:18 +08:00
Paco Xu
8e80173887 sync-changelog: /health break change was reverted
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
2022-06-24 14:57:05 +08:00
Benjamin Wang
33ba5380df
Merge pull request #14146 from SimFG/parse_config
config: Add the default case when failing to parse the log rotate config json
2022-06-24 06:13:29 +08:00
SimFG
1dcd75f8a2 config: Add the default case when failing to parse the log rotate config json
Make sure that the `setupLogRotation` function must return the error when failing parse json.

Signed-off-by: SimFG <1142838399@qq.com>
2022-06-23 19:41:30 +08:00
Benjamin Wang
1da0b011c0
Merge pull request #14141 from ahrtr/3.4_changelog_go_1.16
Update 3.4 change log item for 3.4.19
2022-06-23 04:54:57 +08:00
Benjamin Wang
685435ba34 Update 3.4 change log item for 3.4.19
Changes:
1. Upgrade go version to 1.16 in both go.mod and pieplines;
2. Upgrade boltdb from 1.3.3 to 1.3.6;

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-06-22 10:08:46 +08:00
Piotr Tabor
1a1238814f
Merge pull request #14082 from mikelolasagasti/pb.v3
tools/benchmark: migrate cheggaaa/pb.v1 to cheggaaa/pb/v3
2022-06-21 13:46:20 +02:00
Benjamin Wang
e0998f49e1
Merge pull request #14124 from wayblink/index-op
mvcc:add ut for Revisions/CountRevisions and remove RangeSince as it …
2022-06-21 12:41:25 +08:00
wayblink
428d21f5eb mvcc:add ut for Revisions/CountRevisions and remove RangeSince as it is not used
Signed-off-by: wayblink <wayasxxx@gmail.com>
2022-06-21 11:41:44 +08:00
Mikel Olasagasti Uranga
89637a4223 Tools/benchmark: migrate cheggaaa/pb.v1 to cheggaaa/pb/v3
etcdctl/ctlv3: migrate cheggaaa/pb.v1 to cheggaaa/pb/v3

This commit also changes the format of the progress bar, from using a
custom progress bar to the default provided by the library.

Old behaviour:

./benchmarkv1  put
 0 / 10000 B                                                   !   0.00%
 3987 / 10000 Boooooooooooooom                                 !  39.87%
 10000 / 10000 Boooooooooooooooooooooooooooooooooooooooooooo! 100.00% 1s

New behaviour:

./benchmark put
 6536 / 10000 [----------------------->________________] 65.36% 7053 p/s
10000 / 10000 [---------------------------------------] 100.00% 7581 p/s

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
2022-06-20 15:47:23 +02:00
Marek Siarkowicz
0bac609632
Merge pull request #14133 from ahrtr/changelog_auth_bundle_20220618
update changelog for both 3.5 and 3.6 to cover the authBundle overwrite issue
2022-06-20 10:47:09 +02:00
Benjamin Wang
449ff7b8cb update changelog for both 3.5 and 3.6 to cover the authBundle overwrite issue
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-06-18 07:11:50 +08:00
Benjamin Wang
43434afd48
Merge pull request #14111 from patrocinio/check_perf_doc
Doc: provide more clarify to the usage of check perf command
2022-06-18 05:07:26 +08:00
Piotr Tabor
72b2a06fdb
Merge pull request #14126 from ptabor/20220615-update-grpc3
Update dependencies - including zap (1.21)
2022-06-17 20:25:43 +02:00
Eduardo Patrocinio
e1e3ed11e3 Doc: provide more clarify to the usage of check perf command
This PR describes the fact that different workloads in the `check perf` command
are different, and the results might vary.

Signed-off-by: Eduardo Patrocinio <epatro@gmail.com>
2022-06-17 13:13:58 -03:00
Piotr Tabor
88cd0fe695 Refresh minor dependencies.
Signed-off-by: Piotr Tabor <ptab@google.com>
2022-06-17 10:23:03 +02:00
Piotr Tabor
e7a84b69c8 Update zap to 1.21.
Signed-off-by: Piotr Tabor <ptab@google.com>
2022-06-17 10:05:25 +02:00
Piotr Tabor
8ac23dad88
Merge pull request #14125 from ptabor/20220615-update-grpc2
Update to grpc-1.47 (and fix the connection-string format)
2022-06-17 10:04:11 +02:00