Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
14,853 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

378 Commits

Author SHA1 Message Date
caoming
802e2aaadd etcdserver: remove redundant parentheses. 2019-01-07 10:27:52 +08:00
caoming
b2e0e760a0 etcdserver: add missing lg assignment. 2019-01-05 09:24:48 +08:00
lsytj0413
792aad932f refactor(*): fix golint warning 2018-12-24 11:43:10 +08:00
Gyuho Lee
291768af0f etcdserver/*: add "etcd_cluster_version" metric 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-11-13 21:49:12 -08:00
Shin'ya Ueoka
aa4313a55a *: fix github links 2018-11-10 11:14:18 +09:00
Gyuho Lee
d2a0f17b82
Merge pull request #10155 from gyuho/metrics-messages 
rafthttp: probe all raft transports
 2018-10-09 11:18:31 -07:00
Gyuho Lee
601d8b4677 etcdserver/api/etcdhttp: remove unused "HandleHealth" function 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-10-07 17:16:18 -07:00
Gyuho Lee
004e04a1d1 etcdserver/api/etcdhttp: add "etcd_server_health_success/failures" 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-10-07 17:15:12 -07:00
Gyuho Lee
884a8bd36b etcdserver/api/rafthttp: configure "streamProber" in tests 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-10-07 03:32:05 -07:00
Gyuho Lee
7b1ef37054 etcdserver/api/rafthttp: probe all Raft messages' RTT 
This PR adds another probing routine to monitor the connection
for Raft message transports. Previously, we only monitored
snapshot transports.

In our production cluster, we found one TCP connection had >8-sec
latencies to a remote peer, but "etcd_network_peer_round_trip_time_seconds"
metrics shows <1-sec latency distribution, which means etcd server
was not sampling enough while such latency spikes happen
outside of snapshot pipeline connection.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-10-07 03:28:54 -07:00
Gyuho Lee
4a239070c8 etcdserver/api/rafthttp: display roundtripper name in warnings 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-10-07 03:14:42 -07:00
Gyuho Lee
47cff4dfe5 etcdserver/api/rafthttp: rename to "pipelineProber" 
Preliminary work to add prober to "streamRt"

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-10-07 03:13:10 -07:00
nolouch
4de27039cb server: drop read request if found leader changed 2018-09-14 15:58:35 +08:00
Gyuho Lee
8560221091 etcdserver: fix gofmt warnings with Go 1.11 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-08-28 21:45:12 -07:00
Gyuho Lee
0ef9ef3c74 *: rerun "gofmt" 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-08-28 18:25:39 -07:00
Gyuho Lee
1399bc69ce etcdserver: update import paths to "go.etcd.io/etcd" 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-08-28 17:47:55 -07:00
Sam Batschelet
af85949b41
Merge pull request #10024 from gyuho/became-inactive 
etcdserver/api/rafthttp: clarify "became inactive" warning
 2018-08-24 22:12:16 -04:00
Gyuho Lee
156ff6461d etcdserver/api/rafthttp: clarify "became inactive" warning 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-08-17 17:45:53 -07:00
Jingyi Hu
8d85259b56 etcdserver/api/v3rpc/interceptor: add log level checking 
Check log level before generating and writing log info.
 2018-08-17 16:12:05 -07:00
Gyuho Lee
6f4c509ad8 etcdserver/api/rafthttp: add v3 snapshot send/receive metrics 
Distribution would be:
0.1 second or more
...
25.6 seconds or more
51.2 seconds or more

etcd_network_snapshot_send_success
etcd_network_snapshot_send_failures
etcd_network_snapshot_send_total_duration_seconds
etcd_network_snapshot_receive_success
etcd_network_snapshot_receive_failures
etcd_network_snapshot_receive_total_duration_seconds

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-08-15 12:56:50 -07:00
Gyuho Lee
c392cd20cf etcdserver/api/snap: add v3 snapshot fsync metrics 
etcd_snap_db_fsync_duration_seconds_count
etcd_snap_db_save_total_duration_seconds_bucket

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-08-15 12:56:44 -07:00
Jingyi Hu
368010d8a3 etcdserver: code clean up 
Code clean up in interceptor.go
 2018-08-10 16:29:42 -07:00
Jingyi Hu
30662940f4 vendor: add go-grpc-middleware 
Rebased to master PR #9994.  Fixed a Go format issue in
v3rpc/interceptor.go.  Updated vendor to include go-grpc-middleware.
 2018-08-10 13:15:35 -07:00
Jingyi Hu
dc01734c6b etcdserver: add grpc interceptor to log info on incoming requests to 
etcd server

To improve debuggability of etcd v3. Added a grpc interceptor to log
info on incoming requests to etcd server. The log output includes
remote client info, request content (with value field redacted), request
handling latency, response size, etc. Uses zap logger if available,
otherwise uses capnslog.

Also did some clean up on the chaining of grpc interceptors on server
side.
 2018-08-10 11:01:07 -07:00
Iskander Sharipov
d0f800c930 etcdserver/api/v2discovery: simplify !(x == y) to x != y 
Found using https://go-critic.github.io/overview#boolExprSimplify-ref
 2018-07-28 23:47:17 +03:00
Gyuho Lee
51af6a062f etcdserver: clean up code format 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-21 16:03:16 -07:00
Joe Betz
4b51b6de49
*: Add progress notify request watch request 2018-06-27 16:46:13 -07:00
Gyuho Lee
339cda03b3 etcdserver/api/v3rpc: remove duplicate gRPC logger set 
Fix

=== RUN   TestEmbedEtcd
==================
WARNING: DATA RACE
Write at 0x000001df86d0 by goroutine 711:
  github.com/coreos/etcd/embed.(*Config).setupLogging.func1()
      /go/src/github.com/coreos/etcd/vendor/google.golang.org/grpc/grpclog/loggerv2.go:68 +0x16c
  sync.(*Once).Do()
      /usr/local/go/src/sync/once.go:44 +0xe1
  github.com/coreos/etcd/embed.(*Config).setupLogging()

in gRPC proxy tests.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-18 09:41:37 -07:00
Gyuho Lee
8990126c17 rafthttp: add "RaftDropHeartbeat" failpoint 
To simulate network partition locally.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-15 13:10:58 -07:00
Gyuho Lee
3821f3364d etcdserver/api/rafthttp: add "etcd_network_active_peers/disconnected_peers_total" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:23:45 -07:00
Gyuho Lee
afe78fbe69 etcdserver/api/v2http: document histogram 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
973fe43b83 etcdserver/api/snap: document histograms, add "etcd_snap_fsync_duration_seconds" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
640f5e64a9 etcdserver/api/rafthttp: document round-trip metrics, clean up 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
5a9e48be30 etcdserver/api/rafthttp: increase bucket upperbound up-to 3-sec 
From 0.8 sec to 3.2 sec for more detailed latency analysis

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
a5b32ba941 etcdserver/api/v3rpc: add "etcd_network_server_stream_failures_total" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 08:05:43 -07:00
Sam Batschelet
05554119c9 vendor: use latest "grpc-ecosystem/grpc-gateway" 2018-05-22 17:35:15 -04:00
Gyuho Lee
7940113906 *: move internal "etcdserver/api/rafthttp" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
2dd555c983 *: move "etcdserver/api/v3compactor" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
871c218894 *: move "etcdserver/api/v3alarm" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
9149565cb3 *: move to "etcdserver/api/membership" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
671f1c41a8 etcdserver/api/v2discovery: move internal "discovery" package 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 09:50:38 -07:00
Gyuho Lee
2bd689acea etcdserver/api/snap: rename internal package 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 07:45:34 -07:00
Gyuho Lee
4a4be9275c
Merge pull request #9681 from gyuho/config-log 
doc: deprecate '/config/local/log' in v3.5
 2018-05-15 11:07:07 -07:00
Gyuho Lee
7a92bbfed2 etcdserver/*: move internal v2 packages 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-14 12:49:49 -07:00
Gyuho Lee
294b5745d6 etcdserver/api/v3rpc: support watch fragmentation with max request bytes 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-14 12:35:50 -07:00
Gyuho Lee
7088d2bf52 etcdserver/api/v3rpc: clean up, read lock on "prevKV" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-14 12:35:50 -07:00
Gyuho Lee
e1df2156c7 etcdserver/api/v3rpc: clean up godoc 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-14 12:35:50 -07:00
Gyuho Lee
ba7cc04bac etcdserver/api/v2v3: fix "getDir" with "sorted" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-09 15:42:45 -07:00
Gyuho Lee
8235982f6e etcdserver/api/v2http: remove unused parameters 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-09 15:39:44 -07:00
Gyuho Lee
807770740a etcdserver/api: add TODO to deprecate '/config/local/log' 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-04 21:30:23 -07:00