20298 Commits

Author SHA1 Message Date
Marek Siarkowicz
8345727ece Fix RaftCluster boostrap being based on v3 store while apply is based on v2 store.
Migration off v2 store was unfinished during v3.5 development https://github.com/etcd-io/etcd/pull/12914 leaving RaftCluster broken, half migrated.
This was found in v3.5 and fixed in https://github.com/etcd-io/etcd/pull/13348, however this is was not patched on main branch.

This PR makes v3.6 RaftCluster consistent with v3.5 so we can cleanly
migrate off v2 store.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-09-26 20:26:31 +02:00
Benjamin Wang
55253cee1b
Merge pull request #16652 from fuweid/add-fuweid
Add fuweid as reviewer
2023-09-26 16:54:32 +01:00
Wei Fu
1ee010f5c4 Add fuweid as reviewer
REF: #16650

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-26 23:39:10 +08:00
Benjamin Wang
cfd35afe93
Merge pull request #16636 from ahrtr/grpc_20230925
dependency: bump some dependencies
2023-09-26 12:31:09 +01:00
Marek Siarkowicz
4e7f114fa7
Merge pull request #16638 from fuweid/fix-stylecheck
*: fix stylecheck/unused/unconvert linter issues
2023-09-26 12:15:53 +02:00
Benjamin Wang
4d486a2332 bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.17.0 to 1.18.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-25 21:00:55 +01:00
Benjamin Wang
10cddaaf7c bump go.opentelemetry.io/otel/sdk from 1.17.0 to 1.18.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-25 20:59:30 +01:00
Benjamin Wang
bb85fa8a7f bump gotest.tools/v3 from 3.5.0 to 3.5.1
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-25 20:57:18 +01:00
Benjamin Wang
f90a73c20f bump github.com/mgechev/revive from 1.3.3 to 1.3.4
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-25 20:56:12 +01:00
Benjamin Wang
df7f2d93f8 dependency: bump google.golang.org/grpc from 1.58.1 to 1.58.2
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-25 20:53:56 +01:00
Benjamin Wang
e85949db3a
Merge pull request #16645 from etcd-io/dependabot/github_actions/github/codeql-action-2.21.8
build(deps): bump github/codeql-action from 2.21.7 to 2.21.8
2023-09-25 20:27:42 +01:00
dependabot[bot]
a6d511abe2
build(deps): bump github/codeql-action from 2.21.7 to 2.21.8
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.7 to 2.21.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](04daf014b5...6a28655e3d)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-25 18:53:50 +00:00
Benjamin Wang
06bee68c27
Merge pull request #16646 from etcd-io/dependabot/github_actions/actions/checkout-4.1.0
build(deps): bump actions/checkout from 4.0.0 to 4.1.0
2023-09-25 19:52:40 +01:00
dependabot[bot]
a895710756
build(deps): bump actions/checkout from 4.0.0 to 4.1.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](3df4ab11eb...8ade135a41)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-25 17:48:06 +00:00
Wei Fu
8870cb3070 *: fix unconvert linter
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-25 19:40:45 +08:00
Wei Fu
4704a5af3a *: fix unused issue
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-25 19:37:18 +08:00
Wei Fu
896d161d16 *: fix stylecheck linter
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-25 19:14:01 +08:00
Benjamin Wang
149bcb75ea
Merge pull request #16634 from fuweid/fix-revive
*: fix revive linter
2023-09-25 10:49:01 +01:00
Wei Fu
07effc4d0a *: fix revive linter
Remove old revive_pass in the bash scripts and migirate the revive.toml
into golangci linter_settings.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-24 14:21:11 +08:00
Benjamin Wang
e1ebc260a9
Merge pull request #16628 from fuweid/fix-goimports
*: fix goimports linter
2023-09-22 10:26:14 +01:00
Benjamin Wang
3eae42d810
Merge pull request #16630 from sharathsivakumar/shsi/bump_depedencies_5
bump dependencies manually
2023-09-22 09:48:26 +01:00
Wenjia
c059e5f41f
Merge pull request #16559 from shyamjvs/docs-improvement
Add diagrams for etcd internals and consistent read/write workflows
2023-09-21 11:37:43 -07:00
sharathsivakumar
078b50fe3d
dependency: bump honnef.co/go/tools from 0.4.5 to 0.4.6
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
2023-09-21 20:17:37 +02:00
sharathsivakumar
6060037c53
dependency: bump gotest.tools/gotestsum from 1.10.1 to 1.11.0
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
2023-09-21 20:14:29 +02:00
sharathsivakumar
443ee6eb40
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.43.0 to 0.44.0
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
2023-09-21 20:07:07 +02:00
sharathsivakumar
2048a638fc
dependency: bump google.golang.org/grpc from 1.58.0/1.57.0 to 1.58.1
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
2023-09-21 19:54:54 +02:00
sharathsivakumar
eef790399e
dependency: bump go.uber.org/zap from 1.25.0 to 1.26.0
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
2023-09-21 19:41:16 +02:00
Wei Fu
46df6abb03 *: remove goimports(_fix)_pass and add lint_fix_pass
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-21 21:18:36 +08:00
Wei Fu
aa97484166 *: enable goimports in verify-lint
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-21 21:14:09 +08:00
Benjamin Wang
9079ab3c98
Merge pull request #16626 from fuweid/fix-staticcheck-lint
*: fix staticcheck lint
2023-09-21 11:13:50 +01:00
Wei Fu
c6323b9a52 disable staticcheck for DoubleBarrier.Enter
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-21 17:39:44 +08:00
Wei Fu
502879405f *: lint_pass should use global golangci.yaml
Disable failed linters and enable it by #16610.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-21 16:10:45 +08:00
Wei Fu
2b1e181c8b *: Use golangcilint_pass to run staticcheck and ineffassign
Copy the tools/.golangci.yaml and run the linters for which we have
already fixed. The temp .golangci.yaml will be removed when we fixes all
the linters' issues.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-21 12:34:17 +08:00
Wei Fu
9c3edfa0af *: fix staticcheck lint
Changed TraceKey/StartTimeKey/TokenFieldNameGRPCKey to struct{} to
follow the correct usage of context. Similar patch to #8901.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-21 11:24:26 +08:00
Benjamin Wang
021edb00ed
Merge pull request #16605 from fuweid/fix-ineffassign
*: fix ineffassign lint
2023-09-20 10:54:48 +01:00
Wei Fu
df86cadd8b *: fix ineffassign lint
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-19 22:19:19 +08:00
Benjamin Wang
36403e3909
Merge pull request #16608 from fuweid/fix-shadow-vet
*: fix govet-shadow lint
2023-09-19 15:09:05 +01:00
Benjamin Wang
b3b63fd010
Merge pull request #16621 from ahrtr/gw_20230919
dependency: bump grpc-gateway from 2.17.1 to 2.18.0
2023-09-19 13:25:10 +01:00
Wei Fu
5e3910d96c *: fix govet-shadow lint
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-19 20:24:01 +08:00
Benjamin Wang
ea2d60cad7 dependency: bump grpc-gateway from 2.17.1 to 2.18.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-19 12:17:22 +01:00
Benjamin Wang
892472dd89
Merge pull request #16620 from ahrtr/changelog_grpc_gw_20230919
Update 3.6 changelog to include the grpc-gateway upgrading from v1 to v2 and golang upgrading to 1.21
2023-09-19 11:05:45 +01:00
Benjamin Wang
c15f11041b Update 3.6 changelog to include the grpc-gateway upgrading from v1 to v2 and golang upgrading to 1.21
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-19 09:54:18 +01:00
Benjamin Wang
c70ac642ae
Merge pull request #16595 from ahrtr/gw_20230913
Upgrade grpc-gateway from v1 to v2
2023-09-19 09:39:43 +01:00
Benjamin Wang
357d22667c
Merge pull request #16609 from etcd-io/dependabot/github_actions/github/codeql-action-2.21.7
build(deps): bump github/codeql-action from 2.21.5 to 2.21.7
2023-09-19 07:29:03 +01:00
dependabot[bot]
84d0f1fcc5
build(deps): bump github/codeql-action from 2.21.5 to 2.21.7
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.5 to 2.21.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](00e563ead9...04daf014b5)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-18 17:38:07 +00:00
Benjamin Wang
8eba295bc5 Resolve review comments: add some comments to clarify some confusion script or code
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-18 12:09:46 +01:00
Benjamin Wang
d06cdfa1ee Updated the tools/proto-annotation to exclude grpc.gateway package
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-18 11:22:16 +01:00
Benjamin Wang
5444cdae69 remove all usage of v1 grpc-gateway
1. Manually updated go source file to remove the usage of v1 grpc-gateway;
2. Execute ./scripts/fix.sh

Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-18 11:22:16 +01:00
Benjamin Wang
de41d4d8aa dependency: set github.com/grpc-ecosystem/grpc-gateway/v2 version to 2.17.1 for all modules
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-09-18 11:22:16 +01:00
Benjamin Wang
189f709a5d Apply patches on the generated *.pb.gw.go files to convert v1 messages to v2 messages
Signed-off-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-09-18 11:22:16 +01:00