Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
20,405 Commits 15 Branches 491 Tags
841731bbf01f4fed52a2aa0a5b11603574ebd5d2
Commit Graph

20405 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marek Siarkowicz
841731bbf0 Fix linearization failure not causing test failure 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-13 18:56:22 +02:00
Marek Siarkowicz
57d9a7eec6 Merge pull request #16756 from serathius/robustness-reorder-validation 
Refactor and reorder validation to avoid reporting multiple correlated failures
 2023-10-13 18:12:25 +02:00
Marek Siarkowicz
b02798e946 Refactor and reorder validation to avoid reporting multiple corelated failures 
It doesn't make sense to report watch failure if key value operations
are not linearizable.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-13 14:06:13 +02:00
Benjamin Wang
3eca40d17c Merge pull request #16755 from Juneezee/redundant-len-check 
etcdserver: remove redundant `len` check in health check
 2023-10-13 12:34:54 +01:00
Eng Zer Jun
867faa1924 etcdserver: remove redundant len check in health check 
From the Go specification [1]:

  "1. For a nil slice, the number of iterations is 0."

`len` returns 0 if the slice or map is nil [2]. Therefore, checking
`len(v) > 0` around a loop is unnecessary.

[1]: https://go.dev/ref/spec#For_range
[2]: https://pkg.go.dev/builtin#len

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2023-10-13 18:39:38 +08:00
Marek Siarkowicz
d0d0c33338 Merge pull request #16708 from fuweid/enable-marker-check 
*: enable markdown_marker checker
 2023-10-13 11:54:34 +02:00
Benjamin Wang
a92e0de316 Merge pull request #16753 from fuweid/deflake-TestEtcdTLSVersion 
tests: deflake TestEtcdTLSVersion
 2023-10-13 10:28:04 +01:00
Wei Fu
6f95ea04be tests: deflake TestEtcdTLSVersion 
The proc.Stop just sends the SIGTERM to etcd server. The etcd server
needs time to teardown. If we don't wait for it, the etcd server will
hold the port and then next test case, like TestGrpcProxyAutoSync, will
fail to listen on the port 20000.

```bash
file_/__w/etcd/etcd/tests/fixtures/server.crt_--peer-key-file_/__w/etcd/etcd/tests/fixtures/server.key.insecure_--cert-file_/__w/etcd/etcd/tests/fixtures/server2.crt_--key-file_/__w/etcd/etcd/tests/fixtures/server2.key.insecure_--tls-min-version_TLS1.2_--tls-max-version_TLS1.3) (32856): {"level":"info","ts":"2023-10-13T06:12:32.718845Z","caller":"embed/etcd.go:394","msg":"closing etcd server","name":"e1","data-dir":"/tmp/TestEtcdTLSVersion284993522/001","advertise-peer-urls":["https://127.0.0.1:20000"],"advertise-client-urls":["https://0.0.0.0:0"]}
2023-10-13T06:12:32.7399709Z --- PASS: TestEtcdTLSVersion (1.03s)
2023-10-13T06:12:32.7400181Z === RUN   TestGrpcProxyAutoSync
2023-10-13T06:12:32.7401203Z     logger.go:130: 2023-10-13T06:12:32.719Z	INFO	starting server...	{"name": "TestGrpcProxyAutoSync-test-0"}
2023-10-13T06:12:32.7408306Z     logger.go:130: 2023-10-13T06:12:32.719Z	INFO	spawning process	{"args": ["/__w/etcd/etcd/bin/etcd", "--name=TestGrpcProxyAutoSync-test-0", "--listen-client-urls=http://localhost:20000", "--advertise-client-urls=http://localhost:20000", "--listen-peer-urls=http://localhost:20001", "--initial-advertise-peer-urls=http://localhost:20001", "--initial-cluster-token=new", "--data-dir", "/tmp/TestGrpcProxyAutoSync1139610722/001", "--snapshot-count=10000", "--initial-cluster-token=new", "--initial-cluster=TestGrpcProxyAutoSync-test-0=http://localhost:20001", "--initial-cluster-state=new"], "working-dir": "/__w/etcd/etcd/tests/e2e", "name": "TestGrpcProxyAutoSync-test-0", "environment-variables": ["ETCD_VERIFY=all", "EXPECT_DEBUG=true", "PATH=/__t/go/1.21.3/x64/bin:/go/bin:/__t/go/1.21.3/x64/bin:/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin", "ETCD_UNSUPPORTED_ARCH=amd64"]}

...

2023-10-13T06:12:32.7559855Z /__w/etcd/etcd/bin/etcd (TestGrpcProxyAutoSync-test-0) (32863): {"level":"fatal","ts":"2023-10-13T06:12:32.735191Z","caller":"etcdmain/etcd.go:181","msg":"discovery failed","error":"listen tcp 127.0.0.1:20000: bind: address already in use","stacktrace":"go.etcd.io/etcd/server/v3/etcdmain.startEtcdOrProxyV2\n\tgo.etcd.io/etcd/server/v3/etcdmain/etcd.go:181\ngo.etcd.io/etcd/server/v3/etcdmain.Main\n\tgo.etcd.io/etcd/server/v3/etcdmain/main.go:40\nmain.main\n\tgo.etcd.io/etcd/server/v3/main.go:31\nruntime.main\n\truntime/proc.go:267"}
```

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-10-13 16:48:37 +08:00
Wei Fu
81fe610bd5 *: enable markdown_marker checker 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-10-13 14:00:25 +08:00
Benjamin Wang
bc0f724ae4 Merge pull request #16697 from chaochn47/health_check_bug_fix 
http health check bug fixes
 2023-10-13 05:48:24 +01:00
Chao Chen
c25f1dff82 http health check bug fixes 
Signed-off-by: Chao Chen <chaochn@amazon.com>
 2023-10-12 16:59:34 -07:00
Marek Siarkowicz
6d68ab092d Merge pull request #16707 from serathius/dynamic-flags 
Dynamically generate flags passed to etcd binary
 2023-10-12 18:23:23 +02:00
Marek Siarkowicz
c34ccfbc06 Dynamically generate flags passed to etcd binary 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 17:31:56 +02:00
Marek Siarkowicz
2c86103472 Merge pull request #16748 from serathius/test-dynamic-flags-v2 
Test dynamic flags v2
 2023-10-12 17:26:18 +02:00
Benjamin Wang
bd49f26e9c Merge pull request #16752 from fuweid/update-34-changelog 
CHANGELOG: update 3.4/3.5 golang version
 2023-10-12 16:15:38 +01:00
Wei Fu
42507f4fd8 CHANGELOG: update 3.4/3.5 golang version 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-10-12 22:35:54 +08:00
Marek Siarkowicz
1caf1d32fc Merge pull request #16737 from serathius/disable-failfast 
Continue on e2e failure
 2023-10-12 14:56:49 +02:00
Marek Siarkowicz
c71f60e797 Remove duplicated test 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 14:09:31 +02:00
Marek Siarkowicz
05cc60a539 Use contain to make tests clearer and more resilient to changes 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 14:09:31 +02:00
Marek Siarkowicz
6f63f4b676 Use single string to define a flag allowing for easier testing 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 14:09:29 +02:00
Marek Siarkowicz
d69378bbbd Merge pull request #16747 from serathius/test-dynamic-flags 
Add tests to prepare to dynamic flag generation
 2023-10-12 10:47:11 +02:00
Marek Siarkowicz
6d9a0a40b0 Add tests to prepare to dynamic flag generation 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-11 23:31:39 +02:00
Benjamin Wang
bf800550c6 Merge pull request #16739 from dusk125/http2-update 
bump golang.org/x/net to v0.17.0, google.golang.org/grpc to v1.58.3
 2023-10-11 16:25:16 +01:00
Benjamin Wang
03da2fb55c Merge pull request #16741 from dusk125/go1.21.3 
Bump go to 1.21.3
 2023-10-11 15:53:54 +01:00
Allen Ray
e4c0eb7712 bump google.golang.org/grpc to v1.58.3 
Signed-off-by: Allen Ray <alray@redhat.com>
 2023-10-11 10:39:05 -04:00
Allen Ray
a5580a7292 Bump go to 1.21.3 
Signed-off-by: Allen Ray <alray@redhat.com>
 2023-10-11 10:16:57 -04:00
Allen Ray
3a61187ce3 bump golang.org/x/net to v0.17.0 
Address CVE-2023-39325 and CVE-2023-44487

Signed-off-by: Allen Ray <alray@redhat.com>
 2023-10-11 10:09:14 -04:00
Marek Siarkowicz
b8271d9c70 Continue on e2e failure 
E2e tests has been flaky, with failfast and 2 scenarios tests are twice
as fragile. Any early failure of one of the scenarios cases second to be
canceled. Retryign always require running both scenarios.

Intead let's just wait as in other tests allowing us to retry
just the scenario that failed

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-11 12:25:31 +02:00
Marek Siarkowicz
a404ee5f6b Merge pull request #16735 from serathius/roundrobin 
Return to default write scheduler since golang.org/x/net@v0.11.0 started using round robin
 2023-10-10 21:04:56 +02:00
Marek Siarkowicz
9f40116fa0 Return to default write scheduler since golang.org/x/net@v0.11.0 started using round robin 
Introduction of round robin 120fc906b3
Added in v0.10.0 https://github.com/golang/net/compare/v0.10.0...v0.11.0

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-10 16:31:42 +02:00
Marek Siarkowicz
900877648d Merge pull request #16734 from 0scvr/main 
Update changelog for 3.4 & 3.5
 2023-10-10 14:20:50 +02:00
Oscar
03ceed714e Update changelog for 3.4 & 3.5 
To log the go version 1.20.9 bump.

Signed-off-by: Oscar <5xp395ab@duck.com>
 2023-10-10 12:11:54 +00:00
Marek Siarkowicz
4540db9a7c Merge pull request #16731 from sharathsivakumar/shsi/bump_dependencies_6 
Bump dependencies generated by the bot manually
 2023-10-10 13:51:48 +02:00
Sharath Sivakumar
d884580432 dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.45.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-10-10 11:50:54 +02:00
Sharath Sivakumar
c94deb9511 dependency: bump github.com/prometheus/client_model from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-10-10 11:49:36 +02:00
Sharath Sivakumar
1b1c42a7aa dependency: bump golang.org/x/net from 0.15.0 to 0.16.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-10-10 11:49:35 +02:00
Benjamin Wang
9e7e433b4b Merge pull request #16727 from 0scvr/0scvr/upgrade-go-1.21.2 
Upgrade go version to 1.21.2
 2023-10-10 09:51:43 +01:00
Marek Siarkowicz
16e19a9547 Merge pull request #16269 from dusk125/refactor-revision 
Refactor common revision code to pkg
 2023-10-10 10:16:58 +02:00
Oscar
86ea531b75 etcd: upgrade go version to 1.21.2 
To be up to date with the newest security fix.

Signed-off-by: Oscar <71343264+0scvr@users.noreply.github.com>
 2023-10-09 23:34:26 +02:00
Allen Ray
395376d3ab Refactor common revision code to pkg 
Signed-off-by: Allen Ray <alray@redhat.com>
 2023-10-09 14:53:16 -04:00
Benjamin Wang
20edc39912 Merge pull request #16726 from etcd-io/dependabot/github_actions/ossf/scorecard-action-2.3.0 
build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0
 2023-10-09 19:38:44 +01:00
Benjamin Wang
8e1713dda1 Merge pull request #16714 from fuweid/clean-unconvert_pass 
*: cleanup unconvert_pass and remove revive tools
 2023-10-09 19:38:19 +01:00
Benjamin Wang
2b45c39880 Merge pull request #16725 from etcd-io/dependabot/github_actions/github/codeql-action-2.22.1 
build(deps): bump github/codeql-action from 2.21.9 to 2.22.1
 2023-10-09 19:12:16 +01:00
dependabot[bot]
97fd17d74e build(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](08b4669551...483ef80eb9)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-10-09 17:34:26 +00:00
dependabot[bot]
074128a4d9 build(deps): bump github/codeql-action from 2.21.9 to 2.22.1 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.9 to 2.22.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](ddccb87388...fdcae64e14)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-10-09 17:34:22 +00:00
Wei Fu
82197417f1 tools/mod: remove revive 
We have migrated the revive into golangci-lint.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-10-09 23:28:09 +08:00
Wei Fu
0ec6181466 scripts: remove unconvert_pass 
The `unconvert` has been migrated into golingci-lint.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-10-09 23:27:48 +08:00
Marek Siarkowicz
de39c75053 Merge pull request #16711 from serathius/robustness-fix-profile 
Fix providing profile to robustness tests
 2023-10-09 09:52:55 +02:00
Marek Siarkowicz
b4d54922eb Fix providing profile to robustness tests 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-08 21:27:22 +02:00
Marek Siarkowicz
01a0d8ba83 Merge pull request #16709 from fuweid/remove-markdown-style-checker 
scripts: remove the markdown_you_pass
 2023-10-08 10:18:35 +02:00