21561 Commits

Author SHA1 Message Date
redwrasse
854010f412 fileutil: improve control flow readability of purgeFile function
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-06-29 22:16:13 -07:00
James Blair
04082b7672
Merge pull request #18249 from ivanvc/remove-govulncheck-github-workflow
github: remove govulncheck action
2024-06-30 05:13:39 +12:00
Ivan Valdes
34361a1a81
github: remove govulncheck action
This job has already been migrated to prow.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-28 22:07:01 -07:00
James Blair
8e20ad03ac
Merge pull request #18246 from ivanvc/update-3.4.33-release-date
changelog/3.4: set 3.4.33 release date
2024-06-29 11:54:03 +12:00
Ivan Valdes
396e2918f7
changelog/3.4: set 3.4.33 release date
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-28 15:30:56 -07:00
James Blair
1c22e7b36b
Merge pull request #18243 from masonyc/cleanup-unneeded-logger-check
etcd-client: Clean up unnecessary nil Logger check
2024-06-28 21:42:11 +12:00
Benjamin Wang
3cd044f4bd
Merge pull request #18201 from MadhavJivrajani/e2e-issue-18089
tests/e2e: add e2e test to reproduce issue 18089
2024-06-28 09:43:10 +01:00
Mason Chen
7dec366acd etcdclient: Clena up unnecessary nil Logger check
Clean up unnecessary nil Logger for listener.go as pointed out in issue
#18084

Signed-off-by: Mason Chen <mason.yunchen@gmail.com>
2024-06-28 20:11:44 +12:00
Marek Siarkowicz
9d04ab24b8
Merge pull request #18241 from serathius/robustness-failpoint-name
Add failpoint name to test name allowing us to track a per failpoint failures in testgrid
2024-06-27 19:41:48 +02:00
Marek Siarkowicz
c41e02f7b6 Add failpoint name to test name allowing us to track a per failpoint failures in testgrid
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-27 18:35:04 +02:00
Madhav Jivrajani
ebf2cac6bd tests/e2e: add e2e test to reproduce issue 18089
The goal is to reproduce a DELETE event being dropped in a watch after a compaction
occurs on the revision where the deletion took place. In order to reproduce this, we
perform the following sequence (steps for reproduction thanks to @ahrtr):
  - PUT k v2 (assume returned revision = r2)
  - PUT k v3 (assume returned revision = r3)
  - PUT k v4 (assume returned revision = r4)
  - DELETE k (assume returned revision = r5)
  - PUT k v6 (assume returned revision = r6)
  - COMPACT r5
  - WATCH rev=r5

We should get the DELETE event (r5) followed by the PUT event (r6). However, currently we only
get the PUT event with returned revision of r6 (key=k, val=v6).

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-06-27 14:51:12 +05:30
James Blair
21e5876f7f
Merge pull request #18219 from lhy1024/add-etcd-log
[3.5] CHANGELOG: support multiple values for allowed client and peer …
2024-06-26 12:16:19 +12:00
James Blair
38535c2dd8
Merge pull request #18228 from henrybear327/dependency_update/6_24_24
[2024-06-24] Bump dependency updates identified by dependabot
2024-06-26 10:06:48 +12:00
Marek Siarkowicz
917ded9eda
Merge pull request #18214 from serathius/robustness-separate-persisted
Separate persisted responses without knowing their revision to prevent duplicating state during linearization
2024-06-25 23:22:36 +02:00
lhy1024
e7f51cbd5f [3.5] CHANGELOG: support multiple values for allowed client and peer TLS identities
Signed-off-by: lhy1024 <admin@liudos.us>
2024-06-25 20:49:56 +08:00
Benjamin Wang
a897676d54
Merge pull request #18210 from rleungx/update-changelog
Update release-3.6 changelog
2024-06-25 13:22:46 +01:00
Chun-Hung Tseng
5be397a6a8
Fix a linter issue
golangci-lint reports the following issue:
storage/mvcc/kvstore.go:312:27: (*store).restore - result 0 (error) is always nil (unparam)

It's due to the fact that both Attach() and compactLockfree() within the
function restore() are able to return an error, but we only log them in
the current implementation. Thus, the return value restore() is always
nil, hence the linter warning.

We have agreed to suppress the linter warning for now [1].

Reference:
[1] https://github.com/etcd-io/etcd/pull/18228#issuecomment-2187309957

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-25 11:45:53 +02:00
Chun-Hung Tseng
bfc4dc6206
dependency: bump github.com/google/yamlfmt from 0.12.1 to 0.13.0
Reference:
- https://github.com/etcd-io/etcd/pull/18222

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-25 11:23:58 +02:00
Chun-Hung Tseng
bca81b9450
dependency: bump github.com/golangci/golangci-lint from 1.59.0 to 1.59.1
Reference:
- https://github.com/etcd-io/etcd/pull/18223

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-25 11:23:58 +02:00
James Blair
d80d0f0c8b
Merge pull request #18226 from etcd-io/dependabot/github_actions/aquasecurity/trivy-action-0.23.0
build(deps): bump aquasecurity/trivy-action from 0.22.0 to 0.23.0
2024-06-25 09:40:47 +12:00
Marek Siarkowicz
1870222f41 Separate persisted responses without knowing their revision to prevent duplicating state during linearization
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-24 21:38:27 +02:00
Marek Siarkowicz
0dd79f4e18
Merge pull request #18227 from serathius/robustness-test-patch-history
Add tests for patching history to check output and return values
2024-06-24 21:38:18 +02:00
Marek Siarkowicz
35f4556b59 Add tests for patching history to check output and return values
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-24 20:41:32 +02:00
dependabot[bot]
6414e74486
build(deps): bump aquasecurity/trivy-action from 0.22.0 to 0.23.0
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.22.0 to 0.23.0.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](595be6a0f6...7c2007bcb5)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-24 17:56:43 +00:00
James Blair
74ca64116f
Merge pull request #18217 from jmhbnz/main
Bump shellcheck to latest v0.10.0 release
2024-06-25 04:51:51 +12:00
Benjamin Wang
b96b6ba04c
Merge pull request #18220 from ahrtr/ep__sync_verify_20240624
Add verification on `client.Sync` to ensure the returned endpoints never empty
2024-06-24 17:19:15 +01:00
Benjamin Wang
281f177345 add verification on client.Sync to ensure the returned endpoints never empty
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-06-24 10:07:36 +01:00
Marek Siarkowicz
9314ef760d
Merge pull request #18213 from serathius/robustness-disable-18089
Disable robustness test detection of #18089 to allow detecting other issues
2024-06-24 09:56:32 +02:00
Ryan Leung
893f93e2bc add embed.Config.GRPCAdditionalServerOptions into changelog
Signed-off-by: Ryan Leung <rleungx@gmail.com>
2024-06-24 13:59:43 +08:00
Benjamin Wang
67a6dbdb7c
Merge pull request #18218 from andyxning/changelog_for_bugfix_18164_prometheus_metric_register_of_walWriteSec
add changelog for bugfix 18164 prometheus metric register of walWriteSec
2024-06-24 06:43:02 +01:00
Andy Xie
37fe67b329 add changelog for bugfix 18164 prometheus metric register of walWriteSec
Signed-off-by: Andy Xie <andy.xning@gmail.com>
2024-06-24 11:06:47 +08:00
James Blair
29b4ff2fd8
Bump shellcheck to latest 2024 release.
Signed-off-by: James Blair <mail@jamesblair.net>
2024-06-24 11:24:31 +12:00
Marek Siarkowicz
4fe227c46c Disable robustness test detection of #18089 to allow detecting other issues
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-22 11:01:47 +02:00
James Blair
16ed0fe86e
Merge pull request #18212 from Willhow-Gao/main
mvcc: fix typo
2024-06-22 20:10:26 +12:00
MR_G
c0076a788e mvcc: fix typo
Signed-off-by: MR_G <2044783677@qq.com>
2024-06-22 00:17:13 +08:00
Benjamin Wang
1d13fc58ff
Merge pull request #14066 from rleungx/add-config
embed: add `GRPCAdditionalServerOptions` config
2024-06-21 06:40:32 +01:00
James Blair
00a609751a
Merge pull request #18206 from henrybear327/dependencies/06_19_24
[2024-06-19] Bump dependency update
2024-06-20 07:31:27 +12:00
James Blair
866b8ddc8a
Merge pull request #18205 from ivanvc/add-make-verify-dep-versions
make: fix `verify-dep` target
2024-06-20 07:30:45 +12:00
Ivan Valdes
a016567398
dependency: bump google.golang.org/genproto/googleapis/api to v0.0.0-20240520151616-dc85e6b867a5
Set the same version for google.golang.org/genproto/googleapis/api
across the submodules.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-19 09:02:17 -07:00
Ivan Valdes
4f13e7c2b7
dependency(client): bump golang.org/x/sys from v0.19.0 to v0.21.0
Ensure that golang.org/x/sys is at the same version across the modules
from the project.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-19 09:02:17 -07:00
Ivan Valdes
dfda61bbbf
make: fix verify-dep
Makefile's target `verify-dep` current behavior is to use `go list` to
check consistent dependency versions from direct dependencies. Ignoring
indirect dependencies in a multi-module project could lead to version
mismatches. If module A imports module B, module B's dependency will be
an indirect dependency in module A. Which can potentially have a version
mismatch. Therefore, use `go mod edit` with indirect dependencies, too.
So it can work with all dependencies defined in go.mod.

Fix displaying dependencies with mismatches, as the old code was
searching with grep just for the prefix, which would show other
dependencies that shared the same prefix.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-19 09:02:17 -07:00
Benjamin Wang
a043da50fe
Merge pull request #18062 from stackbaek/main
featuregate: adds EtcdServer.FeatureEnabled interface.
2024-06-19 09:35:54 +01:00
Marek Siarkowicz
97a4068342
Merge pull request #18204 from henrybear327/make/robustness
Use $(MAKE) instead of make
2024-06-19 08:58:27 +02:00
Chun-Hung Tseng
9e7b94dea9
dependency: bump go.etcd.io/gofail from v0.1.1-0.20240517100945-baefa9867390 to v0.2.0
Reference:
- https://github.com/etcd-io/gofail/issues/72

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-19 08:49:31 +02:00
Benjamin Wang
908d31a6fe
Merge pull request #18203 from ahrtr/metrics_url_20240618
Update the error message when client certificate isn't provided for secure metrics url
2024-06-19 05:40:11 +01:00
Chun-Hung Tseng
f21f074baa
Use $(MAKE) instead of make
Recursive make commands should always use the variable MAKE, as
the value of this variable is the file name with which make was invoked

Reference:
- https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-18 19:16:30 +02:00
Benjamin Wang
692e44a80b Update the error message when client certificate isn't provided for secure metrics url
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-06-18 14:03:39 +01:00
Benjamin Wang
9c59b28086
Merge pull request #18186 from gyuho/enforce-non-empty-client-tls-if-metrics-url-scheme-is-https
fix(server): enforce listen-metrics-urls client TLS info when its scheme is https/unixs
2024-06-18 13:59:21 +01:00
Gyuho Lee
3e86af6843
remove unnecessary wait call
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-18 18:18:54 +08:00
Marek Siarkowicz
7dadc328f3
Merge pull request #18202 from MadhavJivrajani/fix-vairable-access
tests/robustness: fix access of ChoiceWeight
2024-06-18 11:25:04 +02:00