21521 Commits

Author SHA1 Message Date
James Blair
866b8ddc8a
Merge pull request #18205 from ivanvc/add-make-verify-dep-versions
make: fix `verify-dep` target
2024-06-20 07:30:45 +12:00
Ivan Valdes
a016567398
dependency: bump google.golang.org/genproto/googleapis/api to v0.0.0-20240520151616-dc85e6b867a5
Set the same version for google.golang.org/genproto/googleapis/api
across the submodules.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-19 09:02:17 -07:00
Ivan Valdes
4f13e7c2b7
dependency(client): bump golang.org/x/sys from v0.19.0 to v0.21.0
Ensure that golang.org/x/sys is at the same version across the modules
from the project.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-19 09:02:17 -07:00
Ivan Valdes
dfda61bbbf
make: fix verify-dep
Makefile's target `verify-dep` current behavior is to use `go list` to
check consistent dependency versions from direct dependencies. Ignoring
indirect dependencies in a multi-module project could lead to version
mismatches. If module A imports module B, module B's dependency will be
an indirect dependency in module A. Which can potentially have a version
mismatch. Therefore, use `go mod edit` with indirect dependencies, too.
So it can work with all dependencies defined in go.mod.

Fix displaying dependencies with mismatches, as the old code was
searching with grep just for the prefix, which would show other
dependencies that shared the same prefix.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-19 09:02:17 -07:00
Benjamin Wang
a043da50fe
Merge pull request #18062 from stackbaek/main
featuregate: adds EtcdServer.FeatureEnabled interface.
2024-06-19 09:35:54 +01:00
Marek Siarkowicz
97a4068342
Merge pull request #18204 from henrybear327/make/robustness
Use $(MAKE) instead of make
2024-06-19 08:58:27 +02:00
Benjamin Wang
908d31a6fe
Merge pull request #18203 from ahrtr/metrics_url_20240618
Update the error message when client certificate isn't provided for secure metrics url
2024-06-19 05:40:11 +01:00
Chun-Hung Tseng
f21f074baa
Use $(MAKE) instead of make
Recursive make commands should always use the variable MAKE, as
the value of this variable is the file name with which make was invoked

Reference:
- https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-18 19:16:30 +02:00
Benjamin Wang
692e44a80b Update the error message when client certificate isn't provided for secure metrics url
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-06-18 14:03:39 +01:00
Benjamin Wang
9c59b28086
Merge pull request #18186 from gyuho/enforce-non-empty-client-tls-if-metrics-url-scheme-is-https
fix(server): enforce listen-metrics-urls client TLS info when its scheme is https/unixs
2024-06-18 13:59:21 +01:00
Gyuho Lee
3e86af6843
remove unnecessary wait call
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-18 18:18:54 +08:00
Marek Siarkowicz
7dadc328f3
Merge pull request #18202 from MadhavJivrajani/fix-vairable-access
tests/robustness: fix access of ChoiceWeight
2024-06-18 11:25:04 +02:00
Madhav Jivrajani
5c2422ba05 tests/robustness: fix access of ChoiceWeight
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-06-18 13:44:40 +05:30
Marek Siarkowicz
c70e0e4f55
Merge pull request #18181 from serathius/robustness-compact-lazyfs
Avoid sending Compact request when LazyFS is enabled
2024-06-18 09:26:41 +02:00
Marek Siarkowicz
2deefb081b
Merge pull request #18060 from siyuanfoundation/robust
robustness: change mixedVersionOption to use ChoiceWeight.
2024-06-18 08:49:47 +02:00
Marek Siarkowicz
2e04ee77b6 Avoid sending Compact request when LazyFS is enabled
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-18 08:36:24 +02:00
Marek Siarkowicz
dd7a2a6237
Merge pull request #17680 from serathius/issue-17529
Reproduce #17529 in robustness tests
2024-06-18 08:32:40 +02:00
Gyuho Lee
497f1a45a3
license
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-18 07:28:43 +08:00
Siyuan Zhang
fff58bb809 robustness: change mixedVersionOption to use ChoiceWeight.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-06-17 15:53:47 -07:00
James Blair
047b440ba9
Merge pull request #18182 from ivanvc/add-makefile-verify-govulncheck
Add run-govulncheck Makefile target
2024-06-18 10:42:14 +12:00
James Blair
fcc834fb18
Merge pull request #18199 from henrybear327/dependency_update/6_17_24
[2024-06-17] Bump dependency updates identified by dependabot
2024-06-18 10:33:06 +12:00
James Blair
381bca7e3c
Merge pull request #18198 from etcd-io/dependabot/github_actions/github/codeql-action-3.25.10
build(deps): bump github/codeql-action from 3.25.8 to 3.25.10
2024-06-18 09:57:58 +12:00
dependabot[bot]
45e7d5bab9
build(deps): bump github/codeql-action from 3.25.8 to 3.25.10
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.8 to 3.25.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](2e230e8fe0...23acc5c183)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-17 20:39:34 +00:00
James Blair
a7fdc2336d
Merge pull request #18197 from etcd-io/dependabot/github_actions/actions/checkout-4.1.7
build(deps): bump actions/checkout from 4.1.6 to 4.1.7
2024-06-18 08:38:51 +12:00
Chun-Hung Tseng
166d26b4e4 dependency: bump github.com/spf13/cobra from 1.8.0 to 1.8.1
Reference:
- https://github.com/etcd-io/etcd/pull/18190

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 22:09:15 +02:00
Chun-Hung Tseng
a947aa0d3f dependency: bump go.opentelemetry.io/proto/otlp from 1.2.0 to 1.3.1
Reference:
- https://github.com/etcd-io/etcd/pull/18191

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 22:09:15 +02:00
Chun-Hung Tseng
3899de4eef dependency: bump github.com/alexfalkowski/gocovmerge from 1.3.4 to 1.3.8
Reference:
- https://github.com/etcd-io/etcd/pull/18194

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 22:09:15 +02:00
Chun-Hung Tseng
e60bccd4cf dependency: bump github.com/google/yamlfmt from 0.11.0 to 0.12.1
Reference:
- https://github.com/etcd-io/etcd/pull/18195

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 21:51:40 +02:00
Chun-Hung Tseng
fa835658e3 dependency: bump google.golang.org/protobuf from 1.34.1 to 1.34.2
Reference:
- https://github.com/etcd-io/etcd/pull/18196

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 21:49:52 +02:00
dependabot[bot]
1bff41630e
build(deps): bump actions/checkout from 4.1.6 to 4.1.7
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](a5ac7e51b4...692973e3d9)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-06-17 17:31:10 +00:00
Gyuho Lee
22f20a827b
test(e2e): add a case where client tls is missing for https metrics url
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-17 21:09:24 +08:00
Gyuho Lee
a657f069a1
fix(server/embed): enforce non-empty client TLS if scheme is https/unixs
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-17 18:21:38 +08:00
Ivan Valdes
043096067f
Add run-govulncheck Makefile target
Add a `Makefile` target to run govuln across the submodules. So, it can
be imported into a prow job.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-15 15:47:13 -07:00
James Blair
debc8fb00b
Merge pull request #15979 from cenkalti/snapshot-status
Improve snapshot status
2024-06-16 08:53:27 +12:00
Marek Siarkowicz
5e42ed9b22 Reproduce issue #17529
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-15 19:40:23 +02:00
Marek Siarkowicz
93873708a9 Upgrade gofail for sleep to not block deactivation
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-06-15 19:25:35 +02:00
Cenk Alti
ea46253b42
Improve snapshot status
Signed-off-by: Cenk Alti <cenkalti@gmail.com>
2024-06-15 10:11:34 -04:00
Marek Siarkowicz
15f9a59547
Merge pull request #18179 from siyuanfoundation/lazyfs
robustness: Separate compaction and LazyFS test scenario for cluster size 1
2024-06-15 10:49:14 +02:00
Marek Siarkowicz
f01f23dab0
Merge pull request #18177 from ArkaSaha30/rm-robustness-amd64-wf
Remove robustness presubmits for `amd64` arch
2024-06-15 09:20:24 +02:00
Baek
14e15bcaca Removes dependency on other k8s packages in featuregate pkg.
The removed packages are:

 * k8s.io/apimachinery/pkg/util/naming
 * k8s.io/klog/v2

Do note that removing naming package necessitates adding feature gate
name argument to featuregate.New().

Signed-off-by: Baek <seungtackbaek@google.com>
2024-06-15 05:34:58 +00:00
Baek
60e3f45469 Adds all feature_gate from component-base.
We'll likely use most of the feature_gate package from component-base.
Also this commit moves the pkg from server/internal/pkg to pkg/.

Signed-off-by: Baek <seungtackbaek@google.com>
2024-06-15 05:34:58 +00:00
Baek
69ebaaebca featuregate: adds EtcdServer.FeatureEnabled interface.
The interface can be used throughout the etcd server binary to check if
the feature is enabled or not.

Note that this commit also copies necessary FeatureGate interface from
k8s component-base.

Signed-off-by: Baek <seungtackbaek@google.com>
2024-06-15 05:34:58 +00:00
Benjamin Wang
d09c935736
Merge pull request #18178 from henrybear327/changelog/Fix-govulncheck-CI-check
Update release-3.5 changelog
2024-06-15 06:24:34 +01:00
Siyuan Zhang
aaa6e9ef8c robustness: Separate compaction and LazyFS test scenario for cluster size 1.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-06-14 13:33:50 -07:00
Chun-Hung Tseng
84c68f391c
Update release-3.5 changelog
Fully address CVE-2023-45288 and fix govulncheck CI check

Reference:
- https://github.com/etcd-io/etcd/pull/18170

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-14 22:12:35 +02:00
ArkaSaha30
6ca3b6ba88
Remove robustness presubmits and periodics workflows
This commit will remove robustness presubmits
for both `amd64` and `arm64` archs, periodics for
`amd64` arch since it has been migrated to test-infra
as prowjobs:
https://github.com/kubernetes/test-infra/blob/master/config/jobs/etcd/etcd-periodics.yaml#L61-L230
https://github.com/kubernetes/test-infra/blob/master/config/jobs/etcd/etcd-presubmits.yaml#L240-L279

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-06-14 23:22:14 +05:30
Benjamin Wang
45f14539e0
Merge pull request #18164 from andyxning/bugfix_register_of_walWriteSec
bugfix: register of walWriteSec
2024-06-14 18:32:15 +01:00
Benjamin Wang
d2b6423a5c
Merge pull request #18171 from henrybear327/ci/fix_govulncheck_release_main
Fix govulncheck CI check on main branch
2024-06-14 18:27:40 +01:00
Chun-Hung Tseng
bc1aed1936
Fix govulncheck CI check on main branch
This commit fixed the Go Vulnerability Checker CI job, which isn't
scanning for all go.mod files within the project.

Reference:
- https://github.com/etcd-io/etcd/discussions/18168

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-14 11:30:10 +02:00
James Blair
3be7dbeb36
Merge pull request #18167 from ivanvc/update-robustness-test-documentation-to-point-to-prow
tests/robustness: update documentation to reflect Prow migration
2024-06-14 10:55:38 +12:00