19982 Commits

Author SHA1 Message Date
Benjamin Wang
882edb3d63
Merge pull request #16231 from jmhbnz/robustness-arm64-release-35
Add new job for nightly release35 arm64 robustness
2023-07-14 14:56:38 +01:00
Benjamin Wang
c59bc52286
Merge pull request #16200 from kensou97/keepalive-ctx-closer
clientv3: create keepAliveCtxCloser goroutine only if ctx can be canc…
2023-07-14 13:46:15 +01:00
Benjamin Wang
dee90e19f1
Merge pull request #16229 from ahrtr/changelog_20230712
Changelog: add items to cover the fix of bumping go to 1.19.11
2023-07-14 12:08:07 +01:00
Marek Siarkowicz
2dc7891c7b
Merge pull request #16234 from jmhbnz/add-new-reviewer
Add jmhbnz as etcd reviewer
2023-07-13 12:01:48 +02:00
Marek Siarkowicz
f008184b0e
Merge pull request #16232 from cuishuang/main
remove repetitive the
2023-07-13 11:59:14 +02:00
James Blair
a35d24ab72
Add jmhbnz as etcd reviewer.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-07-13 21:46:04 +12:00
cui fliter
6760dc9572 remove repetitive the
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-07-13 17:01:01 +08:00
James Blair
5ffac59d88
Add new job for nightly release35 arm64 robustness.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-07-13 20:58:16 +12:00
Benjamin Wang
1cf49e5ef0
Merge pull request #16173 from fuweid/fix-datarace-in-expect
pkg/expect: fix data race
2023-07-13 08:49:13 +01:00
Marek Siarkowicz
1ee6be793e
Merge pull request #16226 from ahrtr/go_20230712
Bump go version to 1.19.11 to fix CVE GO-2023-1878
2023-07-13 09:30:57 +02:00
Wei Fu
56edfa6e28 pkg/expect: fix data race
Let's say there is command which outputs one line and exit with error.

There are three goroutines to acquire the lock:

1. ep.read()
2. ep.waitSaveExitErr()
3. ep.Expect()

When ep.read goroutine reads the log but it doesn't acquire the lock in
time, the ep.waitSaveExitErr acquires the lock and updates the
`exitErr`. And then ep.Expect acquires lock but it doesn't see any log
yet and then returns err.

It's hard to reproduce it in local. Add the extra sleep can reproduce it.

```diff
diff --git a/pkg/expect/expect.go b/pkg/expect/expect.go
index a512a3ce4..602bea73f 100644
--- a/pkg/expect/expect.go
+++ b/pkg/expect/expect.go
@@ -128,6 +128,7 @@ func (ep *ExpectProcess) tryReadNextLine(r *bufio.Reader) error {
        printDebugLines := os.Getenv("EXPECT_DEBUG") != ""
        l, err := r.ReadString('\n')

+       time.Sleep(10 * time.Millisecond)
        ep.mu.Lock()
        defer ep.mu.Unlock()
```

See it once in Github Action [1]. In order to fix it, the patch introduces
`readCloseCh` to wait for ep.read to get all the data and retry it.

[1]: https://github.com/etcd-io/etcd/pull/16137#issuecomment-1605838518

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-07-13 14:56:21 +08:00
Benjamin Wang
8fd423332e Changelog: add items to cover the fix of bumping go to 1.19.11
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-12 17:02:09 +01:00
Benjamin Wang
3c33fc1cf7 bump go version to 1.19.11
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-12 16:47:49 +01:00
Benjamin Wang
930dbbc28d
Merge pull request #16196 from fuweid/benchmark-support-range-countonly
tools/benchmark: support --count-only for range
2023-07-12 16:42:38 +01:00
Benjamin Wang
5216eea132
Merge pull request #16198 from vianamjr/clientv3-precent-nil-pointer
Clientv3 prevent nil pointer
2023-07-12 15:42:26 +01:00
Marek Siarkowicz
a639ecd4ee
Merge pull request #16219 from ahrtr/3.4.27_release_date
Changelog: update etcd 3.4.27's release date
2023-07-11 13:07:39 +02:00
Benjamin Wang
d934510bdd Changelog: update etcd 3.4.27's release date
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-11 10:38:08 +01:00
Marek Siarkowicz
4f37baf287
Merge pull request #16152 from jmhbnz/template-arm64-jobs
Templated arm64 integration and e2e workflows for main and release-3.5
2023-07-11 10:12:32 +02:00
Marek Siarkowicz
2d771b6f8f
Merge pull request #16189 from jmhbnz/update-community-meeting
Update community meeting frequency to fortnightly
2023-07-11 09:36:15 +02:00
Marek Siarkowicz
d206977927
Merge pull request #16218 from fuweid/update34changelog
CHANGELOG: add item for 3.4.27
2023-07-11 09:06:39 +02:00
Wei Fu
c2474d2999 CHANGELOG: add item for 3.4.27
- embed: fix nil pointer dereference when stopServer

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-07-11 14:55:28 +08:00
Benjamin Wang
c853b9c337
Merge pull request #16210 from ahrtr/dependency_20230710
Bump dependencies
2023-07-10 20:21:07 +01:00
Benjamin Wang
1f07d8f159
Merge pull request #16205 from etcd-io/dependabot/github_actions/github/codeql-action-2.20.3
build(deps): bump github/codeql-action from 2.20.2 to 2.20.3
2023-07-10 19:18:24 +01:00
Marek Siarkowicz
5ed5807bf4
Merge pull request #16197 from wenjiaswe/patch-2
Asking for approval to regain maintainer status
2023-07-10 20:10:58 +02:00
Benjamin Wang
bad0894aa3 dependency: bump gotest.tools/gotestsum from v1.10.0 to v1.10.1
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:51:51 +01:00
Benjamin Wang
2c22ca7eba dependency: bump golang.org/x/net from v0.11.0 to v0.12.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:43:30 +01:00
Benjamin Wang
843ddb4b1e dependency: bump golang.org/x/crypto from v0.10.0 to v0.11.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:40:35 +01:00
Benjamin Wang
149256735d dependency: bump golang.org/x/sys from v0.9.0 to v0.10.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-07-10 18:38:16 +01:00
dependabot[bot]
0afea07767
build(deps): bump github/codeql-action from 2.20.2 to 2.20.3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.2 to 2.20.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](004c5de30b...46ed16ded9)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-10 17:25:31 +00:00
Marcondes Viana
2ec12e4b4e clientv3: prevent nil pointer call in get method
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-07-10 08:16:00 -03:00
zhangwenkang
21eb8d2c3b clientv3: create keepAliveCtxCloser goroutine only if ctx can be canceled
Signed-off-by: zhangwenkang <zwenkang@vmware.com>
2023-07-10 01:11:23 +08:00
Wenjia
4755a1646c Update MAINTAINERS
Sending this PR to ask for approval to regain maintainer status.

Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
2023-07-07 01:16:47 -07:00
Marek Siarkowicz
82f6cb4635
Merge pull request #16194 from wenjiaswe/patch-1
Update CHANGELOG for #16029 #16165 #16193
2023-07-07 09:39:42 +02:00
Wenjia
e3e58880d3 Update CHANGELOG for #16029 #16165 #16193
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
2023-07-07 00:29:49 -07:00
Wei Fu
70c8f04a18 tools/benchmark: support --count-only for range
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-07-07 15:07:12 +08:00
Benjamin Wang
ac88260aaf
Merge pull request #16191 from chaochn47/fix-runtime-reconfig-test
tests: exclude learner endpoint from MemberPromote
2023-07-07 07:15:02 +01:00
James Blair
0b6fd24afb
Update community meeting frequency to fortnightly.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-07-07 15:00:37 +12:00
Benjamin Wang
4364e7581b
Merge pull request #16120 from Tachone/shitao.lst/fix_db_close
etcdutl: fix db double closed
2023-07-06 20:03:51 +01:00
Benjamin Wang
f4444e8fb3
Merge pull request #16154 from CaojiamingAlan/uber_applier_test
add tests for uber applier
2023-07-06 20:00:11 +01:00
Benjamin Wang
cd6cab5e03
Merge pull request #16190 from kensou97/changelog-16188
update changelog for #16188
2023-07-06 18:59:31 +01:00
Chao Chen
e5f6673e1a tests: exclude learner endpoints from MemberPromote
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-07-06 09:05:16 -07:00
zhangwenkang
6f94f118e6 update changelog for #16188
Signed-off-by: zhangwenkang <zwenkang@vmware.com>
2023-07-06 17:22:10 +08:00
Benjamin Wang
e887e5291a
Merge pull request #16067 from geetasg/pr1
Adding test for updateClusterVersionV3
2023-07-06 08:36:19 +01:00
Benjamin Wang
93bfdba265
Merge pull request #16156 from kensou97/fix-barrier
clientv3: remove v3.WithFirstKey() in Barrier.Wait()
2023-07-06 08:29:21 +01:00
Benjamin Wang
226e2cf1c8
Merge pull request #15924 from CaojiamingAlan/add-cluster-id-check-for-hashKVHandler
Add cluster id check for hash kv handler
2023-07-05 20:41:41 +01:00
caojiamingalan
eff9517a90 etcdserver: add cluster id check for hashKVHandler
Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
2023-07-05 14:09:40 -05:00
Benjamin Wang
89bbba8fb3
Merge pull request #16174 from twz123/jwt-ed25519-support
auth: Support for EdDSA JWT algorithm
2023-07-05 12:29:04 +01:00
Tom Wieczorek
a8a9ebd281
auth: Support for EdDSA JWT algorithm
The golang-jwt library supports this already, so supporting it is just a
matter of wiring things up.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
2023-07-05 11:33:08 +02:00
Benjamin Wang
76285f7f0f
Merge pull request #15962 from HubertZhang/changelog-15939
update changelog for #15939
2023-07-05 10:20:56 +01:00
zhangwenkang
3d3e91c6e3 clientv3: remove v3.WithFirstKey() in Barrier.Wait()
fix the unexpected blocking when using Barrier.Wait(), e.g.
NewBarrier(client, "a").Wait() will block if key "a" is not existed but "a0" is existed, but it should return immediately.

Signed-off-by: zhangwenkang <zwenkang@vmware.com>
2023-07-04 22:01:54 +08:00