19534 Commits

Author SHA1 Message Date
Msk
a3743a79bc tests: use separate errc for each case in TestTxnPanics
Signed-off-by: Msk <118117161+Mskxn@users.noreply.github.com>
2023-04-10 09:16:39 +08:00
Benjamin Wang
f7af6b64ba
Merge pull request #15673 from fuweid/chore-expect-pkg-comment
chore: remove pkg/expect TODO comment
2023-04-09 14:06:22 +08:00
Wei Fu
85b4da6121 chore: remove pkg/expect TODO comment
https://github.com/google/goexpect has been archived on Feb 7, 2023.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-09 12:57:32 +08:00
Benjamin Wang
da36ce2fe9
Merge pull request #15670 from etcd-io/dependabot/github_actions/github/codeql-action-2.2.11
build(deps): bump github/codeql-action from 2.2.10 to 2.2.11
2023-04-08 17:15:30 +08:00
dependabot[bot]
ce089755e1
build(deps): bump github/codeql-action from 2.2.10 to 2.2.11
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.10 to 2.2.11.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](8c8d71dde4...d186a2a36c)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-08 06:58:00 +00:00
Benjamin Wang
08e6d67b3c
Merge pull request #15650 from etcd-io/dependabot/github_actions/github/codeql-action-2.2.10
build(deps): bump github/codeql-action from 2.2.9 to 2.2.10
2023-04-08 14:57:28 +08:00
Marek Siarkowicz
7153a8f2f4
Merge pull request #15646 from serathius/robustness-readme-watch-issue
tests/robustness: Document analysing watch issue
2023-04-07 23:45:42 +02:00
Marek Siarkowicz
caa775d235
Merge pull request #15663 from serathius/2fa
Require 2FA enabled for all members
2023-04-07 10:59:11 +02:00
Marek Siarkowicz
620956a613
Merge pull request #15654 from ahrtr/changelog_bump_go_20230406
changelog: update items to cover the some new changes in 3.5 and 3.4
2023-04-07 10:55:27 +02:00
Marek Siarkowicz
535ff9638b
Merge pull request #15617 from serathius/robustness-client-refactor
tests: Make using etcdctl expicit in e2e tests
2023-04-07 10:51:01 +02:00
Marek Siarkowicz
7a0e27ac21
Merge pull request #15657 from serathius/maintainers-update
Update maintainer list
2023-04-07 10:47:45 +02:00
Marek Siarkowicz
d72220400b Require 2FA enabled for all members
After this PR is merge, I will enable enforcement on etcd org.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-07 10:41:51 +02:00
Benjamin Wang
64176be02f changelog: update items to cover some changes in 3.5 and 3.4
1. Bumped golang to 1.19.8;
2. etcdserver: set zap logging to wsproxy;
3. Fix CVE-2021-28235.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-07 13:47:13 +08:00
dependabot[bot]
4ea5c08abc build(deps): bump github/codeql-action from 2.2.9 to 2.2.10
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.9 to 2.2.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](04df1262e6...8c8d71dde4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-07 13:06:23 +08:00
Marek Siarkowicz
89f3e20c18 Update maintainer list
Got a confirmation from Sam that he is retiring his contributions.
Removing Tobias as raft was moved to separate repo.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-06 21:12:13 +02:00
Marek Siarkowicz
5327d91c20
Merge pull request #15586 from serathius/changelog-v3.5.8
changelog: Refactor changelog and add changes for v3.5.8
2023-04-06 14:47:16 +02:00
Marek Siarkowicz
34bb7ed7a1 changelog: Refactor changelog and add changes for v3.5.8
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-06 14:42:20 +02:00
Marek Siarkowicz
a5a5862e0b tests: Make using etcdctl expicit in e2e tests
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-06 13:29:37 +02:00
Hitoshi Mitake
573251572c
Merge pull request #15648 from ahrtr/auth_cve_20230406
security: clear password after authenticating the user
2023-04-06 19:34:38 +09:00
Benjamin Wang
8b1cd036ff security: remove password after authenticating the user
fix https://nvd.nist.gov/vuln/detail/CVE-2021-28235

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-06 17:11:54 +08:00
Benjamin Wang
801bb4c6df test: add an e2e test to reproduce https://nvd.nist.gov/vuln/detail/CVE-2021-28235
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-06 16:47:31 +08:00
Benjamin Wang
749a0d8d58
Merge pull request #15649 from ahrtr/bump_go_20230406
security: bump golang to 1.19.8 to fix four CVEs
2023-04-06 14:25:01 +08:00
Benjamin Wang
2d0d3c3fdf security: bump go to 1.19.8 to fix four CVEs
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-06 13:38:58 +08:00
Marek Siarkowicz
2d9aeec91f
Merge pull request #15645 from serathius/tests-cleanup-alternative-binaries
tests/framework: Cleanup alternative binaries in e2e tests
2023-04-06 07:33:17 +02:00
Marek Siarkowicz
99df35e69b
Merge pull request #15644 from serathius/robustness-etcdctl-provided
tests/robustness: Ensure that etcdctl binary is provided
2023-04-06 07:32:01 +02:00
Marek Siarkowicz
540d012e5e tests/robustness: Ensure that etcdctl binary is provided
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-05 23:04:20 +02:00
Marek Siarkowicz
1e41d95ab2 tests/robustness: Document analysing watch issue
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-05 22:40:47 +02:00
Marek Siarkowicz
651873cf7b tests/framework: Cleanup alternative binaries in e2e tests
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-05 15:32:31 +02:00
Marek Siarkowicz
f6bb874298
Merge pull request #15237 from scpmw/guarantee_progress_notify_order
etcdserver: Send requested progress notifications through watchStream (fix #15220)
2023-04-05 13:49:41 +02:00
Peter Wortmann
74feb229c7 etcdserver: Guarantee order of requested progress notifications
Progress notifications requested using ProgressRequest were sent
directly using the ctrlStream, which means that they could race
against watch responses in the watchStream.

This would especially happen when the stream was not synced - e.g. if
you requested a progress notification on a freshly created unsynced
watcher, the notification would typically arrive indicating a revision
for which not all watch responses had been sent.

This changes the behaviour so that v3rpc always goes through the watch
stream, using a new RequestProgressAll function that closely matches
the behaviour of the v3rpc code - i.e.

1. Generate a message with WatchId -1, indicating the revision for
   *all* watchers in the stream

2. Guarantee that a response is (eventually) sent

The latter might require us to defer the response until all watchers
are synced, which is likely as it should be. Note that we do *not*
guarantee that the number of progress notifications matches the number
of requests, only that eventually at least one gets sent.

Signed-off-by: Peter Wortmann <peter.wortmann@skao.int>
2023-04-05 11:54:10 +01:00
Peter Wortmann
42a2643df9 tests/robustness: Reproduce issue #15220
This issue is somewhat easily reproduced simply by bombarding the
server with requests for progress notifications, which eventually
leads to one being delivered ahead of the payload message. This is
then caught by the watch response validation code previously added by
Marek Siarkowicz.

Signed-off-by: Peter Wortmann <peter.wortmann@skao.int>
2023-04-05 11:23:02 +01:00
Peter Wortmann
af25936fb7 tests/integration: Demonstrate manual progress notification race
This will fail basically every time, as the progress notification
request catches the watcher in an asynchronised state.

Signed-off-by: Peter Wortmann <peter.wortmann@skao.int>
2023-04-05 11:19:07 +01:00
Marek Siarkowicz
b504ac1840
Merge pull request #15593 from serathius/community-membership
Move to community membership model closer to kubernetes one
2023-04-05 12:11:31 +02:00
Marek Siarkowicz
9b58269298
Merge pull request #15642 from serathius/robustness-detect-trigger-timeout
tests/robustness: Detect trigger timeout and exit
2023-04-05 10:48:18 +02:00
Benjamin Wang
29a8b56cf2
Merge pull request #15641 from mitake/changelog-15294
changelog: add items to cover 15294
2023-04-05 08:26:08 +08:00
Marek Siarkowicz
5bae6b1e44 tests/robustness: Detect trigger timeout and exit
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-04 15:23:58 +02:00
Hitoshi Mitake
aaf8919a19 changelog: add items to cover 15294
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
2023-04-04 21:56:46 +09:00
Marek Siarkowicz
f9d124974b
Merge pull request #15604 from jmhbnz/robustness-ensure-healthy-clus
tests: Ensure healthy cluster before and after robustness failpoint
2023-04-04 14:22:52 +02:00
James Blair
1227754284 Cancel watch if cluster not healthy before or after injecting failpoints.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-04 13:58:17 +02:00
Marek Siarkowicz
05e2910f15
Merge pull request #15633 from serathius/robustness-enforce-timeout
tests: Enfoce timeout on failpoints
2023-04-04 13:27:03 +02:00
Marek Siarkowicz
6582e349db tests: Enfoce timeout on failpoints
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-04 12:25:07 +02:00
Marek Siarkowicz
523f235c82
Merge pull request #15603 from serathius/robustness-finish-with-success
tests: Ensure that operation history finishes with successful request
2023-04-04 12:03:36 +02:00
Benjamin Wang
32acc662c9
Merge pull request #15638 from ahrtr/dependency_20230404
Bump some dependencies
2023-04-04 17:11:26 +08:00
Marek Siarkowicz
6a5d326519 tests: Ensure that operation history finishes with successful request
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-04 09:40:17 +02:00
Marek Siarkowicz
5e0119eadc
Merge pull request #15636 from lavacat/main-test-watch-delay
tests: increase maxWatchDelay to prevent flaky TestWatchDelay*
2023-04-04 09:38:03 +02:00
Marek Siarkowicz
138fae6246
Merge pull request #15632 from serathius/fix-comparing-etcd-version
tests: Fix comparing etcd version
2023-04-04 09:34:55 +02:00
Marek Siarkowicz
8b6bf90c0d
Merge pull request #15580 from chaochn47/fix_flaking_auth_member_remove_test
fix flaking auth member remove test
2023-04-04 09:34:16 +02:00
Marek Siarkowicz
4fab20aa75
Merge pull request #15618 from serathius/robustness-fix-periodic-etcd-version
tests: Fix building incorrect etcd version and make switch strict
2023-04-04 09:30:20 +02:00
Benjamin Wang
072c5cb5da dependency: bump google.golang.org/protobuf from 1.28.1 to 1.30.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-04 15:28:09 +08:00
Benjamin Wang
56284d5dfe dependency: bump github.com/golang/protobuf from 1.5.2 to 1.5.3
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-04 15:21:22 +08:00