Benjamin Wang
97029d768a
Merge pull request #17614 from ivanvc/address-etcdserver-var-naming-lint-rule
...
etcdserver: address var naming lint rule
2024-03-19 22:40:03 +01:00
Ivan Valdes
14523bdc21
etcdserver: rename MemberId() to MemberID() to address var-naming
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-18 17:18:29 -07:00
Ivan Valdes
c613b78e6c
etcdserver: address golangci var-naming issues
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-18 17:17:07 -07:00
Benjamin Wang
8b9909e20d
Merge pull request #17585 from ivanvc/address-api-var-naming-lint-rule
...
api: address golangci var-naming issues
2024-03-16 11:23:46 +00:00
Ivan Valdes
2190b0f1c6
api: address golangci var-naming issues
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-15 20:37:53 -07:00
Chao Chen
405862e807
Fix event loss after compaction
...
Signed-off-by: Chao Chen <chaochn@amazon.com>
2024-03-15 14:22:37 -07:00
Ivan Valdes
0024569c7c
dependency: bump github.com/stretchr/testify from 1.8.4 to 1.9.0
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-11 11:50:27 -07:00
Ivan Valdes
3996eb5a3c
dependency: bump google.golang.org/grpc from 1.62.0 to 1.62.1
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-11 11:41:17 -07:00
Ivan Valdes
7fae54b302
dependency: bump github.com/prometheus/common from 0.49.0 to 0.50.0
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-11 11:32:03 -07:00
Marek Siarkowicz
ddf54715bf
Merge pull request #17557 from serathius/progressrequest-new-watch
...
Fix progress notification for watch that doesn't get any events
2024-03-11 15:42:13 +01:00
Marek Siarkowicz
6103504d4b
Fix progress notification for watch that doesn't get any events
...
When implementing the fix for progress notifications
(https://github.com/etcd-io/etcd/pull/15237 ) we made a incorrect
assumption that that unsynched watches will always get at least one event.
Unsynched watches include not only slow watchers, but also newly created
watches that requested current or older revision. In case that non of the events
match watch filter, those newly created watches might become synched
without any event going through.
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-03-11 12:11:09 +01:00
Ivan Valdes
0c6b6ac951
dependency: bump google.golang.org/protobuf from 1.32.0 to 1.33.0
...
Addresses CVE-2024-24786 (https://pkg.go.dev/vuln/GO-2024-2611 )
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-07 09:13:28 -08:00
Ivan Valdes
04ef9dcef8
dependency: bump github.com/prometheus/common from 0.47.0 to 0.49.0
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-07 09:13:28 -08:00
Ivan Valdes
60da279da4
dependency: bump go.opentelemetry.io/otel/sdk from 1.23.1 to 1.24.0
...
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-07 09:13:28 -08:00
Allen Ray
bb4b70bbb2
Migrate to go1.22
...
Signed-off-by: Allen Ray <alray@redhat.com>
2024-03-06 17:15:36 -05:00
Dat Tien Nguyen
46d59a2e68
etcdserver: skip when detect a removed peer
...
Signed-off-by: Dat Tien Nguyen <phongtomfapp@gmail.com>
2024-03-04 21:22:19 +07:00
James Blair
e0955afa40
depdendency: bump google.golang.org/grpc from 1.61.1 to 1.62.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-02-28 21:08:42 +13:00
James Blair
170948f681
depdendency: bump go.opentelemetry.io/otel from 1.23.1 to 1.24.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-02-28 21:03:45 +13:00
Abhishek Kr Srivastav
fe113026fa
Increased timeout to fix HashKV test
...
Signed-off-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
2024-02-23 15:58:57 +05:30
Siyuan Zhang
3565a822de
Add VerifyTxConsistency to backend.
...
Signed-off-by: Siyuan Zhang <sizhang@google.com>
Update server/storage/backend/verify.go
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
Update server/storage/backend/verify.go
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
2024-02-22 11:31:16 -08:00
James Blair
9713761c9d
depdendency: github.com/prometheus/common from 0.46.0 to 0.47.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-02-22 22:25:22 +13:00
James Blair
f8141bc039
depdendency: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.47.0 to 0.48.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-02-22 22:25:22 +13:00
James Blair
df1727f3ea
depdendency: github.com/prometheus/client_model from 0.5.0 to 0.6.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-02-22 22:25:22 +13:00
James Blair
08cacf1984
depdendency: google.golang.org/grpc from 1.61.0 to 1.61.1.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-02-22 22:25:22 +13:00
Benjamin Wang
97fc1ec7d9
Merge pull request #17366 from halleyshx/add-keepalive-clientParams-to-proxy
...
Added client keepalive arguments to the grpc-proxy
2024-02-19 09:40:17 +00:00
vivekpatani
2eda06ac18
*: update logrus to v1.9.3
...
- update logrus to address PRISMA-2023-0056
- https://github.com/etcd-io/etcd/issues/17268
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2024-02-17 21:35:54 -08:00
Wei Fu
0354d39ae8
server/verify: use retErr to shadow local err
...
validateConsistentIndex function might return err but defer might still
log it's successful.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-17 17:21:19 +08:00
Benjamin Wang
ccc4318478
Merge pull request #17277 from ivanvc/fixes-etcdutl-memory-allocation-issue
...
etcdutl: Fix snapshot restore memory alloc issue
2024-02-14 11:41:14 +00:00
Ivan Valdes
be28833212
etcdutl: Fix snapshot restore memory alloc issue
...
When running the snapshot command, allow receiving an initial memory map
allocation for the database, avoiding future memory allocation issues.
Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
Co-authored-by: Fatih USTA <fatihusta86@gmail.com>
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-02-13 13:36:13 -08:00
Ivan Valdes
d69adf45f9
server: Implement WithMmapSize option for backend config
...
Accept a third argument for NewDefaultBackend for overrides to the
BackendConfig.
Add a new function, WithMmapSize, which modifies the backend config to
provide a custom InitiamMmapSize.
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-02-13 13:24:44 -08:00
Benjamin Wang
a6d72d5fbc
dependency: bump golang.org/x/net from 0.20.0 to 0.21.0
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
dfff80a89e
dependency: bump golang.org/x/crypto from 0.18.0 to 0.19.0
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
236e8ca881
dependency: bump go.opentelemetry.io/otel from 1.22.0 to 1.23.1
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
5c1b43c079
Dependency: bump golang.org/x/sys from 0.16.0 to 0.17.0
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
shihuixing
3850889442
improve description and update CHANGELOG-3.5.md
...
Signed-off-by: shihuixing <shihuixing@jd.com>
2024-02-09 15:14:27 +08:00
shihuixing
cf296a0b38
improve description for grpc-proxy keepalive arguments
...
Signed-off-by: shihuixing <shihuixing@jd.com>
2024-02-08 14:45:51 +08:00
Sharath Sivakumar
759d88a990
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.19.0 to 2.19.1
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-07 16:15:49 +01:00
shihuixing
79716fa112
added dial-keepalive-time、dial-keepalive-timeout、permit-without-stream arguments to the grpc-proxy
...
Signed-off-by: shihuixing <shihuixing@jd.com>
2024-02-05 11:13:46 +08:00
Wei Fu
32ee8b877a
etcdserver: drain leaky goroutines before test completed
...
If pending changes aren't committed before test completed, it might cause
data race when we don't drain all the background goroutines.
```bash
$ cd server
$ go test -race -v -run TestApplyRepeat ./etcdserver
...
panic: Log in goroutine after TestApplyRepeat has completed: 2024-02-03T17:06:13.262+0800 DEBUG bbolt Committing transaction 2
goroutine 81 [running]:
testing.(*common).logDepth(0xc000502820, {0xc0001b0460, 0x41}, 0x3)
/usr/local/go/src/testing/testing.go:1022 +0x6d4
testing.(*common).log(...)
/usr/local/go/src/testing/testing.go:1004
testing.(*common).Logf(0xc000502820, {0x1421ad7, 0x2}, {0xc000603520, 0x1, 0x1})
/usr/local/go/src/testing/testing.go:1055 +0xa5
go.uber.org/zap/zaptest.testingWriter.Write({{0x15f1f90?, 0xc000502820?}, 0xda?}, {0xc000119800, 0x42, 0x400})
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zaptest/logger.go:130 +0x11e
go.uber.org/zap/zapcore.(*ioCore).Write(0xc0000b55c0, {0xff, {0xc1679e614f9fd7a4, 0x73a3657, 0x1cc2400}, {0x1422b2d, 0x5}, {0xc0001a0330, 0x18}, {0x0, ...}, ...}, ...)
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/core.go:99 +0x193
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc000115930, {0x0, 0x0, 0x0})
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/entry.go:253 +0x2f0
go.uber.org/zap.(*SugaredLogger).log(0xc0001960f8, 0xff, {0x1437885, 0x19}, {0xc0006034e0, 0x1, 0x1}, {0x0, 0x0, 0x0})
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/sugar.go:316 +0x130
go.uber.org/zap.(*SugaredLogger).Debugf(...)
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/sugar.go:171
go.etcd.io/bbolt.(*Tx).Commit(0xc0001aa9a0)
/home/fuwei/go/pkg/mod/go.etcd.io/bbolt@v1.4.0-alpha.0/tx.go:173 +0x206
go.etcd.io/etcd/server/v3/storage/backend.(*batchTx).commit(0xc00019b180, 0x0)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:269 +0xdf
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).unsafeCommit(0xc00019b180, 0x0)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:378 +0x425
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).commit(0xc00019b180, 0x80?)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:355 +0x78
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).Commit(0xc00019b180)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:342 +0x35
go.etcd.io/etcd/server/v3/storage/backend.(*backend).run(0xc000478180)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/backend.go:426 +0x2c7
created by go.etcd.io/etcd/server/v3/storage/backend.newBackend in goroutine 80
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/backend.go:227 +0xbfd
FAIL go.etcd.io/etcd/server/v3/etcdserver 0.129s
FAIL
```
This patch also drains goroutines related to raftNode and watch store.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-03 18:58:17 +08:00
Sharath Sivakumar
9ec752d0f3
dependency: bump google.golang.org/grpc from 1.60.1 to 1.61.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-01 13:57:32 +01:00
Sharath Sivakumar
aa81e57855
dependency: bump go.opentelemetry.io/proto/otlp from 1.0.0 to 1.1.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-01 13:51:29 +01:00
Benjamin Wang
ca41186228
Merge pull request #17288 from ishan16696/promoteLeaner/addLogInfo
...
Added a error log when learner is not sync with etcd leader.
2024-01-30 12:47:28 +00:00
Ishan Tyagi
16a5e1da71
Added a error log when learner is not sync with etcd leader.
...
Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
2024-01-30 15:42:11 +05:30
Benjamin Wang
c12e15d91a
Add verification on keys: should be always mononically increasing
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-01-25 18:00:26 +00:00
Benjamin Wang
c647614b6a
test: fix TestHashKVWhenCompacting: ensure all goroutine finished
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-01-25 13:30:27 +00:00
Benjamin Wang
f932c00791
Merge pull request #17314 from ahrtr/configure_peer_log_20240124
...
Print error log when creating peer listener failed
2024-01-25 10:05:38 +00:00
Benjamin Wang
d1cc01a574
Merge pull request #17319 from jmhbnz/weekly-dependency-update
...
[2024-01-25] Bump dependencies identified by dependabot
2024-01-25 10:02:42 +00:00
James Blair
9cfbbb9556
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.46.1. to 0.47.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-01-25 15:26:26 +13:00
James Blair
3666454826
depdendency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.21.0 to 1.22.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-01-25 15:24:53 +13:00
James Blair
2edcf60b4f
depdendency: bump go.opentelemetry.io/otel from 1.21.0 to 1.22.0.
...
Signed-off-by: James Blair <mail@jamesblair.net>
2024-01-25 15:19:09 +13:00