19336 Commits

Author SHA1 Message Date
Marek Siarkowicz
b3bb996880
Merge pull request #15420 from ahrtr/dependency_20230307
Bump some dependencies
2023-03-09 13:03:56 +01:00
Marek Siarkowicz
12d7a32974
Merge pull request #15433 from jmhbnz/main
Update contributing guide with new codespaces developement option
2023-03-09 13:01:52 +01:00
James Blair
b4c499ed7a
Update contributing docs with new codespaces developement option.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-03-09 22:28:25 +13:00
Benjamin Wang
6bd7660079
Merge pull request #15427 from jmhbnz/main
Updated go to latest 1.19.7 release
2023-03-08 19:06:12 +08:00
James Blair
5b3497555f
Updated go to 1.19.7.
Mitigates CVE-2023-24532.

Signed-off-by: James Blair <mail@jamesblair.net>
2023-03-08 21:39:31 +13:00
Benjamin Wang
24f5d4a6fb
Merge pull request #15201 from dbadoy/main
pkg/schedule: correct comparison for FIFO schedule test
2023-03-08 14:46:58 +08:00
dbadoy4874
ebb5e74ace pkg/schedule:correct comparison for FIFO schedule test
Signed-off-by: dbadoy4874 <dbadoy4874@gmail.com>
2023-03-08 13:18:05 +09:00
Benjamin Wang
aaa8bfee99
Merge pull request #15425 from fuweid/update-TestLeasingDeleteRangeContendTxn
tests/integration: Update TestLeasingDeleteRangeContendTxn
2023-03-08 08:08:38 +08:00
Wei Fu
3419230eea tests/integration: Update TestLeasingDeleteRangeContendTxn
The TestLeasingDeleteRangeContendTxn is trying to test for RangeDelete when
the target resources are being updated.  When the `txnLeasing` wants a
server-side transaction, it needs to ensure all the keys mod revision should
be leass than what it saw. If the compare fails, it will repeat to apply the
server-side transaction until it is sucessful. I believe the test-case is
trying to verify how the `txnLeasing` handles the race issue.

Before the patch #15401, the resource-updating goroutine keeps updating until
the RangeDelete finishes. The testcase is flaky because two goroutines are
sharing one `ctx` and grpc-go client won't wait for the response if `ctx`
has been canceled.

For example,

| DelLease Goroutine   | PutLease Goroutine         | ETCD Server                    | Key/0 Status |
| --                   | ---                        | --                             | --           |
| deleted              |                            |                                | version = 0  |
|                      | send update(key/0=123) req | received update(key/0=123) req | version = 0  |
| cancel               |                            |                                | version = 0  |
|                      | exit because of cancel     |                                | version = 0  |
| get key/0 by putkv   |                            |                                | version = 0  |
|                      |                            | applied update(key/0=123)      | version = 1  |
| get key/0 by raw-cli |                            |                                | version = 1  |

So `raw-cli` gets `[key/0=123]` while the `putkv` gets `[]`. If `putkv`
applies two update reqs to ETCD server and the last one is canceled
before apply, the error will be like:

```
expected [key:"key/0" version:2 value:"123" ], got [key:"key/0" version:1 value:"123" ]
```

The resource-updating goroutine should not share the ctx with RangeDelete here.
And I also revert current main branch because the resource-update goroutine
only updates 8 times and might exit before `RangeDelete`. In this case,
the `txnLeasing` is not handling the race issue.

Fixes: #15352

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-03-07 23:11:41 +08:00
Benjamin Wang
7ed1219861 dependency: bump golang.org/x/net to v0.8.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-03-07 06:52:07 +08:00
Benjamin Wang
b53d63219a dependency: bump github.com/cheggaaa/pb/v3 to v3.1.2
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-03-07 06:17:01 +08:00
Marek Siarkowicz
76a563608e
Merge pull request #15408 from jmhbnz/main
Return default snapshot count to 10,000
2023-03-06 10:23:35 +01:00
James Blair
275e10bcf7
Return default snapshot count to 10,000.
The huge (100k+) value was justified when storev2 was being dumped completely with every snapshot.

With storev2 being decomissioned we can checkpoint more frequently for faster recovery.

Signed-off-by: James Blair <mail@jamesblair.net>
2023-03-06 20:21:03 +13:00
Benjamin Wang
7a98ab3ae0
Merge pull request #15378 from chaochn47/auth_test_split_5
migration auth tests to common #5
2023-03-04 07:07:02 +08:00
Benjamin Wang
69ce1aab54
Merge pull request #15405 from jmhbnz/main
CHANGELOG: Add entries for 3.4 and 3.5 go version 1.19.
2023-03-04 05:03:01 +08:00
Chao Chen
c002e096b5 migration auth tests to common #5
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-03-03 12:26:36 -08:00
Benjamin Wang
28d965b578
Merge pull request #15383 from jmhbnz/feat/add_devcontainer
Add initial .devcontainer for go 1.19
2023-03-04 04:24:05 +08:00
James Blair
8c18bf8bc4
Add CHANGELOG entries for 3.4 and 3.5 go version 1.19.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-03-04 08:47:56 +13:00
Marek Siarkowicz
85bd9d7719
Merge pull request #15401 from tjungblu/racefix_15352
Fixing flaky TestLeasingDeleteRangeContendTxn
2023-03-03 12:23:25 +01:00
Thomas Jungblut
63964ec781 Fixing flaky TestLeasingDeleteRangeContendTxn
Fixes etcd-io#15352.
Depending on the goroutine scheduling, the expected count of 8 might not
have been reached yet. This ensures the routine won't stop earlier than
that.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2023-03-03 11:38:22 +01:00
Piotr Tabor
d358e35f3e
Merge pull request #15379 from chaochn47/auth_test_split_6
migrate auth tests to common #6
2023-03-03 10:55:28 +01:00
Piotr Tabor
c0f37bb5d5
Merge pull request #15384 from xakdwch/main
rpctypes: use status.Error() instead of status.New().Err()
2023-03-03 10:48:23 +01:00
Piotr Tabor
dff5d1e996
Merge pull request #15398 from xakdwch/feature-enhance
rafthttp: replace inline code with existing function
2023-03-03 10:47:09 +01:00
Benjamin Wang
2e0cafce29
Merge pull request #15399 from ahrtr/dependency_20230303
dependency: bump go.opentelemetry.io/otel to v1.14.0
2023-03-03 17:41:11 +08:00
Benjamin Wang
56423eacd2 dependency: bump go.opentelemetry.io/otel to v1.14.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-03-03 15:44:47 +08:00
xakdwch
c767f429f0 rafthttp: replace inline code with existing function
The isMsgApp function implements the judgment of the MsgApp message,
use the isMsgApp function instead.

Signed-off-by: xakdwch <xakdwch5@gmail.com>
2023-03-03 09:50:14 +08:00
James Blair
9783253788
Add initial .devcontainer for go.19.
When the devcontainer starts it will run make build to ensure compiled binaries are immediately available for use.

I've confirmed make test is also behaving as expected within the devcontainer.

Signed-off-by: James Blair <mail@jamesblair.net>
2023-03-03 07:03:25 +13:00
Marek Siarkowicz
d4acc0ad9f
Merge pull request #15313 from serathius/dependabot-root
workflows: Remove non-root gomod dependabot rules
2023-03-02 10:17:29 +01:00
xakdwch
8298ed8204 rpctypes: use status.Error() instead of status.New().Err()
status.Error() returns an error representing error code and msg,
status.Error() is better than status.New().Err().

Signed-off-by: xakdwch <xakdwch5@gmail.com>
2023-03-02 10:47:09 +08:00
Marek Siarkowicz
6471b9e320 workflows: Remove non-root gomod dependabot rules and enable dependency-type all to ensure upgrade of indirect dependencies
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-03-01 13:30:21 +01:00
Chao Chen
d798816baf migrate auth tests to common #6
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-02-28 10:32:29 -08:00
Benjamin Wang
c6beef8f0e
Merge pull request #15376 from ahrtr/dependencies_20230228
Dependencies: bump some dependencies
2023-02-28 16:52:01 +08:00
Benjamin Wang
5f872589cd dependency: bump golang.org/x/sync to v0.1.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-28 06:56:16 +08:00
Benjamin Wang
bc55e615d2 dependency: bump golang.org/x/sys to v0.5.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-28 06:54:08 +08:00
Benjamin Wang
6af2c9dbfa dependency: bump golang.org/x/crypto to v0.6.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-28 06:51:55 +08:00
Benjamin Wang
f333148da9 dependency: bump golang.org/x/time to v0.3.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-28 06:49:39 +08:00
Benjamin Wang
d8b8127084 dependency: bump github.com/stretchr/testify from 1.8.1 to 1.8.2
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-28 06:44:33 +08:00
Benjamin Wang
da4bf0f76f
Merge pull request #15261 from ahrtr/memberlist_20230208
clientv3: support serializable `MemberList` operation
2023-02-28 06:26:38 +08:00
Benjamin Wang
858d25c43b
Merge pull request #15359 from serathius/robustness-rename
tests: Rename linearizability tests to robustness
2023-02-27 06:58:51 +08:00
Marek Siarkowicz
d475cf81a0 tests: Rename linearizability tests to robustness
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-02-26 14:36:18 +01:00
Marek Siarkowicz
cb2a22e5d1
Merge pull request #15351 from chaochn47/auth_test_split_4
migrate auth test to common #4
2023-02-26 13:45:11 +01:00
Benjamin Wang
baa21858c1
Merge pull request #15358 from etcd-io/dependabot/go_modules/client/pkg/golang.org/x/sys-0.1.0
build(deps): bump golang.org/x/sys from 0.0.0-20210603125802-9665404d3644 to 0.1.0 in /client/pkg
2023-02-25 19:30:54 +08:00
dependabot[bot]
8aedd91a02
build(deps): bump golang.org/x/sys in /client/pkg
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20210603125802-9665404d3644 to 0.1.0.
- [Release notes](https://github.com/golang/sys/releases)
- [Commits](https://github.com/golang/sys/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-02-25 08:42:06 +00:00
Benjamin Wang
42eee79f25
Merge pull request #15357 from etcd-io/dependabot/github_actions/github/codeql-action-2.2.5
build(deps): bump github/codeql-action from 2.2.4 to 2.2.5
2023-02-25 08:39:06 +08:00
Benjamin Wang
3de346259b clientv3: update etcdctl's readme and comment of clientv3.WithSerializable to clarify the use cases
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-25 07:23:39 +08:00
Benjamin Wang
1f0d361848 clientv3: support serializable MemberList operation
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-02-25 07:23:39 +08:00
dependabot[bot]
0c52e5e133
build(deps): bump github/codeql-action from 2.2.4 to 2.2.5
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.4 to 2.2.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](17573ee1cc...32dc499307)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-02-24 23:21:07 +00:00
Benjamin Wang
0a8cdddd26
Merge pull request #15356 from jmhbnz/main
Ensure we are using an up to date govulncheck
2023-02-25 07:20:30 +08:00
James Blair
2d2fbcc30e
Ensure we are using an up to date govulncheck.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-02-25 11:25:33 +13:00
Chao Chen
b93745a862 migrate to auth test #4
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-02-23 10:46:31 -08:00