Madhav Jivrajani
cdd018ad2a
tests/robustness: add a robustness test for validating create events
...
Split off valdiating create events from the prevKV test.
The added test tests the following two:
- A create event should not exist in our past history
- A non-create event should exist in our past history
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-02-14 16:28:44 +05:30
Madhav Jivrajani
4fa07a1c8a
tests/robustness: make merging histories work on []PersistedEvent
...
Event histories after merging serve as an authorotative list of
events that can be seen as ones persisted by etcd, we don't need
PrevValue as part of it.
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-02-14 15:44:08 +05:30
Marek Siarkowicz
83817ac786
Merge pull request #17352 from MadhavJivrajani/with-prev-key-robustness-test
...
tests/robustness: add robustness test for watch with PrevKV()
2024-02-14 09:24:33 +01:00
Madhav Jivrajani
9aad6700d5
tests/robustness: add robustness test for watch with PrevKV()
...
Kubernetes relies on the PrevKV() option in the watches it opens
against etcd. This commit adds a robustness test to validate the
same.
A watch response returned with PrevKV() is valid if:
The value in current event's prevKV matches the previous
event's value of the same key if this is not a create event.
There are cases where there can be a prevKV for a create event
as well, for example if a watch is opened after the key is creatd.
Since we don't simulate for that, we don't check for that.
Further, this adjusts revision numbers such that we can successfully create
a new replay. Needed now since we will have unit tests with
and without PrevKV co-existing and we requite creation of a
new replay everytime we validate PrevKV.
We also regenerate test data with so that prevKV exists in it
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-02-13 22:55:57 +05:30
Benjamin Wang
cb91828f56
Merge pull request #17420 from ahrtr/dependency_20240213
...
[2024-02-13] Bump dependencies
2024-02-13 10:49:58 +00:00
Benjamin Wang
a7d5a9e42c
Merge pull request #17418 from ArkaSaha30/configure_cgo
...
Make CGO_ENABLED configurable
2024-02-13 09:36:01 +00:00
Benjamin Wang
dd9dd84a02
dependency: bump github.com/mikefarah/yq/v4 from 4.40.5 to 4.40.7
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
a6d72d5fbc
dependency: bump golang.org/x/net from 0.20.0 to 0.21.0
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
dfff80a89e
dependency: bump golang.org/x/crypto from 0.18.0 to 0.19.0
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
236e8ca881
dependency: bump go.opentelemetry.io/otel from 1.22.0 to 1.23.1
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
5c1b43c079
Dependency: bump golang.org/x/sys from 0.16.0 to 0.17.0
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
2c80656885
Merge pull request #17406 from etcd-io/dependabot/github_actions/actions/upload-artifact-4.3.1
...
build(deps): bump actions/upload-artifact from 4.3.0 to 4.3.1
2024-02-13 09:31:52 +00:00
Benjamin Wang
cb42e2264c
Merge pull request #17407 from etcd-io/dependabot/github_actions/golangci/golangci-lint-action-4.0.0
...
build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0
2024-02-13 09:17:39 +00:00
Arka Saha
20005e0e84
Make CGO_ENABLED configurable
...
Signed-off-by: Arka Saha <arkas1@vmware.com>
2024-02-13 13:24:55 +05:30
dependabot[bot]
78a693fc71
build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 3.7.0 to 4.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](3a91952989...3cfe3a4abb
2024-02-12 17:36:21 +00:00
dependabot[bot]
271b9cdbaa
build(deps): bump actions/upload-artifact from 4.3.0 to 4.3.1
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](26f96dfa69...5d5d22a312
2024-02-12 17:36:19 +00:00
Benjamin Wang
ea89e3fd94
Merge pull request #17403 from ahrtr/cleanup_20240208
...
Remove the unused AuthTokenTTL parameter from integration test
2024-02-12 14:46:28 +00:00
Benjamin Wang
5b2a9e2ab3
Remove the unused AuthTokenTTL parameter from integration test
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-11 14:09:43 +00:00
Benjamin Wang
42f0cb9762
Merge pull request #17395 from ahrtr/update_maintainers_20240208
...
Add Hitoshi Mitake into the Emeritus Maintainers list
2024-02-08 16:05:07 +00:00
Benjamin Wang
8732f27369
Add Hitoshi Mitake into the Emeritus Maintainers list
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-08 15:15:34 +00:00
Benjamin Wang
25f91b4e50
Merge pull request #17384 from mitake/watch-auth-str
...
Remove string dependent error handling in watch and auth
2024-02-08 13:54:46 +00:00
Benjamin Wang
5d45a88ab7
Merge pull request #17380 from dusk125/go1.21-changelog
...
Add go1.21 update to changelog
2024-02-07 17:57:51 +00:00
Benjamin Wang
88e7c381dd
Merge pull request #17388 from Elbehery/update_changelog_35_34
...
add OpenBSD support to changelog 3.5
2024-02-07 17:55:30 +00:00
Benjamin Wang
99e7a4cd89
Merge pull request #17392 from sharathsivakumar/shsi/bump_deps_15
...
Manually bump dependencies
2024-02-07 16:41:54 +00:00
Benjamin Wang
29600058d7
Merge pull request #17287 from nitishfy/Nitish/memberReplaceWithLearner
...
feat: add `memberReplaceLearnerTest` test
2024-02-07 16:32:39 +00:00
Mustafa Elbehery
d42d5a391b
add OpenBSD support to changelog 3.5
...
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
2024-02-07 17:20:22 +01:00
Sharath Sivakumar
759d88a990
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.19.0 to 2.19.1
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-07 16:15:49 +01:00
Allen Ray
aac5c09fe4
Add go1.21 update to changelog
...
Signed-off-by: Allen Ray <alray@redhat.com>
2024-02-07 09:20:17 -05:00
Benjamin Wang
26252c6bb4
Merge pull request #17372 from etcd-io/dependabot/github_actions/github/codeql-action-3.24.0
...
build(deps): bump github/codeql-action from 3.23.2 to 3.24.0
2024-02-07 11:01:32 +00:00
NitishKumar06
70cc19aad5
etcdserver: add memberReplaceLearnerTest to improve testing coverage
...
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
get learner member id
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
get learner member id
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
check for edge case
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
modify testcase to use var declaration
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
remove shadow delcaration of variables
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
resolve minor fixes
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
2024-02-06 20:05:16 +05:30
Benjamin Wang
cf7043391c
Merge pull request #15812 from tangruize/main
...
etcd: ignore SetKeepAlivePeriod errors on OpenBSD
2024-02-06 13:05:56 +00:00
Hitoshi Mitake
15aae5b4e2
Merge pull request #17385 from mitake/retire-mitake
...
Update OWNERS: retire mitake
2024-02-06 21:07:50 +09:00
Hitoshi Mitake
617f1df443
Remove string dependent error handling in watch and auth
...
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
2024-02-06 19:25:53 +09:00
Hitoshi Mitake
8c9dd749a2
Update OWNERS: retire mitake
...
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
2024-02-06 18:42:57 +09:00
Sahdev Zala
b2dae1048d
Merge pull request #17370 from dusk125/backoff-config-changelog
...
Add backoff/retry config to changelog
2024-02-05 20:12:39 -05:00
Sahdev Zala
53a9a354df
Merge pull request #17367 from ahrtr/email_20240205
...
Update ahrtr's email
2024-02-05 20:10:42 -05:00
dependabot[bot]
aaddb79663
build(deps): bump github/codeql-action from 3.23.2 to 3.24.0
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.23.2 to 3.24.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b7bf0a3ed3...e8893c57a1
2024-02-05 17:18:30 +00:00
Allen Ray
4d9bff9834
Add backoff/retry config to changelog
...
Signed-off-by: Allen Ray <alray@redhat.com>
2024-02-05 10:46:03 -05:00
Benjamin Wang
5d356305ee
Update ahrtr's email
...
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-05 14:30:50 +00:00
Benjamin Wang
928173985e
Merge pull request #17365 from fuweid/fix-race
...
etcdserver: drain leaky goroutines before test completed
2024-02-05 12:53:40 +00:00
Wei Fu
32ee8b877a
etcdserver: drain leaky goroutines before test completed
...
If pending changes aren't committed before test completed, it might cause
data race when we don't drain all the background goroutines.
```bash
$ cd server
$ go test -race -v -run TestApplyRepeat ./etcdserver
...
panic: Log in goroutine after TestApplyRepeat has completed: 2024-02-03T17:06:13.262+0800 DEBUG bbolt Committing transaction 2
goroutine 81 [running]:
testing.(*common).logDepth(0xc000502820, {0xc0001b0460, 0x41}, 0x3)
/usr/local/go/src/testing/testing.go:1022 +0x6d4
testing.(*common).log(...)
/usr/local/go/src/testing/testing.go:1004
testing.(*common).Logf(0xc000502820, {0x1421ad7, 0x2}, {0xc000603520, 0x1, 0x1})
/usr/local/go/src/testing/testing.go:1055 +0xa5
go.uber.org/zap/zaptest.testingWriter.Write({{0x15f1f90?, 0xc000502820?}, 0xda?}, {0xc000119800, 0x42, 0x400})
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zaptest/logger.go:130 +0x11e
go.uber.org/zap/zapcore.(*ioCore).Write(0xc0000b55c0, {0xff, {0xc1679e614f9fd7a4, 0x73a3657, 0x1cc2400}, {0x1422b2d, 0x5}, {0xc0001a0330, 0x18}, {0x0, ...}, ...}, ...)
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/core.go:99 +0x193
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc000115930, {0x0, 0x0, 0x0})
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/entry.go:253 +0x2f0
go.uber.org/zap.(*SugaredLogger).log(0xc0001960f8, 0xff, {0x1437885, 0x19}, {0xc0006034e0, 0x1, 0x1}, {0x0, 0x0, 0x0})
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/sugar.go:316 +0x130
go.uber.org/zap.(*SugaredLogger).Debugf(...)
/home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/sugar.go:171
go.etcd.io/bbolt.(*Tx).Commit(0xc0001aa9a0)
/home/fuwei/go/pkg/mod/go.etcd.io/bbolt@v1.4.0-alpha.0/tx.go:173 +0x206
go.etcd.io/etcd/server/v3/storage/backend.(*batchTx).commit(0xc00019b180, 0x0)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:269 +0xdf
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).unsafeCommit(0xc00019b180, 0x0)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:378 +0x425
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).commit(0xc00019b180, 0x80?)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:355 +0x78
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).Commit(0xc00019b180)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:342 +0x35
go.etcd.io/etcd/server/v3/storage/backend.(*backend).run(0xc000478180)
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/backend.go:426 +0x2c7
created by go.etcd.io/etcd/server/v3/storage/backend.newBackend in goroutine 80
/home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/backend.go:227 +0xbfd
FAIL go.etcd.io/etcd/server/v3/etcdserver 0.129s
FAIL
```
This patch also drains goroutines related to raftNode and watch store.
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-02-03 18:58:17 +08:00
Benjamin Wang
43d6759977
Merge pull request #17335 from etcd-io/dependabot/github_actions/github/codeql-action-3.23.2
...
build(deps): bump github/codeql-action from 3.23.1 to 3.23.2
2024-02-01 16:04:56 +00:00
Benjamin Wang
6344109a17
Merge pull request #17334 from etcd-io/dependabot/github_actions/actions/upload-artifact-4.3.0
...
build(deps): bump actions/upload-artifact from 4.2.0 to 4.3.0
2024-02-01 15:20:59 +00:00
Benjamin Wang
7926173240
Merge pull request #17358 from sharathsivakumar/shsi/bump_deps_13
...
Manually bump dependencies
2024-02-01 14:06:05 +00:00
Sharath Sivakumar
93b5e5a3e0
dependency: bump github.com/alexfalkowski/gocovmerge from 1.2.3 to 1.2.6
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-01 14:18:54 +01:00
Sharath Sivakumar
60d642332c
dependency: bump github.com/cheggaaa/pb/v3 from 3.1.4 to 3.1.5
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-01 14:18:36 +01:00
Sharath Sivakumar
9ec752d0f3
dependency: bump google.golang.org/grpc from 1.60.1 to 1.61.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-01 13:57:32 +01:00
Sharath Sivakumar
aa81e57855
dependency: bump go.opentelemetry.io/proto/otlp from 1.0.0 to 1.1.0
...
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-02-01 13:51:29 +01:00
Marek Siarkowicz
13b48947d4
Merge pull request #17356 from MadhavJivrajani/fix-out-of-index-error
...
tests/robustness: fix out of index panic in model replay
2024-02-01 12:24:10 +01:00
Madhav Jivrajani
f0f4e8a4e8
tests/robustness: fix out of index panic in model replay
...
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-02-01 16:14:35 +05:30
