Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
17,085 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

17085 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Wilson Wang
d3ae6f25dd tools: fix small rw-heatmaps python plot script argument parsing bug 
(cherry picked from commit 5b6b3ffe0b9fca7c72edfc2218e98357d1152872)
 2021-06-02 13:32:02 -07:00
Piotr Tabor
004081cc08
Merge pull request #13045 from wilsonwang371/add-benchmark-param 
tool: save test parameters in mixed read/write benchmark script.
 2021-05-27 20:56:11 +02:00
Wilson Wang
8389ab8751 tool: save test parameters in mixed read/write benchmark script. 2021-05-26 20:38:49 -07:00
Piotr Tabor
71934ff244
Merge pull request #13010 from ipixiu/imp/store-scheduleCompaction-lock 
limit tx lock scope in store.scheduleCompaction
 2021-05-26 08:51:44 +02:00
Piotr Tabor
db556c11b2
Merge pull request #13042 from wilsonwang371/no-hardcoded-repeat 
tools: no hardcoded repeat times in rw-benchmark scripts
 2021-05-26 08:36:10 +02:00
Wilson Wang
2ab2b4035c tools: no hardcoded repeat times in rw-benchmark scripts 2021-05-25 15:43:46 -07:00
Gyuho Lee
adecd73975
Merge pull request #13039 from ptabor/20210525-make-logger-public 
Expose clientv3.CreateDefaultZapLoggerConfig
 2021-05-25 14:42:42 -07:00
Gyuho Lee
a3f14cdf53
Merge pull request #13040 from wilsonwang371/main 
tools: update mixed read/write benchmark script
 2021-05-25 14:42:27 -07:00
Piotr Tabor
bda32db121 Expose clientv3.CreateDefaultZapLoggerConfig 
Need raised in
f3f4259d3f.

BTW: Alligned the implementation of grpclogs with what we use in embed
server, so reduced the client code dependencies.
 2021-05-25 22:59:08 +02:00
Wilson Wang
db8ce62984 tools: update mixed read/write benchmark script 2021-05-25 13:30:56 -07:00
Gyuho Lee
99c8b4dae1
Merge pull request #13038 from wilsonwang371/perf-eval 
tools: add mixed read-write performance evaluation scripts
 2021-05-25 12:49:02 -07:00
Wilson Wang
79b2777482 tools: add mixed read-write performance evaluation scripts 2021-05-25 12:03:42 -07:00
Sahdev Zala
05674c87fb
Merge pull request #13018 from ipixiu/feature/bolt-compaction-sleep-interval 
add bolt compaction sleep interval
 2021-05-25 10:06:47 -04:00
Gyuho Lee
7a7b668edb
Merge pull request #12933 from wilsonwang371/shared_txReadBuffer 
server: set multiple concurrentReadTx instances share one txReadBuffer
 2021-05-24 16:38:14 -07:00
Wilson Wang
9c82e8c72b server: set multiple concurrentReadTx instances share one txReadBuffer. 2021-05-24 15:16:53 -07:00
赵延
64b01a7a8d
Enhance the root permission, when root role exist, it always return rootPerm. (#13006) 
etcdctl role grant-permission root readwrite foo.
see etcdctl role get root output.
Before:
Role root
KV Read:
        foo
KV Write:
        foo
After:
Role root
KV Read:
        [, <open ended>
KV Write:
        [, <open ended>
 2021-05-24 14:58:00 -07:00
Piotr Tabor
d2e04a7171
Merge pull request #13034 from spzala/updatechangelog 
CHANGELOG: add missing default setting for grpc gateway flag
 2021-05-24 21:59:14 +02:00
Sahdev Zala
30a67850ce CHANGELOG: add missing default setting for grpc gateway flag 
Add missing changelog entry for the flag setting for the
enable-grpc-gateway.
 2021-05-24 13:30:09 -04:00
Piotr Tabor
06538eee8d
Merge pull request #13032 from astromechza/patch-1 
CHANGELOG: added missing entry for ClientCertFile
 2021-05-24 11:39:46 +02:00
Ben Meier
2ca308969d
CHANGELOG: added missing entry for ClientCertFile 2021-05-24 10:08:28 +01:00
AlexStocks
184b0e5d49 add sleep interval 2021-05-24 16:22:00 +08:00
Piotr Tabor
6c72c1b09c
Merge pull request #13024 from timmyyuan/fix-goroutine-leak 
Fix the goroutine leak in StubServer
 2021-05-21 15:53:57 +02:00
Ting Yuan
838be9c751 Omit the blank line 2021-05-21 21:25:49 +08:00
Ting Yuan
2d2a95c3fb Fix the format issue 2021-05-21 21:23:38 +08:00
Ting Yuan
1b700e5ed8 Fix the goroutine leak in StubServer 
---

(If this PR fixes a github issue, please add `Fixes #<xyz>`)

Fixes #13023

(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>`
to link to the master issue)

Master Issue: #13023

*Motivation*

Currently, StubServer can stop itself (by Stop()) before it start its
grpc server (created by Start()). This race condition may lead to a
goroutine leak mentioned by #13023.

*Modifications*

This PR add a channel to force the Stop() started after Start()

*Verify this change*

Please pick either of following options.

- This change is already covered by existing tests, such as *(please describe tests)*.

Test/TestEtcdGrpcResolver
 2021-05-21 20:54:06 +08:00
Piotr Tabor
e149da312a
Merge pull request #13017 from gpavanb1/assert_replace 
*: Replace internal testutil AssertEqual function
 2021-05-21 11:30:07 +02:00
Pavan BG
facba6c663 client: Replace nil value testing with assert.Nil 
Multiple errors in previous commit where `nil` is not being detected by `assert.Equal`
 2021-05-21 14:18:01 +05:30
Pavan BG
25d3c1b068 *: Fixed go.sum 
Ran fix.sh script to correct for differences in go.sum, perhaps due to multiple Golang versions
 2021-05-21 13:28:43 +05:30
Pavan BG
ce5bb69c28 client: Added missing packages 
go.etcd.io/etcd/client/pkg/v3/testutil: package github.com/stretchr/testify/assert imported from implicitly required module; to add missing requirements, run:
 2021-05-20 21:44:12 +05:30
Pavan BG
319ef4aa42 client: Removed AssertEqual function 
Used github.com/stretchr/testify/assert to replace the AssertEqual function definition. Required the use of copyToInterface to copy a string slice to the empty interface slice
 2021-05-20 21:33:07 +05:30
Pavan BG
d9c5e1f0a2 *: Replace internal testutil AssertEqual function in favour of github.com/stretchr/testify/assert.Equals 
To maintain uniformity in testing methodology, assert.Equals has been used everywhere while replacing testutil.AssertEqual

Fixes #13015
 2021-05-20 19:55:45 +05:30
Piotr Tabor
b29e8e47a6
Merge pull request #13014 from lilic/functional-socket-reuse 
tests/functional: Set socket-reuse-port and socket-reuse-address
 2021-05-20 15:00:43 +02:00
Piotr Tabor
e299264cf3
Merge pull request #13011 from lilic/socket-options-file 
WIP: client,server: Expose reuse-port and reuse-address so they can be configured via a config file
 2021-05-20 13:50:21 +02:00
Lili Cosic
0ee2aba910 .github/workflows/functional.yaml: Adjust to use new script 2021-05-20 13:41:41 +02:00
Lili Cosic
b23ab1f759 tests/functional: Require same version of protoc everwhere 
The main genproto.sh script requires latest version, this confirms the
test protoc to do the same.
 2021-05-20 13:41:41 +02:00
Lili Cosic
fe2a9bd7e9 Update go.mod and go.sum files after running scripts 2021-05-20 13:41:41 +02:00
Lili Cosic
cb8c0a0507 tests/functional/rpcpb/rpc.pb.go: Regenerate 
run ./scripts/genproto.sh
 2021-05-20 13:41:41 +02:00
Lili Cosic
13bf7b0766 tests/functional: Set socket-reuse-port and socket-reuse-address 
Due to flakes in CI and locally which resulted due to shared servers
there is suspcion that fixed port numbers are to blame. This reuses port
and address.
 2021-05-20 13:41:41 +02:00
Piotr Tabor
41227b7a2b
Merge pull request #13012 from gliptak/patch-2 
Correct typo
 2021-05-20 12:38:38 +02:00
Lili Cosic
e0e4ddc268 test.sh: Reference test.sh instead of deprecated test 2021-05-20 10:00:27 +02:00
Lili Cosic
7957f4461d server/embed/config_test.go: Add unit test for socket options 2021-05-20 10:00:27 +02:00
Patrice Chalin
96a1efded0
Documentation/README simplification (#13007) 
In support of https://github.com/etcd-io/website/issues/65, simply direct the reader to the website (rather than once again defining what etcd it).
 2021-05-19 17:51:51 -07:00
Gábor Lipták
204e87cfb8
Correct typo 
Signed-off-by: Gábor Lipták gliptak@gmail.com
 2021-05-19 17:53:00 -04:00
Lili Cosic
73c530de83 client,server: Expose reuse-port and reuse-address so they can be 
configured via a config file.
 2021-05-19 18:41:21 +02:00
AlexStocks
6d68f7841a limit tx lock scope 2021-05-19 23:47:46 +08:00
Hitoshi Mitake
5f60e0d799
Merge pull request #12979 from horizonzy/enhance-role-output 
Enhance getRole output when the role is 'root'.
 2021-05-19 23:39:51 +09:00
horizonzy
6ab56fc237 enhance GetRole output when role is 'root' and the response perm is nil. 
Before output:
Role root
KV Read:
KV Write:

After output:
Role root
KV Read:
	[, <open ended>
KV Write:
	[, <open ended>
 2021-05-19 17:35:13 +08:00
Piotr Tabor
159d1916fe
Merge pull request #12985 from ptabor/20210517-fix-not-a-learner-retries 
Fix not retryable error codes from: Unavailable -> FailedPrecondition
 2021-05-19 08:05:22 +02:00
Piotr Tabor
788bc5359d
Merge pull request #13000 from ptabor/20210519-shouldApplyV3 
applyV2 should apply on backend only once
 2021-05-19 02:09:36 +02:00
Piotr Tabor
16d51d8c26 Fix not retryable error codes from: Unavailable -> FailedPrecondition 
- ErrGRPCNotCapable("etcdserver: not capable") -> codes.FailedPrecondition  (it will not autofix, it requires new version of server)
 - ErrGPRCNotSupportedForLearner("etcdserver: rpc not supported for learner") -> codes.FailedPrecondition (as long as its learner, the call will not work)
 - ErrGRPCClusterVersionUnavailable("etcdserver: cluster version not found during downgrade") -> codes.FailedPrecondition (backend does not contain the version (old etcd?) so retry will not help)

https://github.com/etcd-io/etcd/runs/2599598633?check_suite_focus=true

```
{"level":"warn","ts":"2021-05-17T09:55:30.246Z","logger":"etcd-client","caller":"v3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"etcd-endpoints://0xc000539880/#initially=[unix://localhost:m30]","attempt":0,"error":"rpc error: code = Unavailable desc = etcdserver: rpc not supported for learner"}
{"level":"warn","ts":"2021-05-17T09:55:30.270Z","logger":"etcd-client","caller":"v3/retry_interceptor.go:62","msg":"retrying
of unary invoker
failed","target":"etcd-endpoints://0xc000539880/#initially=[unix://localhost:m30]","attempt":1,"error":"rpc
error: code = Unavailable desc = etcdserver: rpc not supported for
learner"}`
```
 2021-05-19 02:08:53 +02:00