18830 Commits

Author SHA1 Message Date
Tobias Grieger
d4316f34ac
Merge pull request #14795 from falser101/fix/log_unstable
Fixed https://github.com/etcd-io/etcd/issues/14709
2022-11-21 20:57:05 +01:00
Marek Siarkowicz
16862fa0bf
Merge pull request #13552 from dbussink/small-build-improvement
release: build with consistent paths
2022-11-21 15:45:44 +01:00
Dirkjan Bussink
c26dabacbd
release: build with consistent paths
This changes the builds to always add -trimpath which removes specific
build time paths from the binary (like current directories etc).

Improves build reproducability to make the final binary independent from
the specific build path.

Lastly, when stripping debug symbols, also add -w to strip DWARF symbols
as well which aren't needed in that case either.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
2022-11-21 15:06:11 +01:00
Benjamin Wang
ddd65e7fe2
Merge pull request #14803 from ahrtr/experimental_flag
Graduate `--experimental-warning-unary-request-duration` to `--warning-unary-request-duration`
2022-11-19 02:40:50 +08:00
Benjamin Wang
ebfcaaed34 test: fix the test failures in e2e/warning_logging_test.go
1. Fixed the test failures which are caused by recent test framework rafactoring;
2. renamed the file to promote_experimental_flag_test.go.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-19 01:51:06 +08:00
jianfei.zhang
de6b5797ed feat: raft/log_unstable_test use testify packages in tests
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
2022-11-18 19:41:31 +08:00
Benjamin Wang
8265e9fe55 etcdserver: resolve the changelog comment
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-18 18:06:00 +08:00
Bogdan Kanivets
7e8ebf7727 server: added duplicate warning-unary-request-duration flag
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes https://github.com/etcd-io/etcd/issues/13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
2022-11-18 18:06:00 +08:00
Marek Siarkowicz
07a3cfe22e
Merge pull request #14804 from ahrtr/update_gofail
tool: bump gofail version
2022-11-18 11:02:26 +01:00
Benjamin Wang
150ea9d880 tool: bump gofail version
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-18 15:19:18 +08:00
Benjamin Wang
6d8139dcea
Merge pull request #14788 from sashamelentyev/imports
all: goimports -w .
2022-11-18 09:03:43 +08:00
Benjamin Wang
2742bdc32a
Merge pull request #14752 from serathius/linearizability-raftBeforeLeaderSend
Linearizability raft before leader send
2022-11-18 08:56:11 +08:00
Benjamin Wang
67408930a1
Merge pull request #14669 from vivekpatani/upgrade-1.19.2
.github: make govuln-check generic
2022-11-18 08:12:18 +08:00
vivekpatani
0e65199e1a .github: make govuln-check generic
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2022-11-17 13:10:01 -08:00
Marek Siarkowicz
993f3c0942
Fix priority/important label 2022-11-17 20:44:31 +01:00
Sasha Melentyev
c3b6cbdb73 all: goimports -w .
Signed-off-by: Sasha Melentyev <sasha@melentyev.io>
2022-11-17 19:07:04 +03:00
Marek Siarkowicz
9b3bfcdfeb
Merge pull request #14798 from tjungblu/fix_locking_tests
Fix TestCtlV3Lock/Elect flakes
2022-11-17 15:40:47 +01:00
Marek Siarkowicz
371179e292 tests: Trigger raftBeforeLeaderSend
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2022-11-17 14:17:16 +01:00
Benjamin Wang
bba8e6259c
Merge pull request #14794 from cleverhu/fix-max-recv-msg-size-description
docs: fix max recv msg size description
2022-11-17 18:05:47 +08:00
Thomas Jungblut
eebfd15983 Fix TestCtlV3Lock/Elect flakes
waiting for a proper exit after a signal should ensure the goroutines
don't leak.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2022-11-17 10:59:22 +01:00
Marek Siarkowicz
bf3eea8831 tests: Allow creating client for EtcdProcess
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2022-11-17 10:48:14 +01:00
Benjamin Wang
8329c9cbb1
Merge pull request #14793 from ahrtr/changelog_20221117
changelog: add items to cover the issue of refreshing token on CommonName based authentication
2022-11-17 17:22:27 +08:00
cleverhu
d726e9a183 docs: fix max recv msg size description
The correct param forMaxCallRecvMsgSize is '--max-recv-bytes' instead of '--max-request-bytes', so I fixed the documentation and description.

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
2022-11-17 10:37:55 +08:00
Benjamin Wang
9648a291fb changelog: add items to cover the issue of refreshing token on CommonName based authentication
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-17 09:27:09 +08:00
Benjamin Wang
719a0a4249
Merge pull request #14770 from ahrtr/auth_20221116
clientv3: do not refresh token when users use CommonName based authentication
2022-11-16 19:46:15 +08:00
Marek Siarkowicz
e7400b8890
Merge pull request #14766 from serathius/failpoints-disable
Avoid getting gofail/runtime when failpoints are disabled
2022-11-16 12:33:32 +01:00
Benjamin Wang
0c1901466f test: add test case to cover the CommonName based authentication
Refer to https://github.com/etcd-io/etcd/issues/14764

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-16 18:34:34 +08:00
Benjamin Wang
585054e448 test: add certificate with root CommonName
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-16 18:31:53 +08:00
Benjamin Wang
f32ac6e069 clientv3: do not refresh token when using TLS CommonName based authentication
When users use the TLS CommonName based authentication, the
authTokenBundle is always nil. But it's possible for the clients
to get `rpctypes.ErrAuthOldRevision` response when the clients
concurrently modify auth data (e.g, addUser, deleteUser etc.).
In this case, there is no need to refresh the token; instead the
clients just need to retry the operations (e.g. Put, Delete etc).

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-16 18:31:53 +08:00
Benjamin Wang
acfd39f5af
Merge pull request #14785 from clarkfw/functional-options-pattern-EtcdProcessClusterConfig-2-2
tests: refactor EtcdProcessClusterConfig using Functional Options Pattern
2022-11-16 18:29:49 +08:00
Marek Siarkowicz
ebf41c2d48 Avoid getting gofail/runtime when failpoints are disabled
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2022-11-16 11:09:38 +01:00
Clark
7180267d56 tests: refactor EtcdProcessClusterConfig with Functional Options Pattern
remove `cfg *EtcdProcessClusterConfig` param from `NewEtcdProcessCluster` function

Signed-off-by: Clark <fwyongxing@gmail.com>
2022-11-16 15:05:29 +08:00
Clark
9406de0033 tests: refactor EtcdProcessClusterConfig with Functional Options Pattern
replace all initialisations with `DefaultConfig`, `NewConfig` and `EPClusterOption`

Signed-off-by: Clark <fwyongxing@gmail.com>
2022-11-16 15:05:28 +08:00
Benjamin Wang
8438ddae3e
Merge pull request #14767 from sashamelentyev/print
all: Change Printf and friends to Print if there is no formatting
2022-11-16 10:38:20 +08:00
Benjamin Wang
bf5c936ff1
Merge pull request #14731 from ramil600/grpc_withinsecure
client/v3: replace deprecated grpc.WithInsecure()  issue #14732
2022-11-16 06:41:29 +08:00
Benjamin Wang
47e71d925a
Merge pull request #14765 from serathius/linearizability-compact
Linearizability compact
2022-11-16 06:23:14 +08:00
Sasha Melentyev
2c9c209eb6 all: Changing Printf and friends to Print if there is no formatting
Signed-off-by: Sasha Melentyev <sasha@melentyev.io>
2022-11-15 22:11:23 +03:00
Marek Siarkowicz
8ae4420c4c tests: Add compact failpoints
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2022-11-15 15:00:18 +01:00
Marek Siarkowicz
f96957adba tests: Add compact failpoints
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2022-11-15 14:59:03 +01:00
Marek Siarkowicz
a6997644c3
Merge pull request #14761 from tjungblu/main
Update CodeQL to v2
2022-11-15 13:58:47 +01:00
Thomas Jungblut
89bfa4b95c Update CodeQL to v2
CodeQL@v1 is going to be deprecated in three weeks. This PR updates the
branches to track only the currently maintained release branches and
moves the actions to its v2 version.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2022-11-15 13:30:44 +01:00
Benjamin Wang
39ca876f38
Merge pull request #14757 from ahrtr/add_failpoint_20221115
etcdserver: add failpoints for backend
2022-11-15 17:14:14 +08:00
Benjamin Wang
cf190fb5b0 test: apply backend failpoints into the linearizablity test
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-15 16:36:56 +08:00
Marek Siarkowicz
f8162919f9
Merge pull request #14744 from clarkfw/functional-options-pattern-EtcdProcessClusterConfig-2-1
tests: refactor `EtcdProcessClusterConfig` using Functional Options Pattern
2022-11-15 09:27:24 +01:00
Benjamin Wang
f49d96f8b7
Merge pull request #14756 from sashamelentyev/time
all: Change time unit
2022-11-15 15:54:30 +08:00
Benjamin Wang
015196ec10
Merge pull request #14754 from sashamelentyev/clientfmt
client: Use func without format
2022-11-15 15:25:22 +08:00
Benjamin Wang
386e08f5fa
Merge pull request #14747 from falser101/fix/log_test
feat: raft/log_test se testify packages in tests
2022-11-15 11:10:08 +08:00
jianfei.zhang
cadf9de3f8 feat: raft/log_test se testify packages in tests
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
2022-11-15 10:35:30 +08:00
Benjamin Wang
d62e018495
Merge pull request #14755 from serathius/linearizability-traffic
tests: Make linearizability traffic extendable
2022-11-15 09:11:40 +08:00
Benjamin Wang
4f824336ad etcdserver: add two failpoints for backend
1. before and after create boltDB transaction;
2. before and after writebuf back to read buffer;

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2022-11-15 08:09:05 +08:00