Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
20,863 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

1528 Commits

Author SHA1 Message Date
Benjamin Wang
dfff80a89e dependency: bump golang.org/x/crypto from 0.18.0 to 0.19.0 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-02-13 09:32:55 +00:00
Benjamin Wang
236e8ca881 dependency: bump go.opentelemetry.io/otel from 1.22.0 to 1.23.1 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-02-13 09:32:55 +00:00
Benjamin Wang
5c1b43c079 Dependency: bump golang.org/x/sys from 0.16.0 to 0.17.0 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-02-13 09:32:55 +00:00
Sharath Sivakumar
759d88a990
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.19.0 to 2.19.1 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2024-02-07 16:15:49 +01:00
Wei Fu
32ee8b877a etcdserver: drain leaky goroutines before test completed 
If pending changes aren't committed before test completed, it might cause
data race when we don't drain all the background goroutines.

```bash
$ cd server
$ go test -race -v -run TestApplyRepeat ./etcdserver
...
panic: Log in goroutine after TestApplyRepeat has completed: 2024-02-03T17:06:13.262+0800       DEBUG   bbolt   Committing transaction 2

goroutine 81 [running]:
testing.(*common).logDepth(0xc000502820, {0xc0001b0460, 0x41}, 0x3)
        /usr/local/go/src/testing/testing.go:1022 +0x6d4
testing.(*common).log(...)
        /usr/local/go/src/testing/testing.go:1004
testing.(*common).Logf(0xc000502820, {0x1421ad7, 0x2}, {0xc000603520, 0x1, 0x1})
        /usr/local/go/src/testing/testing.go:1055 +0xa5
go.uber.org/zap/zaptest.testingWriter.Write({{0x15f1f90?, 0xc000502820?}, 0xda?}, {0xc000119800, 0x42, 0x400})
        /home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zaptest/logger.go:130 +0x11e
go.uber.org/zap/zapcore.(*ioCore).Write(0xc0000b55c0, {0xff, {0xc1679e614f9fd7a4, 0x73a3657, 0x1cc2400}, {0x1422b2d, 0x5}, {0xc0001a0330, 0x18}, {0x0, ...}, ...}, ...)
        /home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/core.go:99 +0x193
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc000115930, {0x0, 0x0, 0x0})
        /home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/entry.go:253 +0x2f0
go.uber.org/zap.(*SugaredLogger).log(0xc0001960f8, 0xff, {0x1437885, 0x19}, {0xc0006034e0, 0x1, 0x1}, {0x0, 0x0, 0x0})
        /home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/sugar.go:316 +0x130
go.uber.org/zap.(*SugaredLogger).Debugf(...)
        /home/fuwei/go/pkg/mod/go.uber.org/zap@v1.26.0/sugar.go:171
go.etcd.io/bbolt.(*Tx).Commit(0xc0001aa9a0)
        /home/fuwei/go/pkg/mod/go.etcd.io/bbolt@v1.4.0-alpha.0/tx.go:173 +0x206
go.etcd.io/etcd/server/v3/storage/backend.(*batchTx).commit(0xc00019b180, 0x0)
        /home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:269 +0xdf
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).unsafeCommit(0xc00019b180, 0x0)
        /home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:378 +0x425
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).commit(0xc00019b180, 0x80?)
        /home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:355 +0x78
go.etcd.io/etcd/server/v3/storage/backend.(*batchTxBuffered).Commit(0xc00019b180)
        /home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/batch_tx.go:342 +0x35
go.etcd.io/etcd/server/v3/storage/backend.(*backend).run(0xc000478180)
        /home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/backend.go:426 +0x2c7
created by go.etcd.io/etcd/server/v3/storage/backend.newBackend in goroutine 80
        /home/fuwei/go/src/go.etcd.io/etcd/server/storage/backend/backend.go:227 +0xbfd
FAIL    go.etcd.io/etcd/server/v3/etcdserver    0.129s
FAIL
```

This patch also drains goroutines related to raftNode and watch store.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2024-02-03 18:58:17 +08:00
Sharath Sivakumar
9ec752d0f3
dependency: bump google.golang.org/grpc from 1.60.1 to 1.61.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2024-02-01 13:57:32 +01:00
Sharath Sivakumar
aa81e57855
dependency: bump go.opentelemetry.io/proto/otlp from 1.0.0 to 1.1.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2024-02-01 13:51:29 +01:00
Benjamin Wang
ca41186228
Merge pull request #17288 from ishan16696/promoteLeaner/addLogInfo 
Added a error log when learner is not sync with etcd leader.
 2024-01-30 12:47:28 +00:00
Ishan Tyagi
16a5e1da71 Added a error log when learner is not sync with etcd leader. 
Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
 2024-01-30 15:42:11 +05:30
Benjamin Wang
c12e15d91a Add verification on keys: should be always mononically increasing 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-25 18:00:26 +00:00
Benjamin Wang
c647614b6a test: fix TestHashKVWhenCompacting: ensure all goroutine finished 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-25 13:30:27 +00:00
Benjamin Wang
f932c00791
Merge pull request #17314 from ahrtr/configure_peer_log_20240124 
Print error log when creating peer listener failed
 2024-01-25 10:05:38 +00:00
Benjamin Wang
d1cc01a574
Merge pull request #17319 from jmhbnz/weekly-dependency-update 
[2024-01-25] Bump dependencies identified by dependabot
 2024-01-25 10:02:42 +00:00
James Blair
9cfbbb9556
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.46.1. to 0.47.0. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2024-01-25 15:26:26 +13:00
James Blair
3666454826
depdendency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.21.0 to 1.22.0. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2024-01-25 15:24:53 +13:00
James Blair
2edcf60b4f
depdendency: bump go.opentelemetry.io/otel from 1.21.0 to 1.22.0. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2024-01-25 15:19:09 +13:00
Benjamin Wang
362f0a2fcb print error log when creating peer listener failed 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-24 13:47:30 +00:00
Benjamin Wang
dd0b0526e1
Merge pull request #17284 from ahrtr/test_TestScheduleCompaction_20240119 
Fix test issue in TestScheduleCompaction
 2024-01-20 13:29:04 +00:00
Siyuan Zhang
30b242f800 Revert "add test cases of duplicate keys in one tx." 
This reverts commit 8d29b245a39172bd72643106ea7d9e4df727bd7e.

Signed-off-by: Siyuan Zhang <sizhang@google.com>
 2024-01-19 08:58:48 -08:00
Siyuan Zhang
93afd8e430 Revert "add key dedupe when a write buffer writeback to an empty read buffer bucket." 
This reverts commit 971a4f57ccff71dfc10c1f9eb7a6a4d64bec1d2e.

Signed-off-by: Siyuan Zhang <sizhang@google.com>
 2024-01-19 08:58:27 -08:00
Benjamin Wang
82562abc3c Fix test issue in TestScheduleCompaction 
It always reuse the same memory space. Each next iteration
will always overwrite previous data

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-19 15:29:51 +00:00
James Blair
7a7d4684df
depdendency: bump github.com/prometheus/common from 0.45.0 to 0.46.0. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2024-01-17 22:28:43 +13:00
Benjamin Wang
690916f018 replace CreateBucket with CreateBucketIfNotExists 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-16 09:40:20 +00:00
Benjamin Wang
4bc55e5208
Merge pull request #17204 from rahulbapumore/branch1 
mvcc: Printing etcd backend database related metrics inside scheduleCompaction function
 2024-01-15 15:37:08 +00:00
Rahul More
21bbc82710 mvcc: Printing etcd backend database related metrics inside 
scheduleCompaction function

To improve traceability of backend database usage, Added below parameter
related to backend database usage metrics inside scheduledCompaction
function.
current-db-size-bytes
current-db-size
current-db-size-in-use-bytes
current-db-size-in-use

Signed-off-by: Rahul More <rahulbapumore@gmail.com>
 2024-01-15 17:36:38 +05:30
Benjamin Wang
9ded10ec76
Merge pull request #17237 from ahrtr/bbolt_logger_20240112 
Specify logger for bbolt
 2024-01-13 11:03:14 +00:00
Benjamin Wang
ed994248e0
Merge pull request #17228 from siyuanfoundation/txBuf1 
Fix tx buffer inconsistency if there are duplicate keys in one tx.
 2024-01-12 18:34:35 +00:00
Benjamin Wang
cfbf672b3c specify logger for bbolt 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-12 16:38:18 +00:00
Marek Siarkowicz
40f22e9319
Merge pull request #17176 from YaoC/fix-learner-metric 
server: fix learner metric incorrect issue
 2024-01-12 17:37:46 +01:00
Benjamin Wang
cf648e8503 bump raft to v3.6.0-alpha.0 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-12 15:30:11 +00:00
Benjamin Wang
f2ada58144 bump bbolt to 1.4.0-alpha.0 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-12 15:27:48 +00:00
YaoC
f7ab7adf29 server: fix learner metric incorrect issue 
Signed-off-by: YaoC <chengyao09@hotmail.com>
 2024-01-12 09:36:33 +00:00
Siyuan Zhang
971a4f57cc add key dedupe when a write buffer writeback to an empty read buffer bucket. 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
 2024-01-11 11:31:09 -08:00
Siyuan Zhang
8d29b245a3 add test cases of duplicate keys in one tx. 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
 2024-01-11 11:31:03 -08:00
Benjamin Wang
b3bf59a355
Merge pull request #17195 from siyuanfoundation/txBuf1 
Fix delete inconsistencies in read buffer
 2024-01-11 08:21:47 +00:00
Siyuan Zhang
db61c9695d commit bbolt transaction if there is any pending deleting operations 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
 2024-01-10 09:33:21 -08:00
Siyuan Zhang
b3a5307640 add tests to test tx delete consistency. 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
 2024-01-10 09:33:13 -08:00
Benjamin Wang
a73078928d
Merge pull request #17219 from devincd/fix-usage 
Fix Struct Config has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation.
 2024-01-10 09:47:05 +00:00
Sharath Sivakumar
28f4c6fef6
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.18.1 to 2.19.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2024-01-09 16:26:47 +01:00
Sharath Sivakumar
98646057d6
dependency: bump golang.org/x/sys from 0.15.0 to 0.16.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2024-01-09 16:04:19 +01:00
devincd
931687f87e fix Struct Config has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation. 
Signed-off-by: devincd <505259926@qq.com>
 2024-01-09 17:42:59 +08:00
Marek Siarkowicz
a2eb17c809
Merge pull request #17199 from serathius/dont-flock 
Don't flock snapshot files
 2024-01-08 15:03:29 +01:00
Marek Siarkowicz
970abc211e
Merge pull request #17152 from serathius/logs-recover-backend 
Improve logs around recovering snapshot backend and add an e2e test
 2024-01-05 15:38:58 +01:00
Marek Siarkowicz
3471ef133d Add an e2e test and robustness failpoint around recovering from snapshot backend 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2024-01-04 15:25:24 +01:00
Marek Siarkowicz
7f8346b3f2 Don't flock snapshot files 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2024-01-04 14:53:44 +01:00
Benjamin Wang
553d88cfd3 bump github.com/prometheus/client_golang to v1.18.0 
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
 2024-01-02 16:52:42 +00:00
Sharath Sivakumar
c21b966478
dependency: bump google.golang.org/protobuf from 1.31.0 to 1.32.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-12-27 17:27:40 +01:00
dependabot[bot]
0c55ed7464 build(deps): bump google.golang.org/grpc from 1.59.0 to 1.60.1 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.59.0 to 1.60.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.59.0...v1.60.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-12-21 19:07:47 +00:00
Sharath Sivakumar
362477b077
dependency: bump golang.org/x/crypto from 0.16.0 to 0.17.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-12-21 18:19:10 +01:00
Marek Siarkowicz
d39d86a214 Improve logs around recovering from snapshot backend 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-12-20 16:26:27 +01:00