Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
16,059 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

1958 Commits

Author SHA1 Message Date
Jingyi Hu
dc01734c6b etcdserver: add grpc interceptor to log info on incoming requests to 
etcd server

To improve debuggability of etcd v3. Added a grpc interceptor to log
info on incoming requests to etcd server. The log output includes
remote client info, request content (with value field redacted), request
handling latency, response size, etc. Uses zap logger if available,
otherwise uses capnslog.

Also did some clean up on the chaining of grpc interceptors on server
side.
 2018-08-10 11:01:07 -07:00
Iskander Sharipov
d0f800c930 etcdserver/api/v2discovery: simplify !(x == y) to x != y 
Found using https://go-critic.github.io/overview#boolExprSimplify-ref
 2018-07-28 23:47:17 +03:00
Joe Betz
750b87d622
Merge pull request #9924 from jpbetz/persist-lease-deadline 
lease: Persist remainingTTL to prevent indefinite auto-renewal of long lived leases
 2018-07-24 09:39:57 -07:00
Joe Betz
2edb954bce
lease: Checkpoint lease TTLs to prevent indefinite auto-renewal of long lived leases 2018-07-23 16:12:34 -07:00
Gyuho Lee
643d791a11 etcdserver: add "etcd_server_go_version" metric 
Currently, one has to look at server logs manually,
to see what Go version was used to build etcd server.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-23 09:15:22 -07:00
Gyuho Lee
51af6a062f etcdserver: clean up code format 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-21 16:03:16 -07:00
Gyuho Lee
57ec2226cc etcdserver: support zap.Logger in FD monitoring routine 
Keep replacing capnslog

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-20 14:59:03 -07:00
Joe Betz
bbe2d777b1
lease: Add LessorConfig and wire zap logger into Lessor 2018-07-17 13:10:34 -07:00
Joe Betz
75ac18cd2d
lease: Add and lease checkpoint protobuf types 2018-07-17 11:54:51 -07:00
Gyuho Lee
ddf45cb958 etcdserver: remove configuration print methods 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-09 11:26:23 -07:00
Gyuho Lee
9934034bb1 etcdserver: remove unnecessary if-statement 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-05 10:25:00 -07:00
Gyuho Lee
e714dd01b3 etcdserver: remove unnecessary type conversion 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-05 10:08:56 -07:00
Gyuho Lee
37000cc4b8 etcdserver: add "etcd_server_slow_read_indexes_total" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-02 12:58:35 -07:00
Gyuho Lee
4733a1db5c etcdserver: clarify read index warnings 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-02 12:53:35 -07:00
Joe Betz
4b51b6de49
*: Add progress notify request watch request 2018-06-27 16:46:13 -07:00
Gyuho Lee
339cda03b3 etcdserver/api/v3rpc: remove duplicate gRPC logger set 
Fix

=== RUN   TestEmbedEtcd
==================
WARNING: DATA RACE
Write at 0x000001df86d0 by goroutine 711:
  github.com/coreos/etcd/embed.(*Config).setupLogging.func1()
      /go/src/github.com/coreos/etcd/vendor/google.golang.org/grpc/grpclog/loggerv2.go:68 +0x16c
  sync.(*Once).Do()
      /usr/local/go/src/sync/once.go:44 +0xe1
  github.com/coreos/etcd/embed.(*Config).setupLogging()

in gRPC proxy tests.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-18 09:41:37 -07:00
Gyuho Lee
b241e383fd
Merge pull request #9858 from gyuho/lll 
etcdserver: clean up election tick timeout log output
 2018-06-15 13:40:44 -07:00
Gyuho Lee
52ffe9f79a etcdserver: clean up election tick timeout log output 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-15 13:35:25 -07:00
Gyuho Lee
929d390520 etcdserver: log quota only once 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-15 13:13:44 -07:00
Gyuho Lee
8990126c17 rafthttp: add "RaftDropHeartbeat" failpoint 
To simulate network partition locally.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-15 13:10:58 -07:00
Gyuho Lee
a133e9fc8c etcdserver: remove TODO from "warnOfExpensiveGenericRequest" 
Metric is already added.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-12 09:37:00 -07:00
Joe Betz
a6fad51603
etcdserver: Fix txn request 'took too long' warnings to use loggable request stringer 2018-06-11 16:58:48 -07:00
Gyuho Lee
849d3f2ac9
Merge pull request #9826 from jpbetz/response_sizes 
etcdserver: Add response byte size and range response count to took too long warning
 2018-06-11 11:13:24 -07:00
Joe Betz
b47e148d5d
etcdserver: Add response byte size and range response count to took too long warning 2018-06-11 10:02:30 -07:00
Gyuho Lee
e22ab78ccb
Merge pull request #9822 from jpbetz/value_size_stringer 
etcdserver: Replace value contents with value_size in request took too long warning
 2018-06-08 09:39:56 -07:00
Joe Betz
225b0bf80a
etcdserver: Replace value contents with value_size in request took too long warning 2018-06-07 16:41:48 -07:00
Gyuho Lee
7dd7018835 etcdserver: add "etcd_server_quota_backend_bytes" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-06-07 10:44:51 -07:00
Gyuho Lee
3821f3364d etcdserver/api/rafthttp: add "etcd_network_active_peers/disconnected_peers_total" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:23:45 -07:00
Gyuho Lee
afe78fbe69 etcdserver/api/v2http: document histogram 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
973fe43b83 etcdserver/api/snap: document histograms, add "etcd_snap_fsync_duration_seconds" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
640f5e64a9 etcdserver/api/rafthttp: document round-trip metrics, clean up 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
5a9e48be30 etcdserver/api/rafthttp: increase bucket upperbound up-to 3-sec 
From 0.8 sec to 3.2 sec for more detailed latency analysis

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 14:03:28 -07:00
Gyuho Lee
a1aade8c1b etcdserver: rename to "heartbeat_send_failures_total" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 13:11:08 -07:00
Gyuho Lee
dd1baf6e96 etcdserver: add "etcd_server_slow_apply_total" 
{"level":"warn","ts":1527101858.6985068,"caller":"etcdserver/util.go:115","msg":"apply request took too long","took":0.114101529,"expected-duration":0.1,"prefix":"","request":"header:<ID:1029181977902852337> put:<key:\"\\000\\000...

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 13:09:42 -07:00
Gyuho Lee
896a5e4a2b etcdserver: add "etcd_server_heartbeat_failures_total" 
{"level":"warn","ts":1527101858.4149103,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.025771662}
{"level":"warn","ts":1527101858.4149644,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.034015766}

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 13:09:42 -07:00
Gyuho Lee
a5b32ba941 etcdserver/api/v3rpc: add "etcd_network_server_stream_failures_total" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-23 08:05:43 -07:00
Sam Batschelet
05554119c9 vendor: use latest "grpc-ecosystem/grpc-gateway" 2018-05-22 17:35:15 -04:00
Gyuho Lee
7940113906 *: move internal "etcdserver/api/rafthttp" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
2dd555c983 *: move "etcdserver/api/v3compactor" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
871c218894 *: move "etcdserver/api/v3alarm" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
9149565cb3 *: move to "etcdserver/api/membership" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 10:31:16 -07:00
Gyuho Lee
671f1c41a8 etcdserver/api/v2discovery: move internal "discovery" package 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 09:50:38 -07:00
Gyuho Lee
1e4f56114e etcdserver: use new "snap" import paths 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 07:45:34 -07:00
Gyuho Lee
2bd689acea etcdserver/api/snap: rename internal package 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-21 07:45:34 -07:00
Gyuho Lee
955fd99bc9
Merge pull request #9746 from gyuho/raft-logger 
etcdserver: set default Raft logger with zap.Logger
 2018-05-18 16:32:48 -07:00
Gyuho Lee
58ae15bd29 etcdserver: set default Raft logger with zap.Logger 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-18 15:38:39 -07:00
Gyuho Lee
49d672ff9b etcdserver: rename "SnapshotCount", add "SnapshotCatchUpEntries" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-18 14:37:50 -07:00
Gyuho Lee
366db18662 etcdserver: define test transporter 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-17 14:16:52 -07:00
Gyuho Lee
4a4be9275c
Merge pull request #9681 from gyuho/config-log 
doc: deprecate '/config/local/log' in v3.5
 2018-05-15 11:07:07 -07:00
Gyuho Lee
7a92bbfed2 etcdserver/*: move internal v2 packages 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-05-14 12:49:49 -07:00