Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
14,885 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

14885 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mark McLoughlin
fcc29894c2 config: multiple logging fixes 
First, don't panic with invalid --log-outputs. For example:

  $> ./bin/etcd --log-outputs foo
  2018-12-20 15:05:47.988652 C | embed: unknown log-output "foo" (only supports "default", "stderr", "stdout")
  panic: unknown log-output "foo" (only supports "default", "stderr", "stdout")

  goroutine 1 [running]:
  go.etcd.io/etcd/vendor/github.com/coreos/pkg/capnslog.(*PackageLogger).Panicf(0xc000294b00, 0x10fe067, 0x30, 0xc0001fa398, 0x4, 0x4)
        go.etcd.io/etcd/vendor/github.com/coreos/pkg/capnslog/pkg_logger.go:75 +0x161
  go.etcd.io/etcd/embed.(*Config).setupLogging(0xc000291400, 0xc0002a85b0, 0x1)
        go.etcd.io/etcd/embed/config_logging.go:120 +0x1939
  ...

Or:

 $> ./bin/etcd --log-outputs foo,default --logger zap
 panic: multi logoutput for "default" is not supported yet

 goroutine 1 [running]:
 go.etcd.io/etcd/embed.(*Config).setupLogging(0xc000314500, 0xc0001b2f70, 0x1)
        go.etcd.io/etcd/embed/config_logging.go:129 +0x2437
 go.etcd.io/etcd/embed.(*Config).Validate(0xc000314500, 0xc000268a98, 0x127e440)
        go.etcd.io/etcd/embed/config.go:543 +0x43

Second, don't exit in embed.setupLogging(). Before:

  $> ./bin/etcd --log-outputs foo,bar
  --logger=capnslog supports only 1 value in '--log-outputs', got ["bar" "foo"]

and after:

  $> ./bin/etcd --log-outputs foo,bar
  2018-12-20 15:10:24.317982 E | etcdmain: error verifying flags, --logger=capnslog supports only 1 value in '--log-outputs', got ["bar" "foo"]. See 'etcd --help'.

Third, remove duplicated unique strings code. UniqueStringsFromFlag()
is already available to return a sorted slice of values, so just use
that.

Lastly, fix a tiny logging typo in config.
 2019-01-17 15:09:26 -05:00
Gyuho Lee
cbfe0b4b79
Merge pull request #10409 from nolouch/add-logger 
embed: add zap logger builder
 2019-01-17 11:21:52 -08:00
Xiang Li
a00bff7848
Merge pull request #10402 from markmc/interactive-watch-panic 
etcdctl: fix interactive mode panic
 2019-01-16 11:40:34 +08:00
nolouch
ac090fe326 embed: add zap logger builder 
Signed-off-by: nolouch <nolouch@gmail.com>
 2019-01-15 23:22:04 +08:00
Mark McLoughlin
36d7acf330 etcdctl: fix interactive mode panic 
Don't panic if command is given in interactive mode, give a nice error
message instead.

Before:

 $ ./bin/etcdctl watch -i
 <hit return>
 panic: runtime error: index out of range

 goroutine 1 [running]:
 etcdctl/ctlv3/command.watchInteractiveFunc(...)
 	etcd/etcdctl/ctlv3/command/watch_command.go:104 ...

After:

 $ ./bin/etcdctl watch -i
 <hit return>
 Invalid command:  (watch and progress supported)
 foo
 Invalid command foo (only support watch)
 2019-01-14 13:01:37 +00:00
Sam Batschelet
1eee465a43 CHANGELOG: revert discovery-srv-name feature from 3.3.11 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-11 13:12:16 -05:00
Sam Batschelet
a26fa9fe1f CHANGELOG: add "disable CommonName authentication for gRPC-gateway" PR 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-11 13:00:14 -05:00
Sam Batschelet
1eec48083b CHANGELOG: bump version and release date 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-11 12:59:19 -05:00
Xiang Li
fae6e92407
Merge pull request #10390 from johncming/missing-err 
tests/e2e: add missing return error.
 2019-01-09 14:41:48 -08:00
Xiang Li
2063b358c8
Merge pull request #10218 from mailgun/maxim/develop 
Remove infinite loop in doSerialize
 2019-01-09 10:38:25 -08:00
johncming
fffb982f1a tests/e2e: add missing return error. 2019-01-09 13:47:09 +08:00
Xiang Li
1e42503bea
Merge pull request #10379 from johncming/app-resp 
etcdserver: add a test to verify number of MsgAppResp sent is correct.
 2019-01-08 18:55:30 -08:00
johncming
e8f46ce341 etcdserver: add a test to verify not to send duplicated append responses 2019-01-09 10:37:43 +08:00
Sam Batschelet
577d7c0df2 e2e: update test to reflect (ST1005) update. 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 21:04:20 -05:00
Sam Batschelet
a82703b69e *: error strings should not end with punctuation or a newline (ST1005) 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 21:04:20 -05:00
Xiang Li
6511829d1f
Merge pull request #10374 from johncming/deprecated 
api/rafthttp: remove deprecated req.Cancel.
 2019-01-08 14:33:25 -08:00
Sam Batschelet
1e15c7434e vendor: cleanup and revendor deps 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 16:49:51 -05:00
Sam Batschelet
2001786f02 *: Use -n instead of ! -z. [SC2236] 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 13:45:40 -05:00
Gyuho Lee
442c863413
Merge pull request #10377 from johncming/cancel-pos 
api/v2auth: remove defer in loop.
 2019-01-08 09:43:06 -08:00
Gyuho Lee
21e0d3e527
Merge pull request #10359 from rkday/install-instructions 
docs: install etcdctl with `go get` as well
 2019-01-08 09:42:11 -08:00
Sam Batschelet
83c051b701 CHANGELOG: add "disable CommonName authentication for gRPC-gateway" PR 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 12:31:20 -05:00
Sam Batschelet
99704e2a97 e2e: add ClientTLSCertAuth coverage for curl v3 auth tests 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 12:31:20 -05:00
Sam Batschelet
a9a9466fb8 Documentation: document gRPC-gateway CN authentication support 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 12:31:20 -05:00
Sam Batschelet
bf9d0d8291 auth: disable CommonName auth for gRPC-gateway 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2019-01-08 12:31:20 -05:00
Till Adam
9c6b407e7d Documentation: add missing ENV 2019-01-08 11:36:07 -05:00
Xiang Li
b04633fd8e
Merge pull request #10375 from johncming/redundant-parentheses 
etcdserver: remove redundant parentheses.
 2019-01-07 18:38:26 -08:00
caoming
e96dbfb973 api/v2auth: remove defer in loop. 2019-01-08 08:56:55 +08:00
Xiang Li
8945fecf85
Merge pull request #10376 from johncming/snake-case 
api/v2store:  use camel case instead of snake case.
 2019-01-07 10:19:32 -08:00
caoming
5060560f92 api/v2store: use camel case instead of snake case. 2019-01-07 10:35:23 +08:00
caoming
802e2aaadd etcdserver: remove redundant parentheses. 2019-01-07 10:27:52 +08:00
caoming
4651f49a5c api/rafthttp: remove deprecated req.Cancel. 2019-01-07 10:12:47 +08:00
Gyuho Lee
f0aeb705ce
Merge pull request #10371 from johncming/no-assign 
etcdserver: add missing lg assignment.
 2019-01-04 19:04:57 -08:00
caoming
b2e0e760a0 etcdserver: add missing lg assignment. 2019-01-05 09:24:48 +08:00
Xiang Li
fde617d2dc
Merge pull request #10368 from johncming/blankline 
pkg/testutil: add blankline between two functions
 2019-01-03 20:58:07 -08:00
caoming
8f383852e2 pkg/testutil: add blankline between two functions 2019-01-04 09:44:57 +08:00
Gyuho Lee
daec071813
Merge pull request #10367 from gyuho/remove-backoff-utils 
clientv3: remove "JitterUp" imports
 2019-01-03 14:44:18 -08:00
Gyuho Lee
61218004c0 clientv3: remove "JitterUp" imports 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2019-01-03 11:00:45 -08:00
Xiang Li
3a5868a7b9
Merge pull request #10363 from johncming/embed 
embed: add test cases in TestAutoCompactionModeParse.
 2019-01-03 10:49:51 -08:00
caoming
e7b5f2de26 embed: add test cases in TestAutoCompactionModeParse. 2019-01-02 17:08:15 +08:00
Gyuho Lee
400b568fd6
Merge pull request #10360 from yaojingguo/ignore-file 
gitignore: ignore build result and runtime files of raftexample
 2019-01-01 09:31:38 -08:00
Jingguo Yao
e86a12bad0 gitignore: ignore build result and runtime files 2019-01-01 19:14:48 +08:00
Rob Day
959d004bcc docs: install etcdctl with go get as well 
The documentation recommends using `etcdctl` to verify that etcd has
been built correctly, but the `go get` command provided does not install
it. This changes it so that it does, and also clarifies terminology
('using `go get`', referring to the command used to install it, rather
than 'using `$GOPATH`').
 2018-12-30 12:10:32 +00:00
Xiang Li
cc8d446a6e
Merge pull request #8334 from lishuai87/shawnsli/reset-leader-when-become-pre-candidate 
raft: introduce/fix TestPreVoteWithCheckQuorum
 2018-12-28 09:51:06 -08:00
shawnli
23731bf9ba raft: set lead to none when becomePreCandidate 2018-12-28 19:57:26 +08:00
Gyuho Lee
6937b77232 README: remove "you" in "Community Meeting" 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-12-23 21:53:36 -08:00
Gyuho Lee
deeb16c9e8
Merge pull request #10346 from lsytj0413/fix-golint 
refactor(*): fix golint warning
 2018-12-23 20:26:09 -08:00
lsytj0413
792aad932f refactor(*): fix golint warning 2018-12-24 11:43:10 +08:00
Wenjia
9113019936
Update README.md with community meeting info 2018-12-21 15:53:59 -08:00
Sam Batschelet
f3fbedc88f client: update generated ugorji codec, manual remove "yynn2=0" 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
 2018-12-21 18:16:55 -05:00
Gyuho Lee
a580ec4547 CHANGELOG: add patch release, gRPC proxy fix 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2018-12-17 21:22:37 -08:00