Ori Newman
96d9e5800f
[NOD-1561] Add TestCheckParentsIncest and fix validation order ( #1143 )
2020-11-23 18:27:44 +02:00
Ori Newman
8264369c81
[NOD-1561] Add TestValidateMedianTime ( #1141 )
...
* [NOD-1561] Add TestValidateMedianTime
* [NOD-1561] Remove redundant variable
2020-11-23 17:18:30 +02:00
Ori Newman
bb2d7f72ac
[NOD-1560] Add TestValidateTransactionInIsolation ( #1140 )
...
* [NOD-1560] Add TestValidateTransactionInIsolation
* [NOD-1560] Make ForAllNets copy the params before mutating them
* [NOD-1560] Remove redundant continue
* [NOD-1560] Don't change finality duration
2020-11-23 16:28:59 +02:00
Ori Newman
c1505b4748
[NOD-1555] Use stageDiff to update virtualDiffParents ( #1139 )
...
* [NOD-1555] Filter ancestors in updateVirtualDiffParents
* [NOD-1555] Use stageDiff to update virtualDiffParents
* [NOD-1555] Don't add existing blocks in addToVirtualDiffParents
* [NOD-1555] Remove redundant check
* [NOD-1555] Fix log and rename removeAncestorsFromVirtualDiffParents->removeAncestorsFromVirtualDiffParentsAndAssignDiffChild
* [NOD-1555] Add logs
* [NOD-1555] Fix comment
* [NOD-1555] Fix logs
2020-11-23 15:09:39 +02:00
stasatdaglabs
dec9ef5f75
[NOD-1555] Implement TestResolveBlockStatusSanity ( #1138 )
...
* [NOD-1555] Implement TestResolveBlockStatusSanity.
* [NOD-1555] Fix the test name string.
2020-11-23 14:29:41 +02:00
Mike Zak
5211727206
[NOD-1557] Cover the consensusStateManager package in trace logs ( #1135 )
...
* [NOD-1557] Add trace logs in add_block_to_virtual.go.
* [NOD-1557] Add trace logs in resolve_block_status.go.
* [NOD-1557] Add trace logs in calculate_past_utxo.go.
* [NOD-1557] Add trace logs in finality.go.
* [NOD-1557] Add trace logs in multisets.go.
* [NOD-1557] Fix compilation errors.
* [NOD-1557] Add trace logs to verify_and_build_utxo.go.
* [NOD-1557] Add trace logs to update_virtual.go.
* [NOD-1557] Add trace logs to set_pruning_utxo_set.go.
* [NOD-1557] Add trace logs to populate_tx_with_utxo_entries.go.
* [NOD-1557] Add trace logs to pick_virtual_parents.go.
* [NOD-1557] Make go vet happy.
* [NOD-1557] Clarify that some logic in AddBlockToVirtual is there for the sake of logging alone.
* [NOD-1557] Call blockStatusStore directly in AddBlockToVirtual when refetching the block status.
2020-11-23 13:08:10 +02:00
Elichai Turkel
fafe1d534f
Add TestSequenceLocksActive back ( #1133 )
2020-11-22 17:17:39 +02:00
Elichai Turkel
c56a5336f3
Re-add TestPruningDepth ( #1132 )
2020-11-22 17:04:13 +02:00
Elichai Turkel
b3a3121725
Add TestFinality back ( #1129 )
...
* Add VirtualFinalityPoint to TestConsensusStateManager
* Add TestFinality back
2020-11-22 12:30:27 +02:00
Svarog
950dd0cc8d
[NOD-1556] Add some logs ( #1110 )
...
* [NOD-1556] Add logs regarding block status and virtual blue score
* [NOD-1556] UTXODiffAlgebra: add the offending outpoint to the text of errors
* [NOD-1556] Make checkIntersectionWithRule return ok as well
2020-11-19 11:17:05 +02:00
stasatdaglabs
bb244706ea
[NOD-1543] Optimize the performance of Count() in BlockHeaderStore and BlockStore ( #1109 )
...
* [NOD-1543] Optimize Count() in BlockHeaderStore.
* [NOD-1543] Optimize Count() in BlockStore.
* [NOD-1543] Fix commitCount.
* [NOD-1543] Explicitly initialize count to 0.
2020-11-18 16:35:32 +02:00
stasatdaglabs
ed386bbc8f
[NOD-1550] Don't request blocks for invs that are known to be orphans ( #1108 )
...
* [NOD-1550] Implement IsOrphan().
* [NOD-1550] Don't request blocks for invs that are known to be orphans.
2020-11-18 13:37:14 +02:00
stasatdaglabs
75d21d39cc
[NOD-1549] Properly handle errors in unorphanBlock ( #1107 )
...
* [NOD-1549] In AddBlock, simply log RuleErrors.
* [NOD-1549] Properly handle errors in unorphanBlock.
2020-11-18 12:19:30 +02:00
Elichai Turkel
3f92ddd827
Add blueScore to RPC GetBlock, and add more INFO logs ( #1103 )
...
* Add BlueScore to RPC command GetBlock
* Add info logs when getting new blocks from the p2p
2020-11-18 11:19:12 +02:00
Ori Newman
8500acd86b
[NOD-1548] Remove PoW check from tests ( #1105 )
...
* [NOD-1548] Add TestDifficulty and remove PoW check from tests
* [NOD-1548] Add TestSkipProofOfWork
* [NOD-1548] Remove TestDifficulty
2020-11-18 10:27:29 +02:00
Elichai Turkel
5b037950d8
Fix double printing the mainnet has not launched yet message ( #1101 )
2020-11-18 09:16:58 +02:00
stasatdaglabs
184911f76e
[NOD-1547] Make the SendAddresses flow not one-time for the sake of DNSSeeder ( #1104 )
...
* [NOD-1547] Make the SendAddresses flow not one-time for the sake of DNSSeeder.
* [NOD-1547] Add all special commands to chooseRouteForCommand.
2020-11-17 18:05:14 +02:00
stasatdaglabs
7479f5f5e8
[NOD-1545] Fix incorrect block difficulty calculation in buildHeader. ( #1102 )
2020-11-17 16:40:55 +02:00
Ori Newman
891095563e
Fix blocks order ( #1099 )
2020-11-17 16:00:16 +02:00
Ori Newman
60c24d8dea
Fix TestBlueBlockWindow ( #1098 )
...
* Fix TestBlueBlockWindow
* Add comments
2020-11-17 16:00:16 +02:00
Svarog
d4993c1d06
[NOD-1542] Don't try to return more addresses then we have ( #1097 )
...
* [NOD-1542] Don't try to return more addresses then we have
* [NOD-1542] Allocate according to updated count
2020-11-17 16:00:16 +02:00
Elichai Turkel
c785ca0e52
Add more compactBits tests ( #1096 )
2020-11-17 16:00:16 +02:00
Svarog
9eb5c4a0ed
[NOD-1532] Make all nets equal in mining difficulty ( #1095 )
...
* [NOD-1532] Make all nets equal in mining difficulty
* [NOD-1532] Fix comments
2020-11-17 16:00:16 +02:00
stasatdaglabs
9d5d1b02dc
[NOD-1538] Implement a simple orphan pool ( #1093 )
...
* [NOD-1538] Implement a simple orphan pool.
* [NOD-1538] Connect the orphan pool to the appropriate flows.
* [NOD-1538] Make UnorphanBlocks actually unorphan blocks.
* [NOD-1538] Fix logs.
* [NOD-1538] Make unorphaned blocks call LogBlock.
* [NOD-1538] Fix a log and some bad names.
* [NOD-1538] Don't return an error from LogBlock.
* [NOD-1538] Pass a pointer to hash in findChildOrphansOfBlock.
* [NOD-1538] Extract addChildOrphansToProcessQueue to a separate function.
2020-11-17 16:00:16 +02:00
stasatdaglabs
213be67c47
[NOD-1538] Fix isBlockInHeaderPruningPointFuture. ( #1094 )
2020-11-17 16:00:16 +02:00
Ori Newman
14d7ab5fc6
Add TestBigToCompact and TestCompactToBig ( #1092 )
...
* Add TestBigToCompact and TestCompactToBig
* Add tests
2020-11-17 16:00:16 +02:00
Mike Zak
7224d58940
[NOD-1532] Add comments
2020-11-17 16:00:16 +02:00
Mike Zak
b2188f5993
[NOD-1532] AlwaysCallResolveBlockStatus in BuildBlock + Fixes to make it work if there's nothing to resolve
2020-11-17 16:00:16 +02:00
Mike Zak
dbd15aecf5
[NOD-1532] Invert condition in isViolatingFinality
2020-11-17 16:00:16 +02:00
Mike Zak
66f5a5bd7d
[NOD-1532] Genesis is not violating finality by definition
2020-11-17 16:00:16 +02:00
Mike Zak
c994200878
[NOD-1532] ResolveBlockStatus should return the blockStatus
2020-11-17 16:00:16 +02:00
Ori Newman
7050ebeac9
[NOD-1541] Add TestPastMedianTime ( #1091 )
2020-11-17 16:00:16 +02:00
Svarog
f2df48139f
[NOD-1532] Remove virtual from ParentChildren when checking for virtualSelectedParent candidates ( #1089 )
...
* [NOD-1532] Remove virtual from ParentChildren when checking for virtualSelectedParent candidates
* [NOD-1532] Fix minor issues
2020-11-17 16:00:16 +02:00
stasatdaglabs
48d8137604
[NOD-1538] Implement GetBlockCount.
2020-11-17 16:00:16 +02:00
stasatdaglabs
310cf0bb9b
[NOD-1538] Remove bad check in selectPeerForIBD.
2020-11-17 16:00:16 +02:00
Ori Newman
b6c47fdd21
[NOD-1535] fix reachability tests ( #1087 )
...
* [NOD-1535] Don't use pointer to outpoint when serializing
* [NOD-1535] Fix reachability tests
2020-11-17 16:00:16 +02:00
Ori Newman
e6a2b7366f
[NOD-1535] Don't use pointer to outpoint when serializing ( #1086 )
2020-11-17 16:00:16 +02:00
Mike Zak
d8f72e2b27
[NOD-1532] Update VirtualUTXODiffParents diffs even if list didn't change
2020-11-17 16:00:16 +02:00
stasatdaglabs
08749deaeb
[NOD-1538] Fix mempool not wrapping consensus errors and bad invalid message handling ( #1082 )
...
* [NOD-1538] Correct messages.proto.
* [NOD-1538] Fix invalid message handling.
* [NOD-1538] Fix mempool not wrapping consensus errors.
* [NOD-1538] Extract wrapping logic to a separate function.
* [NOD-1538] Extract wrapping logic to an even better separate function.
2020-11-17 16:00:16 +02:00
Mike Zak
83a88d9989
[NOD-1532] newUTXOSetIterator should start with -1 index
2020-11-17 16:00:16 +02:00
Mike Zak
151910c27a
[NOD-1532] Check UTXOCommitment for all blocks
2020-11-17 16:00:16 +02:00
Mike Zak
fca8ed57bd
[NOD-1532] Add another block in TestUTXOCommitment
2020-11-17 16:00:16 +02:00
Ori Newman
56679818be
[NOD-1535] Add non coinbase transactions to diff ( #1084 )
2020-11-17 16:00:16 +02:00
Mike Zak
f07f2edad2
[NOD-1532] Properly deal with selectedParentStatuses in buildBlockWithParents
2020-11-17 16:00:16 +02:00
Mike Zak
2dcfe90850
[NOD-1532] Shouldn't update parent diff if the parent is not UTXO-verified
2020-11-17 16:00:16 +02:00
Mike Zak
dc80a39c54
[NOD-1532] OpTrueScript should also return the redeem script
2020-11-17 16:00:16 +02:00
Mike Zak
34be898491
[NOD-1532] utxoSetIterator should be a pointer receiver
2020-11-17 16:00:16 +02:00
Mike Zak
f4a2fbf64f
[NOD-1532] Fixes in updateVirtualDiffParents
2020-11-17 16:00:16 +02:00
Ori Newman
a0c6076ccc
[NOD-1535] Add new block to virtual diff parents only if it's valid ( #1077 )
2020-11-17 16:00:16 +02:00
Mike Zak
fddce00d08
[NOD-1532] Fixes in updateVirtualDiffParent
2020-11-17 16:00:16 +02:00