Apply suggestions from code review

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
This commit is contained in:
Atemo 2022-11-25 14:53:26 +01:00 committed by Atemo
parent 4ae18c2353
commit 522e2ecd85

View File

@ -10,10 +10,11 @@
//============================================================
sec_in02,126,178,3 script Kachua's Secret Box#bm 4_TREASURE_BOX,{
.@key$ = "K_Secret_Key";
mes "A Secret Box where no one knows what's inside.";
mes "^4d4dffYou can open this box by consuming <ITEM>[Kachua's Secret Key]<INFO>23919</INFO></ITEM>.^000000";
next;
switch(select("^4d4dffOpen the box 1 time (1 Kachua Secret Key)^000000","^4d4dffOpen the box 10 times (10 Kachua Secret Keys)^000000")) {
switch(select("^4d4dffOpen the box 1 time (1 Kachua's Secret Key)^000000","^4d4dffOpen the box 10 times (10 Kachua's Secret Keys)^000000")) {
case 1:
mes "^FF0000[Notice]^000000";
mes "^FF0000Exchange one random item with one Kachua's Secret Key.^000000";
@ -22,7 +23,7 @@ sec_in02,126,178,3 script Kachua's Secret Box#bm 4_TREASURE_BOX,{
if(select("Keep going.","Stop conversation.") == 2) {
mes "You have decided not to open the Box.";
close;
} else if (countitem("K_Secret_Key") < 1) {
} else if (countitem(.@key$) < 1) {
mes "Not enough <ITEM>[Kachua Secret Key]<INFO>23919</INFO></ITEM>.";
close;
} else {
@ -30,7 +31,7 @@ sec_in02,126,178,3 script Kachua's Secret Box#bm 4_TREASURE_BOX,{
mes "^4d4dffPlease make sure you have enough space in your inventory.^000000";
close;
}
delitem("K_Secret_Key", 1);
delitem(.@key$, 1);
getgroupitem(IG_KACHUA_SECRET_BOX);
mes "Kachua's Secret Box was opened!";
mes "Were you lucky?";
@ -45,7 +46,7 @@ sec_in02,126,178,3 script Kachua's Secret Box#bm 4_TREASURE_BOX,{
if(select("Keep going.","Stop conversation.") == 2) {
mes "You have decided not to open the Box.";
close;
} else if (countitem("K_Secret_Key") < 10) {
} else if (countitem(.@key$) < 10) {
mes "You do not have enough <ITEM>[Kachua Secret Key]<INFO>23919</INFO></ITEM>.";
close;
} else {
@ -55,12 +56,12 @@ sec_in02,126,178,3 script Kachua's Secret Box#bm 4_TREASURE_BOX,{
mes "^4d4dffPlease make sure you have enough space in your inventory.^000000";
close;
}
if (countitem("K_Secret_Key") < 1) { // Custom check, just in case
if (countitem(.@key$) < 1) { // Custom check, just in case
close;
}
delitem("K_Secret_Key", 1);
delitem(.@key$, 1);
getgroupitem(IG_KACHUA_SECRET_BOX);
dispbottom "Kachua's Secret Box was opened " + .@i + " times. Another is opening.",0xFFFFFF;
dispbottom "Kachua's Secret Box was opened " + .@i + " times. Another one is being opened.",0xFFFFFF;
specialeffect2 EF_VALLENTINE;
}
mes "Kachua's Secret Box was opened 10 times!";