* Fixes#3530.
* Added constants for script commands getcastledata and setcastledata.
* Adjusted the guardian constants to adjust based on MAX_GUARDIANS define value.
* Updated scripts to reflect changes.
Thanks to @keitenai, @Atemo, and @Lemongrass3110!
* Moved all npc view constants into src
Source side the constants will use Gravity's naming standard(JT_*)
NPC side still supports the old names without JT_
* Moved all effect constants into src
Added check for effect validation to atcommand effect and all script commands using them
Removed the unused and broken function unit_changeviewsize from unit.c
Replaced a lot of hardcoded effect ids with their respective constants
Cleaned up the effect documentations
* Moved all hat effect constants into src
Added check for effect validation to script command hateffect
While refactoring those events the following other changes were made:
Introducing OnInstanceDestroy event. This event can be used to hook script code right in front of the instance destruction. This can be useful if you have any stored references to an instance id for example.
The script command cmdothernpc will now check if the target event exists and report failures. Therefore it now returns true or false.
All agit(FE,SE,TE) start and end commands from atcommand and script commands have been merged in their respective guild function which now returns a bool value of true for successful actions and false if it did not succeed(if the specific WoE was [not] running).
All global triggered events with mapserver status output now call the same function and therefore have the same mapserver output(including their respective event name of course).
Renamed a few events in the script configuration to match the other names
Added constants for months and weekdays
Additionally added constants for gettime types to make it easier to read.
Replaced all existing usages I found with their proper new syntax or better fitting functions.
* Added the following functions:
- "F_GetPlural" (returns plural of noun) / "F_InsertPlural" (returns plural if arg != 1) [credits: EnglishClub for formation rules]
- "F_InsertArticle" (returns 'a' or 'an' preceding word)
- "F_InsertComma" (formats number with commas)
- "F_GetNumSuffix" (formats number with '-st', '-nd', '-rd', or '-th' suffix)
* Added and removed new functions where necessary. (incomplete)
* Added new types to "F_GetArmorType" function, and weapons will now pass to "F_GetWeaponType".
* Reformatted comments.
Other changes:
* Removed some garbage text from scripts.
* Slight edits to custom warper script.
Signed-off-by: Euphy <euphy.raliel@rathena.org>
* Fixed job checks in Falcon Flute Trader script. (bugreport:7839)
* Fixed Guillotine Katar slots. (bugreport:7838)
* Fixed @itembound type 4 not working.
* Bossnia changes:
- Monsters should not be spawned with 'boss_monster' according to official scripts; removed 'notomb' mapflags accordingly (partial revert of r17404).
- Merged file into events/bossnia.txt, since the spawns and warps should be disabled by default.
Signed-off-by: Euphy <euphy@rathena.org>
* Implemented Bakonawa Lake instance.
* Monsters can now spawn on unwalkable cells, as required by the new instances. (credits: Akinari)
* Implemented 2012 RWC Enchants script, disabled by default.
* Reverted change to Mora Enchants from r17387, as the additional items are only present on iRO. (credits: Ziu)
* Fixed some errors from recent updates.
* Applied eol-style:native property to newly added files.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17397 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Replaced and added dividers in many script files with one standard divider.
* Other misc. cleaning...
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16727 54d463be-8e91-2dee-dedb-b68131a5f0ec
* You may also notice that your /guild2/ folder no longer functions. If that's the case... blame Maki (you can find him on the forums, IRC, TS, TSR, etc...)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16571 54d463be-8e91-2dee-dedb-b68131a5f0ec
-Now common scripts goes to the main npc folder, and pre-re-only/re-only ones goes to their respective folders.
-NPCs with practically the same script but little differences have been left in the main folder and uses the command checkre() for the differences.
-For those NPCs with different coordinates but same script, the script has been left in the main folder but the NPCs splitted as duplicates.
-All pre-renewal files has been reverted back to their pre-renewal behavior.
TODO:
-Correct pre-re quest rewards.
-Check for pre-re/re differences in mapflags.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16545 54d463be-8e91-2dee-dedb-b68131a5f0ec
Fixing pre-re / re npc support, moving /config/ folder to src root so other servers may also make use of the #define renewal dir and other stuff.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16382 54d463be-8e91-2dee-dedb-b68131a5f0ec
- removed `MAX_GUILDCASTLE` limit
- char-server now caches guild castles in `DBMap`
- improved guild castle SQL queries to support non-default values of `MAX_GUARDIANS`
- disallowed declaring guild castles on maps that are on other map-servers
- map-server now requests data for all guild castles from char-server on initial connect (bugreport:287)
- removed ''guildcastleinfo events'' as they were esentially duplicated ''OnAgitInit''
- optimized castle data load packets (bugreport:287)
- updated WoE scripts to reflect source changes (scripts no longer need or should request castle or guild data)
- updated related docs
- Added `db_size` macro.
- Replaced manual counting of castles occupied by a guild with `guild_checkcastles()` calls.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@15657 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Applied Ai4rei's patch for the skill WE_CALLPARTNER (bugreport:4437)
* Lots of updates to monster stats/drops, all fairly minor.
* Updated the price and weight of a handful of etc items.
* Removed drops for quest-spawned Satan Morroc. (bugreport:4425)
* Changed weight on novice consumable items to 0 (bugreport:4442)
* Updated Sage quest skill quest with the file curtosy of 5511.
* Fixed the Pink Crystal being named Blue Crystal in Flavius.
* Touched up the archer tutorial, and phantasmic arrow quests.
* Fixed Turbo Track records for 8 and 16 normal saving as expert. (bugreport:4433)
* Corrected the positions for the arug castle 04 exterior flags. (bugreport:4436)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14409 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Fixed the setwalls in Tierra gorge, again. Removed extra mapflags.
* Moved overlapping guild flags outside arug_cas05 to proper points.
* Fixed kRO Name for Women's Bundle. (bugreport:4398)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14385 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Minor item database bug fixes!
- Corrected some lower headgears being able to be refined. (bugreport:4328)
- Fixed wrong view ids for crown of deceit and musical note headband. (bugreport:4328)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14352 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed Tatacho's race, should be Brute. (bugreport:3664)
- Fixed a label name in Control Device01#aru04. (bugreport:3716)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14185 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed typo of a check in god_weapon_creation.txt (bugreport:3613).
- Fixed missing changequest in Knight Job Quest (bugreport:3757).
- Fixed placement of Control Device01#aru04 (bugreport:3716).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14178 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Movement speed, and attack delays are not official. (copy/pasted)
- Skills are, like above, copy, pasted, edited. Not official.
- Decided not to drops added for the mentioned monsters.
* Added mapflags for WoESE guild dungeon.
* Added official WoESE Guild Dungeon NPCs, and custom spawns.
- As the mobs are not 100% (missing stats, no drops, etc) they are disabled by default.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14123 54d463be-8e91-2dee-dedb-b68131a5f0ec
- "Conquered" messages can now be effectively toggled off in Battle log
- Added fontsizes for WoESE messages. (At least the non-default sizes.)
* Added font weight constants, although they don't seem to do anything.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14122 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Added monster_noteleport to Okolnir quest maps. Will fix the tarot card issue.
- Fixed Brynhild dialog in the Asprika quests. (bugreport:3085)
- Removed "Disabled" tag from Volcano base quest. (bugreport:3342)
- Attempted to fix the sign quest dancing portion. (bugreport:3382)
- Fixed Guardian in schg_cas03 using invalid coords. (bugreport:3462)
- Fixed Turbo Track records using wrong variable type. (bugreport:3484)
- Fixed the checkweights in the Crow of Fate quest. (bugreport:3500)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14013 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed a bug on Yuno Castle 2 and 3, not killing guardians.
- Moved battleground team leave on unit remove map to prevent a crash on multimap servers.
- Fixed a bug on checking range with the wrong target. Fix a crash on Item 2002 at refine >= 9.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13979 54d463be-8e91-2dee-dedb-b68131a5f0ec
