18299 Commits

Author SHA1 Message Date
Lemongrass3110
34eb4be25b
Preparatory cleanup of parties (#8418) 2024-06-12 15:39:24 +02:00
Lemongrass3110
9c9dcc8cab
Preparatory cleanup of guilds (#8417) 2024-06-12 14:47:52 +02:00
Lemongrass3110
aaa9890470
Preparatory cleanup of clans (#8416) 2024-06-12 10:03:44 +02:00
Lemongrass3110
6fdaac4a75
Added pincode state tracking (#8412)
Fixes #6595

Thanks to @Danil0v3s
2024-06-11 21:50:16 +02:00
Daegaladh
0d3550e7ea
Fixed clif_move to use the correct movement packets (#8405)
* Removed unused ZC_NOTIFY_MOVE (0x86) packet
---------

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2024-06-11 00:03:43 +02:00
Daegaladh
6ca99e7852
Fixed potentially dangerous map_addflooritem calls and related behaviors (#8360)
*Removed potentially dangerous map_additemfloor calls
*Added weight/inventory checks for marry atcommand
*Fixed overweight message for box items
*Fixed inventory space check for box items to match official requirement (the total number of the items the box will give you *r min 10, plus 1)
*Fixed inventory space message for box items
*Fixed pet egg creation not deleting the pet data when failed to add it to the inventory
*Fixed pet egg creation dropping the egg on the floor when failed to add it to the inventory
*Fixed pet equipment dropping on the floor when failed to retrieve the item
*Added a battle configuration to prevent removing the pet equipment (and disappear into nothingness) when failed to retrieve the item
*Added missing skill_drop_items_full checks on several skills (official behavior makes the items disappear)
---------

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2024-06-10 22:44:19 +02:00
Jittapan Pluemsumran
9267c2bf8a
Added sanity checks to pincode decryption (#8404) 2024-06-10 22:03:49 +02:00
Vincent Stumpf
92722db3ab
Fix dynamic npc timer mismatch (#8265)
* Fix dynamic npc timer mismatch

Fixes #8241
This adds some missing placement news that I'm surprised hasn't blown up yet.
2024-06-10 21:11:19 +02:00
Playtester
6daa032144
Renewal Spiral Pierce, Element vs. Status Attack (#8411)
- When using Spiral Pierce the base damage will now be multiplied with 0.7
- Weight bonus of Spiral Pierce is no longer affected by elemental adjustments
- Size modifiers updated: Small 130%, Medium 115%, Large 100%
- Spiral Pierce will now store its base damage in equipAtk to prevent rounding errors (temporary solution)
- Status Attack will now first apply the elemental table before doubling the right-hand damage
- Fixes #8410
2024-06-10 16:56:59 +02:00
Aristeus09
17a6d039d9
Fixed a couple of clif_message constant values (#8407)
Co-authored-by: Daegaladh <daegaladh@shadowgames.es>
2024-06-07 19:48:17 +02:00
Playtester
ec9a5fae4b
Monster Loot / Item Dropping Position (#8347)
- When a monster is killed, its first item will now always drop at the exact cell the monster was on
- When a monster drops more than one item, the items will be deployed on 3 cells around the monster (looping): SE, W and N
- Fixed drop position of looted items (similar to regular drops but independent to it and starts north)
- Fixed item drop order (script-granted -> regular drops -> looted drops)
- Fixed looted items showing special drop effects
- Searching for a free cell to drop an item on now uses the official algorithm
- When a monster drops an item, it will no longer drop on cells that are occupied by characters or pets
- When a player drops an item, it will now drop in a 5x5 area around the player
- Items dropped by players can now stack on the same cell unless the new "item_stacking" config is disabled
- When an MVP drop drops to the floor because the player's inventory was full, it will now always drop on that player's cell
- Fixes #8345
2024-06-07 18:29:01 +02:00
Playtester
e8f1c7f9e7
Triple Attack vs. Plant Mode (#8403)
- Triple Attack will now deal 3 damage to monsters with plant mode (infinite defense)
2024-06-06 21:13:48 +02:00
Lemongrass3110
4c1b1c1a5c
Added missing conformance mode in MSVS (#8402)
Follow up to 1361e9c
2024-06-06 13:10:47 +02:00
Atemo
ed3f418d15
Item data corrections (#8390)
* Fixed items in DB using wrong field. Some fields don't work with certain item types.
* Added warnings when a type is using a wrong field.
2024-06-05 15:34:14 +02:00
Lemongrass3110
c74ad5c8c2
Fixed PCBLOCK_EQUIP (#8399)
Fixes #8398

Thanks to @nubspixel
2024-06-04 10:02:14 +02:00
Lemongrass3110
48b4623f3e
Fixed all warnings in MSVS (#8391)
Fixes #2859
Fixes #3570
Fixes #8389
2024-06-04 03:07:16 +02:00
Lemongrass3110
660b194ade
Changed droplists from ERI to STL (#8370) 2024-06-04 02:40:55 +02:00
Playtester
23e7e1f367
Fixed Random Spawns (#8397)
- Fixed monsters with random spawn location to sometimes spawn on (0,0) if that cell is not a wall
- Follow-up to 5d232db
2024-06-03 19:48:55 +02:00
Playtester
1c96180fe6
Night Watch Job Bonus, Crimson Revolver (#8396)
- Fixed Sta bonus of Night Watch job
- Fixed Crimson Revolver giving 35 ATK too much
2024-06-03 16:58:31 +02:00
Lemongrass3110
545417ef11 Follow up to 1b9e46b
Fixes #8392

Thanks to @Beginerxx
2024-06-01 15:54:19 +02:00
idk-whoami
f60a4bdfaf
Corrected script for some item #28 (#8340) 2024-05-31 17:10:01 +02:00
Daegaladh
1f9a43c9d2
Replaces more constant names with the official ones (#8374)
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
2024-05-31 14:51:59 +02:00
Lemongrass3110
1b9e46b247
Generic cleanup of packets (#8369)
Standardized initial packet length of dynamic packets to sizeof
Standardized normal casts of packet_buffer to reinterpret_cast
Standardized packet length incrementations to static_cast with decltype
Removed unused function clif_setdisguise
Fixed an issue with string length in clif_scriptmenu
Removed struct keywords
Resolved a few warnings
2024-05-31 14:28:40 +02:00
BotGigo
4e77ada895
Illusion of underwater cooldown (#8383)
Corrected the quest menu for Illusion of underwater daily quests
2024-05-29 20:49:31 +02:00
Playtester
98eaf85a90
Arch Mage, S.MATK, Warlock Summon/Release (#8386)
- Fixed job stat bonuses of Arch Mage
- Fixed damage formula of Summon Elemental Ball / Release 2
- S.MATK is now applied before skill ratio
- Fixes #8381
2024-05-29 09:04:23 +02:00
Playtester
19f94e18f0
Renewal Guillotine Fist, Counter Slash, Shield Press Damage (#8376)
- Fixed the "constant addition" damage bonus being applied before the ratio in renewal, resulting in way too high damage for Guillotine Fist, Rapid Smiting and Shield Press
- Guillotine Fist is now reduced by SoftDEF+HardDEF in renewal
- Guillotine Fist is no longer reduced by Res
- Fixed Counter Slash adding Agi and Job Level to base damage rather than skill ratio
- Fixed Shield Press multiplying the damage by 5 instead of dividing it among 5 hits
- Only base STR of players will increase the Shield Press skill ratio now
- The fixed VIT*REFINE damage bonus of Shield Press is now a bonus that is applied even on MISS
- Fixes https://github.com/rathena/rathena/issues/8363
2024-05-28 22:47:06 +02:00
Daegaladh
3b5b5be574
Fixed compile warning (#8384) 2024-05-28 15:59:45 +02:00
Akkarinage
39644a980f
Removed whitespace & duplicate label in runserver.bat (#8385) 2024-05-28 14:48:58 +01:00
Lemongrass3110
924d1ddad7
Fixed clif_clearchar_skillunit (#8371)
Follow up to cc60c46
2024-05-27 01:00:25 +02:00
Lemongrass3110
79935a75c9
Updated Hercules packets (#8368) 2024-05-26 17:31:23 +02:00
eppc0330
9e2b0b4a4d
New pcblock flag PCBLOCK_EQUIP (#8367) 2024-05-26 15:43:32 +02:00
Daegaladh
05ced985e3
Replaced custom with official message names (#8361) 2024-05-26 13:17:05 +02:00
Atemo
cc60c46e5f
Converted some packets to structs (#8353)
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2024-05-25 22:17:12 +02:00
Playtester
b4ae40d401
Synchronize Damage Feature (#8305)
- Added a new monster stat "ClientAttackMotion" to mob_db.yml which is the time from when a monster attacks until which the damage shows on the client at 1x speed
- Added a new config synchronize_damage; when set to "yes", the client will display the damage of normal monster attacks at the exact time it is applied on the server, removing position lag (fixes #259)

Special thanks to all people who worked together to make this possible.

Co-authored-by: aleos, Lemongrass3110, Atemo
2024-05-25 18:59:22 +02:00
Lemongrass3110
023263df7d Fixed another crash in clif_wis_message
Follow up to 7ddd035 and a44d954

Fixes #8359

Thanks to @gmragnarok
2024-05-25 15:31:30 +02:00
Pokye
7c017bac6a
Missing nodynamicnpc on mapflag (#8357)
Fixes #8356
2024-05-24 15:28:07 +02:00
Atemo
361530a1b6
Converted some packets to structs (#8351) 2024-05-21 21:28:01 +02:00
Atemo
d1cf6f4ac7
Converted some packets to structs (#8332) 2024-05-20 21:13:59 +02:00
Playtester
c83f41a5a3
Consistent Dirx / Diry Array Usage (#8343)
- All skills now use the globally defined dirx/diry variables instead of defining their own
2024-05-20 09:14:18 +02:00
Playtester
5d232db89e
Spawn and Free Cell Search Behavior (#8324)
- When searching for a map-wide free cell, the tiles 15 cells from the edge are no longer considered
  * Added a configuration to change the edge size to any value between 1 and 40
- When searching for a free cell, the tiles 4-5 cells from the edge are now considered invalid and trigger a retry
  * If you make the edge size smaller than this, it will use edge size instead
- Searching for a free cell now defaults to 50 tries, but if the "no spawn on player" option is active, those failed attempts are not counted towards the limit anymore
- When a monster spawns in a defined area there will now be 8 attempts to spawn it on a valid cell within the area and then one attempt on the center cell; if all 9 attempts fail, there will now be 50 tries to spawn it map-wide before it gives up
- When a monster has fixed spawn coordinates, but those coordinates are a wall, it will now spawn in a random location map-wide instead
  * This also applies to icewall blocking the cell unless the boss_monster command was used
- Each monster in an area spawn will now receive its own spawn center within the spawn area on server start
  * This results in the spawn area being larger but having a bias towards the center
  * Added a configuration to disable this behavior
- Fixed slave monsters always being active and constantly calling the "search freecell" function even though neither them nor their master have been spotted yet
- Fixed map server crash when setting no_spawn_on_player to 100 (follow-up to 33b2b02)
- Updated prontera field spawns to official episode 18+
- Updated all champion mob respawn times to 3 minutes and sorted them by map name
- Fixes #8300
2024-05-19 17:12:44 +02:00
eppc0330
949a33081f
Fix slavemob bahavior (#7978)
Fixes #6885

Co-authored-by: aleos89 <aleos89@users.noreply.github.com>
2024-05-19 14:10:23 +02:00
Aleos
b81904d554
Update build_servers_gcc.yml (#8338)
Add a separate job to run specifically for GCC 13 in Ubuntu 24.04 as the package was removed from Ubuntu 22.04.

Related issue actions/runner-images#9866
2024-05-18 13:40:43 +02:00
mettool
aa62b2fa80
Corrected Boss Meow monster Class (#8336) 2024-05-17 14:52:13 +02:00
Kanin Temsrisuk
4327fb05a9
Corrected RG Golden Potion item data (#8286) 2024-05-17 14:50:42 +02:00
Akkarinage
e1e8b68b33
Updated checkout version tag 2024-05-15 19:38:03 +01:00
Akkarinage
91b501bbb2
Added Siege_Teleport_Scroll2 function 2024-05-15 14:24:36 +01:00
eppc0330
a9a8b0d0c4
Fixed plagiarized skills not removed (#8329) 2024-05-14 09:10:03 +02:00
Lemongrass3110
da8229b8f5
Added some suggested code improvements (#8331)
Fixes #8309

Thanks to @mrpond
2024-05-13 17:46:47 +02:00
Lemongrass3110
8980203f7b
Small cleanup to NJ_ZENYNAGE (#8320)
Split NJ_ZENYNAGE from KO_MUCHANAGE
2024-05-13 16:50:30 +02:00
Lemongrass3110
fe9f617f97
Fixed clif_sendfakenpc (#8330)
Fixes #8321
Fixes #8328

Thanks to @kaninhot004
2024-05-13 11:45:00 +02:00