Commit Graph

8901 Commits

Author SHA1 Message Date
Aleos
87032fc95a Updated Gunslinger/Rebellion Bullet behavior (#3459)
* Fixes #2745.
* Disabled the ability to equip old spheres and old slugs.
* Corrected some of the newer bullets name, weight, price, and effects.
* Updated the ASPD for Gunslinger/Rebellion when equipping guns.
* Spread Attack and Ground Drift now only use bullets.
* Adjusted Slug Shot skill item requirement to the new Slug Bullet.
* Separated pre-renewal and renewal ammo NPC (Kenny and Tony).
-- Renewal no longer has Tony.
-- Kenny can now trade in the Sphere bullets for new bullets.
-- Kenny can now trade in the old Slugs for Slug Bullet.
-- Added new bullets into Kenny.
Thanks to @cydh and @exneval!
2018-10-29 10:18:19 -04:00
Jittapan Pluemsumran
84b4f09874 Added skill_duration mapflag. (#2171)
* Added skill_duration mapflag.
* This mapflag sets a skill unit time limit to n% of original duration.
* Implemented mapflags for Hunter's Traps in GVG, BG, and Novice Guild maps.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2018-10-26 08:52:49 -04:00
Jittapan Pluemsumran
2140722743 Fixed potential map server crash in clif_parse_Mail_setattach (#3609) 2018-10-26 13:51:50 +07:00
Aleos
04f127fd7c Corrected equipment stripping success rates (#3597)
* Corrects Strip Weapon, Strip Armor, Strip Shield, Strip Helm, Weapon Crush, and Full Strip success rate.
Thanks to @Cydh!
2018-10-25 18:14:23 -04:00
Jittapan Pluemsumran
180938d971 Fixed free purchase from cashshop NPC exploit (#3605) 2018-10-23 01:13:41 +07:00
Cydh Ramdh
d8e760fa78 Cleanup skill_damage mapflag for skill (#3583)
* Changed from vector to unordered_map with skill_id as key
2018-10-19 08:34:29 +07:00
Atemo
58c520eb07 Initial release of Devil Tower memorial (#2555)
Initial release of Devil Tower memorial (walkthrough conversion)
* TO DO:
** implement Dancingblade, Pulsestrike2 and adjust ice mine skills
** correct progressbar behaviour

Thanks to all the contributors !
Special thanks to Divine Pride !
2018-10-16 17:20:34 +02:00
Atemo
0b18fe4bed Update/moro vol npcs (#3002)
Updated npcs from ep 14.3 (official conversion)
* Adjusted permanent monster random spawn: xy are now optional
* TO DO: update questinfo to display the icon when the variable condition are met

Thanks to all the contributors !
Special thanks to https://www.divine-pride.net/ !
2018-10-16 00:33:37 +02:00
Atemo
33dcaddac5 Nightmare biolab (#3228)
Initial implementation of nightmare biolab.
The missing skills will eventually be implemented later.

Thanks to all the contributor, special thanks to https://www.divine-pride.net/ !
2018-10-15 21:39:28 +02:00
Cydh Ramdh
fe197bfa12 Renewal Monster Updates (#3541)
* Renewal Monster's ATK & MATK Calculation Updates
* Renewal Monster database updates
  * ATK1 is *base* ATK, the range 80%~120% is calculated in src
  * ATK2 is *base* MATK, the range 70%~130% is calculated in src
* Adjusted ATK range min~max in mobinfo atcommand
* Nothing was changed in pre-renewal system!
* Thanks to @aleos89, @slyx88 and Divine-Pride.net
2018-10-13 19:00:14 +07:00
Lemongrass3110
8e7b9a57c0 Change the default packetver to 20180620 (#3557)
We support all required features or have them ready in some pull requests.
The packet version after this will require a huge overhaul since item id sizes have been changed in all packets.
2018-10-11 10:33:55 +02:00
Lemongrass3110
55acdb9863 Initial release of the guild storage log (#3365)
Thanks to @aleos89 and @Everade
2018-10-10 17:51:49 +02:00
Sader Fawall
10e7035beb Added script command getunits (#3389)
* Closes #3159.
* Adds script commands getunits, getmapunits, and getareaunits.
* Replacement for script commands getusers, getmapusers, getareausers. (In a future commit)
Thanks to @sader1992, @Atemo, and @anacondaqq!
2018-10-10 10:33:01 -04:00
Cydh Ramdh
e66dc4f62e Instance map fixes (#3539)
* Fixed #3517, new map from instance doesn't use unused map slots
* Fixed #3528, crashed on reloadscript if there is instance map
* Cleared map flags on reloadscript
2018-10-10 18:05:24 +07:00
Atemo
7d8530e3b1 Fix for issue #3540 "IM_NONE idle timer" (#3550)
* Fix for issue #3540 "IM_NONE idle timer"

* Cleaned redundant map_getmapdata

Thanks to @aleos89 !
2018-10-09 22:58:41 +02:00
Cydh Ramdh
0f8ce36746 ers_destroy called too early in do_final_instance (#3533)
* Fixed #3532
2018-10-02 08:22:29 +07:00
Aleos
926e37cb65 Corrected some GCC 7.1+ compile warnings (#3522)
* Fixes #2787 and fixes #3513.
* Resolved some format-truncation warnings.
* The remaining will be fixed at a later time.
Thanks to @RadianFord and @Lemongrass3110!
2018-09-28 13:57:27 -04:00
Cydh Ramdh
3e1105b0cf Updates Item Sell checks (#3491)
* Added config values for `allow_bound_sell`
  * 0x4 allows bound item to be sold at NPC Shops
  * 0x8 restrict only guild leader who can sell guild bound item at NPC Shops or Itemshops
* Added config to allow rental items can be sold at NPC `rental_transaction` (planned for more config values based on #3490). Default to `yes` allowed to be sold, still can be restricted by item_trade, item id based.
* Fixed itemshop which ignores another item stack in inventory even for same item currency
* Fixed exploit potential by using Itemshop & Pointshop
* Now equipped item cannot be sold at NPC
* Typo and grammar fixes. Thanks to @aleos89 and @secretdataz
2018-09-27 13:54:28 +07:00
rAthenaAPI
79766cd99e Effect State Update 2018-09-25 22:06:43 +02:00
Aleos
7040057a9f Corrected Taekwon Mission mob generator (#3509)
* Fixes #3499.
* Corrected the way target monsters are generated for Taekwon Mission.
* Requires: The mob ID is in the range [MOBID_PORING, MOBID_GREEN_IGUANA], the mob must have below 30,000 HP, the mob must give Base EXP, the mob must be CLASS_NORMAL.
* Added a new mob group: MOBG_Taekwon_Mission
* Removed hard coded checks.
* Created constants for random monster group flags.
Thanks to @mrjnumber1, @Lemongrass3110, and @cydh!
2018-09-25 13:32:11 -04:00
Aleos
8fc790339d Corrected Union of the Sun Moon and Stars HP cost (#3507)
* Fixes #3500.
* Corrected the HP cost formula to reflect Aegis.
Thanks to @mrjnumber1 and @Lemongrass3110!
2018-09-25 13:04:50 -04:00
Aleos
147e8da2e4 Corrected Critical bonuses (#3506)
* Fixes #3501.
* Critical bonuses bCritAtkRate and bCriticalLong should not be applying to skills.
Thanks to @mrjnumber1!
2018-09-25 12:27:30 -04:00
Aleos
f0dfdf9219 Cleaned up equipment stripping skills (#3493)
* Fixes #3476.
* Centralized all equipment stripping skills to skill_strip_equip.
* Updated success rates and durations to match official.
Thanks to @mrjnumber1!
2018-09-24 14:51:51 -04:00
Cydh Ramdh
b614092b75 Updates inf3 in skill_db (#3488)
* Added inf3 0x100000 for skill is not blocked by SC_AUTOGUARD (physical-skill only)
* Added inf3 0x200000 for skill is not blocked by SC_UTSUSEMI or SC_BUNSINJYUTSU (physical-skill only)
* Changed `NK_NO_CARDFIX_ATK` check to the flag above
* Applied those new inf3 flags for skills which are `weapon`-type and have `0x8`-nk
2018-09-21 09:52:56 +07:00
Atemo
a12f1ce02f EDP renewal change (#3485)
This setting only affects renewal mode:
- Switch to a different weapon or unequip a weapon now cancel EDP
- EDP can't be used with fist (right hand check only)

Thanks to @aleos89 and @cydh !
2018-09-19 00:33:45 +02:00
Aleos
0d77398385 Cleaned up Banding behavior (#3486)
* Fixes #3478.
* Adjusted Banding to use proper party counting functions.
* Corrected the DEF and HP Regen bonus for Banding.
* Banding Defense will no longer stack on itself.
Thanks to @admkakaroto and @exneval!
2018-09-18 11:05:27 -04:00
rAthenaAPI
e49505472e Effect State Update 2018-09-18 05:06:10 +02:00
keitenai
3cd7717324 Update documentation typo error (#3489)
* Replace wrong spelling "errur" to "error"
* Thanks to @keitenai
2018-09-14 15:09:50 +07:00
Sader Fawall
ca83d35285 Fix some error and warning in the NPC sample folder (#3458)
* exported EQI_MAX for getequipid.txt
2018-09-12 23:14:46 +02:00
Aleos
e6e0511cf7 Corrected a check for skill usage restrictions (#3472)
* Resolves an issue where the usage of self skills while a storage is open was causing the entire check to fail.
Thanks to @Tokeiburu!
2018-09-12 11:03:14 -04:00
rAthenaAPI
3ac7781c9d Effect State Update 2018-09-12 04:05:57 +02:00
Aleos
d17ddf41fe Corrected some weapon bonuses (#3466)
* Fixes #3465.
* Item bonuses AddEle, AddRace, AddClass, and AddSize now work with shields.
Thanks to @laziem!
2018-09-05 13:46:20 -04:00
Aleos
d3d8f3c5a7 Implemented official ammo equip behavior (#3438)
* Fixes #1155.
* Added specific checks for weapons when equipping ammo.
* Ammo is removed if the required weapon is removed.
* Added battle configs to disable behavior.
Thanks to @Atemo, @exneval, and @benching!
2018-09-05 10:44:34 -04:00
Aleos
618fc37eab Resolved Dynamic Mobs issue (#3467)
* Fixes #3464.
* Fixes Dynamic Mobs not being properly reloaded.
Thanks to @Litro!
2018-09-05 10:22:30 -04:00
rAthenaAPI
3c157f221d Effect State Update 2018-09-05 04:06:07 +02:00
keitenai
d7d012c5c1 atcommand identifyall follow up (#3463)
Fixed unreferenced local variable "i"
2018-09-03 10:03:16 +07:00
Aleos
386ee35507 Updated mob_drop parsing (#3452)
* Fixes #3172.
* Mob Drop Database now updates an item's values if it is already dropped by a monster.
Thanks to @teededung!
2018-08-31 19:01:40 -04:00
Aleos
048de6c90a Cleaned up map property functions (#3460)
* Follow up to da83e61.
* Stop players from attacking when disabling PvP/GvG from script commands.
* Removes redundancy.
2018-08-31 18:42:18 -04:00
Aleos
d699defa74 Updated Arch Bishop skills from kRO maintenance (#3258)
* Fixes #3231.
* Updated Arch Bishop skills from kRO maintenance: http://ro.gnjoy.com/news/update/View.asp?seq=222&curpage=1.
* Added two new skills: Vituperatum and Convenio.
Thanks to @secretdataz, @Rytech2, @Angelic234, @ecdarreola, @redlightliu, @laziem, @xTakami, @admkakaroto, @Tokeiburu, and @flamefury!
2018-08-31 09:19:59 -04:00
Atemo
fd4f7ccd5c Suggestion: identifyall script command (#3419)
* Implemented script command identifyall.
Thanks to @secretdataz for suggestions!
2018-08-30 10:03:03 -04:00
Aleos
3569789ab0 Corrected server info display (#3434)
* Fixes #3431.
* Corrected the VIP EXP bonus amount being displayed incorrectly for the personal information packet.
Thanks to @hendra814!
2018-08-29 09:29:21 -04:00
rAthenaAPI
fe9dbf4787 Mob and NPC Identity Update 2018-08-29 05:00:48 +02:00
Aleos
ae7cb65a96 Fixed a potential crash (#3439)
* Fixes #3413 and fixes #3437.
* Removed extra dynamic storage clearings.
Thanks to @ecdarreola and @mazvi!
2018-08-28 19:22:41 -04:00
aleos
5581da4bc4 Follow up to e469f5f
* Corrected map loaded message when no maps are removed.
2018-08-28 11:03:34 -04:00
Aleos
da83e61738 Corrected some map property issues (#3435)
* Resolves PvP timers and effects not displaying properly.
* Resolves any GvG effects not displaying properly.
* If PvP or GvG is disabled, stop players from attacking.
* Moved PvP timer and attack functions to appropriate locations.
* Removed redundancy from atcommands.
2018-08-27 20:28:18 -04:00
Aleos
0f7f66396c Corrected Blast Mine and Claymore Trap behavior (#3373)
* Fixes #3362.
* Damage should be split among targets.
Thanks to @zakudam!
2018-08-27 19:19:36 -04:00
aleos
e469f5fb62 Corrected a map server notification
* Corrected the removed maps notification not displaying properly.
2018-08-27 18:22:23 -04:00
Aleos
bde33e762c Cleaned up map data checks (#3405)
* Fixes #3398 and fixes #3402.
* Sped up pc_isUseitem, pc_setpos, and pc_dead map data checks.
Thanks to @uddevil!
2018-08-27 18:03:38 -04:00
Aleos
a5af358bf7 Updated mapcache tool (#3406)
* Fixes #3046.
* Mapcache tool now reads the import directory.
Thanks to @secretdataz suggestion!
2018-08-27 14:16:08 -04:00
Atemo
c856b07c45 Suggestion of 'killedgid', variable set when a monster is killed containing the monster game ID (#3418) 2018-08-23 15:49:32 +02:00