12265 Commits

Author SHA1 Message Date
Cydh Ramdh
700d1e9508 Merge pull request #132 from nanakiwurtz/master
Item DB update:
2014-11-29 22:56:40 +07:00
nanakiwurtz
c366d98004 Follow up to 2839983
-- Changed Skill ID to it's corresponding skill constants

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2014-11-28 14:30:29 +07:00
aleos89
a88db39dd9 Follow up to 3be6f5a. Fixed compile warning for pre-renewal mode. 2014-11-27 22:46:14 -05:00
aleos89
3be6f5a4f3 * Adjusted new renewal changes and added missing bonus damage modifiers for several skills. (bugreport:9280)
* Put Gloomy Shyness into INF3_*.
2014-11-27 22:37:25 -05:00
nanakiwurtz
2839983b64 Follow up to ca150c5
-- English names fixed

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2014-11-28 00:35:04 +07:00
nanakiwurtz
ca150c58c7 Item DB update:
-- Up to kRO 2014-10-22

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2014-11-28 00:18:51 +07:00
Cydh Ramdh
0877fed66c Fixed Homunculus crash potential when checking the skill (bugreport:9162)
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-25 19:36:57 +07:00
Cydh Ramdh
4efbffca45 Merge pull request #120 from rathena/script/checkvending
Expand 'checkvending' script
* The returned value is bitmask of &1 - Vending, &2 - Autotrading, &4 - Buyingstore
2014-11-25 19:04:40 +07:00
Playtester
76a30f3927 Hindsight, Song/Dance Effect fixes
- Fixed Hindsight often casting level 0 of a skill when the selected auto-skill was of level 2
- Fixed song and dance effects staying forever on the screen if the bard / dancer walked out of sight (fixed #127)
2014-11-24 21:11:09 +01:00
Cydh Ramdh
a16701f33a Disabled @accinfo request in CZ_REQ_ACCOUNTNAME to avoid unnecessary request. Follow up c953236, bugreport:9186. Thank @anacondaqq
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-23 18:03:04 +07:00
Cydh Ramdh
34ca457ab0 Follow up bbe733e, typos
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-23 14:33:28 +07:00
icxbb-xx
91156ab3ee Fixed typo forgot next line 2014-11-23 03:37:48 +07:00
Playtester
0359420f42 Follow-up to 0fd7ba72df
- Fixed a compiler warning that showed when deactivating ACTIVEPATHSEARCH (special thanks to Napster for pointing it out)
2014-11-22 21:04:41 +01:00
Playtester
e6caa9569b Skill menu and looter fixes
- Fixed a bug that stopped characters server-sided and caused position lag when closing a skill menu (bugreport:9117)
- Fixed behavior of looter monsters (#125=fixed)
  * They will now always target the oldest item in their view range (which makes it seemingly random), rather than always the most south-western item available
  * Their loot range is now "0" meaning they need to be on the same cell as the item to loot it
  * Their AI will no longer get stuck in an endless loop when someone drops an item around the corner
2014-11-22 20:36:06 +01:00
Cydh Ramdh
a212839665 Fixed #122 @accountinfo issue
* Now inter-server always asking to login-server for account info instead using direct query to `login` table. Merged from HerculesWS/Hercules@da233d5
* Inter-server packet usage: HA 0x2720 & AH 0x2721
* Additional changes from inter-server to map-server to parse the account info result with type 1 by using packet 0x3808 for clif_account_name(). Just some changes from @lighta at his old diff
* Moved some messages to char_msg.conf
* Updated inter-server packet documentation

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-22 18:58:29 +07:00
Cydh Ramdh
5386d2e157 Fixed #104, Wurg Dash hit "miss" when bumps monster
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-22 13:47:10 +07:00
Cydh Ramdh
f222779af3 Merge pull request #121 from emistry/patch-1
Fixed #107
2014-11-22 12:23:49 +07:00
Emistry
69f08f7028 Wrong info in NPC message. 2014-11-22 01:04:02 +08:00
Cydh Ramdh
bbe733e236 Expand 'checkvending' script
* Added returned values for buying store.
* Made returned values as bitmask. &1 - Vending, &2 - Autotrading, &4 - Buyingstore

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-21 21:56:16 +07:00
Playtester
0fd7ba72df 1st Transcendent Spirit, monster position lag fixes
- 1st Transcendent Spirit will now work as on official servers (#116)
  * The max total stat that is granted by the skill is now BaseLevel-10 with a maximum of 50 instead of always 50
  * It will now work as Marionette Control and calculate the bonus at cast time rather than overwrite all existing bonuses
  * Agi Up and Blessing will now cancel the soul link
- Fixed various problems that caused position lags on the client (#118)
  * Added a define ACTIVEPATHSEARCH in mob.c; if active (default and official), monsters will only grab targets if the walk path to the target is shorter or equal their search range; search range depends on whether the monster is moving or not (range2 for standing monsters and range3 for walking monsters); this requires a lot of CPU load, if it causes trouble, just comment the define for old behavior
  * Fixed a bug that made monsters display "irregular movement with position lag" continuously when a status change ended that changed their walk speed
  * OFFICIAL_WALKPATH now also applies to monsters
  * If the path search fails while a unit is already moving, we will now issue of fixpos packet so that the unit does not only stop moving on the server, but also on the client
2014-11-21 15:42:38 +01:00
Cydh Ramdh
28601afa16 * Fixed map-server crash possibily by using @channel ban/unban for offline player
* Fixed @channel ban/unban doesn't recognize player's name with space

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-21 18:13:57 +07:00
Akkarinage
9f8af95a88 Merge pull request #114 from rathena/hotfix/mail-cancel
Follow up 9b4d922.
2014-11-18 21:35:19 +00:00
Akkarinage
90f127012a Merge pull request #113 from rathena/hotfix/1024
Removed script command 'getusersname' (bugreport:1024)
2014-11-18 21:20:40 +00:00
Cydh Ramdh
3047292665 Just a little changes
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-19 03:16:59 +07:00
Cydh Ramdh
e3a96c8297 Follow up 9b4d922.
* Fixed Zeny doesn't updated when player cancels to send a mail with attached Zeny. Thank a91323

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-19 02:50:32 +07:00
Akkarinage
d02bd5b016 Removed script command 'getusersname' (bugreport:1024) 2014-11-18 17:12:45 +00:00
Cydh Ramdh
0ad6cdbb4f Just a follow up of a0bd016.
(Seems something changed with the file attribute or what is it, changed a whole file lines and always be assumed unstaged files/uncommited changes)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-18 19:22:58 +07:00
Playtester
d20ac845d1 Direction fixes
- Updated the config setting attack_direction_change from 15 to 0 (official value); that means that a unit's direction will no longer change when it attacks; knock-back effects from e.g. Firewall will depend on the last direction the target walked into instead (bugreport:1322)
- Ensured that the default direction of a monster is always "north", so that immobile monsters will now always be knocked back to the south by e.g. Firewall on default settings, unless a skill like e.g. Backstab changes their direction (bugreport:1322)
2014-11-18 12:03:57 +01:00
Playtester
13d1c2dcd9 Assassin Cross of Sunset updated
- Improved formula of Assassin Cross of Sunset for both pre-renewal and renewal (#111)
2014-11-17 20:19:16 +01:00
Playtester
a0bd0168cf Autobonus on ground skill and Angelic Ring fixed
- Autobonus3 will now also trigger when using ground skills (bugreport:6434)
- Fixed trigger chance of the Angelic Ring auto-bonuses (5% -> 10%) and that they didn't display any effect
2014-11-17 17:05:10 +01:00
Cydh Ramdh
796b97455c * Fixed #109
- @charunban is fully usable now
  - Updated Inter-Server Packet documentation
* Added misc battle config, 'disp_servervip_msg' (default: no)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-17 20:19:30 +07:00
Playtester
d9a9a024f6 Magnum Break damage fixed
- The 20% fire damage bonus now only applies if the base damage is at least 1 (#108)
  (Note: The fix does not work for player damage in renewal.)
- Targets two cells away will now only take 100%+10%*level damage (#108)
2014-11-16 18:06:53 +01:00
Playtester
08bf5112a1 Fire Pillar, Acid Bomb fixes
- Fire Pillar can no longer hit plants (follow-up to 04a1173f7d)
- Acid Bomb will now hit every 500ms instead of every 1000ms on renewal (related to bugreport:6338)
2014-11-15 21:48:44 +01:00
Capuche
0edb5c7ff8 Fixed dialog in quests/eden/eden_quests.txt
Thanks to Phenex

Signed-off-by: Capuche <capucrath@gmail.com>
2014-11-15 18:52:45 +01:00
Playtester
e7e8b5454b Land Protector, Ground Skill Splash, Storm Gust Knock-back
- Land Protector now behaves like on official servers (bugreport:5237)
  * Land Protector now protects from units being placed on it, no matter if they have splash range or not
  * Land Protector no longer protects from damage from units not outside Land Protector that splash inside
  * Meteor Storm no longer shows meteors falling if they would land on Land Protector
  * Pneuma can no longer be placed next to Land Protector
  * Also cleaned up the code a bit, so the checks are done where they should be done
- Ground skill splash ranges updated to their official values (bugreport:5237)
  * Lord of Vermilion places units in a 11x11 area with 3x3 splash range each
  * Storm Gust places units in a 9x9 area with 3x3 splash range each
  * Heaven's Drive places units in a 5x5 area with no splash range
  * Venom Dust now has a splash range of 3x3 and is consequently larger than before
- Storm Gust's knock-back behavior updated to official (bugreport:5237)
  * Each of Storm Gust's units will knock back "Away from center"
  * As units in the south-west are processed first, the knock-back direction will usually be north-east
  * At the edges the knock-back direction will be "to the outside"
  * Land Protector and Ganbantein will influence the knock-back behavior strongly, e.g. if Storm Gust has a hole in the middle, it will have a "suck in" effect
  * Added a config option for those who want the old "random direction" behavior from eAthena
2014-11-15 16:32:26 +01:00
Capuche
ea6ba2dd3f - Fixed item bonus for vesper card in pre re
- Fixed warning for infinite warp where count_rewarp increased when the player was warped near a warp

Special thanks to Radian

Signed-off-by: Capuche <capucrath@gmail.com>
2014-11-13 21:19:15 +01:00
Playtester
525e8178c2 Timer interval, Waterball, Crimson Fire Formation and boss walk delay updates
- Reduced the timer interval from 50ms to 20ms (official value)
  * For a long time it is well known that the Aegis interval is 20ms, but devs have been hesitant to set it to that out of performance reasons; these days however, machines are better and there aren't really many 2000+ player servers anymore, so a 20ms interval is actually quite viable now.
  * Setting the interval to 20ms makes the server perfectly in sync with the client that expects the server to have a delay of no longer than 20ms.
  * All skills that are "chain-able" on official servers will now also be 100% chain-able here (previously it just worked to 40%), assuming there is no lag
  * Skills with cast time will no longer go off 30ms later than officially
  * Several others improvements in regards of client-server sync (timers are used almost everywhere)
  * This might increase the CPU usage by up to ~50%, if you have trouble running your server with this, you can increase it again in timer.c (TIMER_MIN_INTERVAL)
- Strongly improved the Waterball implementation (bugreport:9382)
  * The interval between Waterballs is now 150ms (previously 125ms); due to the timer interval it will alternate between 140ms and 160ms (yes, this is official)
  * While the Waterball effect is active, players and non-boss monsters can no longer walk
  * Added a server-sided canact delay each time a Waterball is shot, which is equal to the one the client gives; this is to prevent hackers from being able to mass-cast Waterball; you can still multi-cast Waterball if your aMotion is shorter than the Waterball interval (i.e. 186 ASPD or higher)
  * The Waterball effect is no longer canceled when the target hides behind an obstacle, but no waterballs will fly and no damage will be applied; walkdelay will remain, but there won't be any canact delay for the caster (meaning he can cast another spell); if the target comes out of its cover during the duration, it will be hit again (this also fixes an exploit against MVPs)
  * Waterball now has a max duration of 10 seconds, even if more water cells are available, the effect will stop; this means that level 10 monster water ball will now only hit up to 67 times
- Fixed Crimson Fire Formation having a knock-back effect although it shouldn't (bugreport:6949)
  * It will hit once every 20ms with no knock-back, regardless of whether the target is undead, non-undead or a player
  * If you want to it to display more "fluently" you would need to set the SKILLUNITTIMER_INTERVAL in skill.c to 20ms, but the performance loss is pretty big for something only this skill and Firewall would benefit from
- Bosses are now able to ignore skill-induced walk delay (#100)
  * They can for example walk after casting Sonic Blow and Waterball (see above)
- Minor description improvements
2014-11-12 22:42:48 +01:00
aleos89
b28e9dc9dd * Fixed #101 - Warg Dash not beginning run action when used. 2014-11-12 08:43:27 -05:00
icxbb-xx
ccebc42dc6 Follow-up to (43f25e3)
- Revert skill cooldown list not support found problem map server crash.
I will try check again.
2014-11-09 23:13:55 +07:00
icxbb-xx
e7c4abb10c Follow-up to (d62d89d)
Special Thank @Playtester
2014-11-09 18:31:14 +07:00
icxbb-xx
66df36b0b2 Fixed compile warning (follow-up to 04a1173)
- Special Thank @tmav94
2014-11-09 10:39:14 +07:00
Euphy
1d2160758c Fixed Ticket Refiner refining above ticket level.
http://rathena.org/board/topic/98997-safe-refine-ticket-refiner/

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-11-07 18:33:32 -05:00
icxbb-xx
2ca6cd7760 Fixed typo in script command merge to dispbottom (follow-up to 4f09d08)
- Special Thank @Euphy
2014-11-08 05:49:14 +07:00
Playtester
04a1173f7d Plant damage, Land Mine, minor fixes and improvements
- Fixed up the damage code in regards of damage against plants (bugreport:9380)
  * Rewrote DAMAGE_DIV_FIX so that it rounds damage down when number of hits is negative (damage split on hits)
  * Created a function battle_apply_div_fix that does not only call DAMAGE_DIV_FIX but also makes sure that damage can only become 0 when the custom config setting skill_min_damage is not set for the current skill type
  * skill_min_damage is now 0 by default (official: all types can fail against plants as long as skills have negative number of hits), if set, all skills will deal as much damage as hits
  * Restructured and renamed function now known as "is_infinite_defense" that will work for all 3 damage types and returns if damage is infinite for the current situation, it will now also properly consider all "MD_IGNORE" modes
  * Fixed the order of processing of all 3 skill types in regards of plant damage: first all calculations are done, then plant damage is applied and then DAMAGE_DIV_FIX is applied
  * Sonic Blow and Rapid Shower are now skills with negative number of hits (i.e. they can't hit plants officially)
  * Traps can no longer ignore plant mode (only way to damage plant more is via status changes)
  * Final Strike is now able to hit plants (deals 1 HP damage)
  * When left-hand-wielding, you will now always deal 2 damage to plants per attack, regardless of whether double attack triggers or you don't even have a weapon in the right hand
  * There will no longer be backhand damage to plants (Katar)
- Land Mine is now a single target skill, the trap still triggers in a 3x3 area, but will only hit the first target that touches it (issue:99)
- Changed the "Don't return reflect damage" flag from 0x1000 to 0x1000000 as apparently the other flag was already used; updated function description so it's easier to see
- Improved SC_SIGHTBLASTER structure slightly
- Typo fixes and description improvements
2014-11-07 23:28:54 +01:00
Cydh Ramdh
c10c05ab61 * Fixed typo in script for RWC2010_Indonesia (18509)
* Changed `mr` values to use constantan value
* Added check for IT_SHADOWGEAR's script restriction before executing it

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-11-06 20:17:49 +07:00
icxbb-xx
d62d89d59c Fixed Bug.
- Snap dodge bug (bugreport:3510)(Hercules 76662cc)
2014-11-05 00:14:57 +07:00
icxbb-xx
4f09d08226 Follow-up to a4f2bdb 2014-11-03 07:08:07 +07:00
Playtester
9d50c57e8a No cell stacking implemented (official version) (bugreport:9378)
- Split config cell_stack_limit into custom_cell_stack_limit (previous feature) and official_cell_stack_limit (see below)
- Expanded map_count_oncell by a flag parameter, currently only one flag is supported: only count standing units (needed for official cell stack feature)
- Added a new function map_closest_freecell that will return the closest free cell using the same order that official servers use
- Monsters will now actively search for a free cell when starting to walk randomly and when unlocking target
- When any unit finishes walking (regularly) and is not on a free cell, it will now actively search for a free cell
- Step actions will be delayed until a suitable cell was found, they will even be executed when the player walked slightly out of attack range
2014-11-02 18:56:06 +01:00
icxbb-xx
a4f2bdb2c1 add new scriptcommand
- dispcolor or displaymessage
displaymessage("<message>"{,<color>{,<Account ID>}})
now you can send message with color to player
Hex color see more : http://www.colorschemer.com/online.html
2014-11-02 15:06:47 +07:00
Playtester
0d8a7c0313 Fixed NPC_STONESKIN, NPC_ANTIMAGIC, NPC_MAGICMIRROR and Autocast on magic hit
- Fixed NPC_STONESKIN, NPC_ANTIMAGIC, NPC_MAGICMIRROR (bugreport:6118, bugreport:9375)
  * Using the skills will now be 100% successful (can't be resisted)
  * Fixed skills not working for players (e.g. Ulfhedinn, Mithril Magic Cape, Platinum Shield)
  * Fixed level 5 and 10 not working at all
  * NPC_STONESKIN and NPC_ANTIMAGIC will no longer change DEF/MDEF, instead they will increase/reduce physical/magical damage percentually, this IS official behavior
- Fixed "Autocast on magic hit" having its chance halved (bugreport:9377)
2014-11-01 18:10:38 +01:00