13056 Commits

Author SHA1 Message Date
marha
f34deb0ebc Fixing upgrade 2014 06 12 losing data when having negative data (e.g. char ids) in card slots. Easiest way to reproduce is on a Wedding Ring. 2015-11-10 00:19:57 +01:00
rAthenaAPI
789a54cc17 SQL synchronization
[ci skip]
2015-11-10 00:17:51 +01:00
Lemongrass3110
be22f35e4e Follow up to 21603f0
Fixed a syntax error and seperated valkyrie circlet into item_db and item_combo_db with it.
2015-11-10 00:16:54 +01:00
Lemongrass3110
085cd98bfd Merge pull request #748 from rathena/feature/pincode_extension
Feature/pincode extension
2015-11-09 23:47:18 +01:00
Lemongrass3110
5b5fb1afa3 Added missing maps to pre-re
Fixes #747
2015-11-09 23:31:46 +01:00
aleos89
2afaac82e9 Bug Fixes
* Fixes #729 - Fixes Silent Breeze not casting correctly.
* Fixes #746 - Updated the list of skills that can be copied by Reproduce. Added: Dark Claw, Tetra Vortex, Summon Fire/Lightning/Water/Water/Stone, Magma Eruption, Illusion Doping, and Rapid Throw.
2015-11-09 17:09:37 -05:00
aleos89
10fcd20fa8 Renewal Skill Cast Formula Fixes
* Resolves several issues with renewal cast times. Includes fixes for for items and skills that grant additions/reductions to cast time.
* Fixes #549
* Fixes #592
* Fixes #657
-- Thanks to @exneval.
2015-11-09 11:03:29 -05:00
nanakiwurtz
21603f0f69 Item DB Update
* Thanks to @Badarosk0

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-11-08 22:40:57 +07:00
rAthenaAPI
7e04987235 SQL synchronization
[ci skip]
2015-11-08 11:30:46 +01:00
Lemongrass3110
3e64038099 Fixed #745
Just copied the required items over from renewal.
2015-11-08 11:28:52 +01:00
aleos89
a7b8fd4a5d Bug Fixes
* Fixes #696 - Fixed an issue with ammo type fail message for bows and guns.
* Fixes #708 - Fixed Neutral Barrier and Stealth Field not staying with the player through warp portals on the same map. Thanks to @exneval.
* Added the new Pile Bunker S/P/T items to the Pile Bunker skill equipment check.
* Updated Exeed Break damage formula.
* Added a check for skill_require_db parsing to skip requirements on invalid item IDs.
2015-11-06 10:55:00 -05:00
aleos89
bda5b80ae6 Skill Cast Time Updates
* Follow up to df35f33.
* Updated times for 3rd class extended skills.
* Merged 3rd class and on changes to pre-renewal.
2015-11-05 09:22:46 -05:00
nanakiwurtz
c262cb9b01 Fixed #740
* Thanks to @ernestfegarido

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-11-05 17:39:52 +07:00
Cydh Ramdh
c73ebec481 Corrected scripts for items following official scripts.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-11-02 10:53:53 +07:00
Cydh Ramdh
d996590cfb Romved duplicate lines in .gitignore. Thank @nanakiwurtz
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-11-01 10:06:54 +07:00
lighta
07ba18d01f Follow up for cppcheck cleanup merge.
Revert some part
2015-10-30 04:14:15 -04:00
lighta
ba9ad77742 Merge branch 'cleanup/cppcheck' 2015-10-30 02:50:40 -04:00
lighta
46d417a458 merge master into cppcheck 2015-10-30 02:48:40 -04:00
nanakiwurtz
a1963b76aa Follow up to 8ac1e744
* Changed the 'Last Updated' date for item_bonus.txt (Thanks to @lighta)

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-30 12:17:13 +07:00
lighta
05aa1ffc8c Type enforcement
Change the type of
father_id,mother_id,child_id
mail.zeny,mail.send_id,mail.dest_id
from int to uint32, as this is their DB representation anyway and most
of those are mapped to char_id which is uint32.
This should remove the need of implicite cast and improve security
overall.
2015-10-29 23:43:48 -04:00
aleos89
b385fd048a Follow up to c48133c and d8d5489
* Fixes #616 - Status effects that damage monsters will now give players their EXP.
2015-10-29 18:09:36 -04:00
aleos89
dc533fe2e1 Core Cleanup
* Removed a useless parameter from elemental_delete().
2015-10-29 17:45:30 -04:00
Cydh Ramdh
ae98019014 Update some NPC constants.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-29 12:16:10 +07:00
nanakiwurtz
8ac1e74400 Follow up to efea117f
* Made changes to bonus3 bAddEff, bonus4 bAddEff, bonus3 bAddEffWhenHit, bonus4 bAddEffOnSkill as well

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-29 10:20:35 +07:00
nanakiwurtz
efea117f91 Fixed #706
Changed y to atf to avoid confusion on 'bonus4 bAddEffWhenHit' & 'bonus5 bAddEffOnSkill' (Thanks to @joelolopez)

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-29 10:15:03 +07:00
Nova
11e5a59663 Follow up 09e91d4, fixed errors and warnings in MSVS 2015-10-27 00:13:10 -07:00
Nova
09e91d4cd4 Warg Dash Bug Fix
Fixes a bug where you're able to spam Warg Dash while next to a mob
based on your ASPD.
Tested the skill live on iRO, and the skill does not cast if a unit is
right in front of your facing direction.
2015-10-26 10:50:39 -07:00
Aleos
286f251e2e Merge pull request #668 from Vennren/master
Fixed a possible syntax error for roulette tables
* Thanks to @Vennren.
2015-10-26 12:34:05 -04:00
aleos89
ea497b2938 Partial revert of ce7aacb
* Added job, skill, and item stat bonuses back into base status.
* Adjusted specific skills that used base stats to use info stored in mmo_charstatus.
* Fixes #713 - Resolved issue with atcommand 'speed' not adjusting player's movement speed.
2015-10-23 13:03:23 -04:00
nanakiwurtz
581c2368fe Fixed #711
* Thanks to @ernestfegarido

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-23 08:47:21 +07:00
aleos89
da94f41908 Bug Fixes
* Follow up to ce7aacb - Adjusted status_calc_bl_main() to calculate player status data through battle_status, not base_status.
* Fixes #709 - Corrected a missed variable type conversion from 82467e1. Thanks to @theultramage.
2015-10-22 07:26:23 -04:00
Cydh Ramdh
5d5aa78b56 Merge pull request #710 from rathena/hotfix/followup-214ff17c
Follow up 214ff17c1955aaaab34c88faea0dedb97600660e, fixed errors and warnings in MSVS
2015-10-22 08:55:29 +07:00
Cydh Ramdh
055f6d86a2 Follow up 214ff17c1955aaaab34c88faea0dedb97600660e, fixed errors and warnings in MSVS
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-21 20:29:46 +07:00
lighta
214ff17c19 Replace macro max and min, by some inline functions :
-To avoid having long operation repeated twice, peoples shouldn'tuse long operation into does macro but they do so...
-To avoid double increment or thing like such.
-Yes this involve some implicite cast sometime, but that still better then redo 10 dereference...
2015-10-21 04:12:01 -04:00
lighta
b480cb3d47 Valkyrie example
Move valkyrie sample config into conf/
Change path for relative path so that it could be applied for all.
tested with : 'valkyrie -f valkyrie_sample.cfg'
Change include in common, true that complicate move for those file but
will facilitate the parsing for some ide.
2015-10-21 01:59:32 -04:00
Nova
edafd267d8 Merge pull request #661 from RagnarokNova/patch-7
Magma Eruption Status Effects
2015-10-20 11:27:35 -07:00
Lemongrass3110
5a49b70ba4 Fixed an issue where the memory leak log name was null on Windows. 2015-10-20 20:25:15 +02:00
Cydh Ramdh
030c4c58c1 Fixed #698, it's if. The check as option not as priority.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-20 19:54:36 +07:00
Nova
fd5e796487 Updated IG_Advanced_Weapons_Box (Used http://www.divine-pride.net/database/item/12623/high-weapon-box and Hercules as reference) 2015-10-20 00:14:34 -07:00
aleos89
66fbcfe49c Follow up to ce7aacb
* Fixed some compile errors/warnings reported in Travis.
2015-10-19 14:43:48 -04:00
aleos89
ce7aacb9a4 Base Status Stats Fix
* Fixes #562 - Fixes Crystallization not taking base VIT into account correctly.
* Confirmed on Aegis that Base Status Stats are NOT affected by job, skill, or item bonuses. These bonuses are stored in Battle Status.
2015-10-19 14:28:06 -04:00
nanakiwurtz
b758f39882 Follow up to 8952412d
* Added additional item script for 5967 + 4163 combo set (Thanks to @Lemongrass3110)

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-19 15:39:31 +07:00
nanakiwurtz
b6187aa9b3 Fixed #695
* Thanks to @ernestfegarido

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-18 22:25:52 +07:00
nanakiwurtz
8952412d07 Follow up to 587da10
Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-18 22:00:46 +07:00
Cydh Ramdh
587da1048d Item DB Update
* Added items, packages, and combos from idRO patch 2015-10-07 and 2015-10-15.
* There are some WoE TE items. (just bad, we don't have WoE TE implemented yet)

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-18 16:38:08 +07:00
Cydh Ramdh
573c7dc3c5 * Fixed #694, Skill cooldown bonus overflow in short variable. Thank @julia40124009
* Fixed #691, Glass_Of_Illusion (14538) gave wrong value. Thank @admkakaroto

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-18 09:43:26 +07:00
nanakiwurtz
e0b24fc670 Fixed #683
* Thanks to @Badarosk0

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-10-15 03:23:24 +07:00
Cydh Ramdh
de40271000 * Follow up 2cee5b6ff1bf53c4ae53bc1278b09ae84b8a0a76: gethominfo, getpetinfo, and getmercinfo for type 0 were correct 'to get ID' from database/their unique ID, not as GID.
* Added type for `gethominfo`, `getpetinfo`, and `getmercinfo` to return GID.
* Added `geteleminfo`, to retrieve Elemental ID and GID. The otherinfo can be gained from `getunitdata`

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-14 10:27:31 +07:00
Cydh Ramdh
415aeabdb1 Added safe check for quest's packet length.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-13 07:21:36 +07:00
Cydh Ramdh
80b88b9067 Fixed #673, fixed map-crash by TK_COUNTER. Thank @lordganja
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-12 19:59:12 +07:00