6854 Commits

Author SHA1 Message Date
Cydh Ramdh
e75a83dc99 * Updated buyingstorelist.txt, sync with last kRO update (2014-05-28)
* Fixed map-server crashed when read item_cash_db.txt (bugreport:9003)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-06-01 12:13:16 +07:00
Cydh Ramdh
794c1a8247 Bug fixes & Misc:
-- Map crashed because empty item_combo script (bugreport:8959)
-- Wrong MATK calculation of Distort Crescent/Zangetsu effect (SC_ZANGETSU) (bugreport:8998)
-- Wrong damage reduction of Sera's Pain Killer effect (SC_PAIN_KILLER) (bugreport:8994)
-- Fixed Shape Shift (NC_SHAPESHIFT) wrong requirement (bugreport:9002)
-- @itembound, getitembound usage. Not, now allowed for unspecified bound_type (thank Ceejay Abne! http://rathena.org/board/index.php?showtopic=94726)
-- Change check behavior for skill requirement level-dependent check.
-- Removed NC_REPAIR hardcoded requirement.
-- Moved the required equipped item to 'RequiredEquipment' on skill_require_db.txt.
-- Missing "Option_Ruwach" as contantan.
-- Corrected Chasewalk STR bonus, it's SC_CHASEWALK2, different with SC_INCSTR.
-- Corrected some Rebellion skill's effects.
-- USESKILL_FAIL_MADOGEAR message for failed skill that needs player has Madogear.
-- Changed skill name and description length to 31 chars.
-- Some documentation updates.
-- Follow up 0f2dd7f. (Well, using empty password in import file, won't works, if you want, empty the original conf file. Fix this later, related on 'sscanf' for those files)
-- Follow up 28c90bb, thank @julia40124009
-- Misc. :P

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-31 21:42:44 +07:00
aleos89
7e92017092 Follow up to 6afcdeb to include changes on the character server and SQL update. 2014-05-23 13:38:38 -04:00
aleos89
5ca8f406e4 Follow up to 1d1a58c when using self skills while storage is open. (Hercules 31486a8) 2014-05-23 12:18:27 -04:00
aleos89
c01d9357d6 Guild Bound items are now removed when someone is offline and expelled. (Hercules b5c2a71) 2014-05-23 11:57:46 -04:00
aleos89
6afcdeb613 Cleaned up the Font System to properly save to the character.
Also expanded @itemlist to support costume item types.
2014-05-23 11:48:28 -04:00
Cydh Ramdh
e83d69be57 Follow up 2d53a78:
* Added 'bonus2 bAddItemGroupHealRate' to replace 'bonus2 bAddItemHealRate' for Item Group ID usage. Since MAX_ITEMGROUP is removed, there is no identifier which entry that Item ID or Item Group. Previous check using 'if (type2 < MAX_ITEMGROUP)' (2d53a782fa (diff-08420bab8271f3965304fee42cf4b865L3220))
* bonus2 bAddItemHealRate,iid,n;
* bonus2 bAddItemGroupHealRate,ig,n;

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-23 21:17:01 +07:00
Cydh Ramdh
dc834fb39f Follow up 7f4a7ba
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-23 10:51:56 +07:00
Cydh Ramdh
7f4a7ba26f * Changed itemgroup from array to DBMap
* Removed MAX_ITEMGROUP limit
* Changed player bonus fixed array
* Minor changes

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-23 01:49:49 +07:00
Akkarinage
8371ecf2e5 MAX_ defines clearly aren't my friends. Thanks for pointing this out, Cydh. 2014-05-22 17:38:23 +01:00
aleos89
1d8bec3100 Bug Fixes
* Adjusted Falcon Assault to take arrow elements into effect. (bugreport:7572)
* Cleaned up Self Destruction damage calculation. (bugreport:8941)
* Cleaned up Dragon Breath damage calculation.
* Fixed Millennium Shield, Crush Strike, and Refresh durations. (bugreport:8981)
* Fixed Makibishi area of effect. (bugreport:8963)
* Cleaned up some MOBID_* defines.
2014-05-21 09:54:56 -04:00
aleos89
2732176786 Modified status_calc_* to support multiple options. (Hercules 6f77d07) 2014-05-20 10:41:15 -04:00
aleos89
9faa805da1 Follow up to 577079b to fix compile errors. 2014-05-17 15:03:54 -04:00
aleos89
577079b331 Bug Fixes
* Added missing feature flag for the Auction System. (bugreport:8980) (Hercules 646f7e2)
* Some more clean ups to skills that have a sliding effect. Thanks to exneval.
* Adjusted Flash Combo damage for renewal.
* Moved Explosion Spirits timer and added extra check to avoid map server crashes.
2014-05-17 14:59:59 -04:00
aleos89
e4ab3be344 Bug Fixes
* Fixed a typo in a define. Thanks to exneval.
* Fixed a potential crash with Ankle Snare. (bugreport:8977)
* Fixed a potential crash with Explosion Spirits SP recovery. (bugreport:8978)
* Cleaned up Fire Expansion - Acid, Varetyr Spear, Kunai, Dark Crow, Counter Slash, Taekwon Kicks, Freezing Trap, Weapon ATK Element bonus, and Force of Vanguard damage formulas.
* Added missing Research Fire Earth VIT bonus.
* Fixed some potential issues with ATK calculations. Follow up to 89ef868's battle calculation cleanup. Thanks to exneval.
* Another follow up to 89ef868 to resolve Extremity Fist sliding effect.
* Various clean-ups.
2014-05-16 13:31:03 -04:00
aleos89
b0bc48571b Bug Fixes
* Cleaned up Weapon Research and Cart Revolution bonuses.
* Added missing Hit bonus for Training Axe.
* Removed an extra check for Research Fire Earth.
* Updated Dragonology race bonuses rate for renewal.
* Fixed Knuckle Arrow sliding effect.
* Bows should not get a refine bonus.
2014-05-15 15:03:05 -04:00
aleos89
28af644b90 Follow up to 89ef868 to fix compile issues. 2014-05-15 10:54:04 -04:00
aleos89
89ef868650 Bug Fixes
* Fixed Extremity Fist sliding issue getting players stuck in un-walkable cells. (bugreport:8949)
* Updated Cursed Circle against the target behavior.
* Updated Tinder Breaker snap behavior.
* Fixed Crush Strike to work with Auto Counter. (bugreport:6919)
* Fixed Fire Expansion - Acid skill animation.
* Fixed Spider Web not trapping targets. (bugreport:8958)
* Feint Bomb cannot be used on top of Land Protector.
* Fixed Slow Grace movement speed penalty. (bugreport:8946)
* Updated Camouflage to official effects.
* Fixed Beyond of Warcry decreasing critical rather than increasing.
* Fixed Zephyr flee bonus to be a solid 25 increase.
* Decrease Agi, Quagmire, Slow Grace, and Adoramus are no longer affected by SC_SPEEDUP1.
* Fixed Warg Strike to be a weapon attack type. (bugreport:8917)
* Fixed Explosion Spirits to double SP regen tick rather than halve SP regen rate. (bugreport:8936)
* Fixed Millennium Shield, Crush Strike, and Refresh having their cooldown values in the wrong field. (bugreport:8957)
* Cleaned up the status change table for 3rd class skills applying/removing SCB's that should/shouldn't be calculated.
* Updated Saturday Night Fever to official effects.
* Updated Berserk damage formula for renewal versus pre-renewal.
* Fixed Masquerade - Laziness not reducing movement speed.
* Updated the behavior of Frigg's Song.
* Updated Light of Regen, Xeno Slasher, and Silent Breeze skills.
* Updated several Homunculus S skill cast values.
* Deadly Infect will now only spread for short ranged attacks.
* Abundance and Guillotine Cross Poisons no longer overlap.
* Fixed Upheaval and Cursed Soil not giving their respective Max HP bonuses. (bugreport:8951)
* Fixed Solid Skin not giving DEF bonus.
* Fixed Stealth Field to properly hide players.
* Burning now reduces MDEF and has an icon.
* Updated the way skills that give equipment attack are calculated. Thanks to exneval.
* Updated the official item delay message.
* Cleaned up some other issues/left overs.
2014-05-14 14:35:24 -04:00
lighta
82a1c702dc Upd Makefile
Fix small typo in intif.h, ifndef was being unused.
Upd Makefile to simplify libconfig inclusion
2014-05-03 03:05:58 -04:00
aleos89
66b8b9f62e Fixed an issue with announce script command to properly support bc_blue and bc_woe. (Hercules eb10f35) 2014-04-25 10:07:28 -04:00
aleos89
e8135f8c77 Follow up to 97755d0 to move status message to map_msg.conf. 2014-04-24 15:42:43 -04:00
aleos89
97755d0792 Merge pull request #50 from Baalberith6/master
Fixed vending items not saving with the correct cart ID and not allow players to log back in. Thanks to @Baalberith6.
2014-04-24 15:28:02 -04:00
aleos89
912b644499 Added support for 2013-12-23 client. 2014-04-24 13:15:45 -04:00
aleos89
c046668034 Bug Fixes
* Updated Earth Strain's equipment divest chance to include Base Level and DEX. (bugreport:8922)
* Updated some skill usages on certain maps. (bugreport:8923)
- Masquerade - Ignorance is no longer usable in instances.
- Dimension Door, Chaos Panic, Bloody Lust, and Sling Item are no longer usabled in towns.
* Updated Earth Drive and Shield Press damage formulas.
* Fixed Raigekisai dealing damage too quickly which was causing double damage. (bugreport:8926)
* Electric Shocker, Reverberation, and Poem of Netherworld cannot be knocked back.
* Updated the effect of Poem of Netherworld, Reverberation, Electric Shocker, and Wall of Thorn to official.
* Updated the skill unit layouts for Man Hole, Dimension Door, Chaos Panic, Maelstrom, and Bloody Lust.
* Zephyr will no longer affect Elementals.
* Dragon Breath and Self Destruction will no longer consider VVS and masteries.
* Updated Vellum Weapons item script to official.
* Masquerades cannot be casted on MVPs.
* Unequipping Hovering Booster will remove Hover.
* Fixed a typo in the map_msg.
* Updated the monster mode documentation.
2014-04-24 12:05:22 -04:00
aleos89
c95be2e877 Implemented a flagged items database for item groups and Dead Branch type item checks. Credits to @cydh! 2014-04-22 14:01:14 -04:00
aleos89
f7c09d95fd Bug Fixes
* Spell Fist will now double damage with Double Attack and fixed damage formula. (bugreport:7024)
* Follow up to 06986d6 to fix Fire Expansion casting the wrong Acid Demonstration skill (magic type). Thanks to @Traxis.
* Fixed Rebound not removing the Decrease Agility status icon. (bugreport:8910)
* Fixed Full Throttle SP reduction rate.
* Gates of Hell now uses weapon element and is forced neutral for the final element. (bugreport:8875)
* Fixed Auto Counter to work with Crush Strike. (bugreport:6919)
* Fixed Masquerade-Groomy renewal ASPD penalty.
* Updated Acceleration, Hovering, Self Destruction, Shapeshift, Emergency Cool, Magnetic Field, Neutral Barrier, Stealth Field, and Repair skill item requirements to only check the player's inventory rather than equipment list. (bugreport:8911)
* Fixed Magnetic Field to stop players from walking in non-PvP maps. (bugreport:8911)
* Charms will now be removed when another Charm element is used. (bugreport:8914)
* Crazy Weed now destroys Man Hole and Dimensional Door.
* Man Hole and Hells Plant are able to be casted on top of players. (bugreport:8918)
* Items are now usable while stuck in Man Hole. (bugreport:8918)
* Fixed Extremity Fist naturally regaining SP during the 5 minute cooldown. (bugreport:8920)
* Fixed an issue with Extremity Fist position updating.
* Fixed Issen's damage calculation order of magnitude. Thanks to @chriser-.
* Updated the SCS_NOCAST table.
2014-04-21 14:49:39 -04:00
aleos89
d1e04fa3c1 Follow up to 1d1a58c to revert some Reading Spellbook conversions. 2014-04-16 13:42:48 -04:00
aleos89
1d1a58cdcb Bug Fixes
* Removed unused guild aura leftovers and fixed some other issues with setting the guild aura. (bugreport:8892)
* Fixed Fire Expansion Acid to be a magic type attack. Thanks to exneval.
* Cleaned up some remaining issues with Issen. (bugreport:8905)
* 16th Night (Izayoi) should remove fixed cast time from all skills.
* Circle of Nature is now part of Group B songs.
* Updated Reading Spell Book spell memorization to official.
* Updated homunculus skill cooldowns.
* Added missing Holy element bonus for Hesperus Lit.
* Fixed Coluseo Heal and Praefatio not giving a party bonus. (bugreport:8904)
* Fixed the status icon for ALL_RIDING not being displayed at login.
* Adjusted the notice display order when players login. (Hercules df1952d)
* Self skills can now be used while storage is open. (Hercules 6f6a6b3)
* Cleaned up SC_NOCHAT/Manner system. (Hercules 94ef1ee)
2014-04-16 11:06:09 -04:00
aleos89
06986d6540 Bug Fixes
* Updated Fire Expansion to official effects. (bugreport:8893)
* Updated Illusion Doping area of effect and hit reduction. (bugreport:8560)
* Cleaned up Full Throttle.
-- Thanks to exneval.
2014-04-13 15:46:49 -04:00
aleos89
d3d34aa5d2 Bug Fixes
* Follow up to 2fe8140 to fix quest_db.txt not being imported anymore. (bugreport:8891)
* Fixed Epiclesis to only run every 3 seconds and added animation display for healing HP and SP. (bugreport:8890)
2014-04-11 11:15:10 -04:00
aleos89
0bbfdfbd85 Bug Fixes
* Fixed Gentle Touch - Energy Gain not gaining spheres. (bugreport:8882)
* Adjusted Full Throttle's cooldown to be 30 minutes. (bugreport:8887)
* Warmth of the Sun/Moon/Stars are now placeable on Land Protector. (bugreport:175)
* Fixed Mechanic's Axe Mastery to give (4 * skill level) ATK bonus for Mace weapons.
* Cleaned up Cart Boost and Camouflage bonus damage.
* Fixed Envenom pre-renewal bonus damage missing. (bugreport:7953)
* Fixed Eska not reducing movement speed. (bugreport:2792)
* Fixed Marsh of Abyss reducing movement speed below 50%. (bugreport:7424)
2014-04-10 11:15:30 -04:00
aleos89
35d838c9d2 Fixed some issues from the CppCheck report. 2014-04-09 22:24:51 -04:00
aleos89
e07a11186d Updated clif_message enum and appropriate clif_msg* functions. 2014-04-09 15:10:58 -04:00
aleos89
81ca299d91 Bug Fixes
* Fixed Overbrand swing damage ground placement. (bugreport:8856)
* Fixed Wug Dash not getting ATK bonus from Tooth of Wug.
* Cleaned up Gates of Hell damage formula.
* Corrected Hell Gate skill define to be passive.
* Added missing immobilization duration reduction for Poem of Netherworld and blocked it from working on MVP. (bugreport:8877)
* Cleaned up NPC_RUN to show e_hlp and not get stuck in a follow state. (bugreport:8875)
* Fixed item bonus DefRatioAtkEle/DefRatioAtkRaceDefRatioAtkClass not working for left handed weapons. (bugreport:8495, bugreport:8808, bugreport:8847)
* Fixed SubSize/SubRace/SubClass stacking to create 100+% immunity. Thanks to @cydh. (bugreport:8827, bugreport:8879)
* Small cleanup to clif_parse_StatusUp.
* Fixed Sling Item to copy the source skill ID and not the dummy ID.
* Fixed spirit spheres not giving ATK bonus. (bugreport:8130, bugreport:8285, bugreport:8686)
* Acid Demonstration is now forced to neutral in renewal.
* Follow up to e2d2494 to fix cooldown for Unlimit.
* Follow up to e2d2494 to clean up some compile warnings.
* Follow up to da0da73 to fix SC_ITEMSCRIPT to only use an icon if val2 is not empty.
2014-04-09 10:10:32 -04:00
Euphy
314ee3918b Added UTF-8 BOM detection for NPC scripts. (Hercules 694d32a)
Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-04-07 20:20:47 -04:00
Cydh Ramdh
e54a1d47df * Follow up e2d2494
- Removed hardcodes SI_ for SC_ITEMSCRIPT
- Changed some item scripts that use SC_ITEMSCRIPT to sc_start2, added val2 as SI_
- Revert some hardcodes ITEMID_
* Changed spiritball limit to MAX_SPIRITBALL (Hercules partial merge)
* Updated .sql item_db files

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-04-05 17:19:44 +07:00
aleos89
3269d0f9af Follow up to 26afd76 to fix Elemental Shield. (bugreport:8872) 2014-04-04 19:13:43 -04:00
aleos89
e2d2494e13 Bug Fixes
* Fixed Main Frame Restructure not giving DEF bonus when wearing Madogear. (bugreport:8863)
* Updated some more damage formulas for Kagerou skills.
* Fixed critical damage bonus from Monster Transformation system.
* Fixed Fire Trap and Ice Trap Burning/Freezing chance.
* Cleaned up the visual effects for Ranger traps.
* Odins Power now decreases DEF/MDEF by 40 at level 2. (bugreport:8869)
* Added skill define for Overbrand's Plus Attack.
* Fixed an issue with Overbrand's pierce damage placement. (bugreport:8856)
* Fixed Unlimit not updating DEF/MDEF on players and increased the cooldown to 5 minutes. (bugreport:8870)
* Few status icon updates.
* Fixed two compile warnings when the VIP system is enabled.
2014-04-04 15:37:29 -04:00
Cydh Ramdh
c8c40a1377 Follow up 0081e25, 8a723ee (msg_conf stuffs)
- Revert MAP_MAX_MSG to 1500
- Moved some messages to empty spaces
- Added warning message if msg_number is invalid when msg_conf files are being read
- And minor stuffs

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-04-04 22:28:11 +07:00
Akkarinage
8a723ee496 Modified map server msg limit to accommodate new @costume messages.
Added additional removal checks when taking off costumes. Fixes bugreport:8862.
p.s. special thanks to aleos for pointing me in the right direction!
2014-04-04 14:48:40 +01:00
aleos89
d876272283 Bug Fixes
* Cleaned up the card fix calculations once more. (bugreport:8848)
* Fixed Kaite pre-renewal effect. (bugreport:6415)
* Fixed a possible crash from Elemental Action.
* Cleaned up the costume atcommand messages.
* Fixed a few issues from the CppCheck report.
2014-04-03 14:38:58 -04:00
aleos89
0081e25922 Costume System cleanup.
- Cleaned up overall system to work like officials.
- Added costume atcommand to easily enable/disable costumes.
2014-04-03 11:26:38 -04:00
aleos89
2fe8140f96 Quest Log system improvement. (Hercules 6f55c00)
- Improved memory usage of the quest log system. (saves up to 75kB per online character).
- Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck - the issues were caused by a de-synchronization between the two parallel questlog arrays in map_session_data.
- Added some code documentation.
- Thanks to @shennetsind and @MishimaHaruna.
2014-04-03 09:39:34 -04:00
aleos89
cc59315323 Fixed some 3rd class skill effects not displaying properly. (bugreport:8144, 8804) (Hercules 8cc9012) 2014-04-03 08:48:49 -04:00
aleos89
44ddd96365 Bug Fixes
* Updated Poem of Braggi cast time reduction bonus from Musical Lessons to only be 1% per level.
* Updated Don't Forget Me ASPD decrease and movement speed formulas.
* Updated many renewal and some pre-renewal status changes that effect ASPD to official.
* Cleaned up some various status change formulas.
2014-04-02 15:23:35 -04:00
aleos89
e86471bb0b Fixed npcshopattach not working on all Shop types. (bugreport:8850) 2014-04-02 13:19:39 -04:00
aleos89
c4a41c4049 Fixed a compile error for pre-renewal. (bugreport:8855) 2014-04-02 08:27:42 -04:00
aleos89
744eb0e532 Follow up to 0fed97c to include a warning when skill_unit_layout/skill_nounit_layout has overflowed to prevent future issues. 2014-04-01 15:08:25 -04:00
aleos89
9b098e109e Merge pull request #62 from cydh/master
Added a few new script commands thanks to @cydh!
- *countitem:
-- Added cartcountitem
-- Added storagecountitem
-- Added cartcountitem2
-- Added storagecountitem2
-- Added a new param 'AccountID'
- *delitem:
-- Added cartdelitem
-- Added storagedelitem
-- Added cartdelitem2
-- Added storagedelitem2
2014-04-01 14:49:45 -04:00
aleos89
0fed97c1d9 Bug Fixes
* Follow up to 6e795af expiration timer passing wrong time value. Thanks to @MrKeiKun.
* Follow up to 26afd76 to force players to use skill_sit before pc_setsit to invoke pc_stop_walking and pc_stop_attack first.
* Follow up to 26afd76 to revert change on Extremity Fist status icon.
* Fixed some Gentle Touch - Revitalize typos.
* Fixed some Gentle Touch - Energy Gain typos. (bugreport:8846)
* Corrected Explosion Spirits effect for renewal. (bugreport:8842)
* Rebound status from Full Throttle will now disable HP and SP regeneration.
* Fixed Mainframe Restructure not giving DEF bonus. (bugreport:8840)
* Added Hiding and Sight to the list of skills not usable while riding Mado using _INF3 and removed hardcoded checks.
* Increased the max skill unit layout to accommodate the addition of Fire Rain. (bugreport:8775)
* Fixed Unlimit to not work with Warg skills and sets DEF/MDEF to 1 per Ziu's tests.
* Fixed damage and life (hits) for Wall of Thorn.
* Added an extra check for Crescent Elbow to check for short range and to handle knockback with the autospell skill.
2014-04-01 14:26:37 -04:00