8070 Commits

Author SHA1 Message Date
Cydh Ramdh
2bb69a3c54 Follow up 039e1b65a3cae96d80b220f078814cac72846737. Fixed #644, fixed #643. Thank @ernestfegarido, @Dark8008
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-18 17:45:45 +07:00
aleos89
039e1b65a3 Quest System Update
* Added support for the new quests that grant item drops from mobs.
2015-09-17 13:24:42 -04:00
Cydh Ramdh
2fc20c460d Follow up f669072e854ae5b67606788b81e16a5f6b92d236 and fa40773e8222cb5d6ac66782f8136b9833c8760d
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-16 20:00:49 +07:00
Cydh Ramdh
f669072e85 Fixed #638
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-16 16:06:09 +07:00
Cydh Ramdh
631747bb07 * Fixed memleak when use @set command for string type variable.
* Removed `0x2715` and `logchrif_parse_updmail`, not being used that was duplicated by `logchrif_parse_reqchangemail` (`0x2722`).
* Changed packet header `0x2736` to `0x2b13` of `chrif_update_ip` from map-server to char-server. That was ambiguous with `0x2736` of `logchrif_parse_updcharip` that being used by char-server to login-server.
* Changed packet header `0x3804` to `0x2726`, the one that being used to send back global account reg from login-server to char-server. That was ambiguous with `0x3804` that being used by char-server (was inter actually) to map-server.
* Some indent clean up as result from char & login server refactor.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-14 20:17:12 +07:00
Napster
ecd0ccd652 Merge branch 'master' of https://github.com/rathena/rathena 2015-09-13 08:49:48 +07:00
Napster
e56f329d5d Follow up fa40773 :
* Revert change some code
2015-09-13 08:48:53 +07:00
Cydh Ramdh
b0f4595688 * Updated doc/packet_interserv.txt
* Added `skill_dummy2skill_id` in `battle_skill_damage`

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-13 08:10:59 +07:00
Napster
93666ce79a Follow up fa40773 :
* Fixed compile warning.
2015-09-12 22:40:43 +07:00
Napster
fa40773e82 * Fixed #630 Cart is not showing. 2015-09-12 21:51:03 +07:00
Cydh Ramdh
d301d1ecb3 * Fixed #633 compile warning. Thank @tmav94
* Move out `enum chrif_req_op` to socket.h so can be used too for `char_mapif.c`

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-12 10:18:32 +07:00
Cydh Ramdh
e933db556f Checked some preprocessors on mmo.h and core.h
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-09 21:05:07 +07:00
Cydh Ramdh
9cee995f3f Fixed variable type mismatch for autotraders
* `struct s_autotrader::id` was `uint16`, should be `uint32`.
* `struct s_autotrade_entry::cartinventory_id` was `uint16`, should be `uint32`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-08 21:52:42 +07:00
Cydh Ramdh
fc2c6a34ff * Fixed #625, autocast state wasn't reseted on failed. Thank @Jeybla.
* A little check for timer id on map_clearflooritem.
* A little clean up for RL_FALLEN_ANGEL's flow.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-07 21:42:56 +07:00
Cydh Ramdh
997836897f Follow up 43068e1777d4b75baa3f36e1c5ff13ca5289e0f4:
* Eff_Crystalize on Sropho_Card (4522) has defined duration.
* Bonus added:
  * `bonus4 bAddEff,eff,n,y,t;`
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when attacking
    * Just like `bonus3 bAddEff,eff,n,y;` but with user-defined duration;
  * `bonus4 bAddEffWhenHit,eff,n,y,t;`
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when being hit by physical damage
    * Just like `bonus3 bAddEffWhenHit,eff,n,y;` but with user-defined duration;
  * bonus5 bAddEffOnSkill,sk,eff,n,y,t;
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when using skill sk
    * Just like `bonus4 bAddEffOnSkill,sk,eff,n,y;` but with user-defined duration;

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-05 08:19:23 +07:00
Cydh Ramdh
31505d1423 * Fixed #607:
* Added array variable option in 3rd param of `getguildmember` and `getpartymember`, so the script will returns the result in reserved array instead using temporary global variable.
  * Also, the script returns the member found directly.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-04 00:32:38 +07:00
aleos89
df35f33480 Renewal Skill Cast Time Updates
* Updated a fair amount of skill cast times to official.
* Cold Slower will only give Freezing if the target wasn't given Frozen.
* Sound of Destruction will now Stun targets if a Performance/Chorus is removed for 5 seconds.
* Updated the Burning (15 seconds), Freezing (40 seconds), Bleeding (120 seconds), and Stun (5 seconds) durations for Tetra Vortex.
* Xeno Slasher will only cause Bleeding at SkillLevel%.
* Corrected a few issues with Reading Spell Book storage.
* Corrected Fire Walk and Electric Walk to only last for 12 seconds in a cell and the skill's duration to last for 30 seconds.
2015-09-03 12:46:25 -04:00
Cydh Ramdh
b5f2f0ae8f * Fixed #610, PR_IMPOSITIO: Lower levels of Impositio Manus will overwrite higher levels. For example, someone with level 5 IM activated will have +25 ATK from the skill, but if level 1 IM were used on them their ATK would drop to only +5. Therefore, this skill can be used offensively.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-03 23:09:13 +07:00
Cydh Ramdh
4a55439550 * Typo in const.txt for SC with ID 608, SC_HASTEATTACK_CASH -> SC_ATTHASTE_CASH.
* Move 'dummy' skill lookup to `skill_dummy2skill_id` so can be used for item bonus for revelant skill.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-02 23:02:13 +07:00
aleos89
ebaefc1476 Bug Fix
* Fixes #615 - Fixed script command 'query_sql' not returning any results.
2015-09-02 10:32:00 -04:00
Aleos
6295c77d39 Merge pull request #457 from rathena/feature/script_engine_upgrade
Script Engine Upgrade
* More information here: https://rathena.org/board/topic/102946-script-engine-upgrade/
2015-08-31 14:26:15 -04:00
aleos89
3452b931b9 Small Changes
* Renamed SQL upgrade file.
* Fixed a buffer overflow in 'set' atcommand.
2015-08-31 14:15:30 -04:00
aleos89
04d2ab7d1c Partial revert of eb0a79f
* Copying skill issue was previously fixed in c4da965.
2015-08-31 10:21:19 -04:00
aleos89
eb0a79f1bf Bug Fixes
* Fixes #587 - Corrected Amistr Defence to properly calculate VIT for renewal and DEF for pre-renewal.
* Fixes #588 - Fixed skills not being properly removed when being copied by Plagiarism or Reproduce.
* Fixes #589 - Blessing no longer gives stat bonuses when Curse is active.
* Fixes #599 - Fixed a possible crash by Praefatio.
* Fixes #601 - Exceed Break now cancels when switching weapons and is properly removed on misses.
2015-08-28 15:05:24 -04:00
Napster
e444270b0a Follow up to 53868d5
* Fixed #600, Hotkey Rotate Packet Implemented, Thank You @dastgir

Credits : Hercules 2b4b33b06a
2015-08-28 16:32:23 +07:00
Cydh Ramdh
c4da965ee6 Item DB Updates
* Added items from idRO patch 19/8

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-26 12:19:49 +07:00
aleos89
b8f6e16f9d Follow up to 9738c82
* Fixed some more memory leaks.
* Added a few checks that were left out/removed by mistake.
2015-08-25 13:23:23 -04:00
aleos89
9738c825cc Follow up to f53916e
* Fixed remaining memory leak.
* Cleaned up and optimized a few more ERS allocations.
2015-08-25 10:31:38 -04:00
Napster
53868d5850 Another follow up 3d9c6e7
* Added 'missing' packets for 2014-10-22, open roulette windows by short cut (ctrl+F12)
2015-08-24 09:51:29 +07:00
aleos89
f53916e060 Script Engine Fixes
* Cleaned up db_vdestroy errors at server shutdown.
* Expanded the ERS system. Thanks to Hercules.
* Added ERS to the database trees to speed up iterator memory allocation. Thanks to Hercules.
2015-08-21 15:16:52 -04:00
aleos89
3fbac9c8e4 Bug Fixes
* Fixes #586 - Resolved some compile warnings.
* Fixes #584 - Cleaned up the success rate and duration for Sling bombs.
- Banana Bomb now reduces LUK by 75.
- Throwing Cure Free now removes Poison, Orcish, Change Undead, Blind, Confusion, Deadly Poison, and heals a static 500 HP.
- Updated pre-renewal Genetic items to match renewal.
2015-08-21 10:45:46 -04:00
Cydh Ramdh
0574b22902 Fixed #583, some correction on skill_unit_group X skill_unit usage. Thank @theultramage
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-19 17:08:27 +07:00
Cydh Ramdh
2e4b499d5c Fixed negative fixed cast time should never reduce cast time. Thank @reigneil
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-18 23:53:23 +07:00
Cydh Ramdh
feec60e8c8 Bug Fixes:
* Fixed some Manhole skill related:
  * Shouldn't be removed by Crazy Weed, Fixed #580
  * Hell's Plant should ignores target under Manhole effect, Fixed #566.
* Fixed #536, Neutral Barrier shouldn't miss magic attack and ranged attack that ignores flee.
* Fixed #522, Change Material always check the first produce line that matches the item/product requested. Also removed some reduntant checks.
* Fixed #568, Gentletouch Cure shouldn't heal Emperium and BG's Barricades.
* (Attempt to) Fixed #533 and fixed #212, Ground Drift damage calculation.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-18 22:11:41 +07:00
aleos89
01a93723c9 Follow Ups
* Follow up to d95f5d2 - Fixes an issue with parenthesis. Thanks to @cydh.
* Follow up to 3c92075 - Fixes a potential divide by zero. Thanks to @theultramage.
2015-08-18 10:59:01 -04:00
aleos89
d95f5d2db7 Bug Fixes
* Fixes #447 - Added script command 'unitblockmove' to be used with OnTouch and Unit Commands.
* Fixes #448 - Leech End will no longer get a player stuck in stand/sit modes.
* Fixes #503 - Added script command 'ignoretimeout' which disables the SECURE_NPCTIMEOUT of a specific script.
* Fixes #521 - Pre-renewal Shield Chain should always be Neutral damage.
* Fixes #532 - Fixed an issue with the 'item_check' config not saving the unique ID when enabled.
* Fixes #537 - Arms Cannon is now a single unit target skill.
* Fixes #541 - Cleaned up Ignition Break damage formula.
* Fixes #543 and Fixes #552 - Cleaned up Reverberation to match official. Now splits damage among targets.
* Fixes #546 - Updated Randomize Spell to the latest official skill list and rates.
* Fixes #547 - Escape is now a self skill and can use normal Traps if no Alloy Traps are available.
* Fixes #551 - Great Echo and Sound of Destruction can now blocked by Pneuma.
* Fixes #556 - Adjusted Arrullo, Deep Sleep Lullaby, Netherworld, and Voice of Siren duration formulas to properly account base/job levels.
* Fixes #561 - Pre-renewal Tiger Cannon now properly removes HP when casting skill.
* Fixes #576 - Shield Spell, Exceed Break, Overbrand, Moon Slasher, Piety, Earth Drive, and Hesperuslit no longer have fixed cast time.
* Cleaned up Shadow Formation SP Drain formula to be 11-skill_lv per second.
* Sound of Destruction is now a placement skill type.
* Updated variable cast time for Windmill Rush from 2 seconds to 1 second.
2015-08-17 14:13:22 -04:00
icxbb-xx
88cfff01e6 Follow up to 58c2b77
* Fixed #484,Client Crashing 2014-10-22, thank you @gengstergile, @limitro
* small fix script command
2015-08-12 22:24:25 +07:00
Cydh Ramdh
c0e4b06005 Implemented 'Broadcast Obtain Special Item'
* Added flag &16 to add manually special item that will be broadcasted if: Dropped by monster -> player pick it up. Added items with this flag:
  * Gold_Key77 (7782)
  * Silver_Key77 (7783)
* Be used also to broadcast item in package/group with flag 'isAnnounced', replaced intif_broadcast().
* The message is using msgstringtable.txt on client side, make sure your translation is not messy.
* Credits:
  * fcba8a2161
  * 2761bb0af9

* Misc updates: Fixed job and class for items:
  * Sealed_Gloom_Under_Night_Gachapon (14696)
  * Sealed_General_Egnigem_Cenia_Scroll (14739)
  * Sealed_Vesper_Scroll (14740)
  * Midgard_Celebration_Lucky_Egg (14741)
  * Hero_Midgard_Egg (14753)
  * Safe_To_Smelting_Scroll (14758)
  * Limited_Edition_JOB_Battle_Manual (14765)
  * Rise_Midgard_Lucky_Egg (17494)
  * Lucky_Silvervine_Fruit_Box_III10 (17495)
  * Lucky_Silvervine_Fruit_Box_III110 (17496)
  * Epic_Heroes_Scroll (17519)
  * Majestic_Lucky_Egg (17526)

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-12 00:43:04 +07:00
Cydh Ramdh
e1b658e462 * Item GUID Updates:
* Removed `ENABLE_ITEM_GUID` from src/config/core.h, after long time introduction it's worth to be enabled by default. Just remove all items with GUID flag if want to remove it generates GUID .
  * Implemented client interface to merge the items. Packet struct credits: 856b6f1feb
  * Edited `mergeitem` script command to use the interface, moved the 'old' `mergeitem` to `mergeitem2`.
  * Fixed the behavior to add GUID'd item to inventory in Cash Shop.
  * Updated item_flag.txt for listing `IT_CASH` items (item type 18).
  * NOTE: `IT_CASH` items which defined in item_flag.txt with flag `4`, cannot be merged.
  * NOTE: Please check the packets for older clients. Tested work on 2012-04-10, 2013-08-07 and 2014-10-22.
  * NOTE: Please import 'upgrade_20150804.sql' for MySQL Log Database.
* Removed duplicate clif functions:
  * `clif_msgtable()` -> `clif_msg()`
  * `clif_msgtable_num()` -> `clif_msg_value()`
* Item DB Updates:
  * Indonesia_Box2 (17079) should gives 5x Wing_Of_Butterfly (602).
  * Changed some item types to 18.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-04 20:57:49 +07:00
Cydh Ramdh
eb3d9587be Fixed #557 compile's error, follow up 64cb02e5f16b549f346be2f2857f13e6f3ebe046. Thank @anacondaqq
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-04 19:36:39 +07:00
Cydh Ramdh
64cb02e5f1 * Introducing Item Reuse Limit Group
* By expanding current item_delay.txt's function to implement official item reuse limit.
  * There's the 3rd optional column, put SC ID value to add reuse limit. The reuse delay will be acknowledged as status change. Ignoring this column will use 'normal' item delay.
  * Added some items to their reuse limit group.
* Item DB Updates
  * Added effect for ASPD_Potion (12684).
  * Added effect and delay for Para_Team_Mark_ (22508).

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-03 20:48:35 +07:00
aleos89
ae6b8f2613 Merge branch 'master' of https://github.com/rathena/rathena 2015-07-22 17:47:05 -04:00
aleos89
51f6465709 Bug Fixes
* Fixes #479 - Fixed the unique item ID system not giving new items their unique ID. Blame 7295bdc.
* Fixes #488 - Fixed Water Barrier, Zephyr, and Power of Gaia not being applied to targets walking into the area of effect.
* Fixes #500 - Cursed Circle will now properly release targets if the caster moves out of AREA_SIZE.
* Fixes #501 - Reverberation can be placed an unlimited amount of times. The magic part now only deals neutral damage.
* Fixes #506 - Magnetic Field will now affect others in PvP maps, except for the caster. Thanks to @exneval.
* Fixes #527 - The Roulette item database will not be loaded at all if the feature is disabled.
* Fixed a small typo for 'unitwalk' and 'unitwalkto' script commands.
2015-07-22 17:46:38 -04:00
Heler
9d47aa4ad9 Fixed warnings 2015-07-16 19:46:20 +03:00
Heler
b10a8c8f33 Fixed VIP system 2015-07-13 04:00:05 +03:00
Cydh Ramdh
890352a3a0 Bug Fixes:
* Fixed #492, thank @julia40124009
* Fixed #494, thank @Canoe

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-07-08 09:46:33 +07:00
Cydh Ramdh
a5b85c925c Merge pull request #482 from anubisK/Wroom_utils
Waiting room utils:
* waitingroomkick
* getwaitingroomusers
2015-07-06 12:11:15 +07:00
Cydh Ramdh
d7ae4bbd7f Fixed compile warning
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-07-01 06:31:12 +07:00
Cydh Ramdh
2ae7862e84 Console Message Log update
* Added `console_msg_log` for char-server and login-server.
* Added `console_log_filepath` to determines log filepath.
  * Default for map_athena.conf is `./log/map-msg_log.log`, removed the hardcoded filepath.
  * Default for char_athena.conf is `./log/char-msg_log.log`.
  * Default for login_athena.conf is `./log/login-msg_log.log`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-30 10:58:07 +07:00
Cydh Ramdh
43792bc775 Merge branch rathena/cleanup/mob_random
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-30 05:10:38 +07:00