8070 Commits

Author SHA1 Message Date
Lemongrass3110
9ca5dc40bd Fixed #733
blame 79f4600 @lighta changed it to unsigned by accident
2015-11-10 14:30:19 +01:00
Lemongrass3110
085cd98bfd Merge pull request #748 from rathena/feature/pincode_extension
Feature/pincode extension
2015-11-09 23:47:18 +01:00
aleos89
10fcd20fa8 Renewal Skill Cast Formula Fixes
* Resolves several issues with renewal cast times. Includes fixes for for items and skills that grant additions/reductions to cast time.
* Fixes #549
* Fixes #592
* Fixes #657
-- Thanks to @exneval.
2015-11-09 11:03:29 -05:00
aleos89
a7b8fd4a5d Bug Fixes
* Fixes #696 - Fixed an issue with ammo type fail message for bows and guns.
* Fixes #708 - Fixed Neutral Barrier and Stealth Field not staying with the player through warp portals on the same map. Thanks to @exneval.
* Added the new Pile Bunker S/P/T items to the Pile Bunker skill equipment check.
* Updated Exeed Break damage formula.
* Added a check for skill_require_db parsing to skip requirements on invalid item IDs.
2015-11-06 10:55:00 -05:00
lighta
07ba18d01f Follow up for cppcheck cleanup merge.
Revert some part
2015-10-30 04:14:15 -04:00
lighta
46d417a458 merge master into cppcheck 2015-10-30 02:48:40 -04:00
lighta
05aa1ffc8c Type enforcement
Change the type of
father_id,mother_id,child_id
mail.zeny,mail.send_id,mail.dest_id
from int to uint32, as this is their DB representation anyway and most
of those are mapped to char_id which is uint32.
This should remove the need of implicite cast and improve security
overall.
2015-10-29 23:43:48 -04:00
aleos89
b385fd048a Follow up to c48133c and d8d5489
* Fixes #616 - Status effects that damage monsters will now give players their EXP.
2015-10-29 18:09:36 -04:00
aleos89
dc533fe2e1 Core Cleanup
* Removed a useless parameter from elemental_delete().
2015-10-29 17:45:30 -04:00
Nova
11e5a59663 Follow up 09e91d4, fixed errors and warnings in MSVS 2015-10-27 00:13:10 -07:00
Nova
09e91d4cd4 Warg Dash Bug Fix
Fixes a bug where you're able to spam Warg Dash while next to a mob
based on your ASPD.
Tested the skill live on iRO, and the skill does not cast if a unit is
right in front of your facing direction.
2015-10-26 10:50:39 -07:00
officialronode
a85c232671 Fixed Cash Shop NPC
This update fix the cash shop npc error ( The Purchase has failed because the NPC does not exist. ) Tried & Tested for 2012-04-10 and 2013-08-07 client.
2015-10-25 01:04:13 +08:00
aleos89
ea497b2938 Partial revert of ce7aacb
* Added job, skill, and item stat bonuses back into base status.
* Adjusted specific skills that used base stats to use info stored in mmo_charstatus.
* Fixes #713 - Resolved issue with atcommand 'speed' not adjusting player's movement speed.
2015-10-23 13:03:23 -04:00
aleos89
da94f41908 Bug Fixes
* Follow up to ce7aacb - Adjusted status_calc_bl_main() to calculate player status data through battle_status, not base_status.
* Fixes #709 - Corrected a missed variable type conversion from 82467e1. Thanks to @theultramage.
2015-10-22 07:26:23 -04:00
Cydh Ramdh
055f6d86a2 Follow up 214ff17c1955aaaab34c88faea0dedb97600660e, fixed errors and warnings in MSVS
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-21 20:29:46 +07:00
lighta
214ff17c19 Replace macro max and min, by some inline functions :
-To avoid having long operation repeated twice, peoples shouldn'tuse long operation into does macro but they do so...
-To avoid double increment or thing like such.
-Yes this involve some implicite cast sometime, but that still better then redo 10 dereference...
2015-10-21 04:12:01 -04:00
lighta
b480cb3d47 Valkyrie example
Move valkyrie sample config into conf/
Change path for relative path so that it could be applied for all.
tested with : 'valkyrie -f valkyrie_sample.cfg'
Change include in common, true that complicate move for those file but
will facilitate the parsing for some ide.
2015-10-21 01:59:32 -04:00
Nova
edafd267d8 Merge pull request #661 from RagnarokNova/patch-7
Magma Eruption Status Effects
2015-10-20 11:27:35 -07:00
Lemongrass3110
5a49b70ba4 Fixed an issue where the memory leak log name was null on Windows. 2015-10-20 20:25:15 +02:00
Cydh Ramdh
030c4c58c1 Fixed #698, it's if. The check as option not as priority.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-20 19:54:36 +07:00
aleos89
66fbcfe49c Follow up to ce7aacb
* Fixed some compile errors/warnings reported in Travis.
2015-10-19 14:43:48 -04:00
aleos89
ce7aacb9a4 Base Status Stats Fix
* Fixes #562 - Fixes Crystallization not taking base VIT into account correctly.
* Confirmed on Aegis that Base Status Stats are NOT affected by job, skill, or item bonuses. These bonuses are stored in Battle Status.
2015-10-19 14:28:06 -04:00
Cydh Ramdh
573c7dc3c5 * Fixed #694, Skill cooldown bonus overflow in short variable. Thank @julia40124009
* Fixed #691, Glass_Of_Illusion (14538) gave wrong value. Thank @admkakaroto

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-18 09:43:26 +07:00
Cydh Ramdh
de40271000 * Follow up 2cee5b6ff1bf53c4ae53bc1278b09ae84b8a0a76: gethominfo, getpetinfo, and getmercinfo for type 0 were correct 'to get ID' from database/their unique ID, not as GID.
* Added type for `gethominfo`, `getpetinfo`, and `getmercinfo` to return GID.
* Added `geteleminfo`, to retrieve Elemental ID and GID. The otherinfo can be gained from `getunitdata`

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-14 10:27:31 +07:00
Cydh Ramdh
415aeabdb1 Added safe check for quest's packet length.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-13 07:21:36 +07:00
Cydh Ramdh
80b88b9067 Fixed #673, fixed map-crash by TK_COUNTER. Thank @lordganja
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-12 19:59:12 +07:00
Lemongrass3110
a2d8b817ca Fixed Quest DB for > 65535
Fixes #675
2015-10-12 13:12:11 +02:00
Cydh Ramdh
34c19edf77 Fixed #667, Arms Cannon didn't give splash damage after d95f5d2db75c10435421fe396dc86e7be9654be5. Thank @Fraterna
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-11 22:08:07 +07:00
Cydh Ramdh
8c8c486b84 Fixed #665, Fxied SG Warm skills had chance to crash server. Thank @anacondaqq
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-11 21:13:32 +07:00
Cydh Ramdh
857b82d6ee Fixed #635, thank @julia40124009.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-11 20:50:45 +07:00
Lemongrass3110
79ef03e656 Merge pull request #669 from rathena/hotfix/questlog-2014
Fixed questlog display for clients from 2014-10-22 on
2015-10-11 14:06:36 +02:00
Cydh Ramdh
927d1e2f5c * Fixed #629. Thank @anacondaqq and @theultramage
* Added optional param `char_id` for `instance_enter`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-10 19:04:15 +07:00
Cydh Ramdh
1210bca097 Moved hardcoded timestamp format for log files to conf/log_athena.conf::log_timestamp_format
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-10 11:38:00 +07:00
aleos89
cef2f9ea63 Bug Fixes
* Fixes #629 - Removed an extra costume check during action requests.
* Fixes #632 - Fixed long broadcast messages getting truncated.
* Fixes #635 - Fixed Elementals getting removed twice from a map during map_quit().
* Fixes #639 - Adjusted two checks from status_get_sc_def() so that tick_def2 is properly adjusted when pc_sc_def_rate is adjusted in battle config.
* Fixes #645 - Fixed atcommand 'iteminfo' displaying items not dropping from any monsters when battle flag 'mobinfo_type' is active.
* Fixes #652 - Don't call clif_scriptclose() on script command 'close' and script command 'end' when an NPC shop is active.
* Fixes #670 - Resolved a possible map crash when using the Lux Anima Runestone.
2015-10-09 18:22:35 -04:00
Lemongrass3110
982d6c1f87 Fixed a warning
(unused variable i)
2015-10-09 17:25:49 +02:00
Lemongrass3110
f110657034 Minor cleanup 2015-10-09 17:19:15 +02:00
Lemongrass3110
45e50a3d24 Fixed questlog display for clients from 2014-10-22 on 2015-10-09 00:24:25 +02:00
Cydh Ramdh
fd7d6c31fd Follow up 99783689, typos. Thank @WhySoSexyMate
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-08 15:41:33 +07:00
Lemongrass3110
bba5e4f425 Added compile time checks whether to enable or disable pincode system code 2015-10-07 20:57:37 +02:00
Lemongrass3110
c1623fd5dc Added an unsupported enum value for documentation reasons 2015-10-07 20:20:29 +02:00
Lemongrass3110
10c2dc10dc Pincode Functionality Extension
Added some options to allow or disallow certain combinations in the pincode as aegis has it.
In AEGIS it is not allowed to use pincodes like 0000 or 1111 where the pincode only contains 1 character. It is also not allowed to use sequences like 1234 or 5678.

In addition to the official check, which only disallows ascending sequences I also added descending ones.
2015-10-07 00:15:11 +02:00
Cydh Ramdh
c9c988abba * Fixed #654, TF_BACKSLIDE failed if player has 'no knock back' bonus.
* Clean up on buildin scripts, to use constant in return value.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-03 22:29:46 +07:00
Lemongrass3110
a597e7bd34 Some more pointer casts and enum fixes. 2015-10-03 01:46:47 +02:00
Lemongrass3110
a760e01c59 Follow up to 78b6c15
Fixed a possible buffer overflow in mapindex.c
2015-10-02 20:31:07 +02:00
Lemongrass3110
78b6c150d2 Added usage of enum values in script.c in some places. 2015-10-02 15:09:01 +02:00
Nova
7bc7b7e449 Magna Eruption Status Effects
This line makes the status effects actually apply. (Burning and Stun)
2015-10-01 09:28:36 -07:00
Cydh Ramdh
e112fc1c50 Fixed #647. Fail to get parameter value from readparam if the parameter given is constant as param-type value. So for an example, readparam(BaseLevel) will be fine now, the result same as like BaseLevel itself.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-27 21:44:54 +07:00
Cydh Ramdh
725903e3ce Fixed a typo
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-26 11:18:07 +07:00
Cydh Ramdh
230811c8ab Bug fixes:
* Fixed #651, now quest_db is separated between Renewal and Pre-Renewal to avoid non-existent monster/item (current missing monster/items are removed on Pre-Renewal). Thank @lordganja.
* Fixed #622, cast warning in script.c::get_val2. Thank @Litro .

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-24 07:41:02 +07:00
Cydh Ramdh
d0d14d04be Just spaces in cli.c
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-23 22:01:17 +07:00