* Fixes#2703.
* Added alternative for script command bpet: birthpet.
* Added alternative for script command pet: catchpet.
* Updated documentation for script command pet.
* Added PET_CATCH_UNIVERSAL_ITEM for script command pet which will attempt to catch the targeted monster as long as it is in the pet database and the targeted monster requires the lure item used.
Thanks to @sader1992!
* Duels are now dynamically created and no longer statically consumes memory.
* Removed max number of duel at once.
* Updated duel modules for multi-thread and safer management.
* Remove various statically allocated tab.
* Removed duplicate code for npc_movenpc.
* Fix few warnings.
Thanks for suggestions from @anacondaqq.
* Cleaned up renewal ASPD calculations
* Fixes#2067 and fixes#2224.
* Adjusted the ASPD table to match Aegis values.
* Angra Manyu now disregards base ASPD values (Pre-Renewal only).
* Relocated Angra Manyu check
* Moved Angra Manyu check to the front to avoid useless calculations.
Thanks to @Lemongrass3110!
* Corrected double weapon calculations
* Resolved wearing two weapons causing ASPD to drop significantly.
* Corrected some typos in the Assassin class ASPD table.
* Added a missing Shadow Arms equipment check.
Thanks to @Lilori!
* Removed some unneeded defines
* Removed the single handed and double handed weapon max defines.
Thanks to @Jeybla!
* Renamed constants to keep legacy values
* Update status.cpp
* Fix#2694
Move down skill_unit_move(bl,gettick(),4) of unit_remove_map_ to avoid conflict with duel changing realm.
The issue was that skill_unit_onleft was called before the duel_leave handling which was reapplying skill_unit_onplace causing an infinite status duration.
Other skill might had same issue.
* Small optimisation.
Avoid calling status_change_end when we have no status set yet (or no status_change holder).
Move down overrecurent call to status_change_end SC_ROLLINGCUTTER.
* Switched mob db searches to find
* Replace NULL with nullptr
As suggested by @Jeybla
This way no (caught) exceptions will be reported in visual studio anymore
* status_change_timer refactorization
* Changes some pointers to const pointers to prevent unwanted behavoir.
* Changes sc_timer_next to a lambda function with only the tick as a
paramter.
* sce is not reassigned in sc_timer_next anymore, therefore it should be
crash safe (see #2414 and #2539)
* Fixes#2539
* Thanks to @whupdo, @MuzTank and @admkakaroto!
* Fix#2425 Character variable lengths and char-server
Medium term fox for crash on char-serv caused by too long character variable.
Add few error msg and safety.
Add npc/test/npc_test_longvar.txt as a basic test.
NB:
The config.in for max_colum size if not really set as best would either retrive that value from sql, or use the same config file to actually set the sql column size...
May be handle later with some kind of hibernate ORM.
Thanks to @Tokeiburu, @aleos89, @Lemongrass3110.
* Snowman Hat (5738): Drop chance Buche de Noel and Candy Cane were reversed
* Holy Mom Love (5790): Corrected auto cast skill to Blessing
* Event Xmas Cake (12200): Heals HP by 5%
* Fixes#2706
* Fixes#2674 and fixes#2678.
* Chain Lightning will no longer bounce across Ice Wall.
* Chain Lightning damage should slowly decrease based on the number of bounces remaining.
* Removed the splash effect which was causing the damage to iterate faster on the first two hits.
* Removed the skill unit defines.
Thanks to @Sweet520!
* Fixed Crush Strike damage bonus
* Fixes#2684.
* Base damage increase should not be affected by a success rate.
* Adjusted Crush Strike weapon attack to take from the current indexed value.
Thanks to @Badarosk0 and @Paoly28!
* Updated Sorcerer Insignia Skills
* Fixes#2630.
* Added missing Elemental 20% damage bonus for level 1 Insignia.
* Adjusted the recovery bonus to only apply to Elementals.
* Adjusted 25% magic damage bonus calculation.
* Added the missing ASPD bonus for Wind Insignia.
* Insignias should not affect status immune.
* Removed the BATK addition.
* Miscellaneous cleanups.
Thanks to @admkakaroto and @exneval!
* Changes some pointers to const pointers to prevent unwanted behavoir.
* Changes sc_timer_next to a lambda function with only the tick as a
paramter.
* sce is not reassigned in sc_timer_next anymore, therefore it should be
crash safe (see #2414 and #2539)
* Fixes#2682: `getitem3`, `delitem3`, and `countitem3` always fail if `RandomValueArray` or `RandomParamArray` are not defined (Not all Item Options need 'Value' and 'Param')
* Thanks to @rAthenaCN
* Updated status change documentation for SC_STRIKING, SC_MOONLITSERENADE, SC_RUSHWINDMILL, SC_GT_REVITALIZE, SC_GT_ENERGYGAIN, SC_GT_CHANGE.
Thanks to @uddevil!
