3995 Commits

Author SHA1 Message Date
Lemongrass3110
8c53679a94 New mob placeholders and npc ids 2018-01-02 19:46:43 +01:00
Jittapan Pluemsumran
19e712c87d
Fixed Heart Wing Hairband (18563) item script (#2752)
Thanks to @im-mi
2018-01-02 00:36:26 +07:00
Jittapan Pluemsumran
8e45966c24
Fixed combo script for Survivor's Rod + Survivor's Meanteau combo (#2753)
Thanks to @BrOgBr
2018-01-02 00:36:00 +07:00
flamefury
84085d7ecd Evil Marcher Hat script fix (#2742)
* Fixes #2741.
* Added missing Critical Attack bonus.
* Added missing Long Attack bonus.
Thanks to @flamefury!
2017-12-30 15:26:37 -05:00
Cydh Ramdh
b4ce1e3d1f
Removed Duplicate Entries in Renewal Quest DB (#2740)
* Removed duplicate entries for Rebellion Job Change Quest
2017-12-30 00:56:45 +07:00
Yudi Maharlika
4302fe6409 Corrected Supplement Part Dex (Item ID : 2995) script (#2723)
* Should have bSkillCooldown instead of bSkillVariableCast.
* Source : https://www.divine-pride.net/database/item/2995
Thanks to @uddevil!
2017-12-28 10:25:28 -05:00
Aleos
ae69e50626 Cleaned up renewal ASPD calculations (#2244)
* Cleaned up renewal ASPD calculations
* Fixes #2067 and fixes #2224.
* Adjusted the ASPD table to match Aegis values.
* Angra Manyu now disregards base ASPD values (Pre-Renewal only).

* Relocated Angra Manyu check
* Moved Angra Manyu check to the front to avoid useless calculations.
Thanks to @Lemongrass3110!

* Corrected double weapon calculations
* Resolved wearing two weapons causing ASPD to drop significantly.
* Corrected some typos in the Assassin class ASPD table.
* Added a missing Shadow Arms equipment check.
Thanks to @Lilori!

* Removed some unneeded defines

* Removed the single handed and double handed weapon max defines.
Thanks to @Jeybla!

* Renamed constants to keep legacy values

* Update status.cpp
2017-12-23 16:00:54 -05:00
Vennren
13721c106e Adventurer Pack (#2698)
The adventurer pack gives stat food items that are not working and not having a continuous reference to items in the same ID range.
2017-12-20 23:54:12 +01:00
aleos89
1ae1e312da Minor cleanups
* Resolved some miscellaneous typos.
2017-12-19 14:42:15 -05:00
Cydh Ramdh
fa35e8b93c
Item DB Updates (#2707)
* Snowman Hat (5738): Drop chance Buche de Noel and Candy Cane were reversed
* Holy Mom Love (5790): Corrected auto cast skill to Blessing
* Event Xmas Cake (12200): Heals HP by 5%
* Fixes #2706
2017-12-16 22:36:57 +07:00
Yudi Maharlika
758e319dfa * Drooping Pope should be refineable (#2713)
* Fixes #2712.
Thanks to @Questune09 and @uddevil!
2017-12-15 12:47:38 -05:00
Aleos
947875d27b
Corrected Chain Lightning behavior (#2683)
* Fixes #2674 and fixes #2678.
* Chain Lightning will no longer bounce across Ice Wall.
* Chain Lightning damage should slowly decrease based on the number of bounces remaining.
* Removed the splash effect which was causing the damage to iterate faster on the first two hits.
* Removed the skill unit defines.
Thanks to @Sweet520!
2017-12-15 10:09:23 -05:00
Yudi Maharlika
346fcef57e * Fixes Hervor (Item ID 2181) (#2709)
* Should have unbreakable shield instead of armor
* Source : https://www.divine-pride.net/database/item/2181
2017-12-15 08:29:14 +01:00
Aleos
0f33de9b4d
Updated Sorcerer Insignia Skills (#2645)
* Updated Sorcerer Insignia Skills
* Fixes #2630.
* Added missing Elemental 20% damage bonus for level 1 Insignia.
* Adjusted the recovery bonus to only apply to Elementals.
* Adjusted 25% magic damage bonus calculation.
* Added the missing ASPD bonus for Wind Insignia.
* Insignias should not affect status immune.
* Removed the BATK addition.
* Miscellaneous cleanups.
Thanks to @admkakaroto and @exneval!
2017-12-12 18:33:08 -05:00
Aleos
5531fef9ed
Corrected Celine Kimi Card (#2646)
* Fixes #1875.
* Should cast level 3 Critical Wound on all the enemies within the area, rather than level 5 on self.
Thanks to @Everade!
2017-12-04 13:21:15 -05:00
Yudi Maharlika
f639c0012f Fixes Item ID 14677 (Limited Power Booster) (#2667)
* bAddClass should use bonus2 instead of bonus
2017-12-03 23:40:41 +01:00
Lemongrass3110
7c1a88270b Added support for custom constant import (#2656) 2017-12-01 13:58:24 -05:00
Aleos
37b95826fb
Corrected some item bonuses (#2642)
* Fixes #1430.
* Corrected the bonuses for Flying Galapago and Falconer's Claw.
* Added missing item Falconer's Flute.
Thanks to @Everade and @exneval!
2017-12-01 10:39:02 -05:00
Aleos
da152c6f7e
Corrected Gray and Thanatos equipment sets (#2638)
* Corrected Gray and Thanatos equipment sets
* Fixes #2636.
* Corrected display names.
* Corrected applicable jobs.
* Corrected item bonuses.
Thanks to @mazvi and @Atemo!
2017-11-30 13:52:10 -05:00
Aleos
b00f3bcf5f
Corrected Magical Ring bonus (#2640)
* Fixes #2635.
* Should add ATK versus element and not add DEF against element.
Thanks to @uddevil!
2017-11-30 12:20:16 -05:00
Atemo
c45db5d6ef Fixed issue #2629 "Dummy at Prontera prevents critical attack from being displayed" 2017-11-25 21:46:15 +01:00
Aleos
1c66035761
Refactored achievements to utilize C++ features (#2607)
* Refactored achievements to utilize C++ features
* Cleaned up the YAML parser.
* Moved achievements from DBMap to an unordered_map.
* Moved achievement targets from DBMap to a vector.
* Changed all struct arrays into vectors.
* Changed all char arrays to strings.
* Changed all int arrays to std::arrays.
* Removed achievement_dummy as it's no longer needed.
* Achievements now use smart pointer to ensure proper construction and deconstruction of objects.
Thanks to @lighta!
2017-11-20 21:34:16 -05:00
Haziel
50ef5650a0 Wickebine's Black Cat Ears (#2606)
* Removed Unofficial Bonuses
* Fixed Class Restriction
* Fixed Level Requirement
* Added Code to item 19134.
* Added Official Autobonus Code
* Arbitrary 'Power Up' Effect
Thanks to @SirHaziel and @hendra814!
2017-11-16 15:38:26 -05:00
Haziel
c4ce8cfeba Item DB Fix: Part I (#2602)
* Fixed Valhalla Idol based on item's description.
Thanks to @AetherHaziel!
2017-11-14 10:39:38 -05:00
Aleos
e0b43ecc93 Corrected Mavka Card item bonus (#2597)
* Fixes #2594.
* The item bonus should increase MATK damage for Fire and Earth.
Thanks to @uddevil!
2017-11-10 19:22:00 +01:00
Lemongrass3110
125ab2853a Last missing mob ids from old range 2017-11-01 16:57:05 +01:00
Lemongrass3110
af358809b9 New npc and mob IDs
The old range has been fully used up now.
2017-11-01 16:40:22 +01:00
Aleos
d15b5fc584
Corrected St. Patrick's Hat and Green Ale (#2558)
* Fixes #2547.
* St. Patrick's Hat bonus should be granted from +8 or higher refine.
* Green Ale has a 10 second use delay.
Thanks to @uddevil!
2017-10-30 17:16:28 -04:00
Atemo
c9ee8eb647 Follow up 5ed2113251 2017-10-28 01:56:00 +02:00
Atemo
5ed2113251
Initial release of Sarah and Fenrir memorial (#2504)
Initial release of Sarah and Fenrir memorial
Notes:
* Some monsters status are inaccurated.
* Sarah seems to cast NPC_WIDESOULDRAIN and Gigantes cast NPC_PETRIFYATTACK (need more infos).

Thanks to @aleos89 for the grammatical fixes !
Big thanks to Divine Pride for the infos!
2017-10-27 23:42:12 +02:00
Atemo
c7d5b61409 New Intro for Renewal - continuation of https://github.com/rathena/rathena/pull/2309 (#2530)
* Update map iz_int in mapcache.dat for the new Intro Map
* Update Academy script for the new Intro based on kRO: [http://www.inven.co.kr/webzine/news/?news=176048&site=ro](http://www.inven.co.kr/webzine/news/?news=176048&site=ro)
* Add monster spawn in the new Intro Map
     
Thanks 805a2b3b1a (diff-8d1dca8dc246e9f4d38c6f1ad0d2c930) for original script.

Thanks @jenkijo for the base, @Lemongrass3110 and @aleos89 for the review, and Divine Pride for some infos !
2017-10-21 00:23:49 +02:00
Atemo
b90df89380 Fixed Crimson Saber (Item ID: 13454) equip class requirement
Thanks @ToiletMaster !
2017-10-20 15:52:17 +02:00
Aleos
c73e10cb30 Added new 2016 Wedding skills (#2479)
* Added new 2016 Wedding skills
* Adds Call All Family, One Forever, and Cheer Up skills to the renewal databases.
* Removed Enlarge Weight Limit R skill from a few job skill trees as it's not needed to be defined there.
Thanks to @Rytech2, @Jeybla, and @Lemongrass3110!
2017-10-19 13:22:55 -04:00
Aleos
db37fc7ddd Fixes required equipment check for skills (#2374)
* Fixes required equipment check for skills
* Fixes #2372.
* Required equipment check was allowing the skill to cast without the proper equipment.
* Adjusted the skill fail messages to their appropriate responses.
Thanks to @M4karov, @exneval, @Jeybla, and @Lemongrass3110!
2017-10-14 22:37:55 -04:00
Lemongrass3110
f42c2ff211 Moved some remaining constants into src (#2501)
* Moved all npc view constants into src

Source side the constants will use Gravity's naming standard(JT_*)
NPC side still supports the old names without JT_

* Moved all effect constants into src

Added check for effect validation to atcommand effect and all script commands using them
Removed the unused and broken function unit_changeviewsize from unit.c
Replaced a lot of hardcoded effect ids with their respective constants
Cleaned up the effect documentations

* Moved all hat effect constants into src

Added check for effect validation to script command hateffect
2017-10-14 18:13:51 +02:00
Aleos
6a2c1229d0 Updated Rebellion class (#1692)
* Updated Rebellion class
* Information based on Rebellion Awakening patch from kRO.
- http://ro.gnjoy.com/news/update/View.asp?seq=183&curpage=1
* Fixes #859 and fixes #1449.
Thanks to @RagnarokNova and Fyrus for their information!
2017-10-12 11:04:03 -04:00
Lemongrass3110
705cc5a869 Mob DB placeholders
kRO patch 2017-10-11
2017-10-11 15:24:06 +02:00
Jey
3e78cc1c3a Fixes item positions
* 28310,Earring_Of_Sarah_L
* 28311,Earring_Of_Sarah_R
* Closes #2493
* Thanks to @Yuchinin
2017-10-09 14:35:59 +02:00
Jeybla
828f78322b Adds a duplicate name check for the itemdb. (#2492)
* Fixes #2487
* Fixes some duplicate itemdb entries.
2017-10-09 03:55:12 +02:00
Jittapan Pluemsumran
800fd3da45 Fixed Zaha Doll Hat not being refinable. Fixes #2485
Thanks to @uddevil
2017-10-08 21:50:38 +07:00
Atemo
319fc4d18c Fixed a duplicate aegis name
Thanks @Jeybla !
2017-10-08 00:57:43 +02:00
Jittapan Pluemsumran
67518f4def Merge pull request #2470 from rathena/feature/moscovia_cards
Implemented cards for Moscovia monsters
2017-10-05 13:17:33 +07:00
Atemo
0791adb4f4 Corrected duplicate item name follow up 7f9747c15d (diff-23f1393132fc5ca16140f50c9591e550R4554) 2017-10-04 16:38:00 +02:00
Atemo
7f9747c15d Aegis item name (#2451)
* Correct Aegis item name from https://rathena.org/board/topic/107649-aegis_id2name_v2/

Thanks @esu1214
2017-10-04 16:30:28 +02:00
Atemo
75653d9da1 Adjust Wood_Goblin_Card item script from the description 2017-10-04 00:00:36 +02:00
Lemongrass3110
b8844a0973 Fixed @Atemo's comments 2017-10-03 15:46:45 +02:00
Lemongrass3110
77a7bc2d9a Fixed a missing comma 2017-10-03 14:55:29 +02:00
Jittapan Pluemsumran
fc8534f766 Implemented cards for Moscovia monsters 2017-10-02 23:34:35 +07:00
Jittapan Pluemsumran
091738ac7e Implemented Terra Gloria cards (#2464) 2017-10-02 23:19:27 +07:00
Edwin
2df18b12e6 Added AB_RENOVATIO as reproducible skill. 2017-10-02 15:00:45 +07:00