9945 Commits

Author SHA1 Message Date
Atemo
f4fbfb3299
Clean-up the npc_enable_target function (#6248)
* Clean-up the npc_enable_target function

Thanks to @Lemongrass3110 and @aleos89
2021-09-11 14:56:36 +02:00
Balfear
54431dd0ec
Pet autofeed config fix (#6249)
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-09-10 22:56:26 +02:00
Aleos
893bfabe91
Adds support for Level field in ItemCost (#5268)
* Fixes #5266.
* Adds the ability to supply the ItemCost level to easily override a specific level or only define some levels that have item requirements.
* When the Level label is provided for ItemCost it becomes dependent to that level only.
* Removes some remaining hardcoded skills that have skill level dependent checks.
* Added support to CSV2YAML to properly convert those level dependent skills.
* Adds documentation to header and upped version.
Thanks to @Pringle012 and @Lemongrass3110!
2021-09-10 14:24:23 -04:00
Atemo
69802a23fb
Suggestion: NPC name as parameter in enablenpc (#6233)
* The required NPC name parameter is now optional for the following script commands:
    enablenpc
    disablenpc
    hideonnpc
    hideoffnpc
    cloakonnpc
    cloakoffnpc
    isnpccloaked
* Updated docs

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
2021-09-09 14:50:24 +02:00
Balfear
c18707bb6d
Script command "delitemidx" (#6247)
Added new command that allow delete items from inventory by index.

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Daegaladh <Daegaladh@users.noreply.github.com>
2021-09-09 13:02:02 +02:00
Lemongrass3110
d25ec40a8f
Fixed an issue with RODEX's retrieve all (#6245)
Sometimes players would not be able to retrieve their items anymore.

Thanks to @Balferian and @limitro
2021-09-09 00:19:32 +02:00
Lemongrass3110
cdce54ac0a
Synced mobs and effects from divine pride (#6244) 2021-09-08 17:25:10 +02:00
Lemongrass3110
870e3d9407
Added an error message to openmail (#6243)
Fixes #6159

Thanks to @SynchronyMaster
2021-09-08 08:27:09 +02:00
Lemongrass3110
b75b8ffafb
Added an additional safeguard (#6241)
Fixes #6229

Thanks to @mrboob
2021-09-08 01:43:52 +02:00
Aleos
9e4dc7df4a
Cleans up some cast time and delay behaviors (#6221)
* Fixes #6135.
* Mystical Amplification should not have the IgnoreStatus CastTime flag.
* Foresight will only apply a cast reduction to learned skills, not those that are granted through item bonuses guild skills, pets, etc.
* Item bonus bDelayRate will now stack with other delay reduction bonuses.
* General cleanups to variable defines.
Thanks to @Everade, @mrjnumber1, and @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-08-31 08:54:28 -04:00
Aleos
bccbf8b166
Fixes a potential map-server crash by skill units (#6226)
Fixes #6224.
Restart the iterator if a skill unit is deleted when trying to clear previous grouped unit skills.
Thanks to @technoken!

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-08-31 12:00:58 +02:00
Atemo
fe7cb5a33f
Converted const.txt to YAML (#6187)
* Converts the Constant Tables file into YAML.
* Includes CSV2YAML converter.

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-08-27 23:54:31 +02:00
SeravySensei
72aafdadea
Fixed drop rate bonuses (#3986)
Fixes #2613

Co-authored-by: aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2021-08-27 23:00:41 +02:00
Lemongrass3110
21cb9e87a2
Fixed a map-server crash (#6223)
Fixes #6220

Thanks to @AsurielRO, @Atemo, @aleos89 and @vstumpf
2021-08-27 00:09:10 +02:00
Lemongrass3110
5a25755386
Fixed a compiler warning (#6216)
Fixes #5999

Thanks to @RadianFord, @CairoLee, @jasonch35 and @Daegaladh
2021-08-26 21:51:49 +02:00
Aleos
cf7923aeee
Fixes skill units not clearing from unit_data (#6218)
* Fixes #6217.
* Follow up to a84e731.
* Adds a missing erase for skill unit data from the unit_data of an object.
Thanks to @AsurielRO!
2021-08-25 16:51:03 -04:00
Daegaladh
b2be269bf7
Fixed changesex not changing the character's sex (#6201) 2021-08-25 00:13:49 +02:00
Daegaladh
136fc5da84
Fixes Grimtooth not causing SC_QUAGMIRE status to monsters (#6215) 2021-08-24 19:37:40 +00:00
Lemongrass3110
d556ab88ae
Added a missing string import (#6214)
Fixes #6210

Thanks to @jasonch35 and @Daegaladh
2021-08-24 17:01:26 +00:00
Aleos
a84e731f79
Cleans up the skill unit group storage (#6195)
* Fixes #2217.
* Adjusts the storage for skill unit group from DBMap to unordered_map.
* Removes the MAX_SKILLUNITGROUP limit.
* Cleans up memory management to utilize shared_ptr.
Thanks to @Lemongrass3110!
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-08-23 14:11:53 -04:00
Aleos
abe40d1eff
Fixes card resistance for renewal (#6179)
* Fixes #5932.
* Resolves the cardfix ratio getting applied twice in renewal.
Thanks to @laziem!
2021-08-23 12:34:25 -04:00
Atemo
eb8c06743e
Resolves some mistakes for getAttribute (#6207)
Follow-up 4d2c5b02d3
Fixed #6205

Thanks to @sonniez
2021-08-21 01:56:04 +02:00
NotKappa
19ef916f6e
Update Hateffect (#6200)
Added latest kRO and jRO hateffects

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-08-18 11:34:02 +00:00
Aleos
7e2a85a578
Updates the behavior of Stasis (#6196)
* Fixes #6071.
* Updates the behavior of Stasis to block Songs, Ensembles, Choruses, and magic type skills.
* Removes the INF2_IGNORESTASIS flag as it doesn't effectively fit it's purpose anymore.
Thanks to @Felleonel!
2021-08-17 15:44:32 -04:00
Aleos
b9c53941f1
Adjusts Comet to a unit skill type (#6186)
* Fixes #5951.
* Adjusts the behavior of Comet to a unit skill type.
* Comet will now behave properly around Maya Card and other unit skill type interactions.
Thanks to @Felleonel, @Playtester, and @Lemongrass3110!
2021-08-17 14:16:38 -04:00
Aleos
92413b8459
Fixes Elemental Converter and equip swap (#6181)
* Fixes #5907.
* Fixes Elemental Converter getting removed when swapping weapons/shields.
Thanks to @Tydus1 and @Lemongrass3110!
2021-08-17 13:41:12 -04:00
Lemongrass3110
ff2c4e2b00
Added NPC path to debug output (#6198)
Have you ever been annoyed by a script error that did not tell you in which file the NPC is located?
This will fix it for you.
2021-08-17 01:50:43 +02:00
Aleos
d8d6d74fc9
Fixes Marionette Control versus Curse/Quagmire (#6183)
* Fixes #5908.
* Marionette Control will no longer cast onto targets that are either Cursed or in Quagmire.
Thanks to @Tydus1!
2021-08-16 14:43:52 -04:00
Aleos
a97f3c6000
Fixes Basilica failing versus other skills (#6190)
* Fixes #6019.
* Partial revert of 01b8e76.
* Resolves Basilica from failing to work with other unit skills in the area.
Thanks to @Indigo000!
2021-08-16 14:03:39 -04:00
Aleos
729482a019
Fixes Frost Nova versus targets on Land Protector (#6185)
* Fixes #5926.
* Frost Nova will no longer damage targets who are standing on Land Protector.
Thanks to @Miraakol and @Playtester!
2021-08-16 13:21:41 -04:00
Atemo
2a97f0bdc7
Fixed an issue with SCB_MODE (#6193)
* status->class_ is now directly defined by the current mode regardless of the previous mode

Fixed #6194
Thanks to @Zarbony !
2021-08-16 15:18:04 +02:00
Aleos
b119c04f3e
Clean up to the item buy/sell checks (#5604)
* Fixes #6163.
* An item's sell value will now always be calculated whether the item exists or not. This resolves adjustment of an item's buy value during the import process.
* Moves a couple checks to the loadingFinished function.
Thanks to @Daegaladh!
Co-authored-by: Atemo <Atemo@users.noreply.github.com>
2021-08-13 15:30:30 -04:00
Aleos
6c6de8355f
Resolves Shadow Trampling not affecting targets (#5881)
* Fixes #5786.
* Resolves Shadow Trampling not applying it's affect on targets around the caster.
Thanks to @Badarosk0!
2021-08-11 14:10:32 -04:00
Aleos
35bdb928a3
Disables costumes and hat effects on GvG/PvP maps (#6177)
* Follow up to 6eb896f.
* Visual costumes are now disabled on PvP maps.
* Hat Effects are now disabled on GvG and PvP maps.
Thanks to @Badarosk0!
2021-08-11 13:46:42 -04:00
Atemo
4d2c5b02d3
Converted Elemental Attribute Damage Adjustment Tables to YAML (#6053)
* Converted Elemental Attribute Damage Adjustment Tables to YAML
* Includes CSV2YAML converter

Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-08-11 18:39:18 +02:00
Lemongrass3110
aba4dc5635 Follow up to 99eed0c 2021-08-11 17:13:10 +02:00
Atemo
99eed0c9b1
Converted mob_item_ratio to YAML (#6021)
* Converted mob_item_ratio to YAML
* Includes CSV2YAML converter.
* Added the possibility to remove an item from monster drop using this feature

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>

Thanks to @idk-whoami !
2021-08-11 16:28:46 +02:00
Aleos
a93daa0c6f
Properly implements Soul Attack (#6126)
* Fixes #6095.
* Proper implementation of Soul Attack for Doram.
* Adds the missing client EFST when learning the skill.
* Fixes the behavior so that skills that block or reduce ranged attacks are properly taken into account.
Thanks to @Everade!
2021-08-10 10:44:49 -04:00
Atemo
3f9b051ebc
Corrected an issue with UniqueId (#6146)
* Corrected an issue with UniqueId
* On Aegis some stackable items have the same GUID, the commit adds a setting to give the stackable items stacked (or not) to the player
* Removed IG_MAX in the parsing to allow new entries from const.txt
* Added more information about the 'Group' in a warning

* Removed exp_guild.txt (mistake from previous PR)
2021-08-09 14:27:48 +02:00
Lemongrass3110
6b84115790
Speeded up item name lookup (#6161)
Partial takeover from #5997
Did some further cleanup and took it out of the pull request until secret has time to finish it.

All credits to @secretdataz

Co-authored-by: secretdataz <secretdataz@users.noreply.github.com>
2021-08-08 16:46:44 +02:00
Atemo
f185b57f21
Implemented the item group IG_XMAS_PACKAGE_14, IG_EASTER_EGG and IG_PITAPAT_BOX (#6121)
* Implemented
IG_XMAS_PACKAGE_14
IG_EASTER_EGG
IG_PITAPAT_BOX
from Aegis data
2021-07-31 14:31:04 +02:00
Aleos
76c81a46ca
Fixes autobonus trigger failure (#6128)
* Fixes #5873.
* Follow up to bf9a3b4.
* Fixes an issue with autobonuses not being triggered properly.
Thanks to @Indigo000!
2021-07-30 11:34:48 -04:00
Aleos
1cbf6aefdd
Cleans up checks for leaving active Battlegrounds (#6124)
* When a player deserts an active Battleground they will no longer receive the  SC_ENTRY_QUEUE_APPLY_DELAY status from leaving the queue. This makes it so that the proper Battleground desertion message is shown when trying to join another Battleground.
2021-07-29 15:33:47 -04:00
Lemongrass3110
ef291e4d83
Fixed soul reaper spirit removal (#6122) 2021-07-28 19:36:20 +02:00
Kagetsu
efd66000f6
Fixes a crash in the csv2yaml tool (#6141) 2021-07-27 10:34:59 -07:00
Lemongrass3110
a7bbbb9379
Fixed some issues with refine UI (#6106)
Fixes #6103

Thanks to @Everade
2021-07-22 10:21:14 +02:00
Aleos
3287388b05
Fixes an issue with players joining active BG (#6105)
* Fixes a timer not getting removed from players when they join an active battleground. The timer would continue after accepting the invite and would eventually remove the player from the queue resulting in the player getting the "Left queue time penalty".
2021-07-21 20:23:34 -04:00
Atemo
789e8f7199
Converted item group database to YAML (#6032)
* Converts the item_bluebox, item_cardalbum, item_giftbox, item_group_db, item_misc,  item_package and item_violetbox txt into YAML.
* Includes CSV2YAML converter.

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-07-22 00:12:10 +02:00
Atemo
7ade6d8c86
Converted txt guild experience database to yaml (#5995)
* Converts the Skill Tree Tables file into YAML.
* Includes CSV2YAML converter.

Co-authored-by: Aleos <aleos89@users.noreply.github.com>
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
2021-07-19 14:30:13 +02:00
Atemo
4b339f7f6e
Added missing cap for default value for AttackDelay and AttackMotion (#6085)
Fixed #6082

Thanks to @Jefferycheng !
2021-07-14 20:45:00 +02:00