Commit Graph

834 Commits

Author SHA1 Message Date
aleos89
c8758478b4 Bug Fixes
* Fixed the stun effect from Berkana Rune. (bugreport:9057)
* Adjusted Thorn Wall to be a placeable skill and to ignore caster's % damage cards.
* Field Manuals (SC_EXPBOOST and SC_JEXPBOOST) now increase EXP gained from NPC quests (through the getexp script command). (bugreport:9091)
* Lif's Mental Change no longer fully restores her HP and SP upon activation.
* Fixed fakename atcommand not working while disguised. (bugreport:8896) (Hercules 1e492e3)
* Fixed speed atcommand resetting when swapping equipment/changing maps. (bugreport:8915) (Hercules 37fdcba)
* Cleaned up some compile warnings.
2014-07-24 11:45:57 -04:00
Cydh Ramdh
171e2f2be9 Bug Fixes:
- Failure when initializing autotrade persitance for PACKETVER < 20120201 or NEW_CARTS, ENABLE_SC_SAVING aren't defined
- Added 'feature.autotrade_open_delay' config at conf/battle/feature.conf to give delay to open vending/buyingstore by autotrade persistency (bugreport:9077)
- Add immediate save after vending/buyingstore opened to avoid missing sc_data (for SC_PUSH_CART) when server terminated before saving routine (bugreport:9077)
- Disable to trigger NPCE_LOGIN (and NPCE_LOADMAP?) for autotraders, avoid vending_reopen & buyingstore_reopen failure (bugreport:9077)
- Set player's state, 'monster_ignore' when autotrade
- EXP calculation overload (bugreport:9127)
- Added macro apply_rate(val,rate) & apply_rate2(val,rate,per)

Thank you all for reports & helps

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-07-16 17:21:58 +07:00
lighta
79f4600dcd -Fix some CppCheck
-Fix bugreport:9088 (constant not always recognize if stating by number) thx to Hercule is_number
-Add infos on read_constant for check/debug
2014-07-04 11:22:40 -04:00
aleos89
62a2813adc Bug Fixes
* Fixed Concentration ending when Frenzy is used. (bugreport:8942)
* Fixed Hells Plant hitting Ghost element enemies. (bugreport:8799)
* Forced guild notice changes to save immediately. (bugreport:8961)
* Fixed Cart Tornado damage formula. (bugreport:9065)
* Adjust Amistr's Castling to now switch to any target type. Still needs skill switching support. (bugreport:1784)
* Removed hard coded 1 second skill duration reduction for Spore Explosion.
* Fixed the party window not displaying the correct map name when in an instance. (bugreport:7949)
* Fixed hatching a pet causing client disconnections. (bugreport:9059) (Hercules 533ff4f)
* Updated Kagerou/Oboro skill cast times. (bugreport:9035)
* Removed deprecated negative nameid value for getitem/getitem2.
* Renamed incuvate to incubate throughout source and SQL.
* Added skill ID to the error display for battle_calc_attack to help resolve issues. (bugreport:8876)
* Cleaned and corrected some Sorcerer Elemental skills. (bugreport:9058)
* Cleaned up some more compile warnings.
2014-06-27 15:45:35 -04:00
lighta
b124498263 Fix -WShadow definition warning
Cleanup some leftover
2014-06-27 06:07:50 -04:00
lighta
9eb5e60b8e Update nullpo, to avoid va_list empty creation.
Update classe model
2014-06-24 01:15:40 -04:00
Lighta
55134d1ae1 Fix ARM compilation.
-Upd configure (merge with Hercule configure.in)
-upd nullpo.c and atomic.h to allow arm compilation, testedon Epiphany parallela.
2014-06-22 17:06:02 -04:00
Cydh Ramdh
0fca530278 * Fixed bugreport:9034 (Hercules aff9c14)
* 'bonus_script' improvement:
-- Added flag values (partial merge from sc_config branch):
-- * 16  : Removeable by Banishing Buster.
-- * 32  : Removable by Refresh.
-- * 128 : Removable by Luxanima.
-- * 256 : Remove when Madogear is activated or deactivated.
-- * 512 : Remove when receive damage.
-- * 1024: Script is permanent, cannot be cleared by bonus_script_clear
-- Added 'bonus_script_clear' command to remove active bonus_script from player (works like sc_end) Thank Napster to mention this. (bugreport:9042)

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-06-20 15:12:42 +07:00
aleos89
7cd82d00db Increased item ID array size.
- Increased limit from 32,767 to 65,535.
- Still uses same amount of memory with doubled usable size.
- Adjusted CARD0_PET from -256 to 256.
- Please run both SQL files after applying this update to avoid values becoming corrupt.
- Tested and works on clients 2012-04-10 and up thanks to Cydh.
- Removed an unused SQL file.
2014-06-12 11:29:10 -04:00
Cydh Ramdh
a8a44254e1 * Bug Fixes & Misc
-- Compiling errors when VIP_ENABLE (bugreport:9013)
-- Taekwon skills leftover when player was in Taekwon Ranker then changes to other job (bugreport:8973)
-- Follow up f511107.Fixed parentheses statement.
-- Follow up 6afcdeb. Updated check for char table.
-- Follow up 794c1a8. Wrong SC constanta order.
* Battle Config Updates
-- 'transcendent_status_points', stat point bonus for trans classes.
-- 'revive_onwarp', disable/enable to revive a dead player when set new position (warping).
-- 'taekwon_ranker_min_lv', minimum level bonus of Taekwon Ranker.
-- 'fame_taekwon_mission', fame point gained when complete Taekwon Mission.
-- 'fame_refine_lv1', fame point when success to refine to +10 forged weapon level 1.
-- 'fame_refine_lv2', fame point when success to refine to +10 forged weapon level 2.
-- 'fame_refine_lv3', fame point when success to refine to +10 forged weapon level 3.
-- 'fame_forge', fame point when success to forge level 3 weapon with 3 additional ingredients.
-- 'fame_pharmacy_3', fame point when success do pharmacy 3 times in a row.
-- 'fame_pharmacy_5', fame point when success do pharmacy 5 times in a row.
-- 'fame_pharmacy_7', fame point when success do pharmacy 7 times in a row.
-- 'fame_pharmacy_10', fame point when success do pharmacy 8 times in a row.

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-06-08 17:04:37 +07:00
lighta
214176ab1b Merge remote-tracking branch 'upstream/master'
Conflicts:
	src/char/char.c
	src/char/int_storage.c
2014-06-05 02:51:01 -04:00
Cydh Ramdh
794c1a8247 Bug fixes & Misc:
-- Map crashed because empty item_combo script (bugreport:8959)
-- Wrong MATK calculation of Distort Crescent/Zangetsu effect (SC_ZANGETSU) (bugreport:8998)
-- Wrong damage reduction of Sera's Pain Killer effect (SC_PAIN_KILLER) (bugreport:8994)
-- Fixed Shape Shift (NC_SHAPESHIFT) wrong requirement (bugreport:9002)
-- @itembound, getitembound usage. Not, now allowed for unspecified bound_type (thank Ceejay Abne! http://rathena.org/board/index.php?showtopic=94726)
-- Change check behavior for skill requirement level-dependent check.
-- Removed NC_REPAIR hardcoded requirement.
-- Moved the required equipped item to 'RequiredEquipment' on skill_require_db.txt.
-- Missing "Option_Ruwach" as contantan.
-- Corrected Chasewalk STR bonus, it's SC_CHASEWALK2, different with SC_INCSTR.
-- Corrected some Rebellion skill's effects.
-- USESKILL_FAIL_MADOGEAR message for failed skill that needs player has Madogear.
-- Changed skill name and description length to 31 chars.
-- Some documentation updates.
-- Follow up 0f2dd7f. (Well, using empty password in import file, won't works, if you want, empty the original conf file. Fix this later, related on 'sscanf' for those files)
-- Follow up 28c90bb, thank @julia40124009
-- Misc. :P

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-31 21:42:44 +07:00
aleos89
6afcdeb613 Cleaned up the Font System to properly save to the character.
Also expanded @itemlist to support costume item types.
2014-05-23 11:48:28 -04:00
lighta
82a1c702dc Upd Makefile
Fix small typo in intif.h, ifndef was being unused.
Upd Makefile to simplify libconfig inclusion
2014-05-03 03:05:58 -04:00
lighta
bf5d94b3e9 Updating Makefile
Cleaning out ligconfig creation rules, use of archive and use of
variable to avoid duplicate.
2014-05-02 12:05:18 -04:00
lighta
06286ebe7c Move and clean few more thing around
Testing refact, looking good for now.
2014-04-30 00:23:28 -04:00
lighta
1a66aad9a7 Merge remote-tracking branch 'upstream/master'
Conflicts:
	src/char/int_quest.c [Manually fixed]
2014-04-28 13:49:51 -04:00
lighta
af5561086a Merging char-refact part 1
This is just a temporary not totally nor functionnal merge of char-
refact.
DO NOT use for prod unless edit.
2014-04-28 13:35:57 -04:00
aleos89
912b644499 Added support for 2013-12-23 client. 2014-04-24 13:15:45 -04:00
aleos89
1d1a58cdcb Bug Fixes
* Removed unused guild aura leftovers and fixed some other issues with setting the guild aura. (bugreport:8892)
* Fixed Fire Expansion Acid to be a magic type attack. Thanks to exneval.
* Cleaned up some remaining issues with Issen. (bugreport:8905)
* 16th Night (Izayoi) should remove fixed cast time from all skills.
* Circle of Nature is now part of Group B songs.
* Updated Reading Spell Book spell memorization to official.
* Updated homunculus skill cooldowns.
* Added missing Holy element bonus for Hesperus Lit.
* Fixed Coluseo Heal and Praefatio not giving a party bonus. (bugreport:8904)
* Fixed the status icon for ALL_RIDING not being displayed at login.
* Adjusted the notice display order when players login. (Hercules df1952d)
* Self skills can now be used while storage is open. (Hercules 6f6a6b3)
* Cleaned up SC_NOCHAT/Manner system. (Hercules 94ef1ee)
2014-04-16 11:06:09 -04:00
aleos89
35d838c9d2 Fixed some issues from the CppCheck report. 2014-04-09 22:24:51 -04:00
Cydh Ramdh
c8c40a1377 Follow up 0081e25, 8a723ee (msg_conf stuffs)
- Revert MAP_MAX_MSG to 1500
- Moved some messages to empty spaces
- Added warning message if msg_number is invalid when msg_conf files are being read
- And minor stuffs

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-04-04 22:28:11 +07:00
aleos89
2fe8140f96 Quest Log system improvement. (Hercules 6f55c00)
- Improved memory usage of the quest log system. (saves up to 75kB per online character).
- Fixed various issues with quest entries disappearing from characters without an apparent reason, or monster kill counters getting stuck - the issues were caused by a de-synchronization between the two parallel questlog arrays in map_session_data.
- Added some code documentation.
- Thanks to @shennetsind and @MishimaHaruna.
2014-04-03 09:39:34 -04:00
lighta
51f26d43d2 Follow up e0c8e01
Move skill_get_cooldown_ into pc_get_skillcooldown
and add a short src_doc description to promote his usage
(and avoid duplicate code)
Fix few cppcheck issues (variable scope optimisation mostly)
2014-03-18 17:36:23 -04:00
Euphy
f3777cce0e Implemented @warp suggestions.
This will display map name suggestions when attempting to @warp to a non-existent map.
To enable, turn on 'feature.warp_suggestions' in 'conf/battle/feature.conf'.

Signed-off-by: Euphy <euphy.raliel@rathena.org>
2014-02-13 21:17:57 -05:00
Cydh Ramdh
94322e7084 Follow up 189a46d, increased MAX_QUEST_DB value
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-01-23 13:23:22 +07:00
aleos89
b818c78f1d Added Oktoberfest costume.
- Requires client version 20131218 or newer.
2014-01-21 11:26:59 -05:00
lighta
b92230e33e Cppcheck
Fix typo in race bonus fix : race<RC_NONE_ && race<RC_MAX
Fix bugreport:8418 => clif_instance_changestatus possible mapcrash
Reduce lot of variable scope and fix unsafe scanf
2014-01-09 02:18:51 -05:00
lighta
4af314500e Check_db
Add a check_db on char-serv startup to ensure all sql-tables was loaded
correctly and avoid error on runtime.
Fix OnInterIfInitOnce being executed on reloadscript, (now only done at
server startup)
2014-01-09 00:08:00 -05:00
lighta
d6caec1c51 Various fixs
Fix bugreport:8418 (possible mapcrash from custom instance script)
Fix bugreport:8439 (pc_bonus_item_drop typos) thx to Baalberith
Fix some errors detected by cppcheck
upd install.sh (leftover of svn and wrong simlink)
2014-01-07 20:15:40 -05:00
lighta
28ecab5712 DB Import
Add folder import/ into db/ to load all customs
This folder is meant to hold all the customs file you wish override rA
one.
(In short it work like conf import)
related to tid:90199
2013-12-31 18:21:45 -05:00
lighta
744195a931 Leak and Optimisation
Fix many typo and optimisation found by :
http://rathena.org/cppreport/index.html
Fix multiple unsafe scanf of string
Fix multiple battle wrong check (elemental bonus)
Fix camouflage defense reduction and cap expiato def reduction
Fix geoip leak
Upd few documentation in doxygen style
Fix path working directory issue to start servers
(now you won't need to be in maindir to launch server)
2013-12-30 02:05:34 -05:00
Cydh Ramdh
be05bc399b *Added 'status_icon' param for *bonus_script script, thank QQfoolsorellina for the suggestion (https://github.com/rathena/rathena/commit/99098c1#commitcomment-4558795)
--> bonus_script "<script code>",<duration>{,<flag>{,<type>{,<status_icon>{,<char_id>}}}};
* Please update your sql database (main database) with upgrade_20131227.sql

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-27 18:17:41 +07:00
lighta
4212080bd9 Storagelist fix
Follow up hash:0f2dd7f (adding support to map<=>client to allow longer
storagelist)
Fix most of : [Error]: WFIFOSET: Maximum write buffer size for client
connection 7 exceeded, most likely caused by packet 0x0996 (len=11932,
ip=127.0.140733193388032.1). Still remain some if you openup the list
like 5time/s, see tid:90541
2013-12-26 04:13:32 -05:00
Cydh Ramdh
716de547dc Added newline at end of file, http://rathena.org/board/tracker/issue-8380-warnings-warnings/
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-25 12:17:48 +07:00
Cydh Ramdh
74740b4491 * Follow up 9cca188, change enum of IT_WEAPON and IT_ARMOR on src files
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2013-12-23 11:07:49 +07:00
aleos89
0f2dd7fcf0 * Cleaned up a mercenary kill check. (bugreport:2222)
Bug Fixes
* Adjusted script commands that use script_isstring and script_isint to use script_getdata to dereference if variable is given. (bugreport:8198)
* Removed the hardcoded password so that users can pass blank passwords through the config for MySQL. (bugreport:7787)
* Increased the hostname array to account for longer hostnames. (bugreport:8003)
* Fixed the CashShop not listing items correctly. (bugreport:7585)
* Fixed Offertorium not consuming the correct amount of SP. (bugreport:8266)
* Cart Boost effect stays even if the cart is removed. Revert of change in r16339. (bugreport:5808)
2013-12-13 15:25:03 -05:00
lighta
4684090de9 InterPacket_rearrange
-Move charban and charunban packet out of 0x2b0e and mark that fonction
reserved for login request purpose.
(Charban and charunban now use 0x2b28 and 0x2b2a)
-Move chrif_savebankdata, chrif_datarequest, chrif_req_vipactive into
0x2b0e (as their some login operation request)
-Harmonize vip_time data type and fix some case where he would have get
INT_MAX value.
-Small revert on a3f0aedf @vip for vip_time alteration as the duration
should be able to get reduced.
-Fix vip_status(3) args of aFree 0x18E2777C is overflowed pointer
and incorect data returned, (altough dunno if we want this as returned
presentation string)
-fix bugreport:8289 where VIP_request anwser was broadcasted to all
mapserv
-Upd split_time month and year factor for a better approximation of
date. (splitting timestamp into years, month, days ...)
-Add loginif_isconnected to check if the loginserv is connected to char.
2013-11-28 00:21:41 -05:00
Cahyadi Ramadhan Togihon
fd700a7812 Added support for MSVS 2013, thank solid2005 for all files (http://rathena.org/board/tracker/issue-8274-compilevisual-studio-2012-to-2013/)
Signed-off-by: Cahyadi Ramadhan Togihon <house.bad@gmail.com>
2013-11-22 13:23:29 +07:00
lighta
3428ae297a Adding charblock
Update HC 0x20d to send the blocklist value, based on Herc:aee2f631
Revamp ZH 0x2b0e and HA 0x2725 to send difftime instead
year,month,day,minutes,secondes values..
Remove duplicate code for char_ban
Add missing sql_upgrade for vip
2013-11-18 20:38:10 -05:00
aleos89
30648216ec Initial release of VIP System.
By default system is disabled (src/config/core.h).
This follows the iRO implementation VIP System. More information can be found on the iRO Wiki.
All settings also have individual configs.
Official VIP scripts will be implemented later.
Big thanks to lighta and Cydh for support and debugging.
2013-11-18 15:21:51 -05:00
lighta
fca76baad8 Memleak fix
Fix some typo on channel ally
2013-11-15 12:05:44 -05:00
Lilith-
bd2503e279 Added Shadow Equipment System support (item type 12) 2013-11-14 16:37:03 -08:00
Akinari1087
a506c7fc0e Follow up to 4d61cc0
Revert SONIC_CRAW consuming spheres.  My mistake
Update Eleanor skill damage formulas and spirit sphere consume requirements based on WarpPortal and iROWiki forums

Fixed most channel memory leaks - http://rathena.org/board/tracker/issue-8044-memory-leak-revision-17486-causes-players-to-disconnect/
Fixed memory leak caused by item combos breaking out of a loop without freeing
2013-11-12 10:36:40 -07:00
Cahyadi Ramadhan Togihon
9e8e3cfacc * Follow up to: 99098c1
-- 'bonus_script' is now by default will be store on 'bonus_script' table. CAUTION: Please import 'upgrade_20131111.sql' file or execute the query inside to make `bonus_script` table.
-- Updated bonus_script documentation following flag &8 (BONUS_FLAG_REM_ON_LOGOUT) behavior. By default, bonus_script will be stored when player logs out and will be continued when player logs in.

* And small changes.
2013-11-11 19:59:35 +07:00
Lilith-
80074e90e3 Fixed bugreport:5154 http://rathena.org/board/tracker/issue-5154-sql-setencoding 2013-11-11 00:35:24 -08:00
lighta
1ebe1ada8a Fix charlist incompatibility for 2012 and 2013 clients
-Note we now rely on the clientinfo version for 1st connection
-Upd date2version up to version 45
-Fix some typo banking merge (RFIFOREST and money capping was too late)
2013-11-07 19:26:43 -05:00
aleos89
9e50599234 Follow-up to 56ac0ee. Corrected compile errors. 2013-11-07 14:26:14 -05:00
aleos89
56ac0eeae6 Created split_time() and solve_time() to be reused as a default format for parsing. Credits: lighta 2013-11-07 13:01:37 -05:00
Akinari1087
9c438ce762 Merged Monster Transformation update from Hercules (9692bc0) - Merge credits to Aleos & Cydh
-> Applied follow-up for using monster IDs with the commands (ead2a83)
Merged revert of r15787 where character must face north (5188b69)
Merged bug fix for visual effects on relog (f304c36)
-> This fixes the Warlock Sphere issue on relog as well as many other visual effects

Applied a possible map crash fix - Credits ivanyan
http://rathena.org/board/tracker/issue-8212-server-crash-guild-retrieveitembound/

Started working on some source code documentation
Renamed bank update SQL file to upgrade_20131105.sql
2013-11-06 05:14:19 -07:00