8752 Commits

Author SHA1 Message Date
Jittapan Pluemsumran
48d79cef43 Don't allocate space for new castle data if castle with the same ID already exists. Fixed #2793.
Thanks to @Daegaladh
2018-01-09 19:44:56 +07:00
Yudi Maharlika
a6818eb501 Fixes typo in atcommand.cpp that makes atcommand @accept after duel cannot be used because of limit player reached. (#2778) 2018-01-07 11:30:37 -05:00
Technoken
15b6d5cc83 Corrected Cannibalize behavior (#2769)
* Fixes #2768.
* Fixes Cannibalize level 5 spawning multiple Geographer due to a typo.
Thanks to @technoken!
2018-01-04 10:38:28 -05:00
Lemongrass3110
6f01321b27 Merged two similar conditions on mapchange 2018-01-03 22:41:58 +01:00
Lemongrass3110
c4bfe0b122 Fixed a wrong fifohead allocation 2018-01-03 22:31:04 +01:00
Jittapan Pluemsumran
bfb6972c59 Implemented getequiptradability script command (#2750)
Thanks to @aleos89 @anacondaqq @Lemongrass3110
2018-01-03 21:51:38 +01:00
Lemongrass3110
8c53679a94 New mob placeholders and npc ids 2018-01-02 19:46:43 +01:00
Cydh Ramdh
32950ecead
Updated Item Group features (#2692)
* Added config to hide last chars of player's name `broadcast_hide_name` and its default value is 2.
* Fixed `getgroupitem` that should give unidentified item for equipment types.
* Added optional param for `getgroupitem` and `getrandgroupitem` to always give player identified item, ignores the `itemdb_isidentified`'s check.
* Thanks to @aleos89 @Lemongrass3110
2018-01-02 12:55:52 +07:00
Lemongrass3110
fb966a12e0
Turned pet db into a dynamic map (#2727)
Thanks to @Jeybla, @lighta and @aleos89
2018-01-01 22:57:47 +01:00
aleos
5602bb04f8 Follow up to 1f0ea81
* Removed specific job restrictions from atcommand bodystyle.
2017-12-30 15:43:17 -05:00
aleos
1f0ea81d3f Added Rune Knight to atcommand bodystyle
* Fixes #2746.
Thanks to @mazvi!
2017-12-30 10:50:47 -05:00
Sader Fawall
e88785b181 Resolved a compile error (#2743) 2017-12-29 20:41:54 +07:00
aleos
e385e167ab Resolved a compile warning
* Follow up to 716f6c0.
* Fixes #2738.
Thanks to @sader1992!
2017-12-28 16:28:58 -05:00
Sader Fawall
d19ba918ae Update pet script command (#2705)
* Fixes #2703.
* Added alternative for script command bpet: birthpet.
* Added alternative for script command pet: catchpet.
* Updated documentation for script command pet.
* Added PET_CATCH_UNIVERSAL_ITEM for script command pet which will attempt to catch the targeted monster as long as it is in the pet database and the targeted monster requires the lure item used.
Thanks to @sader1992!
2017-12-27 21:27:04 -05:00
lighta
716f6c0f29 Duel allocation (#2734)
* Duels are now dynamically created and no longer statically consumes memory.
* Removed max number of duel at once.
* Updated duel modules for multi-thread and safer management.
* Remove various statically allocated tab.
* Removed duplicate code for npc_movenpc.
* Fix few warnings.
Thanks for suggestions from @anacondaqq.
2017-12-27 19:39:45 -05:00
Aleos
ae69e50626 Cleaned up renewal ASPD calculations (#2244)
* Cleaned up renewal ASPD calculations
* Fixes #2067 and fixes #2224.
* Adjusted the ASPD table to match Aegis values.
* Angra Manyu now disregards base ASPD values (Pre-Renewal only).

* Relocated Angra Manyu check
* Moved Angra Manyu check to the front to avoid useless calculations.
Thanks to @Lemongrass3110!

* Corrected double weapon calculations
* Resolved wearing two weapons causing ASPD to drop significantly.
* Corrected some typos in the Assassin class ASPD table.
* Added a missing Shadow Arms equipment check.
Thanks to @Lilori!

* Removed some unneeded defines

* Removed the single handed and double handed weapon max defines.
Thanks to @Jeybla!

* Renamed constants to keep legacy values

* Update status.cpp
2017-12-23 16:00:54 -05:00
Aleos
5e2dd2afee Relocated restricted equip failure check (#2735)
* Fixes #2534.
* Moved the restricted equipment failure check before the Super Novice Soul Link check.
Thanks to @admkakaroto!
2017-12-23 14:17:09 -05:00
lighta
5ad35eb66b
Fix #2694 (#2732)
* Fix #2694

Move down skill_unit_move(bl,gettick(),4) of unit_remove_map_ to avoid conflict with duel changing realm.
The issue was that skill_unit_onleft was called before the duel_leave handling which was reapplying skill_unit_onplace causing an infinite status duration.
Other skill might had same issue.

* Small optimisation.
Avoid calling status_change_end when we have no status set yet (or no status_change holder).
Move down overrecurent call to status_change_end SC_ROLLINGCUTTER.
2017-12-22 14:29:44 -05:00
Lemongrass3110
65771a8ec1 Switched mob db searches to find (#2726)
* Switched mob db searches to find
* Replace NULL with nullptr

As suggested by @Jeybla
This way no (caught) exceptions will be reported in visual studio anymore
2017-12-22 07:43:44 -05:00
aleos89
d44367690c Exported the pet catch constant
* Exported to allow usage in scripts.
2017-12-21 13:00:15 -05:00
Aleos
9315781a48
Updated Pet catching values (#2719)
* Added pet catching constants.
* Converted catch_target_class from short to uint16 for future expansion.
Thanks to @Lemongrass3110!
2017-12-21 12:54:19 -05:00
Lemongrass3110
6e7e97cac7 Fixed a crash caused by setquest in login events (#2728)
Fixes #2700

Thanks to @ignizh
2017-12-21 11:06:16 -04:00
lighta
a0c8961e62 Fix #2724 (#2725)
Prevents accessing a nullpointer from a non existant mob when using mobsearch
2017-12-21 00:14:16 +01:00
Lemongrass3110
88e48ed6ff Follow up to 7a1a76a
Thanks to @AthenaStudioz and @sader1992
2017-12-20 21:55:06 +01:00
Sader Fawall
eb8f33e40f Corrected mapcache build (#2715)
* Removed the hyphen from the name in the Windows build.
Thanks to @sader1992!
2017-12-20 10:02:52 -05:00
Jeybla
5a80f29b65
Fixes potential map server crashes. (#2695)
* status_change_timer refactorization
* Changes some pointers to const pointers to prevent unwanted behavoir.
* Changes sc_timer_next to a lambda function with only the tick as a
  paramter.
* sce is not reassigned in sc_timer_next anymore, therefore it should be
  crash safe (see #2414 and #2539)
* Fixes #2539
* Thanks to @whupdo, @MuzTank and @admkakaroto!
2017-12-20 01:00:10 +01:00
aleos89
1ae1e312da Minor cleanups
* Resolved some miscellaneous typos.
2017-12-19 14:42:15 -05:00
lighta
7a1a76a9a9
Fix #2425 Character variable lengths and char-server (#2647)
* Fix #2425 Character variable lengths and char-server

Medium term fox for crash on char-serv caused by too long character variable.
Add few error msg and safety.
Add npc/test/npc_test_longvar.txt as a basic test.

NB:
The config.in for max_colum size if not really set as best would either retrive that value from sql, or use the same config file to actually set the sql column size...
May be handle later with some kind of hibernate ORM.

Thanks to @Tokeiburu, @aleos89, @Lemongrass3110.
2017-12-19 15:13:55 -04:00
Lemongrass3110
b9981b2e27 Fixed a compilation warning on winapi.cpp
Fixes #2690

Thanks to @hurtsky, @reymarbc and @keitenai
2017-12-19 08:43:16 +01:00
Lemongrass3110
15e509fedd
Added November and current December clients (#2702)
Credits to @4144
2017-12-17 17:07:08 +01:00
sader fawall
1b68303f74 Update sc_end_class (#2673)
* Adjusted script command sc_end_class to accept an optional job ID.
Thanks to @sader1992!
2017-12-17 10:29:30 -05:00
Aleos
b3e67d2172
Resolved enchants not executing unequip script (#2676)
* Fixes #2668.
* Fixes enchant items not properly calling the unequip item script.
Thanks to @admkakaroto and @mrjnumber1!
2017-12-15 14:29:46 -05:00
Aleos
947875d27b
Corrected Chain Lightning behavior (#2683)
* Fixes #2674 and fixes #2678.
* Chain Lightning will no longer bounce across Ice Wall.
* Chain Lightning damage should slowly decrease based on the number of bounces remaining.
* Removed the splash effect which was causing the damage to iterate faster on the first two hits.
* Removed the skill unit defines.
Thanks to @Sweet520!
2017-12-15 10:09:23 -05:00
Aleos
ab1fa803a2
Fixed Giant Growth damage bonus (#2688)
* Fixed Crush Strike damage bonus
* Fixes #2684.
* Base damage increase should not be affected by a success rate.
* Adjusted Crush Strike weapon attack to take from the current indexed value.
Thanks to @Badarosk0 and @Paoly28!
2017-12-14 18:52:19 -05:00
Aleos
0f33de9b4d
Updated Sorcerer Insignia Skills (#2645)
* Updated Sorcerer Insignia Skills
* Fixes #2630.
* Added missing Elemental 20% damage bonus for level 1 Insignia.
* Adjusted the recovery bonus to only apply to Elementals.
* Adjusted 25% magic damage bonus calculation.
* Added the missing ASPD bonus for Wind Insignia.
* Insignias should not affect status immune.
* Removed the BATK addition.
* Miscellaneous cleanups.
Thanks to @admkakaroto and @exneval!
2017-12-12 18:33:08 -05:00
Jey
d08bc1ce2d Revert "status_change_timer refactorization"
This reverts commit 00d8ace8d8f1d2ab525e7b53dcae9cfcae32c638.
2017-12-11 03:02:47 +01:00
Jey
00d8ace8d8 status_change_timer refactorization
* Changes some pointers to const pointers to prevent unwanted behavoir.
* Changes sc_timer_next to a lambda function with only the tick as a
  paramter.
* sce is not reassigned in sc_timer_next anymore, therefore it should be
  crash safe (see #2414 and #2539)
2017-12-11 02:57:03 +01:00
Cydh Ramdh
1e1bd71e5a Fixed script commands for Item Option
* Fixes #2682: `getitem3`, `delitem3`, and `countitem3` always fail if `RandomValueArray` or `RandomParamArray` are not defined (Not all Item Options need 'Value' and 'Param')
* Thanks to @rAthenaCN
2017-12-10 18:40:01 +07:00
sader fawall
6afc36255b packet.h clarification (#2639)
* Added comments to clarify PACKETVER changes.
Thanks to @sader1992!
2017-12-06 14:45:59 -05:00
lighta
fd8e1fe2cd Introduced utilities to gradually replace utils. (#2651)
* Replace current levenshtein with much faster implementation.
* Remove usage of alias to simplify code for VS 2013.
2017-12-06 10:38:10 -05:00
aleos89
c5b7850a9a Fixed atcommand where parsing
* Fixes #2675.
* Resolves atcommand where not accepting players with spaces in their name.
Thanks to @Tokeiburu!
2017-12-04 13:26:21 -05:00
sader fawall
4dde4c664b Fixes title selection in ui window (#2662)
* Fixes #2660
* Thanks to @hnomkeng
2017-12-03 01:56:56 +01:00
Lemongrass3110
f7bc3bca66 Fixed an issue with invisible item shops
Thanks to @Everade
2017-12-02 12:18:07 +01:00
Lemongrass3110
7c1a88270b Added support for custom constant import (#2656) 2017-12-01 13:58:24 -05:00
Lemongrass3110
f59298adda Added support for windows admin detection (#2657)
Credits to Microsoft
2017-12-01 13:09:51 -05:00
Lemongrass3110
812e3a9a04
Disabled root/admin user check for build bots (#2659)
Thanks to @hurtsky
2017-12-01 17:24:16 +01:00
Lemongrass3110
c5af8c76e3 Added 2 new hat effects
Thanks to @RagnarokNova
2017-11-28 23:15:00 +01:00
lighta
618b9356fc
Fix #2591 spinlock issue. (#2637)
* Fix #2591 spinlock issue.
Add basic_test, for few integration test.
Add thread_local_storage support in cmake
Fix thread.c for linux and fix small typo
2017-11-26 22:30:17 -04:00
aleos
1645fc0cdb Corrected a ShowError output
* The new mob database range error message was missing the new ranges.
Thanks to @CairoLee!
2017-11-26 10:29:41 -05:00
aleos
114bebac68 Corrected a potential map crash with achievements
* Follow up to 1c66035.
* Reverted a lambda function which was causing a mismatch between achievement vectors and player achievements.
Thanks to @reymarbc and @cydh!
2017-11-23 16:40:06 -05:00