15776 Commits

Author SHA1 Message Date
Lemongrass3110
ec3b7077cb
Switched supported client to Ragexe (#3765)
Fixes #3376

This adds support for clients after July 2018.
Since no unpacked RagexeRE exist anymore, we need to switch back over to Ragexe.

This should work without problems until 2018-11-21.
After this there are further changes required.

Thanks to @Haikenz
2018-12-20 17:31:09 +01:00
Lemongrass3110
fb81e2d7ad
Fixed autobonus removal (#3767)
Fixes #3739

Thanks to @whupdo for finding the broken removal.

Fixes #3766

Since vector elements will be pushed around in the container when an element is removed,
the original pointer might be invalid at the time the end of the timer has been reached.

A big thank you to @teededung for being persistent and helping me to reproduce the issue.
2018-12-20 08:23:10 +01:00
Aleos
75aef6a544
Corrected AutospellOnSkill (#3770)
* Fixes #3769.
* Added a missing reference call.
* Defaulted item bonus entries to 0/nullptr.
Thanks to @laziem!
2018-12-19 18:09:24 -05:00
Lemongrass3110
7c271d7edc
Disabled iterator sanity checks on VS (#3760)
Fixes #3750

Thanks to @teededung and @aleos89
2018-12-18 18:51:56 +01:00
rAthenaAPI
954cbd54ce SQL synchronization 2018-12-18 17:47:06 +01:00
Lemongrass3110
016d15b79a
Unified infinite tick usage (#3755)
Introducing a new constant INFINITE_TICK
Changed current usages in items, npcs and source to use the new and correct constant.
Replaced some invalid usages of INVALID_TIMER and replaced them with the new constant.
2018-12-18 17:46:56 +01:00
Lemongrass3110
732059ac03
Fixed wrong replacements of CD_CURRENT_ECONOMY (#3764)
Follow up to 7045d58

Fixes #3763

Thanks to @nubspixel
2018-12-18 17:16:59 +01:00
Lemongrass3110
e3dd6238b5
Removed deprecated SI constants from src (#3762)
Froze their values by hardcoding them into the script engine exports.
Removed commented ones.
Removed a leftover reference to SI_BLANK.
2018-12-18 15:54:54 +01:00
Aleos
570c07d50c
Corrected some Summoner skills (#3719)
* Fixes #3706.
* Resolved Blessing of Shrimp not boosting SP recovery properly.
* Resolved Tasty Shrimp Party not accounting for Fresh Shrimp level learned.
* Resolved Lope not placing the caster at the selected target location.
Thanks to @Everade and @exneval!
2018-12-17 21:51:50 -05:00
Lemongrass3110
742232d575
Fixed zero termination for bg messages (#3759)
Fixes #3104

Thanks to @Rolfxx and @vstumpf
2018-12-18 02:32:37 +01:00
Aleos
faee0cde45
Fixed CN Meteor and Lunatic Carrot Beat damage (#3746)
* Fixes #3734.
* Added missing battle cases.
Thanks to @teededung and @Playtester!
2018-12-17 19:47:34 -05:00
Lemongrass3110
200b55e0b9
Fixed Taekwon Jobchanger Location (#3757)
Fixes #3691

Thanks to @zackdreaver and @Balferian
2018-12-17 16:41:23 +01:00
Lemongrass3110
7fa903ce22
Fixed SU_GROOMING while being frozen (#3756)
Fixes #3728

Thanks to @Everade
2018-12-17 14:14:58 +01:00
Lemongrass3110
9183a54a0d
Fixed homunculus auto feed for broken luas (#3758)
Fixes #3318

Thanks to @yoonjunho72, @AzarthMZintos and @admkakaroto
2018-12-17 13:53:37 +01:00
Lemongrass3110
e8a7daec9f
Fixed pre-renewal atk (#3752)
Follow up fe197bfa120aef5fd31c6896122b35fdc06774b4

Fixes #3623

Thanks to @mrjnumber1
2018-12-15 17:04:03 +01:00
Aleos
2d4a594948
Fixed Skill Damage Database parsing (#3747)
* Fixed Skill Damage Database parsing
* Fixes #3732.
* Resolved an issue with constants not being properly parsed for the caster type.
Thanks to @RadianFord, @reunite-ro, and @Lemongrass3110!
2018-12-14 16:05:58 -05:00
Lemongrass3110
9f880768a8
Fixed a documentation typo for bDropAddClass
Fixes #3748 

Thanks to @reunite-ro
2018-12-12 23:27:42 +01:00
Lemongrass3110
18f9574a52
Fixed missing login date for guild members (#3744)
Fixes #3743
2018-12-12 00:23:08 +01:00
rAthenaAPI
6fb680d5e6 SQL synchronization 2018-12-09 16:17:06 +01:00
Atemo
f5b546d67d
Follow-up b87a1758a4 (#3736)
* Changed Thanatos gears to Thanos in item_db.txt
2018-12-09 16:16:55 +01:00
rAthenaAPI
047e001a3a SQL synchronization 2018-12-08 21:00:43 +01:00
Atemo
93cf1881ee
Changed equippable jobs for some items in pre-re/item_db.txt (#3737)
* Rebellion and Summoner job shouldn't be able to equip these items
Thanks to @RadianFord!
2018-12-08 20:59:56 +01:00
Jittapan Pluemsumran
4cff45b881 Fixed clearing of sp_vanish_race (#3729) 2018-12-08 20:03:58 +01:00
Aleos
32c68c73bf
Renewal bBaseAtk readparam returning wrong value (#3731)
* Corrects readparam returning the wrong value for bBaseAtk.
2018-12-07 10:23:46 -05:00
zackdreaver
b87a1758a4 [Proposal] Ghost Palace instance NPC name fixes (#3606)
* Changed Thanatos to Tartanos and Thanatos gears to Thanos,
to follow actual name from Ragnarok manhwa and kRO actual item name translation
* changed "Tartanos Magic Trace" to "Magic Sword Tartanos"

Signed-off-by: zackdreaver <zackdreaver@gmail.com>
2018-12-07 15:27:42 +01:00
Lemongrass3110
5597105451 Fixed an issue with bonus recalculation
Fixes #3725

Thanks to @jester-frost and @laziem
2018-12-06 22:26:35 +01:00
rAthenaAPI
08a45f5e8f SQL synchronization 2018-12-05 05:01:34 +01:00
rAthenaAPI
f233792f53 Mob and NPC Identity Update 2018-12-05 05:01:02 +01:00
MathReaper
2f5e1203eb Corrected vector issue (#3723) 2018-12-04 20:11:21 +01:00
rAthenaAPI
fdf2013a4e SQL synchronization 2018-12-03 14:58:48 +01:00
Atemo
9f24814a03
Lasagna Boss spawn (#3718)
* Takeover of https://github.com/rathena/rathena/pull/3424
* Added Big Eggring spawn and updated monster stats
Thank to @admkakaroto to bring up this
2018-12-03 14:58:37 +01:00
Lemongrass3110
40a4edc4f8 Follow up to e02e85b
Fixes #3721

Thanks to @teededung
2018-12-01 11:19:08 +01:00
Lemongrass3110
9dbd3cb17f Follow up to bff89bd
Thanks to @RadianFord
2018-12-01 00:03:09 +01:00
Atemo
756ef38bc9
Fix for issue #3701 (#3702)
Thanks to @teededung for reporting it
Fixed #3701
2018-11-30 15:53:07 +01:00
Aleos
6a49dc2b90
Corrected possible item loss during char login (#3714)
* Resolved a rare case if a player logs in and the server hasn't fully initialized all of the player's items that the auto-save timer fires off and saves the player with no items.
Thanks to @Tokeiburu!
2018-11-30 09:33:44 -05:00
Aleos
0bb279b64c
Corrected Stone Hard Skin Rune effects (#3713)
* Fixes #3693.
* Stone Hard Skin should not end after taking full damage.
Thanks to @slyx88 and @flamefury!
2018-11-30 09:06:36 -05:00
Aleos
5cc368a177
Corrected a potential overflow in item bonuses (#3709)
* Fixes #3703.
* Fixed bHealPower, bHealPower2, bSPGainValue, bHPGainValue, bMagicSPGainValue, and bMagicHPGainValue having a chance to potentially overflow from signed short limit.
Thanks to @Everade!
2018-11-29 18:54:59 -05:00
Aleos
e02e85b65e
Corrected White Imprison and reflected damage (#3685)
* Fixes #3634.
* Targets in White Imprison using reflect equipment or skills should not send damage back to those outside.
Thanks to @admkakaroto!
2018-11-29 18:13:06 -05:00
Aleos
a0d1087628
Corrected Electric Shocker versus MVP (#3660)
* Fixes #3649.
* Electric Shocker is able to stop MVP as well.
* Status should not stack with itself.
* Status should be cleared by normal means.
Thanks to @admkakaroto!
2018-11-29 17:51:00 -05:00
Aleos
9758a38f07
Updated CN Meteor and Lunatic CB behavior (#3603)
* Implements SU_CN_METEOR2 and SU_LUNATICCARROTBEAT2 skills.
* These skills are used as placeholders for the item requirements for skill bonuses.
Thanks to @Rytech2 and @exneval!
2018-11-29 17:23:09 -05:00
Lemongrass3110
bff89bd70e
Fixed possible string out of bounds in configurations (#3631)
Added safestrncpy to char's inter configurations
Added safestrncpy to map's inter configurations
Added safestrncpy to message configurations
Adjusted some char configurations
Cleaned up logging configurations

Fixes #3624 

Thanks to @mrjnumber1
2018-11-29 22:56:17 +01:00
Lemongrass3110
bde580fdbd
Add drop highlighting effect feature (#3710)
Fixes #3610

Thanks to @Balferian, @admkakaroto and credits to @Asheraf
2018-11-29 22:34:57 +01:00
Aleos
c71ef92fb0
Refactored item bonuses to utilize C++ features (#3235)
* Fixes #996 and fixes #3152.
* Refactored MAX_PC_BONUS item bonuses from static arrays to vectors.
* Increased MAX_PC_BONUS to 50.
* Frees up memory from players that may not ever utilize all their static MAX_PC_BONUS item bonuses.
* Expanded bonus ResEff to not be restricted to SC_COMMON* statuses.
* Removed old ERS usages.
* Removed code redundancy and general cleanups.
Thanks to @Angelic234, @Atemo, @Lemongrass3110, and @Everade!
2018-11-28 21:50:43 -05:00
Aleos
eafb1cb7f9
Corrected Absorb Spirit Sphere on self (#3689)
* Fixes #3534.
* Absorb Spirit Sphere should work on self on all map types.
Thanks to @FriggRM!
2018-11-28 13:11:35 -05:00
rAthenaAPI
64d0da45ca SQL synchronization 2018-11-28 16:56:08 +01:00
atemo
56f5333ac9 Added missing bracket for sql synchro
Thanks to @Lemongrass3110 !
2018-11-28 16:55:42 +01:00
Atemo
a8175337d6
KRO items november-07-2018 (#3708)
Thanks to the translation from Sigma and DP !
Additionally correct a typo in Ancient_Hero_Boots item reported by @Angelic234 from previous PR
2018-11-28 15:55:49 +01:00
Aleos
47d76205c0
Resolved Small and Large Life Potion Healing (#3712)
* Fixes #3705.
* Heal rate was comparing battle status versus base status.
Thanks to @Everade!
2018-11-27 22:26:16 -05:00
Aleos
505a0cd888
Fixed a potential crash on change map events (#3699)
* Fixes #3687.
* When changing to an unknown map (or one on another map-server) the instance checks attempted to check null data.
Thanks to @lelouch22!
2018-11-27 09:46:20 -05:00
Aleos
16c2f22fed
Corrected Fire Charm and Exploding Dragon damage (#3700)
* Fixes #3695.
* Fire Charm was granting too much bonus damage when used with Exploding Dragon.
Thanks to @Balferian!
2018-11-27 09:26:43 -05:00