8579 Commits

Author SHA1 Message Date
ai4rei
edfc3293e5 * Made script engine's DEBUG_DISASM block use script_op2name, rather than hardcoding operator names as per TODO from r13083 (related r9569, follow up to r10667).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14585 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 16:09:18 +00:00
ai4rei
b19741a68a * Cleaned up MOTD reading (related r292 and r4552).
- Added a warning for common client crash caused by the sequence ' :' in MOTD.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14584 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 14:53:57 +00:00
ai4rei
6a0558d0c2 * Fixed impossible condition in soundeffect script command (since athena-dev-2.1.1-mod1046, related r5841).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14583 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 13:48:14 +00:00
ai4rei
adc89d50f4 * Updates to the playBGM functionality (since r14335).
- Removed impossible condition in playBGM script command (from soundeffect).
- Removed unused code (retrieving of a bl) in playBGMall (from soundeffectall).
- Made playBGMall default to 'entire server' when both map name and coordinates are omitted instead of printing an error.
- Updated documentation for playBGM and playBGMall to match actual behavior.
- Removed unused parameter 'bl' in clif_playBGM.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14582 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 13:10:08 +00:00
ai4rei
6aabf7c260 * Fixed script command setd always assuming value parameter to be a string, which causes hexadecimal and octal numbers not being handled properly (topic:261833, followup to r14577 and r14578).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14581 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 01:38:41 +00:00
ai4rei
c961604f0b * Removed motd from ragsrvinfo table in main.sql, missed in previous commit (follow up to r14579).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14580 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 00:58:24 +00:00
ai4rei
d173283814 * Updates to dynamic server information ragsrvinfo on SQL.
- Fixed exp and drop rates (int) getting truncated (short) when sent to char-server.
- Removed `motd` from `ragsrvinfo` as it is not dynamically changed by the server and as such can be read by 3rd party applications directly from conf/motd.txt if required.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14579 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 00:44:38 +00:00
brianluau
8c9202976a - Fixed argument declaration of 'setd' (topic:261833, related r14573).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14578 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-12 00:12:10 +00:00
ai4rei
6a684a566b * Added support for checking argument data type of built-in script functions (bugreport:1701, topic:261833, related r14573).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14577 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 21:52:27 +00:00
ai4rei
72e7dce800 * Fixed error message in intif_parse_mercenary_received printing wrong struct size (bugreport:4633, since r13116).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14576 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 12:13:20 +00:00
ai4rei
806daea231 * Replaced buildin_getpartyname_sub, buildin_getguildname_sub and buildin_getguildmaster_sub, which create only unnecessary overhead, with equivalent inlined code.
- Fixed a memory leak in getguildmasterid, when the guild leader was not online (bugreport:2743).
- Command getguildmasterid no longer requires the guild leader to be online.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14575 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 01:23:38 +00:00
ai4rei
f27307a8cf * Fixed bAutoSpellOnSkill bonuses not working independently of each other (bugreport:4617, since r13596, related r14536).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14574 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-11 00:07:25 +00:00
ai4rei
e560ba458b * Revised argument declaration of all script commands according to the actual functions' argument usage.
- Fixed many script commands with fixed amount of optional parameters to no longer accept any amount of arguments (faulty declaration).
- Corrected use of dummy parameter for guildopenstorage in scripts.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14573 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-10 22:29:12 +00:00
ai4rei
a322c9e9f1 * Applied update to charhelp.txt provided by EvilPuncker to match current charcommand behavior (bugreport:4632, follow up to r13403).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14572 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-10 16:59:20 +00:00
ai4rei
522a51bb10 * Removed some of the duplicate, storage-related packet code.
- Removed clif_guildstoragelist and adjusted clif_storagelist to be able to handle any kind of storage.
- Removed clif_guildstorageitemadded in favor of clif_storageitemadded.
- This also fixes clif_guildstorageitemadded sending old update packet for clients prior 20090603, although packet 0x1c4 (ZC_ADD_ITEM_TO_STORE2) was added before PACKETVER 5 (before 2003-11-03aSakexe, exact addition date unknown) (since r14286).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14571 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-09 23:18:03 +00:00
ai4rei
6cfbe77910 * Applied some script command documentation updates and fixes as already done inside the wiki.
- Updated description for 'next', 'return', 'attachrid', 'detachrid', 'itemskill', 'openstorage', 'skilleffect', 'donpcevent', 'day', 'night', 'atoi' and 'axtoi' to resolve inaccuracies, missing information or unverified behavior.
- Clarified the purpose of the 'jump_zero' and 'getelementofarray' script commands.
- Fixed 'changebase' stating, that it only works in item scripts (since r2402).
- Fixed 'kickwaitingroomall' stating, that it is not properly linked into the script engine, thus not working (since r13732).
- Updated the description for 'cutin' so that it does not give the impression, that the client is able to display multiple illustrations at once, and being less confusing about the maximum size of illustrations.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14570 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-08 23:41:55 +00:00
ai4rei
00a72ed8b9 * Fixed txt-converter-login was no longer compilable with supplied project/make files, due to missing reference to function exists in utils.c (bugreport:4626, since r14528).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14569 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-08 00:15:48 +00:00
ai4rei
437a082a1a * Applied svn:eol-style to VS2010 project files (follow up to r14562).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14568 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 20:10:53 +00:00
ai4rei
e26ea94a2f * Reverted r14563, due to multiple issues which render the source malfunctioning or uncompilable. To be redone later (bugreport:4627).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14567 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:45:24 +00:00
Paradox924X
45c05e45b7 Removed unnecessary reference operator from scanf calls passing character strings as arguments in adduser tool.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14566 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:24:03 +00:00
Paradox924X
f95546e131 Revert of r14564. The value wasn't an arbitrary account id but rather the file format version. Added comment specifying this.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14565 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:18:03 +00:00
Paradox924X
bece9eef66 Removed arbitrary account id from atop account.txt (Since r13000).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14564 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 19:06:48 +00:00
Paradox924X
ca53ef6f4a Changed almost all instances of sprintf() to snprintf().
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14563 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 18:38:03 +00:00
Paradox924X
f6d95be1f9 Added Visual Studio 10 project files.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14562 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 12:14:52 +00:00
ai4rei
eaa7afe00c * Further corrections to doc/item_bonus.txt (bugreport:4624).
- Added documentation for bUnbreakableGarment, bUnbreakableWeapon, bUnbreakableArmor, bUnbreakableHelm, bUnbreakableShield, bUnbreakableShoes, bBreakWeaponRate and bBreakArmorRate (follow up to r485, r915, r1116, r13819).
- Fixed bIgnoreDefEle having race constants listed instead of element constants (since r12804).
- Fixed bUnstripable* not mentioning, that the bonus parameter is meaningless (follow up to r1382).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14561 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-07 10:02:35 +00:00
ai4rei
a6c1101658 * Corrected description for bonuses bHealPower and bHealPower2 stating skill names being supported, although the bonus does not accept 'skill' as parameter (bugreport:4619, since r13821).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14560 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-06 16:17:46 +00:00
L0ne_W0lf
013acf50b1 Added support for bonus bAddItemHealRate, which works for all healing items care of Epoque.
Updated some items to use bonus bAddItemHealRate, and healpower2.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14559 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-06 00:15:16 +00:00
ai4rei
c1151a7ee3 * Fixed party booking search increasing result counter, even when no results were found, causing crashes from r14516 onwards (bugreport:4615, since r14412).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14558 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-05 00:00:37 +00:00
ai4rei
2e82e68ce9 * Fixed soul linkers not receiving taekwon angel buffs upon level up (bugreport:3585, since r3657 and r3660, related r6294).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14556 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 17:27:07 +00:00
L0ne_W0lf
d68eeba638 Corrected incorrect bonuses relating to bAddMonsterDropItem/Group. (burgerport:4569)
Updated the IG_Ore, IG_Food, IG_Recovery and IG_Jewel item groups to official items/rates.
As a result bAddMonsterDropItemGroup now uses the highest rate in group as it's base rate.
Updated instances with more proper English, care of Resplendent.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14555 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 16:14:07 +00:00
ai4rei
d3773c0b51 * Corrected 'chance' in description for bonuses bAddMonsterDropItem and bAddMonsterDropItemGroup (bugreport:4063, partially since r1572).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14554 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 09:59:34 +00:00
ai4rei
5cfc017080 * Removed leftovers of the item_value_db.txt feature (bugreport:2031, since athena-dev-2.1.1-mod377, followup to pre-svn 2004/05/29).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14553 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 09:15:29 +00:00
L0ne_W0lf
e4ae836f44 Updated some more cash shop boxes to use rentitem instead of getitem.
Added mercenary skills for Mimic, Disguise, Alice, Doppelganger, and Egnigem.
Removed duplicate NPCs in Lighthalzen and Morroc. (bugreport:4555)
Corrected typo (Sit -> Suit) in enhcant_arm NPC. (bugreport:4586)
Corrected a typo in the christmas_2008 event. (bugreport:4600)
Changed which White Lady spawns in endless tower. (bugreport:4601)
Also added Quest Log Entries to Endless Tower, please test.


git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14552 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-03 02:24:34 +00:00
ai4rei
cd78795961 * Various code tweaks and updates related to item types.
- Replaced item type literals with their appropriate constants.
- Added itemdb_typename to replace the ugly "BUG!" filled array in @iteminfo (since r1741, follow up to r14550).
- Made the item database parser verify item type for validity.
- Added item type constants to const.txt for use in scripts (getiteminfo).

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14551 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 22:33:32 +00:00
ai4rei
df41665d39 * Added support for IT_CASH to @iteminfo, logging filters and item drop rate adjustment. Added 'show_picker.item_type'-specific IT_CASH value to it's description (follow up to r14549).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14550 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 20:44:38 +00:00
L0ne_W0lf
28e4aaf123 * Added item type IT_CASH (item type 18) Requires user confirmation before using/generating item(s).
* Updated the item types for several of the cash item boxes to 18.
* Fixed the Exorcism_Bible bonus, missing {}'s for who knows how long. (bugreport:4342)
* Updated Brasilis monsters stats again, care of Playtester.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14549 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 19:23:32 +00:00
ai4rei
4ac5525eb8 * Fixed mapflags not getting initialized upon @reloadscript (bugreport:2247, since r1275).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14548 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 18:50:34 +00:00
ai4rei
081db1deb2 * Removed redundant check in food vs. cash food status change overriding code, partially suggested by xazax (related r14437 and r14510).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14547 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 17:20:47 +00:00
ai4rei
ff135c1ee5 * Added an error message when a client connection exceeds the socket write buffer, so that it does not appear to be closed for no apparent reason (follow up to r13469).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14546 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 16:40:44 +00:00
ai4rei
fc662a0020 * Random clif.c fixes and cleanups.
- Fixed clif_homskillup using sd before nullpo check (since r9297 and r9307).
- Merged code responsible for disabling pets in GvG and spawning them as per TODO (related r12002).
- Fixed base and job exp not being sent to the client for new connections (follow to r14505).
- Fixed Magnifier (item) and Identify (skill) attempting to identify an item, even when cancel is pressed, causing skill failed message.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14545 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 14:58:34 +00:00
ai4rei
f9bdaf5426 * Added defines for guild notice sizes (MAX_GUILDMES1 and MAX_GUILDMES2).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14544 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 14:17:07 +00:00
ai4rei
ce93557473 * Added clif_starskill (packet 0x20e, ZC_STARSKILL) to host the packet previously implemented by clif_feel_info, clif_hate_info, clif_mission_info and clif_feel_hate_reset (related r4352, r4375 and r9162).
- This also fixes sd->bl.id being sometimes supplied for monster_id in this packet.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14543 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 13:56:19 +00:00
ai4rei
10638473e4 * Various additions and updates to the comments and documentation of packets in clif.
- Renamed clif_01ac to clif_skillunit_update to make it look less 'mysterious'.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14542 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 13:06:00 +00:00
ai4rei
c8cae9e659 * Removed clif_weather_sub and clif_misceffect2 in favor of clif_specialeffect_single and clif_specialeffect (all of them are ZC_NOTIFY_EFFECT2).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14541 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 12:08:44 +00:00
L0ne_W0lf
521a0280af Monsters spawned with mob-generating items now have MD_ANGRY applied to them.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14540 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 05:09:45 +00:00
ai4rei
a313575e51 * Added packet 0x1b1 (ZC_SHOWDIGIT).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14539 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-02 00:02:55 +00:00
ai4rei
ca36918486 * Confirmed packet 0x291 (ZC_MSG) to be general-purpose msgstringtable.txt packet and updated all functions using it (related r12245 and r13126).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14538 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 23:59:10 +00:00
ai4rei
5c84df6a15 * Fixed using main chat nick longer than 15 characters would cause a buffer overflow (bugreport:2671, since r5013).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14537 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 20:57:47 +00:00
ai4rei
0b5563ac28 * Fixed bAutoSpellOnSkill bonuses could not be chained (bugreport:4421, since r13596).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14536 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 18:36:27 +00:00
ai4rei
9808dfb86b * Fixed NPC_TALK message being displayed with EOL character attached (bugreport:4596, since r14270).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14535 54d463be-8e91-2dee-dedb-b68131a5f0ec
2010-12-01 17:07:14 +00:00